Fix remaining z-index bugs

Kirill Bulatov and Antonio Scandurra created 2 years ago

Co-Authored-By: Antonio Scandurra <[e-mail]>

Change summary

crates/collab_ui2/src/collab_titlebar_item.rs |  1 -
crates/gpui2/src/window.rs                    | 10 ++++++++++
crates/ui2/src/components/tab_bar.rs          |  1 -
crates/workspace2/src/toolbar.rs              |  1 -
4 files changed, 10 insertions(+), 3 deletions(-)

Detailed changes

crates/collab_ui2/src/collab_titlebar_item.rs

@@ -68,7 +68,6 @@ impl Render for CollabTitlebarItem {
 
         h_stack()
             .id("titlebar")
-            .z_index(160) // todo!("z-index")
             .justify_between()
             .w_full()
             .h(rems(1.75))

crates/gpui2/src/window.rs

@@ -2057,9 +2057,14 @@ pub trait BorrowWindow: BorrowMut<Window> + BorrowMut<AppContext> {
                 size: self.window().viewport_size,
             },
         };
+        let new_stacking_order_id =
+            post_inc(&mut self.window_mut().next_frame.next_stacking_order_id);
+        let old_stacking_order = mem::take(&mut self.window_mut().next_frame.z_index_stack);
+        self.window_mut().next_frame.z_index_stack.id = new_stacking_order_id;
         self.window_mut().next_frame.content_mask_stack.push(mask);
         let result = f(self);
         self.window_mut().next_frame.content_mask_stack.pop();
+        self.window_mut().next_frame.z_index_stack = old_stacking_order;
         result
     }
 
@@ -2068,9 +2073,14 @@ pub trait BorrowWindow: BorrowMut<Window> + BorrowMut<AppContext> {
     fn with_z_index<R>(&mut self, z_index: u8, f: impl FnOnce(&mut Self) -> R) -> R {
         let new_stacking_order_id =
             post_inc(&mut self.window_mut().next_frame.next_stacking_order_id);
+        let old_stacking_order_id = mem::replace(
+            &mut self.window_mut().next_frame.z_index_stack.id,
+            new_stacking_order_id,
+        );
         self.window_mut().next_frame.z_index_stack.id = new_stacking_order_id;
         self.window_mut().next_frame.z_index_stack.push(z_index);
         let result = f(self);
+        self.window_mut().next_frame.z_index_stack.id = old_stacking_order_id;
         self.window_mut().next_frame.z_index_stack.pop();
         result
     }

crates/ui2/src/components/tab_bar.rs

@@ -96,7 +96,6 @@ impl RenderOnce for TabBar {
 
         div()
             .id(self.id)
-            .z_index(120) // todo!("z-index")
             .group("tab_bar")
             .flex()
             .flex_none()

crates/workspace2/src/toolbar.rs

@@ -105,7 +105,6 @@ impl Render for Toolbar {
         v_stack()
             .p_1()
             .gap_2()
-            .z_index(80) // todo!("z-index")
             .border_b()
             .border_color(cx.theme().colors().border_variant)
             .bg(cx.theme().colors().toolbar_background)