Don't make events for every rejected suggestion

Joseph Lyons created 2 years ago

Change summary

crates/client/src/telemetry.rs | 2 +-
crates/editor/src/editor.rs    | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)

Detailed changes

crates/client/src/telemetry.rs

@@ -87,7 +87,7 @@ pub enum ClickhouseEvent {
         copilot_enabled_for_language: bool,
     },
     Copilot {
-        suggestion_id: String,
+        suggestion_id: Option<String>,
         suggestion_accepted: bool,
         file_extension: Option<String>,
     },

crates/editor/src/editor.rs

@@ -3098,7 +3098,7 @@ impl Editor {
                     .update(cx, |copilot, cx| copilot.accept_completion(completion, cx))
                     .detach_and_log_err(cx);
 
-                self.report_copilot_event(completion.uuid.clone(), true, cx)
+                self.report_copilot_event(Some(completion.uuid.clone()), true, cx)
             }
             self.insert_with_autoindent_mode(&suggestion.text.to_string(), None, cx);
             cx.notify();
@@ -3117,9 +3117,7 @@ impl Editor {
                     })
                     .detach_and_log_err(cx);
 
-                for completion in &self.copilot_state.completions {
-                    self.report_copilot_event(completion.uuid.clone(), false, cx)
-                }
+                self.report_copilot_event(None, false, cx)
             }
 
             self.display_map
@@ -6884,7 +6882,7 @@ impl Editor {
 
     fn report_copilot_event(
         &self,
-        suggestion_id: String,
+        suggestion_id: Option<String>,
         suggestion_accepted: bool,
         cx: &AppContext,
     ) {