- Support adding ImageContent to messages through copy/paste and through
path completions
- Ensure images are fully converted to LanguageModelImageContent before
sending them to the model
- Update ACP crate to v0.0.24 to enable passing image paths through the
protocol
Release Notes:
- N/A
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
The latest release has span changes in it which prevents rust-analyzer
from constantly showing `Box` and `Box::pin` on hover as well as those
items polluting the go to definition feature on every identifier.
See https://github.com/dtolnay/async-trait/pull/293
Release Notes:
- N/A
43ee604
acp: Clean up entry views on rewind (#36197)
Click to expand commit body
We were leaking diffs and terminals on rewind, we'll now clean them up.
This PR also introduces a refactor of how we mantain the entry view
state to use a `Vec` that's kept in sync with the thread entries.
Release Notes:
- N/A
Agus Zubiaga
created
2acfa5e
copilot: Fix Copilot fails to sign in on newer versions (#36195)
Click to expand commit body
Follow-up for #36093 and
https://github.com/zed-industries/zed/pull/36138
Since v1.355.0, `@github/copilot-language-server` has stopped responding
to `CheckStatus` requests if a `DidChangeConfiguration` notification
hasnβt been sent beforehand. This causes `CheckStatus` to remain in an
await state until it times out, leaving the connection stuck for a long
period before finally throwing a timeout error.
```rs
let status = server
.request::<request::CheckStatus>(request::CheckStatusParams {
local_checks_only: false,
})
.await
.into_response() // bails here with ConnectionResult::Timeout
.context("copilot: check status")?;
````
This PR fixes the issue by sending the `DidChangeConfiguration`
notification before making the `CheckStatus` request. Itβs just an
ordering change i.e. no other LSP actions occur between these two calls.
Previously, we only updated our internal connection status and UI in
between.
Release Notes:
- Fixed an issue where GitHub Copilot could get stuck and fail to sign
in.
smit
created
1a169e0
git: Clear set of dirty paths when doing a full status scan (#36181)
Click to expand commit body
Related to #35780
Release Notes:
- N/A
---------
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
In vim and zed (vim and helix modes) typing "tx" will jump before the
next `x`, but typing it again won't do anything. But in helix the cursor
just jumps before the `x` after that. I added that in helix mode.
This also solves another small issue where the selection doesn't include
the first `x` after typing "fx" twice. And similarly after typing "Fx"
or "Tx" the selection should include the character that the motion
startet on.
Release Notes:
- helix: Fixed inconsistencies in the "f" and "t" motions
fantacell
created
20be133
helix: Allow yank without a selection (#35612)
Click to expand commit body
Related https://github.com/zed-industries/zed/issues/4642
Release Notes:
- Helix: without active selection, pressing `y` in helix mode will yank
a single character under cursor.
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Romans Malinovskis
and
Conrad Irwin
created
528d56e
keymap_ui: Add open keymap JSON button (#36182)
Click to expand commit body
Closes #ISSUE
Release Notes:
- Keymap Editor: Added a button in the top left to allow opening the
keymap JSON file. Right clicking the button provides shortcuts to
opening the default Zed and Vim keymaps as well.
Ben Kunkle
created
f514c7c
Emit a `BreadcrumbsChanged` event when associated settings changed (#36177)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/36149
Release Notes:
- Fixed a bug where changing the `toolbar.breadcrumbs` setting didn't
immediately update the UI when saving the `settings.json` file.
Joseph T. Lyons
created
ba2c45b
Add FutureExt::with_timeout and use it for for Room::maintain_connection (#36175)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Conrad Irwin
,
Antonio Scandurra
, and
Agus Zubiaga
created
ffac8c5
editor: Render all targets in go to def multbuffer title (#36167)
Click to expand commit body
Release Notes:
- N/A
Lukas Wirth
created
b3d048d
Add back `DeletePathTool` to agent2 (#36168)
Click to expand commit body
This was probably removed accidentally as a result of a merge conflict.
Release Notes:
- N/A
Antonio Scandurra
created
8e4f30a
project: Print error causes when failing to spawn lsp command (#36163)
Click to expand commit body
cc https://github.com/zed-industries/zed/issues/34666
Display printing anyhow errors only renders the error itself, but not
any of its causes so we've been dropping the important context when
showing the issue to the users.
Release Notes:
- N/A
Lukas Wirth
created
0291db0
git: Add handler to get default branch on remote (#36157)
Click to expand commit body
Closes #36150
Release Notes:
- Fixed `git: branch` action not worked with ssh workflow
Alvaro Parker
created
5bbdd1a
docs: Update information in MSYS2 section (#36158)
Click to expand commit body
- we are about to drop Zed for MINGW64 because `crash-handler` uses a
symbol which is not presented in `msvcrt.dll`
- mention MSYS2 docs page and CLANGARM64 environment
Release Notes:
- N/A
Release Notes:
- N/A
---------
Co-authored-by: Anthony <anthony@zed.dev>
Mikayla Maki
and
Anthony
created
e67b2da
Make alphabetical sorting the default (#32315)
Click to expand commit body
Follow up of this pr: #25148
Release Notes:
- Improved file sorting.
As described in #20126, I was fed up with lexicographical file sorting
in the project panel. The current sorting behavior doesn't handle
numeric segments properly, leading to unintuitive ordering like
`file_1.rs`, `file_10.rs`, `file_2.rs`.
## Example Sorting Results
Using `lexicographical` (default):
```
.
βββ file_01.rs
βββ file_1.rs
βββ file_10.rs
βββ file_1025.rs
βββ file_2.rs
```
Using alphabetical (natural) sorting:
```
.
βββ file_1.rs
βββ file_01.rs
βββ file_2.rs
βββ file_10.rs
βββ file_1025.rs
```
Tom Planche
created
293992f
In auto-update-helper, fix parsing of `--launch false` (#36148)
Click to expand commit body
This fixes an issue introduced in
https://github.com/zed-industries/zed/pull/34303 where, after an
auto-update was downloaded, quitting Zed would always restart Zed.
Release Notes:
- N/A
Max Brunsfeld
created
665006c
Move the cursor on search in Terminal if ViMode is active (#33305)
Click to expand commit body
Currently, the terminal search function doesn't work well with ViMode.
It matches the search terms, scrolls the active match in the view, but
it doesn't move the cursor to the match, which makes it useless for
navigating the scrollback in vimode.
With this improvement, if a user activates ViMode before the search Zed
moves the cursor to the active search terms. So, when the search dialog
is dismissed the cursor is places on the latest active search term and
it's possible to navigate the scrollback via ViMode using this place as
the starting point.
https://github.com/user-attachments/assets/63325405-ed93-4bf8-a00f-28ded5511f31
Release Notes:
- Improved the search function in the terminal when ViMode is activated
Aleksei Gusev
created
09e90fb
Use trace log level for potentially high-volume vsync duration log (#36147)
Click to expand commit body
This is an attempt to fix
https://github.com/zed-industries/zed/issues/36125
Release Notes:
- N/A
Max Brunsfeld
created
8452532
agent2: Iterate on "new thread" selector in the toolbar (#36144)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
1d2eaf2
editor: Fix first `cmd-left` target for cursor in leading whitespace (#36145)
Click to expand commit body
Closes #35805
If the cursor is between column 0 and the indent size, pressing
`cmd-left` jumps to the indent. Pressing it again moves to the true
column 0. Further presses toggle between indent and column 0.
This PR changes the first `cmd-left` to go to column 0 instead of
indent. Toggling between is unaffected.
Release Notes:
- Fixed issue where pressing `cmd-left` with the cursor in the leading
spaces moved to the start of the text first. It now goes to the
beginning of the line first, then the start of the text.
smit
created
a6e2e0d
onboarding: Fix minimap typo on editing page (#36143)
Click to expand commit body
This PR fixes a small typo on the onboarding editing page where it
should be "Minimap" instead of "Mini Map"
Release Notes:
- N/A
Finn Evers
created
9be4451
Remove Services menu on non-macOS systems (#36142)
Click to expand commit body
Closes #ISSUE
<img width="420" height="379" alt="image"
src="https://github.com/user-attachments/assets/7125c504-508f-4eb1-b0c3-31830598c4a7"
/>
Release Notes:
- Remove Services menu on non-macOS systems which was causing an empty
menu item being rendered
The Zed Plex fonts were found to violate the OFL by using the word Plex
in the name.
Lilex has better ligatures and box-drawing characters than Zed Plex
Mono, but Zed Plex Sans should be identical
to IBM Plex Sans.
Closes #15542
Closes zed-industries/zed-fonts#31
Release Notes:
- The "Zed Plex Sans" and "Zed Plex Mono" fonts have been replaced with
"IBM Plex Sans" and "Lilex". The old names still work for backward
compatibility. Other than fixing line-drawing characters, and improving
the ligatures, there should be little visual change as the fonts are all
of the same family.
- Introduced ".ZedSans" and ".ZedMono" as aliases to allow us to easily
change the default fonts in the future. These currently default to "IBM
Plex Sans" and "Lilex" respectively.
Conrad Irwin
created
4a35498
copilot: Fix Copilot fails to sign in (#36138)
Click to expand commit body
Closes #36093
Pin copilot version to 1.354 for now until further investigation.
Release Notes:
- Fixes issue where Copilot failed to sign in.
Co-authored-by: MrSubidubi <dev@bahn.sh>
cb0bc46
agent2: Add new "new thread" selector in the toolbar (#36133)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
9a375f1
Add some documentation for Helix mode (#35641)
Click to expand commit body
Because there is literally no mention of it in the docs
Release Notes:
- N/A
---------
Co-authored-by: ponychicken <183302+ponychicken@users.noreply.github.com>
Co-authored-by: Ben Kunkle <ben@zed.dev>
ponychicken
,
ponychicken
, and
Ben Kunkle
created
This PR bumps the Emmet extension to v0.0.6.
Changes:
- https://github.com/zed-industries/zed/pull/36126
Release Notes:
- N/A
Marshall Bowers
created
0b9c9f5
onboarding: Make Welcome page persistent (#36127)
Click to expand commit body
Release Notes:
- N/A
Anthony Eid
created
2da80e4
emmet: Use `index.js` directly to launch language server (#36126)
Click to expand commit body
This PR updates the Emmet extension to use the `index.js` file directly
to launch the language server.
This provides better cross-platform support, as we're not relying on
platform-specific `.bin` wrappers.
Release Notes:
- N/A
Marshall Bowers
created
d9a94a5
onboarding: Remove feature flag and old welcome crate (#36110)
1. Welcome Page Open
2. Welcome Nav clicked
3. Skip clicked
4. Font changed
5. Import settings clicked
6. Inlay Hints
7. Git Blame
8. Format on Save
9. Font Ligature
10. Ai Enabled
11. Ai Provider Modal open
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Anthony Eid
and
Marshall Bowers
created
6c1f195
Enhance icon detection for files with custom suffixes (#34170)
Click to expand commit body
Fixes custom file suffixes (module.ts) of some icon themes like:
- **Symbols Icon Theme**
<img width="212" alt="image"
src="https://github.com/user-attachments/assets/419ba1b4-9d8e-46cd-891b-62fb63a8c5ae"
/>
- **Bearded Icon Theme**
<img width="209" alt="image"
src="https://github.com/user-attachments/assets/72974fce-fa72-4368-8d96-7feea7b59b7a"
/>
Release Notes:
- Fixed icon detection for files with custom suffixes like `module.ts`
that are overwritten by the language's icon `.ts`
Gilmar Sales
created
23cd5b5
agent2: Initial infra for checkpoints and message editing (#36120)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>