6ed29fb
Enforce style lints which do not have violations (#36580)
Click to expand commit body
Release Notes: - N/A
tidely created
6ed29fb
Enforce style lints which do not have violations (#36580)
Release Notes: - N/A
tidely created
4ee565c
Fix mentions roundtrip from/to database and other history bugs (#36575)
Release Notes: - N/A
Antonio Scandurra created
f80a0ba
Move clippy lints which aren't apart of the style category (#36579)
Move lints which aren't apart of the style category. Motivation: They might get accidentally get reverted when we turn the style category on again and remove the manual lint enforcements. Release Notes: - N/A
tidely created
7bdc99a
Fix `clippy::redundant_clone` lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
tidely created
cf7c64d
lints: A bunch of extra style lint fixes (#36568)
- **lints: Fix 'doc_lazy_continuation'** - **lints: Fix 'doc_overindented_list_items'** - **inherent_to_string and io_other_error** - **Some more lint fixes** - **lints: enable bool_assert_comparison, match_like_matches_macro and wrong_self_convention** Release Notes: - N/A
Piotr Osiewicz created
a32a264
agent2: Use correct completion intent when generating summary (#36573)
Release Notes: - N/A
Bennet Bo Fenner created
0a80209
agent2: Fix remaining update_model_request_usage todos (#36570)
Release Notes: - N/A
Bennet Bo Fenner created
83d361b
Add more string and comment overrides (#36566)
Follow-up to #36469 Part of the issue was that we hadn't defined comment and string overrides for some languages. Hence, even after the fix edit predictions would show up in comments for me in e.g. JSONC files. This PR adds some more overrides where possible for this repo to ensure this happens less frequently. Release Notes: - N/A
Finn Evers created
4290f04
agent2: Fix token count not updating when changing model/toggling burn mode (#36562)
Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com>
Bennet Bo Fenner and Antonio Scandurra created
44941b5
Fix `clippy::for_kv_map` lint violations (#36493)
Release Notes: - N/A
tidely created
d4d049d
agent2: Port more Zed AI features (#36559)
Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bennet Bo Fenner and Danilo Leal created
4c85a0d
project: Register dynamic capabilities even when registerOptions doesn't exist (#36554)
Closes #36482 Looks like we accidentally referenced [common/formatting.ts#L67-L70](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/formatting.ts#L67-L70) instead of [common/client.ts#L2133](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/client.ts#L2133). Release Notes: - Fixed code not formatting on save in language servers like Biome. (Preview Only)
Smit Barmase created
5d2bb24
ACP history mentions (#36551)
- **TEMP** - **Update @-mentions to use new history** Closes #ISSUE Release Notes: - N/A
Conrad Irwin created
159b5e9
agent2: Port `user_modifier_to_send` setting (#36550)
Release Notes: - N/A
Danilo Leal created
1e1110e
thread_view: Increase click area of the user rules links (#36549)
Release Notes: - N/A
Danilo Leal created
6096040
thread view: Refine the UI a bit (#36504)
Release Notes: - N/A --------- Co-authored-by: Agus Zubiaga <agus@zed.dev>
Danilo Leal and Agus Zubiaga created
fbba6ad
docs: Document `global_lsp_settings.button` and remove duplicate docs for `lsp_highlight_debounce` (#36547)
Follow up to this discussion: https://github.com/zed-industries/zed/pull/36337 Release Notes: - N/A This will (gracefully) break links to https://zed.dev/docs/configuring-zed#lsp-highlight-debounce-1 I don't see anything show up for that on google or github search and I don't think its load bearing. --------- Co-authored-by: zumbalogy <3770982+zumbalogy@users.noreply.github.com>
zumbalogy and zumbalogy created
d273aca
agent_ui: Add check to prevent sending empty messages in MessageEditor (#36545)
Release Notes: - N/A
Ben Brandt created
ceec258
Some clippy fixes (#36544)
These showed up today, so just applied the simplifications, which were mostly switching matches to if let Release Notes: - N/A
Ben Brandt created
cac80e2
Silence a bucketload of logs (#36534)
Closes #ISSUE Release Notes: - Silenced a bunch of logs that were on by default
Conrad Irwin created
b12d862
Rename acp flag (#36541)
Release Notes: - N/A
Agus Zubiaga created
3996587
Add version detection for CC (#36502)
- Render a helpful message when the installed CC version is too old - Show the full path for agent binaries when the version is not recent enough (helps in cases where multiple binaries are installed in different places) - Add UI for the case where a server binary is not installed at all - Refresh thread view after installing/updating server binary Release Notes: - N/A
Cole Miller created
7c70439
Improve claude tools (#36538)
- Return unified diff from `Edit` tool so model can see the final state - Format on save if enabled - Provide `Write` tool - Disable `MultiEdit` tool - Better prompting Release Notes: - N/A
Agus Zubiaga created
714c36f
claude: Include all mentions and images in user message (#36539)
User messages sent to Claude Code will now include the content of all mentions, and any images included. Release Notes: - N/A
Agus Zubiaga created
ce21643
Refactor ssh remoting - make ChannelClient type private (#36514)
This PR is one step in a series of refactors to prepare for having "remote" projects that do not use SSH. The main use cases for this are WSL and dev containers. Release Notes: - N/A
Max Brunsfeld created
82ac8a8
collab: Make `stripe_subscription_id` and `stripe_subscription_status` nullable on `billing_subscriptions` (#36536)
This PR makes the `stripe_subscription_id` and `stripe_subscription_status` columns nullable on the `billing_subscriptions` table. Release Notes: - N/A
Marshall Bowers created
757b37f
Hide old Agent UI when ACP flag set (#36533)
- **Use key value store instead of JSON** - **Default NewThread to the native agent when flagged** Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
Conrad Irwin created
ecee674
Attach minidump errors to uploaded crash events (#36527)
We see a bunch of crash events with truncated minidumps where they have a valid header but no events. We think this is due to an issue generating them, so we're attaching the relevant result to the uploaded tags. Release Notes: - N/A Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Julia Ryan and Max Brunsfeld created
88754a7
Rebuild recently opened threads for ACP (#36531)
Closes #ISSUE Release Notes: - N/A
Conrad Irwin created
88c4a5c
Suspend macOS threads during crashes (#36520)
This should improve our detection of which thread crashed since they wont be able to resume while the minidump is being generated. Release Notes: - N/A
Julia Ryan created
5fb68cb
agent2: Token count (#36496)
Release Notes: - N/A --------- Co-authored-by: Agus Zubiaga <agus@zed.dev>
Bennet Bo Fenner and Agus Zubiaga created
6825715
Another batch of lint fixes (#36521)
- **Enable a bunch of extra lints** - **First batch of fixes** - **More fixes** Release Notes: - N/A
Piotr Osiewicz created
69b1c6d
Fix `workspace::SendKeystrokes` example in docs (#36515)
Closes: https://github.com/zed-industries/zed/issues/25683 Remove two bad examples from the key binding docs. `cmd-shift-p` (command palette) and `cmd-p` (file finder) are async operations and thus do not work properly with `workspace::SendKeystrokes`. Originally reported in https://github.com/zed-industries/zed/issues/25683#issuecomment-3145830534 Release Notes: - N/A
Peter Tripp created
05fc0c4
Fix a bunch of other low-hanging style lints (#36498)
- **Fix a bunch of low hanging style lints like unnecessary-return** - **Fix single worktree violation** - **And the rest** Release Notes: - N/A
Piotr Osiewicz created
df9c2ae
thread_view: Fix issues with images (#36509)
- Clean up failed load tasks for mentions that require async processing - When dragging and dropping files, hold onto added worktrees until any async processing has completed; this fixes a bug when dragging items from outside the project Release Notes: - N/A
Cole Miller created
a91acb5
onboarding: Fix theme selection in system mode (#36484)
Previously, selecting the "System" theme during onboarding would hardcode the theme based on the device's current mode (e.g., Light or Dark). This change ensures the "System" setting is saved correctly, allowing the app to dynamically follow the OS theme by inserting the correct theme in the config for both light and dark mode. Release Notes: - N/A Signed-off-by: Umesh Yadav <git@umesh.dev>
Umesh Yadav created
6ba52a3
Re-add history entries for native agent threads (#36500)
Closes #ISSUE Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com>
Conrad Irwin and Antonio Scandurra created
6b6eb11
agent2: Fix tool schemas for Gemini (#36507)
Release Notes: - N/A --------- Co-authored-by: Agus Zubiaga <agus@zed.dev>
Bennet Bo Fenner and Agus Zubiaga created
1af47a5
helix: Uncomment one test (#36328)
There are two tests commented out in the helix file, but one of them works again. I don't know if this is too little a change to be merged, but I wanted to suggest it. The other test might be more complicated though, so I didn't touch it. Release Notes: - N/A
fantacell created
e092aed
Split external agent flags (#36499)
Release Notes: - N/A
Agus Zubiaga created
d1cabef
editor: Fix inline diagnostics min column inaccuracy (#36501)
Closes https://github.com/zed-industries/zed/issues/33346 Release Notes: - Fixed `diagnostic.inline.min_column` being inaccurate
Lukas Wirth created
013eaae
editor: Render dirty and conflict markers in multibuffer headers (#36489)
Release Notes: - Added rendering of status indicators for multi buffer headers
Lukas Wirth created
43b4363
lsp: Enable dynamic registration for TextDocumentSyncClientCapabilities post revert (#36494)
Follow up: https://github.com/zed-industries/zed/pull/36485 Release Notes: - N/A
Smit Barmase created
1444cd9
Fix Windows test failures not being detected in CI (#36446)
Bug introduced in #35926 Release Notes: - N/A
Cole Miller created
6c255c1
Lay the groundwork to support history in agent2 (#36483)
This pull request introduces title generation and history replaying. We still need to wire up the rest of the history but this gets us very close. I extracted a lot of this code from `agent2-history` because that branch was starting to get long-lived and there were lots of changes since we started. Release Notes: - N/A
Antonio Scandurra created
c4083b9
Fix unnecessary-mut-passed lint (#36490)
Release Notes: - N/A
Piotr Osiewicz created
e3b593e
project: Take 2 on Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36485)
Relands https://github.com/zed-industries/zed/pull/36441 with a
deserialization fix.
Previously, deserializing `"includeText"` into
`lsp::TextDocumentSyncSaveOptions` resulted in a `Supported(false)` type
instead of `SaveOptions(SaveOptions { include_text: Option<bool> })`.
```rs
impl From<bool> for TextDocumentSyncSaveOptions {
fn from(from: bool) -> Self {
Self::Supported(from)
}
}
```
Looks like, while dynamic registartion we only get `SaveOptions` type
and never `Supported` type.
(https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSaveRegistrationOptions)
Release Notes:
- N/A
---------
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Smit Barmase and Lukas Wirth created
8f56738
Auto-fix clippy::collapsible_if violations (#36428)
Release Notes: - N/A
Piotr Osiewicz created
9e8ec72
Revert "project: Handle `textDocument/didSave` and `textDocument/didChange` (un)registration and usage correctly (#36441)" (#36480)
This reverts commit c5991e74bb6f305c299684dc7ac3f6ee9055efcd. This PR broke rust-analyzer's check on save function, so reverting for now Release Notes: - N/A
Lukas Wirth created
2fb89c9
chore: Default settings: Comments: dock option (#36476)
Minor tweak in the wording of the comments for the default settings regarding the `dock` option of the panels, in order to make them congruent across all panels. Release Notes: - N/A
Vincent Durewski created