ab08fe2
sort expanded ranges
Cole Miller created
ab08fe2
sort expanded ranges
Cole Miller created
44231fd
fix diff hunk boundary check
Cole Miller created
c8c6b01
rework trailing newline handling, get to SEEd=97
Cole Miller created
dc1b4e6
special case expansion
Cole Miller created
bb0848d
fix reference excerpt expansion
Cole Miller created
16d93bb
wip
Cole Miller created
c00f5ac
fix seeds 15 and 16
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Cole Miller and Piotr Osiewicz created
4a66906
fix seed 13
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Cole Miller and Piotr Osiewicz created
eaea701
start fixing randomized test
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
68e02d8
wip
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
93d47c5
wip fixing tests
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
4bbba6d
sort out randomized test
Cole Miller created
c2423b4
wip
Cole Miller created
d9326ec
fix more multibuffer tests
Cole Miller created
bf9fa39
Tidyup, try randomly_edit
Conrad Irwin created
26fa0a4
wip
Cole Miller created
231d81c
wip
Cole Miller created
1056543
wip removing fields from buffer state
Cole Miller created
dc5491e
wip
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
657186b
wip getting ready to try changing anchorseektarget
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
cb4ac51
wip
Cole Miller created
403904d
diff hunks
Cole Miller created
ee4eb30
wip
Cole Miller created
0eebdc3
push ExcerptAnchor further
Cole Miller created
e34bfe2
wip introduce ExcerptAnchor
Cole Miller created
aa498e1
selections_in_range
Cole Miller created
72ba581
text_anchors_to_visible_anchors
Cole Miller created
73b5a70
excerpt_offset_for_anchor
Cole Miller created
bd76222
implement anchor summary functions
Cole Miller created
24bd651
wip working on summary_for_anchor
Cole Miller created
a41a5cd
fix some compilation errors with update_excerpts_for_path
Cole Miller created
472aca6
add path key index to anchor
Cole Miller created
f08b5ab
update expand excerpts
Cole Miller created
4e96faa
Update update_path_excerpts
Conrad Irwin created
571c217
Start to remove ExcerptId from multibuffer
Conrad Irwin created
da2bed1
agent: Rename run_turn to send in subagent handle (#50242)
Align better with naming in thread. I grabbed the wrong function name :D Release Notes: - N/A
Ben Brandt created
6a74938
Add fast mode toggle in agent panel (#49714)
This is a staff only toggle for now, since the consequences of activating it are not obvious and quite dire (tokens costs 6 times more). Also, persist thinking, thinking effort and fast mode in DbThread so the thinking mode toggle and thinking effort are persisted. Release Notes: - Agent: The thinking mode toggle and thinking effort are now persisted when selecting a thread from history.
Tom Houlé created
d858f52
settings: Remove unused `file_finder.git_status` setting (#49889)
From the looks of it, this setting was never used by the File Finder. It also doesn’t make much sense to show git info in the File Finder. The Project Panel already exposes this information to the user. Closes #49709. | Before | After | |--------|--------| | <img width="1012" height="769" alt="image" src="https://github.com/user-attachments/assets/9666ace7-38cb-4789-8681-80c15b8ac3fd" /> | <img width="1012" height="769" alt="image" src="https://github.com/user-attachments/assets/5e0505d7-3ede-46fa-bb33-a44865a9f64b" /> | Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Removed unused `file_finder.git_status` setting
Kunall Banerjee created
14f37ed
GPUI on the web (#50228)
Implements a basic web platform for the wasm32-unknown-unknown target for gpui Release Notes: - N/A *or* Added/Fixed/Improved ... --------- Co-authored-by: John Tur <john-tur@outlook.com>
Lukas Wirth and John Tur created
e832531
languages: Add `.prettierrc` to JSON `path_suffixes` (#50156)
`.prettierrc` can be [written](https://prettier.io/docs/configuration)
in either JSON or YAML. Whether you write JSON or YAML, VS Code will
default to recognizing it as JSON. See screenshot.
Without this change, the user is forced to do:
```jsonc
"file_types": {
"JSON": [".prettierrc"],
},
```
Small QoL improvement.
| VS Code | Zed (after the changes) |
|--------|--------|
| <img width="1732" height="1125" alt="image"
src="https://github.com/user-attachments/assets/1f9533fc-a77a-40f3-b8a5-6c36faeccffd"
/> | <img width="1732" height="1125" alt="image"
src="https://github.com/user-attachments/assets/bef8ca94-006c-44bd-ac1c-59f915b67123"
/> |
Closes #50072.
Before you mark this PR as ready for review, make sure that you have:
- [x] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [x] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
Release Notes:
- Added `.prettierrc` to JSON `path_suffixes`
Kunall Banerjee created
13933b8
Handle empty match list and do safe vector selection instead of slicing (#50232)
Handles a panic found in telemetry - when there are no template matches or feature matches, the picker delegate will panic due to an indexing exception. This solves by: 1. Returning early if there are no matches, and 2. Performing safe vector `get` operations instead of slicing, so we can handle a not-found scenario. https://github.com/user-attachments/assets/ac76164d-63aa-4e2b-8555-d8e4f4dd2524 Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed potential crash from initializing devcontainer.json
KyleBarton created
dd9efd9
gpui: Fix `send_file_drop_event` holding mutex during event callback (#50173)
`send_file_drop_event` was the only event dispatch site in window.rs that called the event callback while still holding the `MacWindowState` mutex. every other callback site in the file uses the established `take() / drop(lock) / callback()` pattern which releases the lock before invoking user code. this is a latent code quality issue: no deadlock occurs today because the current file-drop callback chain does not reenter `MacWindowState`'s mutex (`Window::mouse_position()` returns a cached field `Window::refresh()` only marks a dirty flag and `cx.activate()` uses a separate `MacPlatform` mutex). but `parking_lot::Mutex` is not entering so any future platform call added inside a filedrop handler would deadlock immediately and silently. the fix brings `send_file_drop_event` in line with the rest of the file by taking the callback out of the state dropping the lock invoking the callback then reacquiring the lock to restore the callback and update state. Release Notes: - N/A
Albab Hasan created
820774a
agent: Simplify subagent tool and handle (#50230)
Moves parent thread information into the environment, and also models it as a turn on the handle rather than waiting for output. Release Notes: - N/A
Ben Brandt created
be57636
Start removing callers of legacy excerpt APIs (#50144)
Paving the way to remove `ExcerptId`. Done in this PR: - Unshipped the stack trace view - Get rid of `push_excerpts` - Get rid of some callers of `remove_excerpts` We still need to remove some calls to `remove_excerpts` and other APIs, especially in `randomly_edit_excerpts` and collaboration. Release Notes: - The stack trace multibuffer view has been removed. --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller and Conrad Irwin created
8b2829e
language_selector: Auto-select current language when opening (#48475)
Xiaobo Liu created
fc2d805
Fix `Collapse All Files` button being limited to the current buffer (#50076)
Refactor buffer search bar click handler to use listener pattern The click handler for the buffer search bar now uses the `cx.listener` pattern instead of directly dispatching the action. This approach properly binds the action handler to the component's context and ensures consistent behavior with other event handlers in the codebase. Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) before: https://github.com/user-attachments/assets/4fe5eaa4-be5c-4fe5-92d6-60a4f2059f7a after: https://github.com/user-attachments/assets/31238988-b664-4c4b-b143-e4d09c5f0a62 Release Notes: - Fixed the "Collapse All Files" button to work globally, now it's limited to the current buffer --------- Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
0x2CA and Joseph T. Lyons created
c767dcc
Get collab test suite passing (#50214)
The test suite was failing with this error: methods `is_screen_capture_supported` and `screen_capture_sources` are never used. I added allow(dead_code) attribute on both methods to fix it action that was failing: https://github.com/zed-industries/zed/actions/runs/22444029970/job/64993825469 Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
Anthony Eid created
1ad9d59
git: Fix a panic when searching the split diff (#50211)
This could happen when you initiated a search on the left side, then toggled into the unified view, then tried to select the next match. Closes ZED-55G Release Notes: - Fixed a panic when toggling the split diff view while searching.
Cole Miller created
ceb7c0e
Duplicates bot v2: focus on root cause, larger issue body preview (#50209)
Release Notes: - N/A
Lena created
2434a77
ui: Fix modals not using UI font and text color (#50208)
The bug occurred because we weren't setting the right text style on the root div anymore (Multiworkspace), which was introduce in #49995 ### Before <img width="3248" height="2122" alt="image" src="https://github.com/user-attachments/assets/eca71731-5009-4e47-a948-d80eb3f13938" /> ### After <img width="3248" height="2122" alt="image" src="https://github.com/user-attachments/assets/75d8c591-f539-413e-a171-71e4fc847f13" /> Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
Anthony Eid created