Commit log

9f32a6e collab 0.23.3

Max Brunsfeld created

3f66cae Fix error in query for last N channel messages (#3100)

Max Brunsfeld created

1dd82df Use display name for release channel in panic events (#3101)

Click to expand commit body
This was a mistake from long ago - something I've been meaning to fix
for a long time. All other events use `display_name()`, but panic
events, which leads to mistakes when filtering out `Zed Dev`, which
isn't the format that `dev_name()` returns. I'm adding a fix to zed.dev
as well:

- https://github.com/zed-industries/zed.dev/pull/393

so that the values are adjusted for all clients, not just ones with this
fix. I will correct the data in clickhouse, and adjust the queries in
metabase.

Release Notes:

- N/A

Joseph T. Lyons created

81bc86b Use display name for release channel in panic events

Joseph T. Lyons created

663649a Fix error in query for last N channel messages

Max Brunsfeld created

1e557dd Add session id to panic events (#3098)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

456baaa Mainline GPUI2 UI work (#3099)

Click to expand commit body
This PR mainlines the current state of new GPUI2-based UI from the
`gpui2-ui` branch.

Included in this is a performance improvement to make use of the
`TextLayoutCache` when calling `layout` for `Text` elements.

Release Notes:

- N/A

---------

Co-authored-by: Nate Butler <iamnbutler@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>

Marshall Bowers , Nate Butler , and Antonio Scandurra created

2c7e37e Add session id to panic events

Joseph T. Lyons created

c46137e chore: Upgrade to Rust 1.73 (#3096)

Click to expand commit body
Release Notes:
- N/A

Piotr Osiewicz created

b391f56 rust: Highlight async functions in completions (#3095)

Click to expand commit body
Before (code in screenshot is from this branch,
`crates/zed/languages/rust.rs:179`):

![image](https://github.com/zed-industries/zed/assets/24362066/6b709f8c-1b80-4aaa-8ddc-8db9dbca5a5e)
Notice how the last 2 entries (that are async functions) are not
highlighted properly.
After:

![image](https://github.com/zed-industries/zed/assets/24362066/88337f43-b97f-4257-9c31-54c9023e8dbb)

This is slightly suboptimal, as it's hard to tell that this is an async
function - I guess adding an `async` prefix is not really an option, as
then we should have a prefix for non-async functions too. Still, at
least you can tell that something is a function in the first place. :)

Release Notes:
- Fixed Rust async functions not being highlighted in completions.

Piotr Osiewicz created

559433b Fix panic when immediately closing a window while opening paths (#3092)

Click to expand commit body
Fixes this panic that I've been seeing in Slack:


[example](https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1696530575535779)


```
thread 'main' panicked at 'assertion failed: opened_items.len() == project_paths_to_open.len()'
crates/workspace/src/workspace.rs:3628
<backtrace::capture::Backtrace>::create
<backtrace::capture::Backtrace>::new
Zed::init_panic_hook::{closure#0}
std::panicking::rust_panic_with_hook
std::panicking::begin_panic_handler::{{closure}}
std::sys_common::backtrace::__rust_end_short_backtrace
_rust_begin_unwind
core::panicking::panic_fmt
core::panicking::panic
<workspace::Workspace>::new_local::{closure#0}::{closure#0}
```

I believe it was caused by a window being closed immediately, while it
was still loading some paths. There was a mismatch in expectation
between the `workspace::open_items` function (which contains this
assertion), and the `Workspace::load_workspace` method. That later
method can return an empty vector if the workspace handle is dropped
while it is executing.

Release Notes:

- Fixed a crash when closing a Zed window immediately after opening it

Max Brunsfeld created

8fafae2 Fix panic when immediately closing a window while opening paths

Max Brunsfeld created

b3c9473 collab 0.23.2

Max Brunsfeld created

b77c815 Fix bugs in handling mutual following (#3091)

Click to expand commit body
This fixes some bugs in our following logic, due to our attempts to
prevent infinite loops when two people follow each other.

* Propagate all of leader's views to a new follower, even if those views
were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
following that follower.
* Avoid redundant active view updates on the client.

Release Notes:

- Fixed bugs where it was impossible to follow someone into a view that
they previously following you into.

Max Brunsfeld created

37de4a9 Add markdown parsing to channel chat (#3088)

Click to expand commit body
TODO:
- [x] Add markdown rendering to channel chat
- [x] Unify (?) rendering logic between hover popover and chat
- [x] ~~Determine how to deal with document-oriented markdown like `#`~~
Unimportant until we want to do something special with `#channel`
- [x] Tidy up spacing and styles in chat panel

Release Notes:

- Added markdown rendering to channel chat
- Improved channel chat message style
- Fixed a bug where long chat messages would not soft wrap

Mikayla Maki created

c4870e1 re-unify markdown parsing between hover_popover and chat

Mikayla created

438dd42 Fix bugs in handling mutual following

Click to expand commit body
* Propagate all of leader's views to a new follower, even if those views
  were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
  following that follower.
* Avoid redundant active view updates on the client.

Max Brunsfeld created

f57d563 Improve chat rendering

Mikayla created

c853544 Add session id (#3090)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

84ea34f Add session id

Joseph T. Lyons created

44ada52 Fix bug where chat text wouldn't wrap to width

Mikayla created

78b1231 Clear SelectionGoal on input (#3089)

Click to expand commit body
Release Notes:

- `up` and `down` now go to the correct place after inserting

Conrad Irwin created

f1c7432 Clear SelectionGoal on input

Conrad Irwin created

d298afb Create markdown text element and add to channel chat

Mikayla created

acffc7e Remove old code from notes icon click handler (#3085)

Click to expand commit body
Release Notes:

- Fix clicking the notes icon when people are in the channel (preview
only)

Mikayla Maki created

b0e56b7 107 channel touch ups (#3087)

Click to expand commit body
Release Notes:

- Add user avatars to channel chat messages
- Group messages by sender
- Fix visual bugs in new chat and note buttons

Mikayla Maki created

df2fa87 collab 0.23.1

Max Brunsfeld created

a27be35 Ensure chat messages are retrieved in order of id (#3086)

Click to expand commit body
Also, remove logic for implicitly marking chat messages as observed when
they are fetched. I think this is unnecessary, because the client always
explicitly acknowledges messages when they are shown.

Release Notes:

- Fixed a bug where chat messages were shown out of order (preview only)

Max Brunsfeld created

2f3c3d5 Fix hit boxes and hover styles for new buttons

Click to expand commit body
co-authored-by: conrad <conrad.irwin@gmail.com>

Mikayla and conrad created

d09767a Ensure chat messages are retrieved in order of id

Max Brunsfeld created

427a857 Fix panic in increment (#3084)

Click to expand commit body
Release Notes:

- Fixes a panic in vim when incrementing a non-number.

Conrad Irwin created

e984209 save tweaks (#3031)

Click to expand commit body
- use SaveAll instead of Save
- TODO: fix where closing a multi-buffer gives a confusing save prompt

Conrad Irwin created

73e78a2 Adjust channel rendering to group related messages

Mikayla created

f7cd0e8 Remove old code from notes icon click handler

Conrad Irwin created

a4e77af Fix panic in increment

Conrad Irwin created

5074bcc Add image avatars to channel messages

Mikayla created

7d94b03 Fix renaming (#3083)

Click to expand commit body
Release Notes:

- Fix bugs arising from saving an untitled buffer

Conrad Irwin created

ff1722d Fix tracking newly saved buffers

Click to expand commit body
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>

Conrad Irwin and Mikayla Maki created

6cb674a collab 0.23.0

Joseph T. Lyons created

6db4747 v0.108.x dev

Joseph T. Lyons created

01b45f4 Show when a channel resource changes (#3074)

Click to expand commit body
This PR adds a mechanism for notifying the client when a channel note
has been edited or a message has been changed.

TODO: 
- [x] Fix infinite loop when opening the chat panel
- [x] Switch to client-side ack model of observation detection
- [x] Add client-side-only change detection (e.g. for when a channel
note is open locally but not focused)
- [x] Review implementation / query performance.
- [x] Fix lack of ACK on restart for channel buffers
- [x] remove channel note opening on click
- [x] Fix channel messages sent while chat channel is in the background
not showing the channel as changed.

Release Notes:

- N/A

Mikayla Maki created

4d61d01 Add an RPC handler for channel buffer acks

Click to expand commit body
co-authored-by: max <max@zed.dev>

Mikayla and max created

dd0edcd Changed the on-click behavior of joining a channel to not open the chat, and only open 1 project instead of all projects

Click to expand commit body
Co-authored-by: conrad <conrad.irwin@gmail.com>
Co-authored-by: max <max@zed.dev>

Mikayla , conrad , and max created

e548572 Fix channel messages test

Mikayla created

db8096c Fix most tests for new chat changes

Mikayla created

3bc7024 Fix unit test

Click to expand commit body
co-authored-by: Conrad <conrad.irwin@gmail.com>

Mikayla and Conrad created

4ff80a7 Fix a few mouse event id bugs and move facepile to the left

Click to expand commit body
co-authored-by: conrad <conrad.irwin@gmail.com>

Mikayla and conrad created

23ee821 Lower frequency of popup warning when leaving a call

Click to expand commit body
co-authored-by: conrad <conrad.irwin@gmail.com>

Mikayla and conrad created

95342c8 Merge branch 'main' into channel-changes

Max Brunsfeld created

61e0289 Acknowledge channel notes and chat changes when views are active

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created