Commit log

3198eb6 Merge branch 'main' into splits

Mikayla created

9a36402 Use copy button for copy channel link

Joseph T. Lyons created

10b015c Style scrollbars with theme colors (#3588)

Click to expand commit body
This PR updates the styling of scrollbars in the editor to use the theme
colors.

Release Notes:

- N/A

Marshall Bowers created

cd2abc7 Adjust nightly to build twice a day

Joseph T. Lyons created

8ed642d Clear out easy todo!()s

Conrad Irwin created

fe46459 Pull more scrollbar colors from VS Code

Marshall Bowers created

6add173 Style scrollbar when using diff markers

Marshall Bowers created

3271cf1 Map scrollbar colors from VS Code themes

Marshall Bowers created

89884d2 Pull scrollbar colors from theme

Marshall Bowers created

dd42adc Remove warnigns

Conrad Irwin created

b9bbc4a Extend theme colors (#3587)

Click to expand commit body
[[PR Description]]

Title

Release Notes:

- N/A

Nate Butler created

af7c93b Merge branch 'main' into vim2

Conrad Irwin created

c97c9f9 Revert actions! changes

Conrad Irwin created

76cea3e Fire click event only when using left button (#3584)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

ea9a42b Add new colors to themes

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

59d0fea actions3 (#3586)

Click to expand commit body
- Fix action registrations

Release Notes:

- N/A

Conrad Irwin created

b8f9918 Add new colors to One Dark

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

b66b491 Merge branch 'main' into vim2

Conrad Irwin created

6792a21 Add new color defs

Nate Butler created

d678efe Fix some action registrations

Conrad Irwin created

bc130fd Project search2 (#3585)

Click to expand commit body
Semantic search and tests are gonna be shipped in a separate PR.

Release Notes:

- N/A

Piotr Osiewicz created

01ecbec Comment out the tests

Piotr Osiewicz created

ddbd5cf Merge branch 'main' into project_search2

Piotr Osiewicz created

40c1ef8 Add Editor::Tab and CycleMode actions

Piotr Osiewicz created

0b7072b Fire click event only when using left button

Antonio Scandurra created

9f1e7a1 fixup! Further warnings churn

Piotr Osiewicz created

d4a246c Further warnings churn

Piotr Osiewicz created

3c49011 Fix up warnings (automatic)

Piotr Osiewicz created

7330495 Make match index 1-based

Piotr Osiewicz created

3f87c35 Make the query editor expand in size less

Piotr Osiewicz created

66e0650 Forego using dispatch_action for click handlers

Piotr Osiewicz created

db39c3d Fix porting mistake that caused clicking on the editor to misbehave (#3583)

Click to expand commit body
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.

Release Notes:

- N/A

Antonio Scandurra created

fdc0ef8 Maintain focus correctly when activating panes in zed2 (#3582)

Click to expand commit body
Previously, before emitting a `Focus` event from the pane inside of the
`focus_in` listener, we would erroneously check whether the pane's focus
handle was _not_ focused. However, by the time the pane was notified of
being "focused in", the focus handle would already be focused, which was
preventing the pane from ever emitting a `Focus` event. In turn, this
would cause the workspace to not maintain the active pane correctly.

This pull request maintains an explicit `was_focused` boolean as part of
the `Pane` state, which ensures we only emit the `Focus` event the first
time the pane receives focus.

As part of this, I also reworked how the outline view gets deployed to
allow clicking breadcrumbs even when the corresponding pane doesn't have
focus.

Release Notes:

- N/A

Antonio Scandurra created

b4fc8ea Fix porting mistake that caused clicking on the editor to misbehave

Click to expand commit body
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.

Antonio Scandurra created

3c56f6d Focus editor when confirming outline item

Antonio Scandurra created

38d844a fixup! Add major text

Piotr Osiewicz created

5768f14 Emit `Focus` events from `Pane` only when it didn't have focus before

Antonio Scandurra created

e7c14da Show the correct outline when clicking on a breadcrumb

Antonio Scandurra created

1599ee5 Add major text

Piotr Osiewicz created

fe315c6 Bind actions on the whole search bar, not just the query editor

Piotr Osiewicz created

36d2ab4 Always open new project search view `workspace::NewSearch` action (#3581)

Kirill Bulatov created

cdf7c10 Add an action to expand Rust macros with rust-analyzer (#3580)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1282

If rust-analyzer responds with non-empty message, opens a new singleton
multibuffer with the expansion result:

![image](https://github.com/zed-industries/zed/assets/2690773/5f790ffd-1ad8-4f02-a60d-49ee0756362d)

In gpui2, only editors with excerpts containing Rust languages get the
action, in gpui1 every editor (even the *.ts one) has this action
enabled but it does nothing.

Release Notes:

- Added an `editor::ExpandMacroRecursively` command to expand Rust
macros with rust-analyzer.

Kirill Bulatov created

da44b51 Always open new project search view `workspace::NewSearch` action

Kirill Bulatov created

55374e8 Port to gpui1

Kirill Bulatov created

3694265 Finalize the command

Kirill Bulatov created

e3fc810 Draft an expand macro recusively command

Kirill Bulatov created

db8e58b Introduce scrollbars in `editor2` (#3579)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

e3c0b1f Listen for mouse events on scrollbar

Antonio Scandurra created

03df63a Merge remote-tracking branch 'origin/main' into scrollbars2

Antonio Scandurra created

cea26c9 actions3 (#3578)

Click to expand commit body
- Restore impl_actions! and remove derive(Action)

Originally in gpui2 we inferred the action's namespace from the module
it was
defined in. This worked most of the time (ignoring the "remove_the_2"
hack),
but caused unintended (and mostly invisible) behavior in crates with
multiple
modules.

#3577 restored the namespace parameter to actions!, and this PR
reintroduces
`impl_actions!` to do the same for non-unit structs.

I considered trying to keep the struct-attribute API work, because it
does feel
more stylistically appropriate for rust, but two problems lead to it
feeling less good than `impl_actions!` in practice:
1. You have to repeat the namespace for each struct (and usually you're
defining them all in the same namespace)
2. You can't pass an argument to a derive macro inline, you need to use
an attribute instead.


Release Notes:

- N/A

Conrad Irwin created