Commit log

15d8fed collab 0.34.0

Conrad Irwin created

1a993ca Read-only access for channel guests (#3841)

Conrad Irwin created

460b364 Disable Dangerous Downtime-causing Default (#3873)

Click to expand commit body
According to
https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates

you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.

Conrad Irwin created

94d0fe9 Fix current lsp logs menu item not shown as selected (#3916)

Click to expand commit body
Release Notes:

- Fixed current LSP logs menu item not shown as selected

Kirill Bulatov created

12b5dbf Fix current lsp logs menu item not shown as selected

Kirill Bulatov created

c066480 Fix dock right click labels (#3626)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

4644d55 Upgrade `ctor` to v0.2.6 (#3915)

Click to expand commit body
This PR upgrades our version of `ctor` to v0.2.6.

We were previously using a fork that contained this fix:
https://github.com/mmastrac/rust-ctor/pull/295.

A new version of `ctor` has now been released with that change, so we
can switch back to the mainline version.

I scanned through the diff between versions (since we're upgrading from
effectively v0.1.20) and didn't notice anything that seemed obviously
breaking:
https://github.com/mmastrac/rust-ctor/compare/564b87f1dc13cf061ef9997ee501fa5378f35ba1...ee6b4b1c7bd3c9c1edad3b6f4d906e767767ba3d

Release Notes:

- N/A

Marshall Bowers created

3c00528 Merge branch 'main' into channel-guests

Conrad Irwin created

7cc0068 Bump nu tree sitter dependency (#3914)

Click to expand commit body
My contact over at nushell told me they are finally getting some fixes
in on the tree sitter repo, as they have an enthusiastic user running
around opening PRs - figured it would be good to bump this again, since
it wasn't in a great place before.

https://github.com/nushell/tree-sitter-nu/commits/main/

Release Notes:

- Bumped `nu` tree sitter dependency

Joseph T. Lyons created

df0076a Better TestWindow support (#3876)

Click to expand commit body
Adding guest roles led us down a rabbit hole where we'd have liked to
rely on a
side-effect of activating a window in tests; but the test window didn't
implement that.

Looking into that, I realized our TestWindow wasn't doing a great job of
emulating the MacWindow, so this makes the two more similar.

Conrad Irwin created

fa73cf3 Correct dock menu names

Conrad Irwin created

c57a556 Bump nu tree sitter dependency

Joseph T. Lyons created

06ab986 fmt

Conrad Irwin created

ea43d7a Iterate on design of project search bar (#3913)

Click to expand commit body
This PR iterates on the design of the project search bar:

- Mode selections have been updated to use `ToggleButton`s
- Spacing has been added between the various elements.

Release Notes:

- Improved the look of the project search bar.

Marshall Bowers created

5935979 Set a minimum size for the search input field (#3912)

Click to expand commit body
Release Notes:

- Show search input field wider for narrow panes

Kirill Bulatov created

319f18e Use the `editor_background` color for the project search empty state (#3911)

Click to expand commit body
This PR updates the project search empty state to use the same
background color as the editor.

Release Notes:

- Updated the background color of the project search's empty state to
match the editor background.

Marshall Bowers created

6cc48b9 Set a minimum size for the search input field

Kirill Bulatov created

0083ca3 Use the `editor_background` color for the welcome screen's background (#3910)

Click to expand commit body
This PR updates the welcome screen to use the same background color as
the editor.

<img width="1136" alt="Screenshot 2024-01-05 at 11 28 19 AM"
src="https://github.com/zed-industries/zed/assets/1486634/30f2bd7b-e25f-4851-9f43-eb187d1d62e6">

Release Notes:

- Updated the background color of the welcome screen to match the editor
background.

Marshall Bowers created

a205b2d Update call controls & Add tinted buttons (#3886)

Click to expand commit body
This PR introduces Tinted button styles and the `selected_style` field
on buttons to allow replicating the previous design of titlebar call
controls. It also updates the styles of the titlebar controls.

### Creating a tinted button:

```
Button::new("accept-cta", "Accept")
    .style(ButtonStyle::Tinted(TintColor::Accent))
    .on_click(...)
```

Ths button will always be tinted blue.

### Creating a button that becomes tinted when selected::

```rust
IconButton::new("screen-share", Icon::Screen)
    .style(ButtonStyle::Subtle)
    .selected(is_screen_sharing)
    .selected_style(ButtonStyle::Tinted(TintColor::Accent))
    .on_click(...),
```

This button will be flat/subtle by default, but be tinted blue when it
is `selected`.

Note: There appears to be some issue where `is_deafened` isn't
activating correctly, making the speaker icon not toggle when selected.

Release Notes:

- Restore call control styles to a similar look to Zed 1.

Nate Butler created

6c43509 Update titlebar call status icons

Nate Butler created

9d4d58a Implement Tinted buttons and selected_style for buttons

Nate Butler created

c8dcc80 Respect the setting to show/hide the assistant and chat panels (#3909)

Click to expand commit body
This PR makes it so we respect the setting to show/hide the assistant
and chat panels.

Resolves https://github.com/zed-industries/community/issues/2370.

Release Notes:

- Fixed an issue where the settings to show/hide certain panels were not
respected.

Marshall Bowers created

bf11a04 Remove extra dbg!'s

Kirill Bulatov created

eceed71 Avoid leaking `TerminalPanel`, which would in turn leak `Project` (#3908)

Click to expand commit body
Release Notes:

- Fixed a leak that would prevent projects from being automatically
unshared or left when closing the corresponding window.

Antonio Scandurra created

b853937 Avoid leaking `TerminalPanel`, which would in turn leak `Project`

Antonio Scandurra created

92d6a8c Return back git status colors for tab labels (#3906)

Kirill Bulatov created

a984a15 gpui: Use async-task 4.7

Piotr Osiewicz created

3070a6e Return back git status colors for tab labels

Kirill Bulatov created

3e6b4a1 Don't shift pane content when following someone (#3905)

Click to expand commit body
Release Notes:

- Fixed a bug that would shrink the pane when following someone.

Antonio Scandurra created

cf03ea2 Don't shift pane content when following someone

Antonio Scandurra created

fbf2f79 Return back old project search behavior as default. (#3892)

Click to expand commit body
Add a `workspace::DeploySearch` action and use it as a default for
"cmd-shift-f" binding. This action opens existing search tab if it
exists, or creates a new one otherwise. `workspace::NewSearch` action is
still available and always opens an existing search tab.

Release Notes:

- Added a `workspace::DeploySearch` action and use it as a default for
"cmd-shift-f" binding. `workspace::NewSearch` action is still available
and always opens an existing search tab.

Kirill Bulatov created

fff415e Improve deactivate simulation

Conrad Irwin created

1f09f98 Remove un-needed change

Conrad Irwin created

319bfff Fix more tests broken by timing change

Conrad Irwin created

9840a84 Add LeakDetector for gpui2 (#3903)

Click to expand commit body
Needed for debugging some fun following tests

Conrad Irwin created

5037cca Add LeakDetector for gpui2

Click to expand commit body
Co-Authored-By: Julia <julia@zed.dev>

Conrad Irwin and Julia created

22c3eb7 Uncomment editor tests (#3896)

Click to expand commit body
Co-Authored-By: Julia <julia@zed.dev>

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

4a7233f Fixy fix

Conrad Irwin created

a86f401 Moar terminal bugs de2ified (#3894)

Click to expand commit body
Release Notes:

- N/A

Julia created

1d09c9a Fix accidental load of default keymap *after* loading user keymap (#3901)

Max Brunsfeld created

c29a7f2 Fix terminal selection when cursor leaves terminal bounds (#3898)

Click to expand commit body
Previously, terminal mouse selection didn't work when the cursor moved
outside the bounds of the terminal, which made it difficult to select
large amounts of text in the terminal.

Max Brunsfeld created

ad20bc3 Fix accidental load of default keymap *after* loading user keymap

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Mikayla , and Marshall created

783256c Move Registrar implementation for Workspace to outer scope.

Click to expand commit body
This fixes various actions like "Activate regex mode" that were dispatched onto main pane instead of assistant search bar.

Piotr Osiewicz created

b6655de Add DivRegistrar to reduce code duplication

Piotr Osiewicz created

9cdcdbe Use Registrar in Assistant Panel.

Click to expand commit body
This fixes various actions like "Activate regex mode" that were dispatched onto main pane instead of assistant search bar.

Piotr Osiewicz created

5ad125a Touchups to registrar API

Piotr Osiewicz created

f70eddc Explore registrar-based API for search bar.

Click to expand commit body
This commit adds a Registrar trait for use by search crate. Registrar can register actions on some target and search can utilize that trait to opaquely add actions on that target.
Notably, search is now opt-in (it always was in zed2 actually). Having editor doesn't make it searchable straight out of the gate. You might have to call BufferSearchBar::new a bunch more.

Piotr Osiewicz created

cd0b15e fixup! terminal/search: Partially fix search in terminal. There are two issues with search in terminal as is: - terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that workspace::active_pane will *never* return terminal pane as active. - We've had the implementation of as_searchable commented out. Duh!

Piotr Osiewicz created

b3d8b23 terminal/search: Partially fix search in terminal.

Click to expand commit body
There are two issues with search in terminal as is:
- terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that
  workspace::active_pane will *never* return terminal pane as active.
- We've had the implementation of as_searchable commented out. Duh!

This commit fixes second issue. That means that if you drag the terminal over to the main editor pane (so that it's in a "legit" pane), it'll work. 1st issue still stands though.

Piotr Osiewicz created

3f06a05 Iterate on collab panel filter input style (#3900)

Click to expand commit body
This PR takes another pass at the collab panel filter input to improve
its styling.

Release Notes:

- Improved the look of the filter input in the collab panel.

Marshall Bowers created