Commit log

e876262 collab 0.35.0

Conrad Irwin created

fac8ebf Fix error border color for email input in feedback dialog (#3959)

Click to expand commit body
This PR fixes the border color used when the email input in the feedback
dialog is invalid.

Previously this was hardcoded just to `red` instead of using the
appropriate color from the theme.

<img width="653" alt="Screenshot 2024-01-08 at 5 40 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ea01cd76-d661-4512-b668-c82b8d00d84e">

Release Notes:

- Fixed the border color used for the email input in the feedback dialog
when an invalid email is entered.

Marshall Bowers created

475d91a guest acls (#3958)

Click to expand commit body
- First pass of real access control
- Check user is host for host-broadcasted project messages
- Only allow read-write users to update buffers

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

59a1648 Disallow creating files with '..' (#3156)

Click to expand commit body
Release Notes:

- Fixed a crash that could occur when creating files with '..' in the
path

Conrad Irwin created

d7c5d29 Only allow read-write users to update buffers

Conrad Irwin created

71149bc Fix relative path opening from project symbols

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

ae6d09b chore: Extract `assets` module out of zed crate. (#3957)

Click to expand commit body
This essentially shaves off about 10% off of an incremental build after
project change and potentially more if you're changing stuff like
`welcome` that's very close to the `zed` crate in the dep graph. That's
because macro expansion takes place even in incremental builds it seems?
And zed (lib) + zed (bin) could take up to 4 seconds out of an
incremental build, which is a *lot* in a 10s build. In reality though it
shaves 1 second off of 5 seconds incremental 'welcome'/ 1s off of 10s
'project' builds.

Note that we had `assets` crate in the past (removed in #2575 /cc
@maxbrunsfeld), but this is a bit different, because `assets` is a
dependency of *just* zed and nothing else. We essentially cache macro
expansion results ourselves.

Release Notes:

- N/A

Piotr Osiewicz created

80f204f Style the chat panel message input (#3956)

Click to expand commit body
This PR styles the message input in the chat panel.

<img width="242" alt="Screenshot 2024-01-08 at 4 28 33 PM"
src="https://github.com/zed-industries/zed/assets/1486634/48e83692-878e-4891-8e40-8738cdeb23a8">

Release Notes:

- Improved the styling of the message editor in the chat panel.

Marshall Bowers created

c951b4c Fix prevention of cross-channel joins (#3949)

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

aed97f6 Use "test" consistently

Conrad Irwin created

667d901 Improve chat panel empty states (#3955)

Click to expand commit body
This PR improves the empty states for the chat panel:

- The signed-out state has been updated to match our other signed-out
panel states.
- A new state has been added to account for the case where a user is
signed in but doesn't have an active chat.

Release Notes:

- Improved the design of empty states in the chat panel.

Marshall Bowers created

ed76315 Fix prevention of cross-channel joins

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

604fcd8 No .. paths...

Conrad Irwin created

a2a0628 Show context menu on project panel empty space right click (#3954)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2383

Release Notes:

- Fixed context menu not shown when right clicking empty project panel
space

Kirill Bulatov created

35ce34c Show context menu on project panel empty space right click

Kirill Bulatov created

18b31f1 Check user is host for host-broadcasted project messages

Max Brunsfeld created

7235b3d Clean up outline selections when its modal gets closed (#3953)

Click to expand commit body
Release Notes:

- Fixed outline selections not being cleared on certain modal dismiss
actions

Kirill Bulatov created

2ca17bd Clean up outline selections when its modal gets closed

Kirill Bulatov created

dd73054 chore: Fix spurious rebuilds of Zed library and binary (#3952)

Click to expand commit body
Currently when one runs `cargo build` twice without changing anything,
zed lib and binary are gonna get rebuilt every time. I checked out cargo
logs and it turns out we were querying wrong path to `.git/logs/HEAD` in
our build.rs, causing it to rerun on every build and thus marking zed
lib as dirty.

See logs (`CARGO_LOG=cargo::core::compiler::fingerprint=trace cargo
build`):
```
0.501173792s  INFO cargo::core::compiler::fingerprint: fingerprint dirty for zed v0.120.0 (/Users/hiro/Projects/zed/crates/zed)/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/Users/hiro/Projects/zed/crates/zed/build.rs", Edition2021) }
0.501180417s  INFO cargo::core::compiler::fingerprint:     dirty: FsStatusOutdated(StaleItem(MissingFile("/Users/hiro/Projects/zed/crates/zed/.git/logs/HEAD")))
```
The path to .git directory is relative to crates/zed and not to the
workspace's root.

/cc @maxbrunsfeld 

Release Notes:
- N/A

Piotr Osiewicz created

8214a7f Fix inconsistent sizing between the buffer search and the project search (#3951)

Click to expand commit body
This PR fixes the inconsistent sizing between the buffer search and the
project search when both elements have both a primary and secondary item
shown in the toolbar.

Release Notes:

- Fixed some inconsistent sizing in the buffer search and project search
when both have two rows of tools in the toolbar.

Marshall Bowers created

a3bc482 First pass of real access control

Click to expand commit body
Co-Authored-By: Max<max@zed.dev>

Conrad Irwin and Max created

5c28c68 theme: Removed commented-out `ActiveTheme` impl (#3950)

Click to expand commit body
This PR removes a commented-out implementation for the `ActiveTheme`
trait on the `WindowContext`.

We don't need this implementation as we can go through the
`AppContext`'s implementation.

Release Notes:

- N/A

Marshall Bowers created

9b06c66 terminal: Remove resolved TODO (#3948)

Click to expand commit body
This PR removes a resolved TODO in the `terminal` crate.

Release Notes:

- N/A

Marshall Bowers created

00fc22a terminal: Clean up doc comment for `rgb_for_index` (#3947)

Click to expand commit body
This PR cleans up the doc comment for the `rgb_for_index` function.

Release Notes:

- N/A

Marshall Bowers created

1bf7afd Update Copilot UI (#3904)

Click to expand commit body
Updates Zed2 Copilot UI

- Introduces the `Headline` component for rendering large text
- Styles the 3 Copilot prompt states

![CleanShot 2024-01-08 at 13 19
09@2x](https://github.com/zed-industries/zed/assets/1714999/4b58b85f-23aa-4c22-9ca6-d0abd232cf18)
![CleanShot 2024-01-08 at 13 18
55@2x](https://github.com/zed-industries/zed/assets/1714999/0bf71e1d-63b5-4fbb-8672-e42f8602516d)


Release Notes:

- Updated the connect Copilot modal UI.

Nate Butler created

e4b1c76 Display setting documentation in settings.json (#3936)

Click to expand commit body
Let this screenshot of settings.json speak for itself: 

![image](https://github.com/zed-industries/zed/assets/24362066/fca60383-1788-43f9-803b-00f083394c8a)

Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Piotr Osiewicz and Marshall Bowers created

5e401e4 Fix layout shift when renaming a channel (#3946)

Click to expand commit body
This PR fixes the layout shift that would occur in the channel list when
opening a rename editor for a channel.

Release Notes:

- Fixed layout shift when opening a rename editor for a channel.

Marshall Bowers created

72de75d Adjust spacing of extra call participant count indicator (#3945)

Click to expand commit body
This PR adjusts the spacing of the indicator showing the number of extra
call participants that appears after the facepile:

<img width="242" alt="Screenshot 2024-01-08 at 1 09 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6d9cbefa-3b4e-4501-ab11-51026dfb5b6c">

Release Notes:

- Added more space between the call participant facepile and the number
indicating additional call participants.

Marshall Bowers created

b57a1f9 Update copilot ui

Nate Butler created

a8c193c Remove resolved TODO (#3943)

Click to expand commit body
This PR removes a resolved TODO in drawing diff hunk status.

Release Notes:

- N/A

Marshall Bowers created

4ebff57 Fix flaky open_paths_action test (#3944)

Click to expand commit body
I've missed a single run_until_parked call. mb

Release Notes:

- N/A

Piotr Osiewicz created

46a99fe Use correct color for folded diff indicator (#3942)

Click to expand commit body
This PR updates the indicator for changes within a fold to use the
correct color from the theme:

<img width="380" alt="Screenshot 2024-01-08 at 12 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/b8bf6bf3-6acc-43a4-8c4b-a02c975c7f02">

Release Notes:

- Updated the color of the indicator for a fold containing modified
lines.

Marshall Bowers created

2f6bbde Improve styling of tree branches in collab panel (#3941)

Click to expand commit body
This PR updates the styling of the tree branches in the current call
section of the collab panel:

- Fixed the gap between the notes and chat items.
- We now overdraw the tree branch on the notes item so it fills the gap.
- The tree branch lines are now thinner.

<img width="231" alt="Screenshot 2024-01-08 at 12 35 35 PM"
src="https://github.com/zed-industries/zed/assets/1486634/844c9e18-c2de-4163-9384-41d1577e23a0">

Note: I think the signature for `render_tree_branch` could use some
improvement. I don't like having the multiple `bool` parameters, but any
change I could think of was going to be a bit more invasive than I
wanted to take on in this PR.

Release Notes:

- Improved the style of the tree branches in current call details in the
collab panel.

Marshall Bowers created

fd2abb7 Adjust thickness of tree branches

Marshall Bowers created

d3c9626 Comment out test_open_paths_action pending investigation (#3939)

Click to expand commit body
Commenting this one out temporarily to not break CI for folks while I
look into it.
Release Notes:

- N/A

Piotr Osiewicz created

bba3449 Fix Checking Indicator (Diagnostics) (#3940)

Click to expand commit body
Fixes some issues with the Checking icon I added last week.

- Use default text color for "Checking..." text and icon
- Always show text and icon while checks are running

I think we should probably remove the `✅` while checks are running as it
incorrectly indicates nothing is wrong when we don't yet know that – but
that is a larger change so I'll keep this fix contained.

Release Notes:

- Fixes "Checking" diagnostics icon only showing until the first
diagnostics item is found.

Nate Butler created

04f01ab Overdraw the tree branch to avoid gaps

Marshall Bowers created

1ede003 Always show checking with icon if checks are still running

Nate Butler created

c40e45e Use default instead of muted color

Nate Butler created

3541dd8 Tweak message role indicator in the assistant panel (#3938)

Click to expand commit body
This PR tweaks the message role indicator in the assistant panel.

Previously we added a negative margin in #3925 to align the indicator
with the text, but the result of this was the left side of the button
getting clipped on hover.

To remedy this, we now use the filled button style so that the
background always shows and maintains the visual alignment.

### Before

<img width="451" alt="Screenshot 2024-01-08 at 10 50 21 AM"
src="https://github.com/zed-industries/zed/assets/1486634/dd3ae3dc-13c5-4d81-abd7-8023aca496c8">

### After

<img width="401" alt="Screenshot 2024-01-08 at 10 54 42 AM"
src="https://github.com/zed-industries/zed/assets/1486634/c089a879-1c88-4d94-9532-4e9433a35828">

We could also do what we did in Zed1, where the hover style doesn't have
any padding and is flush with the left side of the text, but I don't
think this looks as polished.

The "Assistant" role now also uses a separate color from "System".

Release Notes:

- Updated the style of the message role indicator in the assistant
panel.

Marshall Bowers created

42bd9ff Use filled button style for role indicator in assistant panel

Click to expand commit body
This fixes the left side of the button getting clipped on hover.

Marshall Bowers created

5866420 Use info color for assistant role indicator

Marshall Bowers created

97aed8a Restore ability to reset pane split size by double clicking drag handle. (#3937)

Click to expand commit body
Release notes
- Fixed double clicking on pane drag handle not resetting pane's split
size.
- Fixed pane group sizes not being serialized.

Piotr Osiewicz created

53564fb Bring back zed.rs tests (#3907)

Click to expand commit body
At present 3 tests still fail; 2 are related to keymap issues that (I
believe) @maxbrunsfeld is working on. The other one
(`test_open_paths_action`) I'll look into. edit: done
This PR also fixes workspace unregistration, as we've put the code to do
that behind `debug_assert`
(https://github.com/zed-industries/zed/pull/3907/files#diff-041673bbd1947a35d45945636c0055429dfc8b5985faf93f8a8a960c9ad31e28L649).
Release Notes:
- N/A

Piotr Osiewicz created

d475f13 gpui: Further docs refinement & moved some reexports into 'private' module (#3935)

Click to expand commit body
This commit mostly fixes invalid URLs in docstrings. It also
encapsulates crates we reexport (serde stuff + linkme) into a public
module named "private" in order to reduce the API surfaced through docs.
Moreover, I fixed up a bunch of crates that were pulling serde_json in
through gpui explicitly instead of using Cargo manifest.

Release Notes:
- N/A

Piotr Osiewicz created

eb9ddef Always show full command on terminal tab hover (#3934)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1856

Release Notes:

- Fixed terminal tab tooltip being truncated

Kirill Bulatov created

d566a0d Always show full command on terminal tab hover

Kirill Bulatov created

419b4d0 External file drag and drop (#3933)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1317
Deals with https://github.com/zed-industries/community/issues/486

Reworks pane drag and drop code to support 
* dropping external files into main pane (supports splits same as tabs
and project entries drop) — this will open the file dropped
* dropping external files, tabs and project entries drop into the
terminal — this will add file abs path into the terminal

Release Notes:

- Added a way to drag and drop external files into Zed main & terminal
panes; support tabs and project entries drop into terminal pane

Kirill Bulatov created

df937ea Use fs to determine if file path is a dir

Kirill Bulatov created

e5fbc53 Instrument welcome screen events (#3930)

Click to expand commit body
# TODO

- [x] Fix busted tests
- [x] Check all events from actions on welcome screen
    - [x] change theme
    - [x] change keymap
    - [x] install cli
    - [x] enable vim
    - [x] send metric data
    - [x] send diagnostics
    - [x] close welcome screen
- [X] Check all settings events
    - [x] record theme change (in main and in selector)
    - [x] record base keymap change (in main and in selector)
    - [x] record metric data value
    - [x] record diagnostics value
- [X] Triple check that telemetry settings still block events from being
sent, since we updated how we check for settings changes
- [X] Remove immediate flush mode and allow the flush method to be
called publicly
- [x] Remove references to clickhouse in the code (should be generic at
the client level)

Release Notes:

- N/A

Joseph T. Lyons created