Commit log

5d6af53 Remove unused `PlatformAtlas::clear` method (#4116)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

233ae81 Refactor LanguageSever::fake into FakeLanguageServer::new (#4117)

Click to expand commit body
This is just moving code around and doesn't change behaviour, but it's
something Julia and I bumped into yesterday while writing docs.

Release Notes:

- N/A

Thorsten Ball created

5e6d1a4 Refactor LanguageSever::fake into FakeLanguageServer::new

Click to expand commit body
This is just moving code around and doesn't change behaviour, but it's
something Julia and I bumped into yesterday while writing docs.

Thorsten Ball created

82b48a6 Use a proper action when clicking navigate forward button (#4115)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2428

Release Notes:

- Fixed navigate forward button on click navigating backwards instead

Kirill Bulatov created

5594619 Remove unused `PlatformAtlas::clear` method

Antonio Scandurra created

b6786d5 Use a proper action when clicking navigate forward button

Kirill Bulatov created

ed28170 Always synchronize terminal before rendering it

Click to expand commit body
Previously, we were trying not to synchronize the terminal too often
because there could be multiple layout/paint calls prior to rendering
a frame.

Now that we perform a single render pass per frame, we can just synchronize
the terminal state. Not doing so could make it seem like we're dropping frames.

Antonio Scandurra created

29c81e0 Fix buffer search focus not working (#4113)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/4100
When the Deploy action is called in the buffer with the buffer search
bar already deployed, the focus should be on the search bar.

Release Notes:

- N/A

Kirill Bulatov created

aacb17e Fix buffer search focus not working

Click to expand commit body
When the Deploy action is called in the buffer with the buffer search bar already deployed, the focus should be on the search bar.

Kirill Bulatov created

9240a1a Use try_global() (#4112)

Click to expand commit body
Use `try_global()` in places where we are using the "if global exists,
then give me the global" pattern.

Release Notes:

- N/A

Joseph T. Lyons created

b807e6f Use try_global()

Joseph T. Lyons created

4d9ff5c Simplify service discovery in development

Conrad Irwin created

ef6f39d Upload panics via zed.dev instead

Conrad Irwin created

bef1b83 Add ownership post example

Nathan Sobo created

1d3ca8e Adjust APIs for simpler examples in blog post

Nathan Sobo created

345b983 Improve panic logging

Click to expand commit body
Send along every symbol for inlined frames, and also include the address
(and if we have it filename + lineno)

Conrad Irwin created

6809290 Send crash reports to Slack automatically

Conrad Irwin created

93d068a Update verify_access_token doc comment

Max Brunsfeld created

9f04fd9 For impersonating access tokens, store impersonatee in the new column

Click to expand commit body
This way, we don't need an index on both columns

Max Brunsfeld created

69bff7b Exclude squawk rule forbidding regular-sized integers

Max Brunsfeld created

ab1bea5 Store the impersonator id on access tokens created via ZED_IMPERSONATE

Click to expand commit body
* Use the impersonator id to prevent these tokens from counting
  against the impersonated user when limiting the users' total
  of access tokens.
* When connecting using an access token with an impersonator
  add the impersonator as a field to the tracing span that wraps
  the task for that connection.
* Disallow impersonating users via the admin API token in production,
  because when using the admin API token, we aren't able to identify
  the impersonator.

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

933fb87 Fix editor selection issue (#4110)

Click to expand commit body
Release Notes:

- Fixes a bug where, editor selections would update in the wrong pane
when split.

Mikayla Maki created

aa73510 Add typo detection to CI (#4107)

Click to expand commit body
Adding the typos crate to our CI will take some doing, as we have
several tests which rely on typos in various ways (e.g. checking state
as the user types), but I thought I'd take a first stab at fixing what
it finds.

Release Notes:

- N/A

Mikayla Maki created

58333b9 Adjust config

Mikayla created

6ea23d0 Fix canary

Mikayla created

4070eef Use cargo to install typo check

Mikayla created

edb2045 Fix selection bug in editor causing selections to be un-ended

Mikayla created

9521f49 Clean up references in doc comments in `lsp` crate (#4109)

Click to expand commit body
This PR cleans up a handful of references in doc comments in the `lsp`
crate so that `rustdoc` will link and display them correctly.

Release Notes:

- N/A

Marshall Bowers created

9a3709d Revert vscode theme changes

Mikayla created

ec2b299 settings: Suggest fonts bundled in Zed (#4102)

Click to expand commit body
Fixes an issue where Zed Sans is not being suggested as a font.

Release Notes:
- N/A

Piotr Osiewicz created

078fd35 WIP

Mikayla created

17018fa Update typos.toml

Mikayla Maki created

6cbc49e Editor docs (#4097)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Kirill <kirill@zed.dev>

Piotr Osiewicz and Kirill created

e3e3ef5 Add typos ci

Mikayla created

e42a9ac Add typos configuration for zed and add a few more typo fixes

Mikayla created

647b08b Update local development workflow to not involve zed.dev (#4103)

Click to expand commit body
When testing Zed locally, it's rarely necessary to log in the real with,
via Zed.dev and GitHub. We usually use `zed-local`. Since zed.dev is not
going to be open source (at least right away), this PR removes it from
our local development workflow.

* Remove zed.dev from the Procfile
* Change the `seed` script to not create an admin user for your
signed-in github user
* Instead have both `zed-local` and the `seed` script read from an
`.admins.json` file, which the user can create in order to customize who
they sign in as when running `zed-local`.
* Update all of the docs for building and developing zed.

Max Brunsfeld created

e6ca92f Fix a few more typos

Mikayla created

285f4d1 Fix busted test

Mikayla created

9a7d2e3 fmt

Mikayla created

0711476 Merge branch 'main' into fix-typos

Mikayla Maki created

75f8748 Document party 2 (#4106)

Click to expand commit body
@mikayla-maki and @nathansobo's contributions

Release Notes:

- N/A

Mikayla Maki created

57400e9 Fix typos detected by crate-ci/typos

Mikayla created

6f40da7 Fix scrolling in collab panel (#4105)

Click to expand commit body
When the `List` element's state is `ListState::reset()`, it eagerly
trashes it's cached element heights in anticipation of a prompt render.
But, due to the recent `display_layer` changes, that re-render is not
always forthcoming. This is a problem for `ListState::scroll()`, which
depends on these cached elements to correctly calculate the new logical
scroll offset.

Solutions we attempted:

- Cache the element heights and continue the scroll calculation 
- This was conceptually incorrect, reset should only be called when the
underlying data has been changed, making any calculation with the old
results meaningless.
- Lazily re-compute the element heights in scroll 
- Beyond being a non-trivial refactor, this would probably also cause us
to double-render the list in a single frame, which is bad.
- Cache the scroll offset and only calculate it in paint 
- This solution felt awkward to implement and meant we can't supply
synchronous list scroll events.
- Delay resetting until paint 
- This means that all of the other APIs that `ListState` supplies would
give temporarily incorrect results, worsening the problem

Given these issues, we settled on the solution with the least
compromises: drop scroll events if the state has been `reset()` between
`paint()` and `scroll()`. This shifts the responsibility for the problem
out of the List element and into consumers of `List`, if you want
perfectly smooth scrolling then you need to use `reset()` judiciously
and prefer `splice()`.

That said, I tested this by aggressively scrolling the Collab panel, and
it seems to work as well as it did before.

This PR also includes some initial testing infrastructure for working
with input from the platform and rendered elements.

Release Notes:

- N/A

Mikayla Maki created

9a22327 Add migration information to release docs and fix scripts (#4026)

Click to expand commit body
Release Notes:

- N/A

Mikayla Maki created

9eecda2 Update method name and partially document platform crate

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

7a299e9 Document view crate

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

d67e461 document app module in gpui 🎉

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

8f3d79c Fix file paths in stories (#4104)

Click to expand commit body
This PR fixes some file paths used in our stories that were still
referencing the `ui2` crate.

Release Notes:

- N/A

Marshall Bowers created

6db18e8 Drop scroll events if there's been a reset

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>
co-authored-by: Conrad <conrad@zed.dev>

Mikayla , Nathan , and Conrad created

ad2b4f2 Update procfile and local development docs, zed.dev is no longer needed

Max Brunsfeld created