Commit log

4184686 Lock down test platform implementation

Mikayla created

0176618 Fix typo

Mikayla created

9da6b8c Lock down mac os platform type visibility in the rest of GPUI

Click to expand commit body
Add documentation to all platform types

Mikayla created

29ac1fd Merge remote-tracking branch 'origin/main' into chat-font-size

Conrad Irwin created

6e1f441 Render newlines as newlines in chat

Conrad Irwin created

778856c Add a setting "use_autoclose" to control autoclose

Click to expand commit body
Also disable autoclose for Chat

Conrad Irwin created

72689b0 shift-enter for newline in chat

Conrad Irwin created

42c8135 Fix placeholder height

Conrad Irwin created

a811b15 Resize Nightly icons to same scale as Stable/Preview

Thorsten Ball created

87be105 When searching in visual mode switch to normal mode

Click to expand commit body
This matches Neovim behaviour by setting the mode to `Normal` when using
search while in visual mode.

Co-authored-by: Conrad <conrad@zed.dev>

Thorsten Ball and Conrad created

3310548 Make platform input handler private

Click to expand commit body
Automatically record the context on non-view input handlers
Simplify the async window context update() method

Mikayla created

0858db9 Autocomplete mentions (#4171)

Click to expand commit body
Release Notes:

- Added autocomplete for @-mentions in the chat panel.

Max Brunsfeld created

8fb0270 Make applying of additional completion edits go through the CompletionProvider

Max Brunsfeld created

c8adde3 Add shift-enter binding for newline in auto-height editors

Max Brunsfeld created

739d117 Stop propagation when confirming a completion

Max Brunsfeld created

23d9919 Link previews in chat

Conrad Irwin created

4fb3e6d Ensure editors context menus get at least 3 lines of height

Max Brunsfeld created

24de848 Prevent breadcrumbs from overflowing the toolbar (#4177)

Click to expand commit body
This PR prevents the breadcrumbs from overflowing the toolbar when its
contents are long:

<img width="1270" alt="Screenshot 2024-01-19 at 6 15 58 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ecee7a42-51ef-43d4-99a1-9c3da784dede">

Release Notes:

- Fixed an issue where long breadcrumbs would overflow the toolbar.

Marshall Bowers created

107b801 Fix hover popovers showing up over zoomed panels (#4176)

Click to expand commit body
Release Notes:

- Fixes a bug where open popovers would stay over top of zoomed panels,
if already open when the panel is zoomed.
- Fixes a bug where the terminal would create a selection when clicking
the status bar or title bar.

Mikayla Maki created

25f78a2 Fix terminal selection firing when dragging anywhere

Mikayla created

eaa0e93 Fix hover popovers showing up over zoomed panels

Mikayla created

5dee891 Make chat font sizes consistently small

Conrad Irwin created

7620feb Prevent many call participants from overflowing the title bar (#4173)

Click to expand commit body
This PR fixes an issue where having a lot of participants in a call
could cause the avatars/facepiles to overflow the title bar, pushing the
call controls off-screen.

The participant list will now scroll when it would otherwise exceed the
available space:


https://github.com/zed-industries/zed/assets/1486634/806c77e6-bd4c-4864-8567-92e0960734ee

Release Notes:

- Fixed participant list overflowing the title bar.

Marshall Bowers created

ac350e9 Fix positioning of windows on secondary displays (#4169)

Click to expand commit body
CGDisplayBounds returns data in "global display coordinates" (which are
the same as Zed's coordinates), different from the NS APIs which use
"screen coordinates" (which have the Y axis inverted)

Also remove some transmutes while we're at it

Release Notes:

- Fixed position of notifications on secondary displays

Conrad Irwin created

137e219 Don't toggle WHOLE_WORD in vim search (#4165)

Click to expand commit body
Fixes */# in visual mode, and avoids setting up irritating state.

[[PR Description]]

Release Notes:

- vim: Improved `*` and `#` to not toggle Zed's search state. Instead we
now use the regex to identify start and end of words (more like vim).

Conrad Irwin created

98ef4ce Show cursors sligthly longer (#4172)

Click to expand commit body
2 seconds feels a little jittery, lets try a bit longer

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

af30a9b Show cursors sligthly longer

Conrad Irwin created

139986d Start work on autocomplete for chat mentions

Click to expand commit body
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Conrad , Nathan , and Marshall created

cb84043 Merge branch 'main' into fix-notification-positioning

Conrad Irwin created

1ceccdf Move the details of completion-resolution logic into Project

Click to expand commit body
Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

00e46fd Fix positioning of windows on secondary displays

Click to expand commit body
CGDisplayBounds returns data in "global display coordinates" (which are
the same as Zed's coordinates), different from the NS APIs which use
"screen coordinates" (which have the Y axis inverted)

Also remove some transmutes while we're at it

Conrad Irwin created

df2b0f6 Add more terminal colors to the theme (#4168)

Click to expand commit body
This PR adds more terminal colors that were present in the Zed1 themes
to the Zed2 theme.

Namely, we now have the `dim_` variants for the various ANSI colors and
various `foreground` colors.

Release Notes:

- Improved terminal colors.

Marshall Bowers created

1cc7f66 Fix documentation labels obscuring other content in completion menu (#4167)

Click to expand commit body
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.

#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87">

#### After

<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235">

Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:

<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a">

I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:

<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6">

Release Notes:

- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419](https://github.com/zed-industries/community/issues/2419)).

Marshall Bowers created

2166f07 Fix panic in window open (#4148)

Click to expand commit body
Fix a panic caused by toggleFullScreen on one window untoggling
full-screen on
another.

I managed to reproduce this only once, which makes me sad, but this
change
should fix it regardless.

https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1705631681238979

Release Notes:

- Fixed an occasional panic when opening a new fullscreen window.

Conrad Irwin created

cfbd49c Watch deploys a little closer (#4164)

Click to expand commit body
The current thing of returning before it's done makes me so nervous

Conrad Irwin created

9ec6855 Start work on API docs for the language crate (#3981)

Max Brunsfeld created

0479ebc Don't toggle WHOLE_WORD in vim search

Click to expand commit body
Fixes */# in visual mode, and avoids setting up irritating state.

Conrad Irwin created

ce5adc7 Rename `show cursors` to `display cursor names` (#4162)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

4a92506 Watch deploys a little closer

Conrad Irwin created

0578c1b Style notifications for notification panel (#4163)

Click to expand commit body
This PR styles the notifications for the notification panel.

These are the notification toasts you receive when you have a new
notification (e.g., a mention in chat):

<img width="423" alt="Screenshot 2024-01-19 at 11 39 16 AM"
src="https://github.com/zed-industries/zed/assets/1486634/a1fc7a67-5aad-4cb2-8dc9-35d302984fcb">

Release Notes:

- Improved the look of toasts for incoming notifications.

Marshall Bowers created

595428a Rename `show cursors` to `display cursor names`

Joseph T. Lyons created

01f06f9 Update tenses of doc comment summary lines (#4161)

Click to expand commit body
This PR updates the tenses used by the summary line of doc comments to
match the [Rust API documentation
conventions](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#summary-sentence).

Specifically:

> The summary line should be written in third person singular present
indicative form. Basically, this means write ‘Returns’ instead of
‘Return’.

I'm sure there are plenty occurrences that I missed.

Release Notes:

- N/A

Marshall Bowers created

cb1b791 Allow cursors to be shown via a command (#4153)

Joseph T. Lyons created

14863e9 Fix assistant panel header when viewing conversation history (#4160)

Click to expand commit body
This PR fixes the assistant panel header when in the conversation
history view to hide the irrelevant tools and/or the slots where they
would go.

Release Notes:

- Improved the assistant panel header when viewing conversation history.

Marshall Bowers created

e55e895 Cancel language server requests if request is dropped (#4159)

Click to expand commit body
Before this change, we would send requests to language servers without
canceling them even if we never wait for their response.

Example: when doing document highlights, we'd send a request (modulo
debouncing) whenever a change was made, ignoring previously sent
requests that might still be in-flight.

With this change, we now send a Cancel request (from the LSP spec) to
the language server in case no one listens to the response anymore
(which is what happens when the `Future` returned by `request_internal`)
is dropped.

Release Notes:

- Improved performance when interacting with language servers.

Thorsten Ball created

1a6cd73 Cancel language server requests if request is dropped

Click to expand commit body
Before this change, we would send requests to language servers without
canceling them even if we never wait for their response.

Example: when doing document highlights, we'd send a request (modulo
debouncing) whenever a change was made, ignoring previously sent
requests that might still be in-flight.

With this change, we now send a Cancel request (from the LSP spec) to
the language server in case no one listens to the response anymore
(which is what happens when the `Future` returned by `request_internal`)
is dropped.

Thorsten Ball created

f4e3c4a Remove VS Code config (#4151)

Click to expand commit body
Who uses VS Code anymore?

Release Notes:

- N/A

Marshall Bowers created

bcc13e1 Change struct field name

Joseph T. Lyons created

338dcd7 Center "Open Chat" button in chat panel (#4157)

Click to expand commit body
The layout of the chat panel wasn't correct but this visual glitch was
being masked by caching, because it seems like Taffy was rendering
things slightly differently when laying out the chat panel as a detached
layout node. This wasn't an issue with caching, but rather an
inconsistency with how Taffy lays things out.

Release Notes:

- N/A

Antonio Scandurra created

0b3923a Center "Open Chat" button in chat panel

Click to expand commit body
The layout of the chat panel wasn't correct but this visual glitch
was being masked by caching, because it seems like Taffy was rendering
things slightly differently when laying out the chat panel as a detached
layout node. This wasn't an issue with caching, but rather an inconsistency
with how Taffy lays things out.

Co-Authored-By: Thorsten <thorsten@zed.dev>
Co-Authored-By: Piotr <piotr@zed.dev>

Antonio Scandurra , Thorsten , and Piotr created