Commit log

dd25902 collab 0.41.0

Conrad Irwin created

fc2f5d8 collab fixes (#6720)

Click to expand commit body
- Fail faster on serialization failure
- Move expensive participant update out of transaction

Release Notes:

- Fixed creating/moving channels in busy workspaces

Conrad Irwin created

fbdca99 Format

Conrad Irwin created

adb6f3e Move expensive participant update out of transaction

Click to expand commit body
Co-Authored-By: Marshall <marshall@zed.dev>

Conrad Irwin and Marshall created

ca27ac2 Fail faster on serialization failure

Click to expand commit body
Co-Authored-By: Thorsten <thorsten@zed.dev>

Conrad Irwin and Thorsten created

7068161 Sort `.mailmap` alphabetically (#6711)

Click to expand commit body
This PR sorts the entries in the `.mailmap` file to keep them in
alphabetical order.

Release Notes:

- N/A

Marshall Bowers created

2b844f5 Sort file finder matched entries better (#6704)

Click to expand commit body
* applicable history items were sorted by latest opened order, now
sorted by match score as the search matches
* adjust the match sorting to show paths in the alphanumerical order (in
case of a tie on other params)

Release Notes:

- Improved file finder entries ordering

---------

Co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

50c3ad9 Improve performance of select-all-matches (#6700)

Click to expand commit body
This fixes #6440.

The previous approach was calling select-next-match in a loop, which
leaves optimizations on the table when you already know that you want to
select all of the matches.

So what we did here is to optimize the code for the "give me all
matches" case:

1. Find all results in the current buffer
2. Build up *all* selections
3. Sort selections & throw away overlapping ones (keep oldest)
4. Unfold if necessary
5. Render selections

On my M3 Max searching for `<span` in the test file [1] from the ticket,
it

previously took: ~1.07s
now takes: ~4ms

[1]:
https://github.com/standardebooks/edgar-allan-poe_poetry/blob/master/src/epub/text/poetry.xhtml

![screenshot-2024-01-25-12 49
32@2x](https://github.com/zed-industries/zed/assets/1185253/9f8ef0fa-a3a7-461c-9ed6-263e48835806)

### Release Notes:

- Improved performance of select-all-matches by factor of ~250
([#6440](https://github.com/zed-industries/zed/issues/6440)).

Thorsten Ball created

e13fb31 small refactoring in color crate (#6695)

Click to expand commit body
Make the code more readable

Thomas Coratger created

0a78c67 Improve performance of select-all-matches

Click to expand commit body
This fixes #6440.

The previous approach was calling select-next-match in a loop, which
leaves optimizations on the table when you already know that you want to
select all of the matches.

So what we did here is to optimize the code for the "give me all
matches" case:

1. Find all results in the current buffer
2. Build up *all* selections
3. Sort selections & throw away overlapping ones (keep oldest)
4. Unfold if necessary
5. Render selections

On my M3 Max searching for `<span` in the test file [1] from the ticket,
it

previously took: ~1.07s
now takes: ~4ms

[1]: https://github.com/standardebooks/edgar-allan-poe_poetry/blob/master/src/epub/text/poetry.xhtml

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

062288d Search woes (#6698)

Click to expand commit body
Fixes #6441 
Release Notes:
- Fixed "SelectNextMatch", "SelectPrevMatch" and "SelectAllMatches"
actions not working when search bar is not visible.
- Fixed "SelectPrevMatch" not being bound in project search.

---------

Co-authored-by: Kirill <kirill@zed.dev>

Piotr Osiewicz and Kirill created

dd3ec15 Log error if worktree fails to relativize git repo path (#6693)

Click to expand commit body
This is a follow-up to #6459. It logs the error instead of silently
skipping it.

Release Notes:

- N/A

Thorsten Ball created

d17d37f Log error if worktree fails to relativize git repo path

Click to expand commit body
We saw a panic that was caused by the previous `Option.unwrap()`, so
this changes the method to return a `Result` and logs the error if
possible.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

710e479 Add Conrad and Thorsten to .mailmap file (#6691)

Click to expand commit body
Follow-up to #4138.

Release Notes:

- N/A

Thorsten Ball created

c6e7cf1 bugfix: fix LineEnding for windows (#6688)

Click to expand commit body
fixes a bug when compiling on windows


![image](https://github.com/zed-industries/zed/assets/715417/5a35b1b2-29f4-4987-9410-730c9b287f82)

Release Notes:

- Fixed: compilation error related to `LineEnding` on Windows

Thorsten Ball created

dcf0581 Add Conrad and Thorsten to .mailmap file

Thorsten Ball created

0c4679f bugfix: fix LineEnding for windows

Sharun created

dd07d2f Update cocoa to crates.io version (#6452)

Click to expand commit body
https://github.com/servo/core-foundation-rs/pull/457 was released in
cocoa 0.25, so this patch dependency on github can be removed.

Release Notes:

- N/A

gmorenz created

1c2859d collab errors (#4152)

Click to expand commit body
One of the complaints of users on our first Hack call was that the error
messages you got when channel joining failed were not great.

This aims to fix that specific case, and lay the groundwork for future
improvements.

It adds two new methods to anyhow::Error

* `.error_code()` which returns a value from zed.proto (or
ErrorCode::Internal if the error has no specific tag)
* `.error_tag("key")` which returns the value of the tag (or None).

To construct errors with these fields set, you can use a builder API
based on the ErrorCode type:

* `Err(ErrorCode::Forbidden.anyhow())`
* `Err(ErrorCode::Forbidden.message("cannot join channel").into())` - to
add any context you want in the logs
* `Err(ErrorCode::WrongReleaseChannel.tag("required", "stable").into())`
- to add structured metadata to help the client handle the error better.


Release Notes:

- Improved error messaging when channel joining fails.

Conrad Irwin created

01424a6 Allow prompts to have detail, and use for good

Click to expand commit body
Make channel panel errors louder

Conrad Irwin created

5fcc75b gpui: Add hello world example (#6465)

Click to expand commit body
Added hello world example to the gpui crate copied from https://gpui.rs

Release Notes:

- N/A

Sean Aye created

cf3b2ba Fix panic from unwrapping a relativize() (#6459)

Click to expand commit body
Release Notes:

- Fixed a panic that could occur finding a git repository.

Conrad Irwin created

e77db87 Remove references to community repo (#6466)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

f9170cb Remove references to community repo

Joseph T. Lyons created

bf74892 Clean up docs (#6464)

Click to expand commit body
This PR cleans up some of the Zed meta docs.

Namely:
- Removed references to the `zed-industries/community` repository
- Removed old docs directory (it'll be in Git history if we need it)

Release Notes:

- N/A

Marshall Bowers created

ba97661 Fix backend dependencies link in local collaboration docs (#6461)

Click to expand commit body
Release Notes:

- N/A

Jeff Li created

320088f Fix panic from unwrapping a relativize()

Conrad Irwin created

df420c3 Better naming

Conrad Irwin created

4bcd349 Try to send typed errors back and forth

Click to expand commit body
TEMP

TEMP

First pass of structured errors

Improved error handling for channel joining failures

Conrad Irwin created

8653698 Fix circular locking in prompts (#6456)

Click to expand commit body
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks

Release Notes:

- Fixed a crash when opening the MacOS Save As dialogue.

Conrad Irwin created

a181dc8 Use the correct snapshot when calculating mouse positions (#6453)

Click to expand commit body
Release Notes:

- Fixed a panic in calculating remote cursor positions

Conrad Irwin created

249a6da Fix circular locking in prompts

Click to expand commit body
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks

Conrad Irwin created

f185aca Use the correct snapshot when calculating mouse positions

Conrad Irwin created

6ed7cc7 Simplify language server startup (#6449)

Click to expand commit body
These are just some small refactorings of our language-server-starting
code, motivated by another change that I decided to bail on:
https://github.com/zed-industries/zed/pull/6448.

Max Brunsfeld created

90c1d8f Update `Cargo.lock` (#6445)

Click to expand commit body
This PR updates `Cargo.lock` to reflect the changes made in #6435.

Release Notes:

- N/A

Marshall Bowers created

416696a Fix typo in build instructions (#6444)

Click to expand commit body
Typo fix.

Release Notes:

- N/A

Dragan Okanovic created

1043779 Remove unused dependency (#6435)

Click to expand commit body
[[PR Description]]

The `color` crate is not actually used by the `zed` crate, despite being
listed as a dependency. This PR removes it.

Joseph T. Lyons created

569bb68 Prevent channel from vertically growing when containing facepile (#6439)

Click to expand commit body
Previously at UI font size of 20
 - User-less channel: 28 px tall
 - Occupied channel: 30 px tall
 
Now, still at UI font size 20:
 - User-less channel: 30 px tall
 - Occupied channel: 30 px tall

Release Notes:

- Fixed an issue where a channel would grow in height while showing
participant avatars.

Julia created

9bc968e Prevent channel from vertically growing when containing facepile

Julia created

4ac3095 chat mentions for newly joined users (#5099)

Click to expand commit body
Release Notes:

- Added chat mentions for everyone in the call

Conrad Irwin created

5907bb5 Remove unused dependency

Julian Braha created

28b2c89 Fix crash in feedback modal (#6431)

Click to expand commit body
After the general release we saw a number of crashes due to a SEGFAULT
inside the
System::new() method apparently relating to refreshing the user list.

As we do not need the user list, and the similar code in the telemtry
create is not crashing,
do less work for now.

Release Notes:

- Fixed a crash when opening the feedback modal

Conrad Irwin created

cf3b4b0 Fix: Comment shortcut in Svelte files now respects if the line(s) are HTML vs JS/TS (#5860)

Click to expand commit body
Release Notes:

- Fixed: When using the comment shortcut, previously HTML or JS/TS would
all prefix lines with `// `. This PR brings the comments inline with
what is expected (`// ` for JS/TS, `<!-- ... -->` for HTML). Fixes
[#4578](https://github.com/zed-industries/zed/issues/4578).

Chase Weaver created

71ec781 Fix RUSTSEC-2018-0017 (#5338)

Click to expand commit body
[[PR Description]]

This replaces the `tempdir` crate with `tempfile`, which resolves
[RUSTSEC-2018-0017](https://rustsec.org/advisories/RUSTSEC-2018-0017).

Mikayla Maki created

e1b7b5e Update all links pointing to community (#6434)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

40dbe15 Update all links point to community

Joseph T. Lyons created

6c555fe Fix typos (#6429)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

334dc62 Fix crash in feedback modal

Conrad Irwin created

1a11da9 Fix typos

Joseph T. Lyons created

fc01eee Update links to script

Joseph T. Lyons created