On a .zig files , the `CMD-/` keybinding don't work,
In the language config its the only language with '//' type comment that
is written in singular without array.
This fixed the problem, so i assume it was just a typo

Release notes:
- Fixed line comment continuations and Editor::ToggleComments for Zig, Haskell and PureScript.
Jsonc is a simplified json format which allows comments and unquoted
values delimited by whitespace. A jsonc formatted file can be
unambiguously transformed to a json file. Comments will be stripped out
and quotes added.
Release Notes:
- Added an icon for .jsonc files
d1y
created
4954275
Correctly check existence of target directory in `copy_recursive` function (#6875)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/6778
Release Notes:
- Fixed issue where copy-paste for folders was not working in the
project panel
([#6778](https://github.com/zed-industries/zed/issues/6778)).
George Munyoro
created
9ef830e
update: Add arch and os to release query parameters. (#6976)
Click to expand commit body
This is no-op right now, but we need it for multi-platform support and
(potentially) to split the Universal Binary on mac into two
non-universal targets.
Related to: #6837
Release Notes:
- N/A
Piotr Osiewicz
created
8fbc88b
Load embedded fonts directly from .rdata instead of cloning (#6932)
Click to expand commit body
The fonts we embed in Zed binary (Zed Sans & Zed Mono) weigh about 30Mb in total and we are cloning them several times during startup and loading of embedded assets (once explicitly in Zed and then under the hood in font-kit). Moreover, after loading we have at least 2 copies of each font in our program; one in .rdata and the other on the heap for use by font-kit.
This commit does away with that distinction (we're no longer allocating the font data) and slightly relaxes the interface of `TextSystem::add_fonts` by expecting one to pass `Cow<[u8]>` instead of `Arc<Vec<u8>>`. Additionally, `AssetSource::get` now returns `Cow<'static, [u8]>` instead of `Cow<'self, [u8]>`; all existing implementations conform with that change.
Note that this optimization takes effect only in Release builds, as the library we use for asset embedding - rust-embed - embeds the assets only in Release mode and in Dev builds it simply loads data from disk. Thus it returns `Cow<[u8]>` in it's interface. Therefore, we still copy that memory around in Dev builds, but that's not really an issue.
This patch makes no assumptions about the build profile we're running under, that's just an intrinsic property of rust-embed.
Tl;dr: this should shave off about 30Mb of memory usage and a fair chunk (~30ms) of startup time.
Release Notes:
- Improved startup time and memory usage.
Hey all. This is a follow-up to my last PR
https://github.com/zed-industries/zed/pull/6821. I went through and
applied the same style changes to more pages so your docs are more
consistent.
<img width="1330" alt="image"
src="https://github.com/zed-industries/zed/assets/18583882/b9adbb38-b98d-47c6-b585-7e298ffae854">
Note that some pages from your old docs repo haven't been ported to
`zed-industries/zed` yet.
Release Notes:
- Improved documentation consistency.
Kieran Gill
created
6cd306e
docs: Add initial language settings documentation (#6957)
Click to expand commit body
This pull request implements the following documentation changes:
- [x] Copy existing language settings docs from old docs repo
- [x] Add new pages for Zig, Haskell, Gleam, Deno and PureScript
- [x] Add `rust-analyzer` target directory section to Rust language page
Release Notes:
- Added initial language settings documentation
([#4264](https://github.com/zed-industries/zed/issues/4264)).
Brian Ginsburg
created
5d0c144
theme_importer: Define more colors in `VsCodeTheme` (#6960)
Click to expand commit body
This PR extends the `VsCodeTheme` struct with more of the colors
available on a VS Code theme.
Release Notes:
- N/A
Marshall Bowers
created
331b6e7
Support "dtx" vim key combination when "x" is immediately to the right of the cursor (#6830)
Click to expand commit body
Closes #4358
The bug originates on this line:
https://github.com/zed-industries/zed/blob/5db7e8f89ee4f5d9801a2eab88adc1db3fda0f46/crates/vim/src/motion.rs#L451
- When running "dtx" on "ˇabcx", the range to delete is 0 -> 2 ("abc")
- When running "dtx" on "abˇcx", the range to delete is 2 -> 2 ("c"), so
`new_point == point` and the function incorrectly returns `None` and "c"
is not deleted
- We need to disambiguate between the "not found" case and the "found
immediately to the right" case
- This bug does not apply to the backwards case ("dTx")
Release Notes:
- Fixed "dtx" vim key combination when "x" is immediately to the right
of the cursor (#4358)
Conrad Irwin
created
4ab1d8a
Add support for u and U in vim visual mode (#6948)
Click to expand commit body
This pull request adds support for upper / lower casing a visual
selection with `u` or `U` respectively, and resolves #6901.
I took an approach to split out the logic of the existing `ChangeCase`
action into something that could be reused for the two new actions. One
area that I could use feedback on is whether or not vim binding updates
make sense. Judging purely from the way things work from a clean install
of Vim / Neovim, I'm pretty sure that it's a bug that `u` applies an
undo in visual mode, so I think it's safe to make this change, but it
changes a behavior that some users may be used to by now in Zed.
Release Notes:
- Added support for `u` and `U` in Vim visual mode
([#6901](https://github.com/zed-industries/zed/issues/6901)).
92911de
Update top ranking issues script to take in a day interval (#6951)
Click to expand commit body
Switch to `poetry`
Update script to take in a `query-day-interval` argument, so we can make
a report from all issues or just n last days.
Release Notes:
- N/A
Closes https://github.com/zed-industries/zed/issues/6916
Specification:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspaceEdit
Adds a safe minimum of the capabilities that Zed supports already,
allowing rust-analyzer to send file edits on rename.
Release Notes:
- Fixed rust module rename from editor not renaming the FS entries
([6916](https://github.com/zed-industries/zed/issues/6916))
Kirill Bulatov
created
444f918
Retrieve credentials for saved conversations (#6949)
Click to expand commit body
This PR fixes an issue where credentials for saved conversations weren't
being fully retrieved, which was preventing continuing a conversation
with the assistant in a saved conversation.
Release Notes:
- Fixed continuing a saved conversation with the Zed assistant.
Marshall Bowers
created
52f7f2d
Update name of function to match other implementation
Brooks Swinnerton
created
c0c0aba
Add support for u and U in vim visual mode
Brooks Swinnerton
created
8e523d8
Fix #4628: npm install to a wrong location (#6742)
Click to expand commit body
By default `npm install` will walk up the folder tree checking for a
folder that contains either a package.json file, or a node_modules
folder. If such a thing is found, then that is treated as the effective
"current directory" for the purpose of running npm commands.
This caused npm dependencies for language servers sometimes to be
installed in the wrong folder, described in #4628.
Adding `--prefix ./` to `npm install` forces
node_runtime.npm_install_packages to install packages in provided path
even if node_modules dir exists somewhere up the filesystem tree from
installation path.
Julia
created
1f82a2a
Remove obviated comment in `zed-licenses.toml` (#6946)
Click to expand commit body
This PR removes a comment from `zed-licenses.toml`, as it no longer
applies now that we don't have `buildLicenses.ts` anymore.
Release Notes:
- N/A
027f055
Update casing of "OpenAI" in identifiers to match Rust conventions (#6940)
Click to expand commit body
This PR updates the casing of "OpenAI" when used in Rust identifiers to
match the [Rust naming
guidelines](https://rust-lang.github.io/api-guidelines/naming.html):
> In `UpperCamelCase`, acronyms and contractions of compound words count
as one word: use `Uuid` rather than `UUID`, `Usize` rather than `USize`
or `Stdin` rather than `StdIn`.
Release Notes:
- N/A
Marshall Bowers
created
e8bf06f
Style crate names in `CONTRIBUTING.md` (#6939)
Click to expand commit body
This PR styles the crate names in `CONTRIBUTING.md` using inline code.
Release Notes:
- N/A
Marshall Bowers
created
5dec9f7
Link to the Zed roadmap in `CONTRIBUTING.md` (#6937)
Click to expand commit body
This PR updates `CONTRIBUTING.md` to link to the public Zed roadmap.
Release Notes:
- N/A
Marshall Bowers
created
f7b6bfe
chore: Remove rerun-if-changed clause that might cause spurious rebuilds (#4193)
Click to expand commit body
Something is stomping over the timestamp of generated scene.h right
after the build script finishes:
`Dirty gpui v0.1.0 (/Users/someonetoignore/work/zed/zed/crates/gpui):
the file target/debug/build/gpui-ca04eedfe8d0e13c/out/scene.h has
changed (1705922004.637000680s, 1s after last build at
1705922003.507431315s)`
^ That's an output of `-v` flag added to either `cargo run` or `cargo
build`.
This comes up when you do `cargo build` followed by `cargo run` or
another `cargo build`; the artifact is not getting reused, even though
it should be possible?
Release Notes:
- N/A
This should be a standard recognized by everyone
```bash
mkdir todo
touch todo/.gitkeep # just placeholder
git add todo
git commit
```
Release Notes:
- Added icon for `.gitkeep` files.
This icon is designed based on [Ruby's official logo], to harmonize with
the other icons.
It is deformed and simplified to be human-recognizable, even at letter
size.
[Ruby's official logo]: https://www.ruby-lang.org/en/about/logo/
Release Notes:
- Added Ruby file icon.
This PR replaces a usage of an IIFE with `maybe!`.
Release Notes:
- N/A
Marshall Bowers
created
bbdf401
Use `async_maybe!` instead of inline IIFEs (#6906)
Click to expand commit body
This PR replaces instances where we were using an async IIFE with the
`async_maybe!` macro.
Release Notes:
- N/A
Marshall Bowers
created
5b9cc26
Gracefully handle errors when loading themes (#6904)
Click to expand commit body
This PR improves the theme loading to gracefully handle when a theme
couldn't be loaded.
Trying to debug a panic that happens on startup in Nightly.
Release Notes:
- N/A
Marshall Bowers
created
dfad36f
Upgrade `tree-sitter-php` to v0.21.1 (#6902)
Click to expand commit body
This PR upgrades `tree-sitter-php` to v0.21.1.
Here is the diff between our current version and this version:
https://github.com/tree-sitter/tree-sitter-php/compare/d43130fd1525301e9826f420c5393a4d169819fc...29a49d3a53353444ee2226e2efa140fec69dd3e0
The primary impetus for this change is to get this change that adds the
`license` field to the `Cargo.toml`:
https://github.com/tree-sitter/tree-sitter-php/pull/193
This will silence the warning that is shown when running
`script/generate-licenses`.
Release Notes:
- Upgraded `tree-sitter-php` to v0.21.1.
This PR bumps our version of `tree-sitter-haskell` for the addition of
the `license` field in
https://github.com/tree-sitter/tree-sitter-haskell/pull/112.
This will silence the warning that is shown when running
`script/generate-licenses`.
Release Notes:
- N/A
Marshall Bowers
created
9b453d2
Remove old themes using `UserTheme` constructs (#6897)
Click to expand commit body
This PR removes the themes defined using the `UserTheme` types, as we're
now loading the themes via JSON.
The `theme_importer` has also been reworked to read in a VS Code theme
and output a new JSON theme.
Release Notes:
- N/A
This PR changes the theme loading to use the JSON themes bundled with
the binary rather then the Rust theme definitions.
### Performance
I profiled this using `cargo run --release` to see what the speed
differences would be now that we're deserializing JSON:
**Before:** `ThemeRegistry::load_user_themes` took 16.656666ms
**After:** `ThemeRegistry::load_user_themes` took 18.784875ms
It's slightly slower, but not by much. There is probably some work we
could do here to bring down the theme loading time in general.
Release Notes:
- N/A
This PR adds serialized versions of each of the themes that currently
ship with Zed.
In a future PR we'll be looking to make these the canonical
representations of the built-in themes.
Note that we're intentionally repurposing the `theme_importer` to do
this, so that crate is a bit rough-and-ready at the moment.
Release Notes:
- N/A
- check hidden files
- fix a typos in a hidden file
- ignore "ba" typos in a more specific way
- ignore a typo in collab/migrations/ literally
Release Notes:
- N/A
Viktor Szépe
created
1564bd8
Add installation instructions to README (#6870)
Click to expand commit body
This PR adds installation instructions to the README, with a note on
which platforms we currently support.
Release Notes:
- N/A
Marshall Bowers
created
bd39258
Address a couple comments re Ruby file associations (#6863)
Click to expand commit body
Release Notes:
- Fixed: Address a [couple comments re Ruby file
associations](https://github.com/zed-industries/zed/pull/6812#discussion_r1468437144)
Stuart Hinson
created
ac3e0af
fix: move anyhow dependency to dependencies (#6866)
Click to expand commit body
Was moved by mistake in: ebbe52e6b0a33458956e1db400ba07f0e33398c3
This was throwing errors everywhere on Linux because anyhow is needed by
the code and is not macOS dependent.
Release Notes:
- N/A
William Desportes
created
0a0a866
Licenses: change license fields in Cargo.toml to AGPL-3.0-or-later. (#5535)