9f2c541
Fetch 100 results per page (#33124)
Click to expand commit body
Release Notes: - N/A
Joseph T. Lyons created
9f2c541
Fetch 100 results per page (#33124)
Release Notes: - N/A
Joseph T. Lyons created
9597c73
Account for issue types in top-ranking issues script (#33118)
Release Notes: - N/A
Joseph T. Lyons created
7812985
linux: Fix blurry rendering on Wayland when using fractional scaling (#33087)
Closes #25195 In Wayland, To create buffer size (`renderer.update_drawable_size`), we convert logical pixels to device pixels by taking the scale factor into account. Later, we also let the compositor know the logical pixels we want to use for our app (`viewport.set_destination`). Then, the compositor takes our buffer and tries to scale it to fit the viewport size we provided. If this is accurate, we see perfect rendering. If our buffer size is not accurate (off by 1px in this case), the compositor scales our buffer to fit the viewport size. This causes blur. To make sure we set correct buffer size for renderer as same as what compositor is going to use, we needs to use rounding instead of truncate when converting logical pixels to device pixels. It's not super clear from docs, what exact algorithm it uses but it says it uses rounding and seems to fix issue for me if we follow that for our buffer. From https://wayland.app/protocols/fractional-scale-v1: > If a surface has a surface-local size of 100 px by 50 px and wishes to submit buffers with a scale of 1.5, then a buffer of 150px by 75 px should be used and the wp_viewport destination rectangle should be 100 px by 50 px. > > For toplevel surfaces, the size is **rounded halfway away from zero**. The rounding algorithm for subsurface position and size is not defined. Tested on: - [x] Gnome - [x] KDE - [ ] ~Sway~ (Need to investigate this more for Sway) Release Notes: - Fixed blurry rendering on Wayland when using fractional scaling for Gnome and KDE. Co-authored-by: Julia Ryan p1n3appl3@users.noreply.github.com Co-authored-by: Antonio Scandurra me@as-cii.com
Smit Barmase , Julia Ryan p1n3appl3@users.noreply.github.com , and Antonio Scandurra me@as-cii.com created
b0f192e
agent: Do not send stale files notifications (#32974)
Removing it for two reasons: 1. We need a better implementation that doesn't hurt caching and doesn't distracts the agent too much (see https://github.com/zed-industries/zed/pull/32876 for more context) 2. Current insertion point of notifications doesn't play well with Claude Thinking models (see https://github.com/zed-industries/zed/issues/33000#issuecomment-2991709484) I think we should get this code back in a form of a tool. But for now, I'm dropping it to resolve recent issues. Closes #33000 Release Notes: - N/A
Oleksiy Syvokon created
c9e5ff2
docs: Update manifest keys in debugger extension docs (#33085)
This is silly and caused at least one of our users a lot of confusion. Closes #33040 Release Notes: - N/A
Piotr Osiewicz created
c02e249
windows: Simplify the logic of `handle_get_min_max_info_msg` (#33102)
Release Notes: - N/A
张小白 created
a7bbbc0
Fix handling of `--diff` flag (#33094)
* Restore the ability to combine --diff with other path arguments * Restore combining --diff with --wait There is still one defect in the current handling of `--diff`: when Zed is already open, we'll open the diff view in your current active zed window. It would be better to search all of the open zed windows for any window containing the diffed paths, but implementing that is a bit complex. Currently, the logic for *picking* an existing zed window is coupled to the logic for opening buffers in that window. I'd like to decouple it, but I wanted to keep this change small, so that we hotfix it to stable without too much risk. Release Notes: - Fixed a bug where the `--diff` CLI flag did not work with `--wait` Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Max Brunsfeld and Ben Brandt created
f8a0eb5
Fix capslock on windows (#33093)
The new feature doesn't work well on windows Release Notes: - N/A
张小白 created
d97a58b
debugger: Refresh variable list on set variable value response (#33078)
Variable list wasn't notified when a set variable value request was successfully. This caused the variable list and inline values to show stale data in some cases, which this PR fixes. Release Notes: - debugger: Fix bug where setting a variable's value wouldn't update the variable list or inline values
Anthony Eid created
10f0aab
docs: Update development debugger guide to include Zed's debugger (#33080)
Closes #33069 Release Notes: - N/A
Anthony Eid created
2624950
agent: Fix text wrapping in the provider set up list items (#33063)
Release Notes: - agent: Fixed text wrapping in the provider set up list items in the settings view.
Danilo Leal created
ca3f1d6
Ensure compiled extensions work with older Zed versions (#33051)
Closes #33039 This PR fixes a bug which causes the newest versions of the Biome and Tombi extensions to not work with older Zed versions. The bug occurs because in #32822, the type of the debug adapter and debug locators was changed from a Vec to a BTreeMap. However, these fields were already introduced much earlier in Zed, which now causes the de-serialization of the `extension.toml` to fail for older Zed versions. Any extension compiled with the newest extension CLI bumped in https://github.com/zed-industries/extensions/pull/2866 will not work with older Zed versions prior to v0.191. By adding this change and bumping the extension CLI again, this could be prevented. On de-serialization, we would just fallback to either a Vec for versions prior to v0.190 or a BTreeMap after. Feel free to let me know what you think here. Release Notes: - N/A
Finn Evers created
00fe195
debugger: Move breakpoint management to the pane strip (#33062)
Closes #ISSUE Release Notes: - debugger: Moved "remove breakpoint" button to the top of a breakpoint list"
Piotr Osiewicz created
bca1a91
Make pull diagnostics remote test more robust (#33057)
Follow-up of https://github.com/zed-industries/zed/pull/33028 Due to request races, we cannot predict the amount of result_id s that we'll get. Ensure their amount grows monotonically each time. This time, iterations=5000 did not fail for me. Release Notes: - N/A
Kirill Bulatov created
b89ddf3
agent: Improve layout shift on previous message editor (#33055)
Follow up to https://github.com/zed-industries/zed/pull/32765. This PR creates a slot for the `message_editor::create_editor` to allow using different values for min and max lines. In practice, the panel's main editor now has a minimum of 4 lines, whereas the previous message editor has just one. This makes the layout shift when clicking on a previous message to edit it much smaller. Release Notes: - agent: Improved layout shift when clicking to edit a previous sent message.
Danilo Leal created
5c7e90d
agent: Move focus to the panel after sending a user message edit (#33049)
Follow up to https://github.com/zed-industries/zed/pull/31611. Closes https://github.com/zed-industries/zed/issues/33005. Release Notes: - agent: Fixed a bug where, after confirming editing a previous user message while zoomed in, the focus went to the buffer and the panel got closed.
Danilo Leal created
61abfd5
agent: Avoid layout shift due to the "waiting for confirmation" label (#33046)
Just a tiny, one-line change to avoid the "Waiting for Confirmation" animated label pushing the "allow" buttons to the side. Release Notes: - agent: Fixed layout shift in "waiting for confirmation" state in the terminal card.
Danilo Leal created
ddaa8b3
agent: Expand disclosure click area in setting view's provider section (#33041)
Previously, you could only expand the provider item in the agent panel settings view by clicking on the little chevron icon button. Now, you can click on the whole title area (minus the button, when present) to do that. Just that little bit more convenient to interact with it. Release Notes: - N/A
Danilo Leal created
3b31db1
open_router: Avoid redundant model list downloads (#33033)
Previously, the OpenRouter models list (~412kb) was being downloaded around 10 times during startup -- even when OpenRouter was not configured. This update addresses the issue by: 1. Fetching the models list only when OpenRouter settings change. 2. Skipping API calls if OpenRouter is not configured. Release Notes: - Avoid unnecessary requests to OpenRouter
Oleksiy Syvokon created
1f736ed
copilot: Remove PromptTokensDetails from Usage struct (#33029)
Closes #33024 Release Notes: - Removed `PromptTokensDetails` from `Usage` as Gemini no longer supplies cached token data for copilot.
Umesh Yadav created
0b228ad
debugger: Fix issues with debugging scripts from package.json (#32995)
- [x] Pass in cwd - [x] Use the appropriate package manager - [x] Don't mix up package.json and composer.json Release Notes: - debugger: Fixed wrong arguments being passed to the DAP when debugging scripts from package.json.
Cole Miller created
e914d84
copilot: Fix config dir logic to support Flatpak environments (#32901)
Closes #30784 In github copilot we were not handling the config path correctly for FLATPAK. * Only tested on mac don't have access to other platform. But this should work on other platform as well. It follows the similar pattern seen in zed config path resolution. - [x] Macos - [ ] Linux - [ ] Linux with Flatpak - [ ] Windows Release Notes: - Fix copilot config detection for flatpack
Umesh Yadav created
ec0f2fa
agent: Fix button ids for resetting keys in OpenAI settings (#33032)
These "Reset API Key" and "Reset API URL" button had the same ids, so therefore, they weren't working. Release Notes: - N/A
Danilo Leal created
1bd49a7
linux: Add title bar for rules library (#33025)
Closes #30513 - Abstract away common wrapper component to `platform_title_bar`. - Use it in both zed and rules library. - For rules library, keep traffic like only style for macOS, and add custom title bar for Linux and Windows. Release Notes: - Added way to minimize, maximize, and close the rules library window for Linux.
Smit Barmase created
c8d4940
Fix pull diagnostics on the remote clients (#33028)
Also add a test. Release Notes: - Fixed pull diagnostics on the remote clients
Kirill Bulatov created
e202981
editor: Scale minimap width to editor width (#32317)
Evan Simkowitz created
dec7bae
Revert "client: Fix an issue where non-IP proxy URLs didn’t resolve c… (#33013)
This reverts commit bc68455320f1be3f3a135ea1c0de24c026990286. More bugs... Closes #32838 Release Notes: - N/A
张小白 created
2839c2e
Fix document colors not showing on file reopen (#33009)
Closes https://github.com/zed-industries/zed/issues/32989 Release Notes: - Fixed document colors not showing on file reopen
Kirill Bulatov created
0e94ca2
debugger: Refine session modal design (#33004)
This PR makes all footer elements in the debugger session modal more consistent, as well as fixes some weird UI quirks with leaking borders and whatnot. Took the opportunity to do some light style clean up and use `prelude::*` for UI imports. Release Notes: - N/A
Danilo Leal created
804b91a
agent: Improve the UX around interacting with MCP servers (#32622)
Still a work in progress! Todos before merging: - [x] Allow to delete (not just turn off) an MCP server from the panel's settings view - [x] Also uninstall the extension upon deleting the server (check if the extension just provides MCPs) - [x] Resolve repository URL again - [x] Add a button to open the configuration modal from the panel's settings view - [x] Improve modal UX to install and configure a non-extension MCP Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Danilo Leal , Bennet Bo Fenner , and Ben Brandt created
526faf2
docs: Ruby debug configuration should be an array (#32991)
Closes #ISSUE Small correction for something I noticed while setting up the debugger today. Release Notes: - N/A
Jeff Bonhag created
6e64628
Silence another backtrace-full log (#32990)
Release Notes: - N/A
Kirill Bulatov created
522d92f
docs: Add instructions for how to use v0 via OpenAI (#32983)
Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>
Danilo Leal and Bennet Bo Fenner created
cec19ae
Omit outlines from the outline panel, not related to the buffer's main language (#32987)
Closes https://github.com/zed-industries/zed/issues/15122 Release Notes: - Fixed outline panel showing extra languages' outlines
Kirill Bulatov created
c34b24b
open_ai: Fix issues with OpenAI compatible APIs (#32982)
Ran into this while adding support for Vercel v0s models: - The timestamp seems to be returned in Milliseconds instead of seconds so it breaks the bounds of `created: u32`. We did not use this field anywhere so just decided to remove it - Sometimes the `choices` field can be empty when the last chunk comes in because it only contains `usage` Release Notes: - N/A
Bennet Bo Fenner created
05f944b
Add up and down global bindings for `menu::SelectNext` and `menu::SelectPrevious` (#32981)
Closes https://github.com/zed-industries/zed/discussions/32587 Release Notes: - Fixed Linux keybindings not having up/down keys bound for menu navigation
Kirill Bulatov created
629bd42
agent: Add ability to change the API base URL for OpenAI via the UI (#32979)
The `api_url` setting is one that most providers already support and can be changed via the `settings.json`. We're adding the ability to change it via the UI for OpenAI specifically so it can be more easily connected to v0. Release Notes: - agent: Added ability to change the API base URL for OpenAI via the UI --------- Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>
Danilo Leal and Bennet Bo Fenner created
ab189b8
vim: Fix escape key switching back to default mode instead of normal mode (#31843)
Closes #31728 This PR introduced new setting `"helix_mode"`. Enabling which will enable the `vim_mode` along with `helix` behavior. This solves issue where `vim`'s `default_mode` was being used to switch between mode instead of opening in `default_mode`. When `helix_mode` is enabled switcing to `Normal mode` will now switch to `HelixNormal` Release Notes: - Fixed - escape key not switching to normal mode when default_mode is insert - Added - `helix_mode` setting to enable/disable helix key bindings --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Sanjeev Shrestha and Conrad Irwin created
d2ca68b
copilot chat: Remove invalid assertions (#32977)
Related to #32888, but will not fix the issue.
Turns out these assertions are wrong (Not sure if they were correct at
some point).
I tested with this code:
```
request = LanguageModelRequest {
messages: vec![
LanguageModelRequestMessage {
role: Role::User,
content: vec![MessageContent::Text("Give me 10 jokes".to_string())],
cache: false,
},
LanguageModelRequestMessage {
role: Role::Assistant,
content: vec![MessageContent::Text("Sure, here are 10 jokes:".to_string())],
cache: false,
},
],
..request
};
```
The API happily accepted this and Claude proceeded to tell me 10 jokes.
Release Notes:
- N/A
Bennet Bo Fenner created
72a3292
Add a small script to make debugging the CLI easier (#32971)
Release Notes: - N/A
Mikayla Maki created
ccb4644
docs: Fix `lsp.rust-analyzer.binary` config (#32967)
Document the `lsp.rust-analyzer.binary.arguments` setting (currently incorrectly referred to as `args`) Verify: https://github.com/zed-industries/zed/blob/99215f7660a722461792e49cb920bfda5c801286/crates/extension_api/wit/since_v0.1.0/settings.rs#L24-L29 Question: can such inconsistencies be avoided by automatically documenting the config using a preprocessor? Release Notes: - N/A
Artem Zhurikhin created
fdd307c
collab: Add automatic install of minio deb or rpm to script/bootstrap (#32968)
Release Notes: - N/A
Michael Sloan created
c1d0d72
Fix a bug where --diff wouldn't open the diff (#32962)
Release Notes: - Fixed a bug where `zed --diff A B` wouldn't open a diff
Mikayla Maki created
db99d71
debugger: Add onboarding modal (#32961)
- **debugger: Add debugger onboarding modal (wip)** - **woops** Release Notes: - debugger: Added the onboarding modal. --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Julia Ryan <p1n3appl3@users.noreply.github.com>
Piotr Osiewicz , Danilo Leal , and Julia Ryan created
99215f7
debugger: Run debug scenarios from package.json (#32958)
Release Notes: - New session modal for a debugger will now show tasks from package.json as debuggable scenarios --------- Co-authored-by: Remco Smits <djsmits12@gmail.com> Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Piotr Osiewicz , Remco Smits , and Anthony Eid created
73fee01
docs: Remove beta tag from Debugger (#32950)
Release Notes: - N/A
Danilo Leal created
74aa227
Wait for source maps when setting TypeScript breakpoints (#32954)
Closes #ISSUE Release Notes: - debugger: Fix setting breakpoints in typescript code when debugging compiled javascript
Conrad Irwin created
d0e909e
Add Anthropic ZDR to AI improvement documentation (#32955)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
morgankrey created
aa9daca
editor: Log error instead of panic on index out of bounds for line layouts (#32953)
Closes #30191 `line_ix` should never exceed the bounds of `line_layouts`, but a panic happens on out-of-bounds for this, which seems weird. I couldn’t reproduce this panic at all. Since this is for displaying inline blame, we now log an error if this occurs instead of panicking. Release Notes: - N/A
Smit Barmase created
48491fa
Bump Zed to v0.193 (#32947)
Release Notes: -N/A
Joseph T. Lyons created