0180f3e
deepseek: Fix for max output tokens blocking completions (#45236)
Click to expand commit body
They count the requested max_output_tokens against the prompt total.
Seems like a bug on their end as most other providers don't do this, but
now we just default to None for the main models and let the API use its
default behavior which works just fine.
Closes: #45134
Release Notes:
- deepseek: Fix issue with Deepseek API that was causing the token limit
to be reached sooner than necessary
Ben Brandt
created
5488a19
terminal: Respect RevealStrategy::NoFocus and Never focus settings (#45180)
Click to expand commit body
Closes #45179
## Summary
Fixes the focus behavior when creating terminals with
`RevealStrategy::NoFocus` or `RevealStrategy::Never`. Previously,
terminals would still receive focus if the terminal pane already had
focus, contradicting the documented behavior.
## Changes
- **`add_terminal_task()`**: Changed focus logic to only focus when
`RevealStrategy::Always`
- **`add_terminal_shell()`**: Same fix
The fix changes:
```rust
// Before
let focus = pane.has_focus(window, cx)
|| matches!(reveal_strategy, RevealStrategy::Always);
// After
let focus = matches!(reveal_strategy, RevealStrategy::Always);
```
## Impact
This affects:
- Vim users running `:!command` (uses `NoFocus`)
- Debugger terminal spawning (uses `NoFocus`)
- Any programmatic terminal creation requesting background behavior
Release Notes:
- Fixed terminal focus behavior to respect `RevealStrategy::NoFocus` and
`RevealStrategy::Never` settings when the terminal pane already has
focus.
rabsef-bicrym
created
bb1198e
languages: Allow using locally installed `ty` for Python (#45193)
Click to expand commit body
Release Notes:
- Allow using locally installed `ty` for Python
Henry Chu
created
69fe27f
Keep tab stop-less snippets in completion list (#45227)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/45083
cc @agu-z
Release Notes:
- Fixed certain rust-analyzer snippets not shown
Kirill Bulatov
created
469da2f
gpui: Fix Windows credential lookup returning error instead of `None` when credentials don't exist (#45228)
Click to expand commit body
This spams the log with amazon bedrock otherwise
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
4f87822
gpui: Persist window bounds and display when detaching a workspace session (#45201)
Click to expand commit body
Closes #41246 #45092
Release Notes:
- N/A
**Root Cause**:
Empty local workspaces returned `DetachFromSession` from
`serialize_workspace_location()`, and the `DetachFromSession` handler
only cleared the session_id **without saving window bounds**.
**Fix Applied**:
Modified the `DetachFromSession` handler to save window bounds via
`set_window_open_status()`:
```rust
WorkspaceLocation::DetachFromSession => {
let window_bounds = SerializedWindowBounds(window.window_bounds());
let display = window.display(cx).and_then(|d| d.uuid().ok());
window.spawn(cx, async move |_| {
persistence::DB
.set_window_open_status(database_id, window_bounds, display.unwrap_or_default())
.await.log_err();
persistence::DB.set_session_id(database_id, None).await.log_err();
})
}
```
**Recording**:
https://github.com/user-attachments/assets/2b6564d4-4e1b-40fe-943b-147296340aa7
This was from an early iteration and this code path isn't used anymore
Release Notes:
- N/A
Ben Brandt
created
54f360a
Add a test to ensure we invalidate brackets not only on edits (#45219)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/45187
Release Notes:
- N/A
Kirill Bulatov
created
b2a0b78
acp: Change default for gemini back to managed version (#45218)
Click to expand commit body
It seems we unintentionally changed the default behavior of if we use
the gemini on the path in #40663
Changing this back so by default we use a managed version of the CLI so
we can better control min versions and the like, but still allow people
to override if they need to.
Release Notes:
- N/A
Ben Brandt
created
f1ca2f9
workspace: Fix new projects opening with default window size (#45204)
Click to expand commit body
Previously, when opening a new project (one that was never opened
before), the window bounds restoration logic would fall through to
GPUI's default window sizing instead of using the last known window
bounds.
This change consolidates the window bounds restoration logic so that
both empty workspaces and new projects use the stored default window
bounds, making the behavior consistent: any new window will use the last
resized window's size and position.
Closes #45092
Release Notes:
- Fixed new files and projects opening with default window size instead
of the last used window size.
MostlyK
created
4b34ade
Update Mistral models context length to their recommended values (#45194)
Click to expand commit body
I noticed some of mistral models context lenghts were outdated, they
were updated accordingly to mistral documentation.
The following models had their context lenght changed:
[mistral-large-latest](https://docs.mistral.ai/models/mistral-large-3-25-12)
[magistral-medium-latest](https://docs.mistral.ai/models/magistral-medium-1-2-25-09)
[magistral-small-latest](https://docs.mistral.ai/models/magistral-small-1-2-25-09)
[devstral-medium-latest](https://docs.mistral.ai/models/devstral-2-25-12)
[devstral-small-latest](https://docs.mistral.ai/models/devstral-small-2-25-12)
Follow up to https://github.com/zed-industries/zed/pull/44297.
Initial implementation in ce884443f1c38ca8da9edf9fbbb8e7fd579452cb used
`Arc` to store the reference to the hash map inside the iterator while
keeping the lifetime static. The code was later simplified in
5151b22e2ea37fb457cf4f88b88fe4f315306074 to build the list eagerly but
the Arc was forgotten, although it became unnecessary.
cc @bennetbo
Release Notes:
- N/A
Oleksii Orlenko
created
cdc5cc3
Return back the eager snapshot update (#45210)
Click to expand commit body
Based on
https://github.com/zed-industries/zed/pull/45187#discussion_r2630140112
Release Notes:
- N/A
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Kirill Bulatov
and
Lukas Wirth
created
0f7f540
Always invalidate tree-sitter data on buffer reparse end (#45187)
Click to expand commit body
Also do not eagerly invalidate this data on buffer reparse start
Closes https://github.com/zed-industries/zed/issues/45182
Release Notes:
- Fixed bracket colorization not applied on initial file open
Kirill Bulatov
created
184001b
docs: Add note about conflicting global macOS shortcut (#45186)
Click to expand commit body
This is already noted in our `default-macos.json`, but was never
surfaced in our docs for some reason. A user noted their LSP completions
were not working because they were not aware of the conflicting global
shortcut.
Ref:
https://github.com/zed-industries/zed/issues/44970#issuecomment-3664118523
Release Notes:
- N/A
Kunall Banerjee
created
225a2a8
google_ai: Refactor token count methods in Google AI (#45184)
Click to expand commit body
The change simplifies the `max_token_count` and `max_output_tokens`
methods by grouping Gemini models with identical token limits.
Release Notes:
- N/A
Xiaobo Liu
created
ea37057
Restore generic modal closing on mouse click (#45183)
Click to expand commit body
Was removed in
https://github.com/zed-industries/zed/pull/44887/changes#diff-1de872be76a27a9d574a0b0acec4581797446e60743d23b3e7a5f15088fa7e61
Release Notes:
- (Preview only) Fixed certain modals not being dismissed on mouse click
outside
Kirill Bulatov
created
77cdef3
Attempt to fix the autofix auto scheduler (#45178)
Click to expand commit body
Release Notes:
- N/A
Conrad Irwin
created
05108c5
agent_ui: Make tool call raw input visible (#45097)
Click to expand commit body
<img width="500" height="1246" alt="Screenshot 2025-12-17 at 9 28@2x"
src="https://github.com/user-attachments/assets/eddb290d-d4d0-4ab8-94b3-bcc50ad07157"
/>
Release Notes:
- agent: Made tool calls' raw input visible in the agent UI.
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Torstein Sørnes
and
Danilo Leal
created
07538ff
Make sweep and mercury API tokens use `cx.global` instead of `OnceLock` (#45176)
9073a26
Revert "git: Mark entries as pending when staging a files making the staged highlighting more "optimistic"" (#45175)
Click to expand commit body
Reverts zed-industries/zed#43434
This caused a regression because the additional pending hunks don't get
cleared.
Cole Miller
created
843a35a
extension api: Make server id types constructible, to ease writing tests (#45174)
Click to expand commit body
Currently, extensions cannot have tests that call methods like
`label_for_symbol` and `label_for_completion`, because those methods
take a `LanguageServerId`, and that type is opaque, and cannot be
constructed outside of the `zed_extension_api` crate.
This PR makes it possible to construct those types from strings, so that
it's more straightforward to write unit tests for these LSP adapter
methods.
Release Notes:
- N/A
0c9992c
terminal: Forward Ctrl+V when clipboard contains images (#42258)
Click to expand commit body
When running Codex CLI, Claude Code, or other TUI agents in Zed’s
terminal, pasting images wasn’t supported — Zed
treated all clipboard content as plain text and simply pushed it into
the PTY, so the agent never saw the image data.
This change makes terminal pastes behave like they do in a native
terminal: if the clipboard contains an image, Zed now emits a raw Ctrl+V
to the PTY so the agent can read the system clipboard itself.
Release Notes:
- Fixed terminal-launched Codex/Claude sessions by forwarding Ctrl+V for
clipboard images so agents can attach them
Kingsword
created
cec4607
git_ui: Preserve newlines in commit messages (#45167)
Click to expand commit body
Closes #44982
Release Notes:
- Fixed Git panel to preserve newlines in commit messages
Mayank Verma
created
f9b69ae
Fix Wayland platform resize resulting in non-interactive window (#45153)
Click to expand commit body
Closes #40361
Release Notes:
- Linux(Wayland): Fixed an issue where the settings window would not
respond to user interaction until resized
Ben Kunkle
created
f00cb37
macOS: Bundle placeholder Document.icns so Finder can display Zed file icons (#44833)
Click to expand commit body
Generated by AI.
`DocumentTypes.plist` declares `CFBundleTypeIconFile` as `Document` for
Zed’s document types, but the macOS bundle did not include
`Contents/Resources/Document.icns`, causing Finder to fall back to
generic icons.
This PR:
- Adds `crates/zed/resources/Document.icns` as a placeholder document
icon (currently derived from the app icon).
- Updates `script/bundle-mac` to copy it into the `.app` at
`Contents/Resources/Document.icns` during bundling.
- Adds `script/verify-macos-document-icon` for one-command validation.
## How to test (CLI)
1. Build a debug bundle:
- `./script/bundle-mac -d aarch64-apple-darwin`
2. Verify the bundle contains the referenced icon:
- `./script/verify-macos-document-icon
"target/aarch64-apple-darwin/debug/bundle/osx/Zed Dev.app"`
## Optional visual validation in Finder
- Pick a file (e.g. `.rs`), Get Info → Open with: Zed Dev → Change
All...
- Restart Finder: `killall Finder` (or log out/in)
@JosephTLyons — would you mind running the steps above and confirming
Finder shows Zed’s icon for source files after "Change All" + Finder
restart?
@danilo-leal — this PR ships a placeholder `Document.icns`. When the
real document icon is ready, replace
`crates/zed/resources/Document.icns` and the bundling script will
include it automatically.
Closes #44403.
Release Notes:
- TODO
---------
Co-authored-by: Matt Miller <mattrx@gmail.com>
Nathan Sobo
and
Matt Miller
created
25e1e2e
Don't trigger autosave on focus change in modals (#45166)
Click to expand commit body
Closes #28732
Release Notes:
- Opening the command palette or other modals no longer triggers
auto-save with the `{ "autosave": "on_focus_change" }` setting. This
reduces the chance of unwanted format changes when executing actions,
and fixes a race condition with `:w` in Vim mode
I think we're not triggering the after-release workflow because of
github's loop detection when you use the default GITHUB_TOKEN
Closes #ISSUE
Release Notes:
- N/A
Closes #26424
Supersedes #35328
Originally, `git::blame` uses its own `ParsedCommitMessage` as the
source for the commit information, including the PR section. This
changes unifies this with `git::repository` and `git_ui::git_panel` by
moving this and some other commit-related structs to `git::commit`
instead, and making both `git_ui::blame_ui` and `git_ui::git_panel` pull
their information from these structs.
Release notes :
- (Let's Git Together) Fixed the commit tooltip in the git panel not
showing information like avatars.
---------
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
LoricAndre
,
Cole Miller
, and
Zed Zippy
created
302a4bb
git panel: Fix file path truncation and add some UI code clean up (#45161)
Click to expand commit body
This PR ensures truncation works for the file paths, which should set up
the stage for when the new GPUI `truncation_start` method lands
(https://github.com/zed-industries/zed/pull/45122) so that we can use
for them. In the process of doing so and figuring it out why it wasn't
working as well before, I noticed some opportunities to clean up some UI
code: removing unnecessary styles, making the file easier to navigate
given all of the different UI conditions, etc.
Note: You might notice a subtle label flashing that comes with the label
truncation and that's a standalone GPUI bug that's also visible in other
surface areas of the app. I don't think it should block these changes
here as it's something we should fix on its own...
Release Notes:
- N/A
Danilo Leal
created
c4f8f2f
Use less generic globs for JSONC to avoid overmatching (#45162)
Click to expand commit body
Otherwise, all *.json files under `zed` directory will be matched as
JSONC, e.g `zed/crates/vim/test_data/test_a.json` which is not right.
On top, `globset` considers that `zed/crates/vim/test_data/test_a.json`
matches `**/zed/*.json` glob (!).
Release Notes:
- N/A
Kirill Bulatov
created
52c7447
gpui: Add Vietnamese chars to `LineWrapper::is_word_char` (#45160)
Cameron Mcloughlin
created
65f7412
A couple new inline assistant tests (#45049)
Click to expand commit body
Also adjust the code for streaming tool use to always use a
rewrite_section; remove insert_here entirely.
Release Notes:
- N/A
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Michael Benfield
and
Max Brunsfeld
created
8aab646
terminal: Improve regex hyperlink performance for long lines (#44721)
Click to expand commit body
Related to
- #44407
This PR further improves performance for regex hyperlink finding by
eliminating unnecessary regex matching. Currently, we repeatedly search
for matches from the start of the line until the match contains the
hovered point. This is only required to support custom regexes which
match strings containing spaces, with multiple matches on a single line.
This isn't actually a useful scenario, and is no longer supported. This
PR changes to only search twice, the first match starting from the start
of the line, and the hovered word (space-delimited). The most dramatic
improvement is for long lines with many words.
In addition to the above changes, this PR:
- Adds test for the scenarios from #44407 and #44510
- Simplifies the logic added in #44407
Performance measurements
For the scenario from #44407, this improves the perf test's iteration
time from 1.22ms to 0.47ms.
main:
| Branch | Command | Iter/sec | Mean [ms] | SD [ms] | Iterations |
Importance (weight) |
|:---|:---|---:|---:|---:|---:|---:|
| main |
terminal_hyperlinks::tests::path::perf::pr_44407_hyperlink_benchmark |
819.64 | 937.60 | 2.20 | 768 | average (50) |
| this PR |
terminal_hyperlinks::tests::path::perf::pr_44407_hyperlink_benchmark |
2099.79 | 1463.20 | 7.20 | 3072 | average (50) |
Release Notes:
- terminal: Improve path hyperlink performance for long lines
Dave Waggoner
created
9ad059d
copilot: Add support for Next Edit Suggestion (#44486)
Click to expand commit body
This PR introduces support for Next Edit Suggestions while doing away
with calling legacy endpoints. In the process we've also removed support
for cycling completions, as NES will give us a single prediction, for
the most part.
Closes #30124
Release Notes:
- Zed now supports Copilot's [Next Edit
Suggestions](https://code.visualstudio.com/blogs/2025/02/12/next-edit-suggestions).
Piotr Osiewicz
created
0d0a082
Fix windows path canonicalization (#45145)
Click to expand commit body
Closes #44962
Release Notes:
- N/A
localcc
created
8146322
Support opening and saving files with legacy encodings (#44819)
Click to expand commit body
## Summary
Addresses #16965
This PR adds support for **opening and saving** files with legacy
encodings (non-UTF-8).
Previously, Zed failed to open files encoded in Shift-JIS, EUC-JP, Big5,
etc., displaying a "Could not open file" error screen. This PR
implements automatic encoding detection upon opening and ensures the
original encoding is preserved when saving.
## Implementation Details
1. **Worktree (Loading)**:
* Updated `load_file` to use `chardetng` for automatic encoding
detection.
* Files are decoded to UTF-8 internal strings for editing, while
preserving the detected `Encoding` metadata.
2. **Language / Buffer**:
* Added an `encoding` field to the `Buffer` struct to store the detected
encoding.
3. **Worktree (Saving)**:
* Updated `write_file` to accept the stored encoding.
* **Performance Optimization**:
* **UTF-8 Path**: Uses the existing optimized `fs.save` (streaming
chunks directly from Rope), ensuring no performance regression for the
vast majority of files.
* **Legacy Encoding Path**: Implemented a fallback that converts the
Rope to a contiguous `String/Bytes` in memory, re-encodes it to the
target format (e.g., Shift-JIS), and writes it to disk.
* *Note*: This fallback involves memory allocation, but it is necessary
to support legacy encodings without refactoring the `fs` crate's
streaming interfaces.
## Changes
- `crates/worktree`:
- Add dependencies: `encoding_rs`, `chardetng`.
- Update `load_file` to detect encoding and decode content.
- Update `write_file` to handle re-encoding on save.
- `crates/language`: Add `encoding` field and accessors to `Buffer`.
- `crates/project`: Pass encoding information between Worktree and
Buffer.
- `crates/vim`: Update `:w` command to use the new `write_file`
signature.
## Verification
I validated this manually using a Rust script to generate test files
with various encodings.
**Results:**
* ✅ **Success (Opened & Saved correctly):**
* **Japanese:** `Shift-JIS` (CP932), `EUC-JP`, `ISO-2022-JP`
* **Chinese:** `Big5` (Traditional), `GBK/GB2312` (Simplified)
* **Western/Unicode:** `Windows-1252` (CP1252), `UTF-16LE`, `UTF-16BE`
* ⚠️ **limitations (Detection accuracy):**
* Some specific encodings like `KOI8-R` or generic `Latin1` (ISO-8859-1)
may partially display replacement characters (`?`) depending on the file
content length. This is a known limitation of the heuristic detection
library (`chardetng`) rather than the saving logic.
Release Notes:
- Added support for opening and saving files with legacy encodings
(Shift-JIS, Big5, etc.)
---------
Co-authored-by: CrazyboyQCD <53971641+CrazyboyQCD@users.noreply.github.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Ichimura Tomoo
,
CrazyboyQCD
, and
Conrad Irwin
created
e8807e5
git: Fix tree view folders not opening when file inside is selected (#45137)
Click to expand commit body
Closes #44715
Release Notes:
- Fixed git tree view folders don't open when file inside is selected
Xipeng Jin
created
73f129a
git: New actions for git panel navigation (#43701)
Click to expand commit body
I could not find any related issue, but at least I want to use the git
panel like this :)
Being used to `lazygit`, this PR makes navigation of the git panel more
similar to the CLI tool.
Instead of selecting -> enter'ing for skimming each file, I just want to
move between the files in the git panel and have the diff multibuffer
advance to the appropriate file. This also adheres to the behavior of
the outline panel, which I like better.
If the multibuffer is not active, it behaves same as before (just
selecting the file in the panel, nothing else).
I did not modify existing `menu::Select*` actions in case anybody still
prefers previous behavior.
https://github.com/user-attachments/assets/2d1303d4-50c8-4500-ab3b-302eb7d4afda
Release Notes:
- Improved navigation of the git panel, by advancing the "Uncommitted
Changes" multibuffer to the current selected file. To restore the old
behavior, you can bind `up` and `down` to `menu::SelectPrevious` and
`menu::SelectNext` under the `GitPanel` context in your keymap.
Co-authored-by: Cole Miller <cole@zed.dev>
Luis Cossío
and
Cole Miller
created
fa529b2
agent_ui_v2: Fix broken LICENSE-GPL symlink pointing to itself (#45136)
Click to expand commit body
Fix broken LICENSE-GPL symlink that was pointing to itself instead of
the LICENSE-GPL file in the root of the repo.
It caused jujutsu to freak out and made it impossible to work with the
repo using it without switching to raw git:
```
Internal error: Failed to check out commit 22d04a82b119882e7aed88fb422430367c4df5f9
Caused by:
1: Failed to validate path /Users/aqrln/git/zed/crates/agent_ui_v2/LICENSE-GPL
2: Too many levels of symbolic links (os error 62)
```
Release Notes:
- N/A
Add support for the new Gemini 3 Flash model
Release Notes:
- Added support for Gemini 3 Flash model
Richard Feldman
created
83ca2f9
Add Vim-like Which-key Popup menu (#43618)
Click to expand commit body
Closes #10910
Follow up work continuing from the last PR
https://github.com/zed-industries/zed/pull/42659. Add the UI element for
displaying vim like which-key menu.
https://github.com/user-attachments/assets/3dc5f0c9-5a2f-459e-a3db-859169aeba26
Release Notes:
- Added a which-key like modal with a compact, single-column panel
anchored to the bottom-right. You can enable with `{"which_key":
{"enabled": true}}` in your settings.
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
Xipeng Jin
,
Conrad Irwin
, and
Zed Zippy
created
847457d
Fix a bug where switching the disable AI flag would cause a panic (#45050)
The below memory leaks were caused by failing to release reference
counted resources. I confirmed using instruments that my changes stopped
the leaks from occurring.
- System prompts
- Screen capturing
- loading font families
There were also two memory leaks I found from some of our dependencies
that I made PRs to fix
- https://github.com/RustAudio/coreaudio-rs/pull/147
- https://github.com/servo/core-foundation-rs/pull/746
Release Notes:
- N/A
This updates our CI workflow to try to run the autofix.yml workflow
if any of prettier, cargo fmt, or cargo clippy fail.
Release Notes:
- N/A
Conrad Irwin
created
c56eb46
Add davidbarsky to community champion labelers (#45132)
Miguel Raz Guzmán Macedo
created
ec6702a
Remove global workspace trust concept (#45129)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/44887
Trims the worktree trust mechanism to the actual `worktree`s, so now
"global", workspace-level things like `prettier`, `NodeRuntime`,
`copilot` and global MCP servers are considered as "trusted" a priori.
In the future, a separate mechanism for those will be considered and
added.
Release Notes:
- N/A
Kirill Bulatov
created
f084e20
Fix stale pending keybinding indicators on focus change (#44678)
Click to expand commit body
Closes #ISSUE
Problem:
- The status bar’s pending keystroke indicator (shown next to --NORMAL--
in Vim mode) didn’t clear when focus moved to another context, e.g.
hitting g in the editor then clicking the Git panel. The keymap state
correctly canceled the prefix, but observers that render the indicator
never received a “pending input changed” notification, so the UI kept
showing stale prefixes until a new keystroke occurred.
Fix:
- The change introduces a `pending_input_changed_queued` flag and a new
helper `notify_pending_input_if_needed` which will flushes the queued
notification as soon as we have an App context. The
`pending_input_changed` now resets the flag after notifying subscribers.
Before:
https://github.com/user-attachments/assets/7bec4c34-acbf-42bd-b0d1-88df5ff099aa
After:
https://github.com/user-attachments/assets/2264dc93-3405-4d63-ad8f-50ada6733ae7
Release Notes:
- Fixed: pending keybinding prefixes on the status bar now clear
immediately when focus moves to another panel or UI context.
---------
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Xipeng Jin
,
Nathan Sobo
, and
Conrad Irwin
created