00097df
Improve C/C++ indentation flow for single statement blocks (#34549)
Click to expand commit body
Before this, indentation did not automatically increase after
if/for/while/do/else statements in C++, and only increased after if/for
in C. This led to Zed using last line logic when inserting lines *after*
the indented statement, as well as not indenting the statement itself,
resulting in irregular indentation during typing.
Just adding indentation (similar to C) creates a new problem: now if a
scope is started with a brace on a new line, that brace is indented.
Thus we need to deindent it.
Using else_clause in the indent guide results in the else statement
being indented forward as well, so we need to deindent that too.
Note: the most significant issue for me is the one where indentation
jumps forward when inserting lines after indented lines. Unfortunately,
it appears that fixing that issue requires all of these other changes. I
would have preferred a simpler fix, but I'm not sure if disabling last
line behavior for C/C++ is appropriate as it probably breaks something
else, like cases where the file is incomplete and the statements can't
be parsed properly.
Editing flow before this change:
[Screencast From 2025-07-16
08-31-36.webm](https://github.com/user-attachments/assets/3dea86c5-47bd-47c2-aee8-b0aa613948e6)
Editing flow after this change:
[Screencast From 2025-07-16
08-35-36.webm](https://github.com/user-attachments/assets/7ef23e60-1ee3-49fd-90f9-d53f909ca674)
(note: the "else" snippet is completely breaking the flow here, but I
think that comes from clangd by default? Unfortunately I haven't found a
way to disable it cleanly but that is a separate problem that happens
right now too.)
Release Notes:
- Improve indentation during typing for C/C++ around if/for/while/do
blocks
Arseny Kapoulkine
created
c133223
docs: Document pull diagnostics support for Ruby (#34028)
Click to expand commit body
This is now supported.
Release Notes:
- N/A
Andy Waite
created
c1307ce
Add `;` key binding for Helix mode (#34315)
Click to expand commit body
Closes #34111
In Helix mode, the `;` key should collapse the current selection without
moving the cursor. I've added a new action `vim::HelixCollapseSelection`
to support this behavior.
https://github.com/user-attachments/assets/1a40821a-f56f-456e-9d37-532500bef17b
Release Notes:
- Added `;` key binding to collapse the current text selection in Helix
mode
Daniel Sauble
created
8a7bd5f
agent: Adjust retry on Burn Mode layout (#34680)
Click to expand commit body
Quick follow-up to https://github.com/zed-industries/zed/pull/34669 so
that the buttons don't look so big in comparison to the callout.
Release Notes:
- N/A
Danilo Leal
created
c287397
Rename "CloseInactiveItems" action to "CloseOtherItems" (#34676)
Click to expand commit body
This is following feedback from folks that were searching the "close
others" action, available in the tab's context menu, and not finding it
because it was actually named "close inactive", which was confusing. So,
this PR makes sure the tab's menu item and the action have consistent
naming.
Release Notes:
- Rename "CloseInactiveItems" action to "CloseOtherItems" for naming
consistency.
Danilo Leal
created
a7284ad
editor: Fix cursor doesn’t move up and down on arrow keys when no completions are shown (#34678)
Click to expand commit body
Closes #34338
After https://github.com/zed-industries/zed/pull/31872, to avoid
re-querying language servers, we keep the context menu around, which
stores initial query, completions items, etc., even though it may not
contain any items and hence not be rendered on screen. In this state,
up/down arrows try to switch focus in the context menu instead of
propagating it to the editor. Hence blocking buffer movement.
This PR fixes it by changing the context for `menu`,
`showing_completions`, and `showing_code_actions` to only be added when
the menu is actually being rendered (i.e., not empty).
Release Notes:
- Fix an issue where the cursor doesn’t move up and down on arrow keys
when no completions are shown.
Smit Barmase
created
4314b35
keymap_ui: Don't panic on `KeybindSource::from_meta` (#34652)
Click to expand commit body
Closes #ISSUE
Log error instead of panicking when `from_meta` is passed an invalid
value
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Ben Kunkle
created
ed4deaa
agent: Remove layout shift due to the "waiting for confirmation" label (#34674)
Click to expand commit body
Take 2 on https://github.com/zed-industries/zed/pull/33046.
Release Notes:
- N/A
Danilo Leal
created
f0a9150
keymap_ui: Add some design refinements (#34673)
Click to expand commit body
Mostly small stuff over here.
Release Notes:
- N/A
Now we only auto-retry if burn mode is enabled. We also show a "Retry"
button (so you don't have to type "continue") if you think that's the
right remedy, and additionally we show a "Retry and Enable Burn Mode"
button if you don't have it enabled.
<img width="484" height="260" alt="Screenshot 2025-07-17 at 6 25 27 PM"
src="https://github.com/user-attachments/assets/dc5bf1f6-8b11-4041-87aa-4f37c95ea9f0"
/>
<img width="478" height="307" alt="Screenshot 2025-07-17 at 6 22 36 PM"
src="https://github.com/user-attachments/assets/1ed6578a-1696-449d-96d1-e447d11959fa"
/>
Release Notes:
- Only auto-retry Agent requests when Burn Mode is enabled
This PR removes the `GET /billing/usage` endpoint, as it has been moved
to `cloud.zed.dev`.
Release Notes:
- N/A
Marshall Bowers
created
9efe9df
Harmonize `buffer_font_size` between default.json and initial_settings.json (#34650)
Click to expand commit body
Release Notes:
- N/A
Peter Tripp
created
dab0b35
Unify agent server settings and extract e2e tests out (#34642)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
0f72d7e
editor: Fix sometimes green (+) cursor style appearing when cmd-clicking in same buffer (#34638)
Click to expand commit body
Follow-up for https://github.com/zed-industries/zed/pull/34557
This PR clears the selection drag state on click, because mouse up
doesn't trigger on click event because of `cx.stop_propagation`. The
issue occurs with similar repro steps as mentioned in the attached PR.
Release Notes:
- Fixed the issue where the green (+) cursor style sometimes appears
when navigating to the definition in buffer.
b4dc7f8
debugger: Add support for running test methods with function receiver in Go (#34613)
Click to expand commit body
Closes #33759
Release Notes:
- debugger: Add support for running test methods with function receiver
in Go
Signed-off-by: Umesh Yadav <git@umesh.dev>
Umesh Yadav
created
b94649c
keymap_ui: Show edit icon on hovered and selected row (#34630)
Click to expand commit body
Closes #ISSUE
Improves the behavior of the edit icon in the far left column of the
keymap UI table. It is now shown in both the selected and the hovered
row as an indicator that the row is editable in this configuration. When
hovered a row can be double clicked or the edit icon can be clicked, and
when selected it can be edited via keyboard shortcuts. Additionally, the
edit icon and all other hover tooltips will now disappear when the table
is navigated via keyboard shortcuts.
<details><summary>Video</summary>
https://github.com/user-attachments/assets/6584810f-4c6d-4e6f-bdca-25b16c920cfc
</details>
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Ben Kunkle
created
948c1f2
keymap_ui: Improve keybind display in menus (#34587)
Click to expand commit body
Closes #ISSUE
Defines keybindings for `keymap_editor::EditBinding` and
`keymap_editor::CreateBinding`, making sure those actions are used in
tooltips.
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: Finn <dev@bahn.sh>
Before:
<img width="1728" height="1079" alt="before"
src="https://github.com/user-attachments/assets/4ab19211-8de4-458d-a835-52de859b7b20"
/>
After:
<img width="1728" height="1079" alt="after"
src="https://github.com/user-attachments/assets/231c9362-a0b0-47ae-b92e-de6742781d36"
/>
Makes clear which path is causing the FS error and removes backtraces
from logging.
Release Notes:
- N/A
Kirill Bulatov
created
4df7f52
agent: Disable `project_notifications` by default (#34615)
Click to expand commit body
This tool needs more polishing before being generally available.
Release Notes:
- agent: Disabled `project_notifications` tool by default for the time
being
758c5fb
Allow disabling snippet completion by setting `snippet_sort_order` to `none` (#34565)
Click to expand commit body
This mirrors VSCode setting that inspired `snippet_sort_order` to begin
with; VSCode supports inline/top/bottom/none, with none completely
disabling snippet completion. See
https://code.visualstudio.com/docs/editing/intellisense#_snippets-in-suggestions
This is helpful for LSPs that do not allow configuring snippets via
configuration such as clangd.
Release Notes:
- Added `none` as one of the values for `snippet_sort_order` to
completely disable snippet completion.
Arseny Kapoulkine
created
acb3ece
Do not send project notifications when agent creates a file (#34610)
This disables the minimap in the inspector UI as it doesn't bring any
value to it and just takes up unnecessary space.
Release Notes:
- N/A
Finn Evers
created
1d72fa8
git: Add ability to pass `--signoff` (#29874)
Click to expand commit body
This adds an option for `--signoff` to the git panel and commit modal.
It allows users to enable the [`--signoff`
flag](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt-code--signoffcode)
when committing through Zed. The option is added to the context menu of
the commit button (following the style of the "Editor Controls").
To support this, the commit+amend experience was revamped (following the
ideas of [this
comment](https://github.com/zed-industries/zed/pull/29874#issuecomment-2950848000)).
Amending is now also a toggle in the commit button's dropdown menu. I've
kept some of the original experience such as the changed button text and
ability to cancel outside the context menu.
The tooltip of the commit buttons now also includes the flags that will
be used based on the amending and signoff status (which I couldn't
capture in screenshots unfortunately). So, by default the tooltip will
say `git commit` and if you toggle, e.g., amending on it will say `git
commit --amend`.
| What | Panel | Modal |
| --- | --- | --- |
| Not amending, dropdown | 
| 
|
| Amending, dropdown | 
| 
|
| Amending | 
| - |
The initial implementation was based on the changeset of
https://github.com/zed-industries/zed/pull/28187.
Closes https://github.com/zed-industries/zed/discussions/26114
Release Notes:
- Added git `--signoff` support.
- Update the git `--amend` experience.
- Improved git panel to persist width as well as amend and signoff on a
per-workspace basis.
Closes #34536
Release Notes:
- (preview only) Fix shortcuts on Extended Latin keyboards on Linux
Conrad Irwin
created
ebad5ca
linux: Fix buttons clicks wouldn’t work on startup until clicked on center pane (#34590)
Click to expand commit body
Closes #31805
This is an issue with Linux currently that `window.focus` is `None` upon
startup in both X11 and Wayland. Specifically, the order in which
[this](https://github.com/zed-industries/zed/blob/8d05a3d389b6a1caa80bb18f26c3dac0c26debcb/crates/gpui/src/window.rs#L3116)
and
[this](https://github.com/zed-industries/zed/blob/8d05a3d389b6a1caa80bb18f26c3dac0c26debcb/crates/gpui/src/app.rs#L956)
are executed varies between Linux and macOS. That is, one tries to
remove (blur) focus from a window, while other checks window focus to
put that focus id to a frame. In macOS, blur happens afterwards setting
focus on a frame, but in Linux, the inverse of it happens, leading to
`window.focus` to `None`.
For the time being, we handle all visible buttons to take care of this
**focus can be `None`** case, and make it work anyway. But, we should
look at the deeper issue mentioned above with GPUI. Created new issue to
track that https://github.com/zed-industries/zed/issues/34591.
Release Notes:
- Fixed an issue where button clicks wouldn’t work on startup until
clicked on the center pane on Linux.
Smit Barmase
created
b9ff538
docs: Discuss `inlay_hints.show_value_hints` in debugger docs (#34581)
Click to expand commit body
This isn't under the `debugger` settings key, but it seems good to
document on the debugger page anyway.
Release Notes:
- N/A
Keystroke input now gets cleared when toggling to normal search mode
Main search bar is focused when toggling to normal search mode
This also gets rid of highlight on focus from keystroke_editor because
it also matched the search bool field and was redundant
Release Notes:
- N/A
This PR removes the `GET /billing/subscriptions` endpoint, as it has
been moved to `cloud.zed.dev`.
Release Notes:
- N/A
Marshall Bowers
created
e23a456
keymap_ui: Open Keymap editor from settings dropdown (#34576)
Click to expand commit body
@probably-neb I guess we should be opening the keymap editor from title
bar and menu as well. I believe this got missed in this: #34568.
Release Notes:
- Open Keymap editor from settings from menu and title bar.
Umesh Yadav
created
f82ef1f
agent: Support GEMINI_API_KEY environment variable (#34574)
Click to expand commit body
Google Gemini Docs now recommend usage of `GEMINI_API_KEY` and the
legacy `GOOGLE_AI_API_KEY` variable is no longer supported in the modern
SDKs.
Zed will now accept either.
Release Notes:
- N/A
Addresses upstream errors such as:
<img width="831" height="100" alt="Screenshot 2025-07-16 at 3 37 03 PM"
src="https://github.com/user-attachments/assets/2aeb0257-6761-4148-b687-25fae93c68d8"
/>
These should now automatically retry like other upstream HTTP error
codes.
Release Notes:
- N/A
Richard Feldman
created
0023773
docs: Add Zed as Git Editor example (#34572)
Closes #ISSUE
Release Notes:
- Rebound the keystroke to open the keymap file, to open the new keymap
editor
Ben Kunkle
created
13f4a09
Improve keystroke search in keymap editor (#34567)
Click to expand commit body
This PR improves Keystroke search by:
1. Allow searching by modifiers without additional keys.
2. Take match count into consideration when deciding if we should show
an action as a search match.
3. Take order into consideration as well.
Release Notes:
- N/A
---------
Co-authored-by: Ben Kunkle <ben@zed.dev>
Anthony Eid
and
Ben Kunkle
created
573836a
keymap_ui: Replace `zed::NoAction` with `null` (#34562)
Click to expand commit body
Closes #ISSUE
This change applies both to the UI (we render `<null>` as muted text
instead of `zed::NoAction`) as well as how we update the keymap file
(the duplicated binding is bound to `null` instead of `"zed::NoAction"`)
Release Notes:
- N/A *or* Added/Fixed/Improved ...