4c85a0d
project: Register dynamic capabilities even when registerOptions doesn't exist (#36554)
Click to expand commit body
Closes #36482
Looks like we accidentally referenced
[common/formatting.ts#L67-L70](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/formatting.ts#L67-L70)
instead of
[common/client.ts#L2133](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/client.ts#L2133).
Release Notes:
- Fixed code not formatting on save in language servers like Biome.
(Preview Only)
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Danilo Leal
and
Agus Zubiaga
created
fbba6ad
docs: Document `global_lsp_settings.button` and remove duplicate docs for `lsp_highlight_debounce` (#36547)
Click to expand commit body
Follow up to this discussion:
https://github.com/zed-industries/zed/pull/36337
Release Notes:
- N/A
This will (gracefully) break links to
https://zed.dev/docs/configuring-zed#lsp-highlight-debounce-1 I don't
see anything show up for that on google or github search and I don't
think its load bearing.
---------
Co-authored-by: zumbalogy <3770982+zumbalogy@users.noreply.github.com>
zumbalogy
and
zumbalogy
created
d273aca
agent_ui: Add check to prevent sending empty messages in MessageEditor (#36545)
- Render a helpful message when the installed CC version is too old
- Show the full path for agent binaries when the version is not recent
enough (helps in cases where multiple binaries are installed in
different places)
- Add UI for the case where a server binary is not installed at all
- Refresh thread view after installing/updating server binary
Release Notes:
- N/A
- Return unified diff from `Edit` tool so model can see the final state
- Format on save if enabled
- Provide `Write` tool
- Disable `MultiEdit` tool
- Better prompting
Release Notes:
- N/A
Agus Zubiaga
created
714c36f
claude: Include all mentions and images in user message (#36539)
Click to expand commit body
User messages sent to Claude Code will now include the content of all
mentions, and any images included.
Release Notes:
- N/A
Agus Zubiaga
created
ce21643
Refactor ssh remoting - make ChannelClient type private (#36514)
Click to expand commit body
This PR is one step in a series of refactors to prepare for having
"remote" projects that do not use SSH. The main use cases for this are
WSL and dev containers.
Release Notes:
- N/A
Max Brunsfeld
created
82ac8a8
collab: Make `stripe_subscription_id` and `stripe_subscription_status` nullable on `billing_subscriptions` (#36536)
Click to expand commit body
This PR makes the `stripe_subscription_id` and
`stripe_subscription_status` columns nullable on the
`billing_subscriptions` table.
Release Notes:
- N/A
Marshall Bowers
created
757b37f
Hide old Agent UI when ACP flag set (#36533)
Click to expand commit body
- **Use key value store instead of JSON**
- **Default NewThread to the native agent when flagged**
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Conrad Irwin
created
ecee674
Attach minidump errors to uploaded crash events (#36527)
Click to expand commit body
We see a bunch of crash events with truncated minidumps where they have
a valid header but no events. We think this is due to an issue
generating them, so we're attaching the relevant result to the uploaded
tags.
Release Notes:
- N/A
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Julia Ryan
and
Max Brunsfeld
created
88754a7
Rebuild recently opened threads for ACP (#36531)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Conrad Irwin
created
88c4a5c
Suspend macOS threads during crashes (#36520)
Click to expand commit body
This should improve our detection of which thread crashed since they
wont be able to resume while the minidump is being generated.
Release Notes:
- N/A
- **Enable a bunch of extra lints**
- **First batch of fixes**
- **More fixes**
Release Notes:
- N/A
Piotr Osiewicz
created
69b1c6d
Fix `workspace::SendKeystrokes` example in docs (#36515)
Click to expand commit body
Closes: https://github.com/zed-industries/zed/issues/25683
Remove two bad examples from the key binding docs.
`cmd-shift-p` (command palette) and `cmd-p` (file finder) are async
operations and thus do not work properly with
`workspace::SendKeystrokes`.
Originally reported in
https://github.com/zed-industries/zed/issues/25683#issuecomment-3145830534
Release Notes:
- N/A
Peter Tripp
created
05fc0c4
Fix a bunch of other low-hanging style lints (#36498)
Click to expand commit body
- **Fix a bunch of low hanging style lints like unnecessary-return**
- **Fix single worktree violation**
- **And the rest**
Release Notes:
- N/A
Piotr Osiewicz
created
df9c2ae
thread_view: Fix issues with images (#36509)
Click to expand commit body
- Clean up failed load tasks for mentions that require async processing
- When dragging and dropping files, hold onto added worktrees until any
async processing has completed; this fixes a bug when dragging items
from outside the project
Release Notes:
- N/A
Cole Miller
created
a91acb5
onboarding: Fix theme selection in system mode (#36484)
Click to expand commit body
Previously, selecting the "System" theme during onboarding would
hardcode the theme based on the device's current mode (e.g., Light or
Dark). This change ensures the "System" setting is saved correctly,
allowing the app to dynamically follow the OS theme by inserting the
correct theme in the config for both light and dark mode.
Release Notes:
- N/A
Signed-off-by: Umesh Yadav <git@umesh.dev>
Umesh Yadav
created
6ba52a3
Re-add history entries for native agent threads (#36500)
There are two tests commented out in the helix file, but one of them
works again. I don't know if this is too little a change to be merged,
but I wanted to suggest it.
The other test might be more complicated though, so I didn't touch it.
Release Notes:
- N/A
1444cd9
Fix Windows test failures not being detected in CI (#36446)
Click to expand commit body
Bug introduced in #35926
Release Notes:
- N/A
Cole Miller
created
6c255c1
Lay the groundwork to support history in agent2 (#36483)
Click to expand commit body
This pull request introduces title generation and history replaying. We
still need to wire up the rest of the history but this gets us very
close. I extracted a lot of this code from `agent2-history` because that
branch was starting to get long-lived and there were lots of changes
since we started.
Release Notes:
- N/A
e3b593e
project: Take 2 on Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36485)
Click to expand commit body
Relands https://github.com/zed-industries/zed/pull/36441 with a
deserialization fix.
Previously, deserializing `"includeText"` into
`lsp::TextDocumentSyncSaveOptions` resulted in a `Supported(false)` type
instead of `SaveOptions(SaveOptions { include_text: Option<bool> })`.
```rs
impl From<bool> for TextDocumentSyncSaveOptions {
fn from(from: bool) -> Self {
Self::Supported(from)
}
}
```
Looks like, while dynamic registartion we only get `SaveOptions` type
and never `Supported` type.
(https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSaveRegistrationOptions)
Release Notes:
- N/A
---------
Co-authored-by: Lukas Wirth <lukas@zed.dev>
9e8ec72
Revert "project: Handle `textDocument/didSave` and `textDocument/didChange` (un)registration and usage correctly (#36441)" (#36480)
Click to expand commit body
This reverts commit c5991e74bb6f305c299684dc7ac3f6ee9055efcd.
This PR broke rust-analyzer's check on save function, so reverting for
now
Release Notes:
- N/A
Lukas Wirth
created
2fb89c9
chore: Default settings: Comments: dock option (#36476)
Click to expand commit body
Minor tweak in the wording of the comments for the default settings
regarding the `dock` option of the panels, in order to make them
congruent across all panels.
Release Notes:
- N/A
47e1d45
editor: Fix `edit_predictions_disabled_in` not disabling predictions (#36469)
Click to expand commit body
Closes #25744
Only setting changes and editor init determined whether to show
predictions, so glob patterns and toggles correctly disabled them. On
cursor changes we call `update_visible_edit_prediction`, but we weren’t
discarding predictions when the scope changed. This PR fixes that.
Release Notes:
- Fixed an issue where the `edit_predictions_disabled_in` setting was
ignored in some cases.
ed14ab8
gpui: Introduce stacker to address stack overflows with deep layout trees (#35813)
Click to expand commit body
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Co-authored-by: Ben Kunkle <ben@zed.dev>
Release Notes:
- N/A
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Co-authored-by: Ben Kunkle <ben@zed.dev>
Piotr Osiewicz
,
Anthony Eid
,
Lukas Wirth
, and
Ben Kunkle
created
1fbb318
Fix iterator related clippy style lint violations (#36437)
Click to expand commit body
Release Notes:
- N/A
tidely
created
176c445
Avoid symlink conflicts when re-extracting `eslint-xx.tar.gz` (#36068)
Click to expand commit body
Closes #34325
**Background**
When upgrading/reinstalling the ESLint language server, extracting the
archive over an existing version directory that contains symlinks can
fail and interrupt the installation.
```
failed to unpack .../vscode-eslint-2.4.4/.../client/src/shared
File exists (os error 17) when symlinking ../../$shared/ to .../client/src/shared
```
**Root cause**
Extracting into a non-empty directory conflicts with leftover
files/symlinks (e.g., `client/src/shared -> ../../$shared`), causing
“File exists (os error 17)”.
When `fs::metadata(&server_path).await.is_err()` is true, the code falls
back to cached_server_binary, but that still targets the same
(potentially corrupted/half-installed) directory and does not run `npm
install` or `npm run compile`, so the system cannot recover and remains
broken.
**Change**
Before downloading and extracting, delete the target version directory
(vscode-eslint-<version>) to ensure an empty extraction destination and
avoid conflicts.
**Alternative approaches**
temp directory + rename: extract into a clean temp directory and rename
into place to avoid half-installed states
[async-tar](https://github.com/dignifiedquire/async-tar) enhancement:
tolerate already-existing symlinks (or add a “replace-existing” option).
Release Notes:
- Fixed eslint installation not clearing files after previous attempts'