e697cf9
editor: Fix edit range for linked edits on do completion (#29650)
Click to expand commit body
Closes #29544
Fixes an issue where accepting an HTML completion would correctly edit
the start tag but incorrectly update the end tag due to incorrect linked
edit ranges.
I want to handle multi cursor case (as it barely works now), but seems
like this should go first. As, it might need whole `do_completions`
overhaul.
Todo:
- [x] Tests for completion aceept on linked edits
Before:
https://github.com/user-attachments/assets/917f8d2a-4a0f-46e8-a004-675fde55fe3d
After:
https://github.com/user-attachments/assets/84b760b6-a5b9-45c4-85d8-b5dccf97775f
Release Notes:
- Fixes an issue where accepting an HTML completion would correctly edit
the start tag but incorrectly update the end tag.
Smit Barmase
created
e4e455a
Fix duplicate thread entries in agent navigation menu (#29672)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Cole Miller
created
ff4900c
Mitigate panic in merge conflict resolution (#29678)
Click to expand commit body
We have a report of a panic when indexing into
`BufferConflicts.block_ids` using the `old_range` from the
`ConflictsUpdated` event, indicating that the `block_ids` array can get
out of sync with the underlying `ConflictSet`. This PR adds a mitigation
so that we won't panic in this situation, as a stopgap until the bug can
be reproduced in a test and fixed at the root.
Release Notes:
- N/A
Cole Miller
created
632f08d
project: Check path extension first, then worktree's (#29671)
Click to expand commit body
This fixes a bug with opening images on worktrees that contain
"extension" in the dir name, like `zed.dev`
Release Notes:
- N/A
Oleksiy Syvokon
created
5589e78
python: Do not look up venv path from source file path (#29676)
⚠️ Work in progress until all of the to-dos are knocked out:
- [x] Disable soft-wrapping
- [x] Make it foldable only after a certain number of lines
- [x] Display tool status errors
- [x] Fix horizontal scroll now that we've disabled soft-wrap
- [ ] Don't render unnecessary extra lines (will be added later, on a
follow-up PR)
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
Danilo Leal
,
Agus Zubiaga
, and
Michael Sloan
created
7587340
Fix a bug that interfered with sorting of conflicted paths in the git panel (#29534)
Click to expand commit body
This PR updates the git store to not register a change in a repository's
merge heads until conflicted paths are seen.
We currently use the repository's merge heads only to decide when the
list of conflicted paths should be refreshed. Previously, the logic
looked like this:
- Whenever we see a change in the merge heads, set the list of
conflicted paths by filtering the output of `git status`.
It turns out that when a conflicting merge takes a while, we can see
this sequence of events:
1. We get an event in .git and reload statuses and merge heads.
Previously there were no merge heads, and now we have some, but git
hasn't finished figuring out which paths have conflicts, so we set the
list of conflicted paths to `[]`.
2. Git finishes computing the list of conflicted paths, and we run
another scan that picks these up from `git status`, but then we throw
them away because the merge heads are the same as in (1).
By not updating our stored merge heads until we see some conflicts in
`git status`, we delay this step until (2), and so the conflicted paths
show up in the git panel as intended.
This means that our merge heads state no longer matches what's on disk
(in particular, during a clean merge we'll never update them at all),
but that's okay because we only keep this state for the purpose of
organizing conflicts.
Release Notes:
- Fixed a bug that could cause conflicted paths to not appear in their
own section in the git panel.
Cole Miller
created
5073cba
agent: Add keybindings to open the panel's extra menu (#29663)
Click to expand commit body
Maybe "extra" isn't the best word, but I'm referring to the ellipsis
menu on the far right of the panel that holds "extra" or "additional
options". There is a known issue with context menus, at least if
implemented this way, that makes hitting enter to select an option not
work. Will leave this fix to a later PR.
Release Notes:
- N/A
This new default profile is one that doesn't use any tools; it's
completely "naked" and it shouldn't lean into trying to read things from
the current project at hand. Better suited for general topic chats with
the LLM.
PS: Still expecting some wordsmithing here before merging.
Release Notes:
- agent: Added a new default profile called "Manual" that doesn't
include any tools, for general topic chats with the LLM.
59708ef
Revert "python: Enable subroot detection for pylsp and pyright (#27364)" (#29658)
Click to expand commit body
This reverts commit e661a0afd64e3e6e1e51c981cb7bda4e0af724fd.
Closes #ISSUE
Release Notes:
- Reverted changes to Python subroot detection which could have caused
multiple python processes to be spawned when working in projects with
multiple `pyproject.toml` files.
Piotr Osiewicz
created
152ea04
chore: Move Windows dependencies to windows section (#29649)
9767033
debugger: Extract running state from DebugSession mode and remove mode field (#29646)
Click to expand commit body
DebugSession.mode is no longer needed because project::debugger::Session
manages its own state now (booting, running, terminated), and removing
mode simplifies a lot of the code that uses running state.
I used Zed AI to do a good chunk of the refactor, but I doubled-checked
everything it did and changed a good amount of its updates.
Release Notes:
- N/A
Co-authored-by: Zed AI <ai@zed.dev>
Anthony Eid
and
Zed AI
created
edf78e7
Fix token counting requests in Gemini (#29643)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
8d77efa
extensions_ui: Fix scroll to top only on refetch (#29640)
Click to expand commit body
Closes #29604
Release Notes:
- Fixes case where extension page scrolls up to the top when installing
an extension.
Smit Barmase
created
747a029
Split diagnostics markdown style out (#29637)
c8685dc
Fix eval judging missing final response (#29638)
Click to expand commit body
Fixed issue where eval thread judges were not considering the last
response in the thread.
The problem was that they were getting the full list of messages from
`last_request`, which (being a request!) did not have the response yet.
Release Notes:
- N/A
Richard Feldman
created
d566864
Make code block eval resilient to indentation (#29633)
Click to expand commit body
This reduces spurious failures in the eval.
Release Notes:
- N/A
Richard Feldman
created
75a9ed1
vim: Fix incorrect escaping parenthesis of replacement string (#29555)
Click to expand commit body
Closes #29356

Release Notes:
- vim: Fixed a bug when escaping `(` and `)` in command-palette find and
replace
- Stop merging same row diagnostics
- (for Rust) show code fragments surrounded by `'s in monospace
Co-authored-by: Serge Radinovich <sergeradinovich@gmail.com>
Closes #29362
Release Notes:
- diagnostics: Diagnostics are no longer merged when they're on the same
line
- rust: Diagnostics now show code snippets in monospace font:
<img width="551" alt="Screenshot 2025-04-29 at 16 13 45"
src="https://github.com/user-attachments/assets/d289be31-717d-404f-a76a-a0cda3e96fbe"
/>
Co-authored-by: Serge Radinovich <sergeradinovich@gmail.com>
Conrad Irwin
and
Serge Radinovich
created
b473223
Skip serializing `None` fields in Gemini API (#29632)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
b1395c5
agent: Add new panel navigation dropdown (#29539)
Click to expand commit body
- [x] Ensure what appears in the dropdown is really what is accurate
- [x] Ensure keyboard navigation works:
- [x] Switching tabs with `enter`
- [x] Closing items from the menu item
- [x] Opening the dropdown
- [x] Focus assistant panel on dismiss
- [x] Add ability to close items from the dropdown menu
- [x] Persistence
- [x] Correct behavior when opening a text thread
Release Notes:
- agent: Added a navigation menu that shows the recently opened threads.
The button to see the full history view has been changed inside this
menu.
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Cole Miller <m@cole-miller.net>
Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
Co-authored-by: Cole Miller <cole@zed.dev>
Danilo Leal
,
Bennet Bo Fenner
,
Cole Miller
,
Bennet Bo Fenner
, and
Cole Miller
created
1a4d724
agent: Make token indicator not flash if last count tokens request failed (#29628)
Add a targeted eval for code block formatting, and revise the system
prompt accordingly.
### Eval before, n=8
<img width="728" alt="eval before"
src="https://github.com/user-attachments/assets/552b6146-3d26-4eaa-86f9-9fc36c0cadf2"
/>
### Eval after prompt change, n=8 (excluding the new evals, so just
testing the prompt change)
<img width="717" alt="eval after"
src="https://github.com/user-attachments/assets/c78c7a54-4c65-470c-b135-8691584cd73e"
/>
Release Notes:
- N/A
Adds popular examples of long-running commands to system prompt.
Unfortunately, I couldn't add an eval example as the new terminal tool
no longer works in `eval`. We can look into that tomorrow, but I'm
seeing improvements when manually testing this, so I'd like to merge it.
<img
src="https://github.com/user-attachments/assets/ac24e617-e068-466f-875d-c30e1f2465c4"
width=400></img>
Release Notes:
- agent: Discourage long-running commands
Agus Zubiaga
created
a09e5d2
vim: Create anyquotes, anybrackets, miniquotes, and minibrackets text objects (#26748)
Click to expand commit body
## Why?
Some users expressed a preference for the AnyQuotes and AnyBrackets text
objects to align more closely with traditional Vim behavior, rather than
the mini.ai plugin's approach. To address this, I’ve introduced two new
text objects: MiniQuotes and MiniBrackets. These retain the mini.ai
plugin behavior, while the updated AnyQuotes and AnyBrackets now follow
the logic described in [this bug
report](https://github.com/zed-industries/zed/issues/25563) and [this
bug report](https://github.com/zed-industries/zed/issues/25562).
## Behavior Overview:
### AnyQuotes and AnyBrackets:
These now prioritize the innermost range first (e.g., the closest quotes
or brackets). If none are found, they fall back to searching the current
line. This aligns with the behavior requested in the issue.
### MiniQuotes and MiniBrackets:
These maintain the mini.ai plugin behavior, prioritizing the current
line before expanding the search outward.
### Usage Examples:
AnyQuotes: Works like ```ci', ci", ci` , ca', ca", ca` , etc.```
AnyBrackets: Works like ```ci(, ci[, ci{, ci<, ca(, ca[, ca{, ca<,
etc.```
Please give these changes a try and let me know your thoughts!
### Release Notes:
- vim: Add AnyQuotes, AnyBrackets, MiniQuotes and MiniBrackets text
objects
---------
Co-authored-by: Ben Kunkle <ben@zed.dev>
Osvaldo
and
Ben Kunkle
created
33abf1e
agent: Log errors from token counting APIs (#29626)
Until we land #28128, we're disabling the nightly nix builds so they're
not constantly failing.
Release Notes:
- N/A
Julia Ryan
created
24e47de
collab: Add `has_extended_trial` to `LlmTokenClaims` (#29622)
Click to expand commit body
This PR adds the `has_extended_trial` field to the LLM token claims.
Release Notes:
- N/A
Marshall Bowers
created
15a83b5
Stop routing session events via the DAP store (#29588)
Click to expand commit body
This cleans up a bunch of indirection and will make it easier to
show the session building state in the debugger terminal
Closes #ISSUE
Release Notes:
- N/A
Loosen trait bounds from `std::error::Error` to `std::fmt::Display`,
since it's not required for the `log::error!` macro or any other bounds.
Specify that `AssetLogger` specifically logs errors in its
documentation.
Use the `futures::TryFutureExt` trait extension to use `inspect_err`
directly on a future.
Release Notes:
- N/A
tidely
created
f2813f6
vim: Fix end of paragraph deletion when there's no blank lines (#29490)
Click to expand commit body
This Pull Request attempts to fix an issue where using `d}` in vim mode
would not delete all characters in case there's no blank lines at the
end of the buffer.
When calculating the end point for this motion, if there's no blank
lines at the end of the buffer, Zed was calculating it to be the last
character in the last line. However, if there's a newline at the end of
the buffer, it calculates the end point to be the point at the right of
the last character.
Here's an example, for the following buffer contents:
```
Hello!
Hello!
```
If the `d}` command is run at `(0, 0)`, the end point will be set to
`(1, 5)`. However, fi the same command is run for this buffer instead:
```
Hello!
Hello!
```
The end point will be set to `(1, 6)`, there's a 1 unit difference in
the column, which leads to all characters actually being deleted.
Closes #29393
Release Notes:
- Fixed deleting to the end of paragraph when there's no blank lines
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Dino
and
Conrad Irwin
created
4758173
Use image cache to stop leaking images (#29452)
Click to expand commit body
This PR fixes several possible memory leaks due to loading images in
markdown files and the image viewer, using the new image cache APIs
TODO:
- [x] Ensure this didn't break rendering in any of the affected
components.
Release Notes:
- Fixed several image related memory leaks
cf6b051
keymap: Make F10 toggle the menu on Linux (#29607)
Click to expand commit body
Closes: https://github.com/zed-industries/zed/issues/27271
Release Notes:
- Added support for F10 toggling menus on Linux
Peter Tripp
created
a376038
agent: Add icon for Zed's max mode (#29610)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
2973bf1
bash: Don't treat `raw_string` as bracket (#29617)
Click to expand commit body
Closes #29222
Release Notes:
- Fixed a crash when inputting `ciq` in vim mode inside of a raw string
in a bash file
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Anthony <anthony@zed.dev>
Ben Kunkle
,
Conrad
, and
Anthony
created
386970c
collab: Add support for extended Zed Pro trial (#29612)
Click to expand commit body
This PR adds support for an extended Zed Pro trial, applied based on the
presence of the `agent-extended-trial` feature flag.
Release Notes:
- N/A
Marshall Bowers
created
f7f44bf
Fix channel notes searching in buffer picker (#29611)
Click to expand commit body
Previously they all used the name "Channels" for searching, now it uses
the actual content of the channel name and status.
Release Notes:
- N/A
Julia Ryan
created
fd17f2d
agent: Enrich `grep` tool output with syntax information (#29601)
Click to expand commit body
The `grep` tool used to include 4 lines of context around the match, but
the lines included would often be unhelpful. This PR improves this
behavior by using the range of the parent syntax node that contains the
full line(s) matched.
The match headers will also now include symbol breadcrumbs so that the
model can already gather code structure before/without reading files.
````md
### impl GitRepository for RealGitRepository › fn compare_checkpoints › L1278-1284
```rust
let result = git
.run(&[
"diff-tree",
"--quiet",
&left.commit_sha.to_string(),
&right.commit_sha.to_string(),
])
```
````
This positively impacts the `add_arg_to_trait_method` eval example with
better diff output, fewer tool failures, and reduced total turns.
Note: We have some plans to use a an "elision" approach where we would
combine all matches for a given file, skipping lines between them while
keeping symbol declaration lines. The theory is that this would be map
more closely to the expected input for edits. For now, this PR is a
significant improvement.
Release Notes:
- Agent: Enrich `grep` tool output with syntax information
Agus Zubiaga
created
5507958
debugger: Transition to path! macro to create paths in debugger tests (#29605)
Click to expand commit body
This should prevent some cases where a test passes on one platform and
not another
Release Notes:
- N/A
Co-authored-by: Zed AI <ai@zed.dev>
Anthony Eid
and
Zed AI
created
fa40353
bedrock: Preserve thinking blocks for Bedrock (#29602)
Click to expand commit body
Fixes a regression from #29055, resolves #29290
Release Notes:
- agent: Fixed a regression that rendered Claude 3.7 Thinking unusable
on Bedrock.
Shardul Vaidya
created
83b8530
agent: Create `TerminalToolCard` and display shell output while it's running (#29546)
Click to expand commit body
Also, don't require a worktree to run the terminal tool.
Release Notes:
- N/A
João Marcos
created
5afb89c
collab: Take the mode into account when syncing usage to Stripe (#29606)
Click to expand commit body
This PR makes it so we take the mode that was used into account when
syncing usage over to Stripe.
Release Notes:
- N/A
Marshall Bowers
created
6386336
debugger: Fix bug where active debug line highlights weren't cleared (#29562)
Click to expand commit body
## Context
The bug occurred because we stopped propagating the
`BreakpointStoreEvent::SetDebugLine` whenever a new debug line highlight
had been set. This was done to prevent multiple panes from having
editors focus on the debug line. However, it stopped the event from
propagating to editors that needed to clear their debug line highlights.
I fixed this by introducing two phases
1. Clear all debug line highlights
2. Set active debug line highlight in singular editor
I also added a test to prevent regressions from occurring
Release Notes:
- N/A