bd105a5
Continue improving font adjustment settings (#24908)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/24857
Based on the feedback,
* made non-persisting font size change as a default in Zed keymaps
JetBrains IDEs seem to persist font size changes by default, hence left
to do so in Zed keymaps too
* fixed a bug with holding a binding to change the font size caused
flickering
Release Notes:
- N/A
Kirill Bulatov
created
c049df2
docs: Add section on file icons to `CONTRIBUTING.md` (#24905)
Click to expand commit body
This PR adds a section on file icons to the `CONTRIBUTING.md` guide.
Release Notes:
- N/A
Marshall Bowers
created
3040ef4
file_icons: Add icon key for Crystal and ECR files (#24903)
Click to expand commit body
Release Notes:
- Icon themes: Added the ability to change the file icon for Crystal
(`.cr`, `.ecr`) files.
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Closes #24832
Only turns specified deperecated keys and values to snake case.
Release Notes:
- Fixed issue where keybindings would open task selector instead of
spawn that task.
smit
created
1d26a27
go: Fix tree-sitter query for outlines (#24861)
Click to expand commit body
Closes #14497
Release Notes:
- Fixed outline view for Go to correctly indent types and show missing
variables.
----
This PR fixes the tree-sitter query for outlines for Go code. It
correctly indents "grouped" `type` declarations. It also fixes missing
variables for "grouped" `var` declarations.
### Before:
1. Incorrectly indented types from `G` to `K` and `aliasInt`
2. Missing vars `M` and `N` in outline

### After:
1. Types no longer indented incorrectly
2. Missing vars `M` and `N` appear in the outline, as expected

### Caveats:
1. This fix comes from an hour or so of reading about tree-sitter and
its query syntax. I'm not an expert.
2. I'm not sure how to test this. I've done manual testing and it
appears to works as expected without an regressions.
Ashish Bhate
created
294dea1
vim: Change into visual mode on select all matches (#24897)
Click to expand commit body
This Pull Request fixes an issue where selecting all matches on a search
would not update vim to visual mode.
In the video below the following scenarios are tested:
1. Clicking "Select All Matches" in the buffer search bar correctly
changes vim to visual mode
2. Pressing Enter jumps the cursor to the first match and does not
change vim's mode
3. Selecting all matches with the `β₯β` changes vim to visual mode
https://github.com/user-attachments/assets/f7535638-987e-4f33-9364-292f99b60167
Thanks @ConradIrwin for both the quick pairing session and the solution!
π
Closes #14681
Release Notes:
- vim: Use visual mode for "select all matches" in search (to be
consistent with `ga`)
This PR fixes the issue response script.
There were a number of things preventing it from working:
- The directory name used in the GitHub Action did not match the one on
disk.
- The script has been moved accordingly
- `ts-node` does not support ESM.
- `ts-node` seems unmaintained, so I changed the script to be plain JS
that is type-checked with TypeScript.
- The data being sent to the Slack API was invalid:
- Each section block can only have a maximum of 3000 characters in the
`text` field, so we need to break up the issue list across multiple
sections.
- We needed to escape `&`, `<`, and `>` characters in the issue titles.
Release Notes:
- N/A
Marshall Bowers
created
de020af
Fix duplicate hunk controls after splitting DisplayDiffHunk (#24893)
Click to expand commit body
This PR fixes expanded modification hunks having two sets of hunk
controls after #24834.
Release Notes:
- N/A
Cole Miller
created
610158b
Force manual publishing of preview (#24894)
Click to expand commit body
This is just a temporary change to help us debug with some weird issues
happening:
- Discord release not firing for certain builds
- Random blank release drafts showing up
Release Notes:
- N/A
Joseph T. Lyons
created
2046023
Fix scroll to top on multibuffer save (#24885)
Closes #12519.
Release Notes:
- Added support for Mistral to the Assistant.
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Shidfar Hodizoda
and
Marshall Bowers
created
5c5caf1
linux: Fix reload hangs for several minutes (#24882)
Click to expand commit body
Closes #22666
This PR fixes the long wait time to open Zed (2 mins in my case) after
reloading on Linux.
This bug fix is funny:
1. We were using TCP for Zed instances to talk to each other. Reload was
broken here too due to TCP connections not being killed on time.
2. [#11488](https://github.com/zed-industries/zed/pull/11488) PR fixed
the TCP connection issue by adding a wait until it gets killed. I
suppose at that time, this wait time was small.
3. Later, we changed how Zed talks to each other in
[#11585](https://github.com/zed-industries/zed/pull/11585) by using
Datagram and removing TCP. The new approach simply uses a `.sock` file
and a file descriptor to check if some program is listening to it.
4. TCP check is now unnecessary, and it still wait for a long time (I
suppose, TIME_WAIT time, don't quote me on this), even though we donβt
use TCP anymore for this.
This PR just removes that unnecessary TCP wait.
Release Notes:
- Fixed issue where reload hangs for several minutes on Linux.
smit
created
39c9b1f
Gutter-highlight removed and added portions of expanded diff hunks separately (#24834)
Click to expand commit body
cc @iamnbutler
Release Notes:
- Color gutter highlights separately for removed and deleted portions of
git modification hunks
Co-authored-by: Conrad <conrad@zed.dev>
Agus Zubiaga
,
Danilo Leal
,
Antonio Scandurra
, and
Marshall Bowers
created
744579e
Move git status updates to a background thread #2 (#24722)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/24307
Brings back the PR and fixes the issue with the git status not
propagated, if computed too slow.
Now, git repo update
* waits in the background for all `scan_dir` repo status updates and
triggers another status update send afterwards
* ensures that the update sent is reported correctly (`scanning = true`)
if either FS or status scan is running still
* during worktree's git statuses updates, bumps `status_scan_id` to
ensure the repo update is reported to all subscribers
Release Notes:
- Improved project panel's speed in large projects
Release Notes:
- Fixed a panic when displaying a whitespace-only line in the edit
prediction preview
---------
Co-authored-by: Antonio <antonio@zed.dev>
Agus Zubiaga
and
Antonio
created
a618830
project: Fine-grained language server management (#24038)
Click to expand commit body
Closes #ISSUE
https://github.com/zed-industries/zed/pull/23804
Release Notes:
- Improved detection of project roots for use by language servers.
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: smit <0xtimsb@gmail.com>
Co-authored-by: Henrikh Kantuni <henrikh.kantuni@gmail.com>
Co-authored-by: Caleb! <48127194+kaf-lamed-beyt@users.noreply.github.com>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Danilo <danilo@zed.dev>
Co-authored-by: Nate Butler <iamnbutler@gmail.com>
Piotr Osiewicz
,
smit
,
Henrikh Kantuni
,
Caleb!
,
Marshall Bowers
,
Kirill Bulatov
,
Agus Zubiaga
,
Danilo
, and
Nate Butler
created
We were disabling edit predictions altogether when
`show_edit_predictions` was set to `false`. However, even in that case,
`editor::ShowEditPrediction` is supposed to let your request a
prediction manually.
Release Notes:
- Fixed `editor::ShowEditPrediction` when `show_edit_predictions` is set
to `false`.
Agus Zubiaga
created
79ee01e
theme: Fix icon theme switching changing the theme (#24849)
Click to expand commit body
Closes #24846
Release Notes:
- Fixed an issue where changing the icon theme would change the theme.
Sanjeev Shrestha
created
3b91de8
Adds a way to toggle font size without settings adjustments (#24857)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/23505
Now `zed::IncreaseBufferFontSize` (and all the same UI- and
Buffer-related settings) action is parameterized with `{ "persist": true
}` (default).
Using `"persist": false` brings back resizing behavior prior to
https://github.com/zed-industries/zed/pull/23265
Release Notes:
- Added a way to toggle font size without settings adjustments
Kirill Bulatov
created
2f734cb
Fix missing hunks in project diff (#24847)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
5ac8216
Attempt to fix issue_response script (#24842)
This might require a few follow-up commits to get this to work! π
Release Notes:
- N/A
Joseph T. Lyons
created
9094f53
Disable edit prediction in Cloudflare Workers `.dev.vars` files (#24838)
Click to expand commit body
This PR adds `.dev.vars` files as a default exclusion for edit
prediction.
These files are used by Cloudflare Workers and are likely to contain
secrets.
Release Notes:
- Excluded Cloudflare Workers `.dev.vars` files from edit prediction.
Marshall Bowers
created
5d26ce1
Centralize the `CopyPath` and `CopyRelativePath` actions to `zed_actions` (#24836)
Click to expand commit body
I spent an hour with @marcospb19 this morning debugging an issue with
adding `Copy Path` and `Copy Relative Path` actions to the editor
context menu. Turned out that the problem was using
`workspace::CopyPath` in the menu and `editor::CopyPath` in the action
handler.
This is an easy mistake to make, so let's fix it for everyone.
Release Notes:
- N/A
Mikayla Maki
created
28c667a
Fix issue with `vim::PushOperator` documentation (#24825)
Click to expand commit body
Closes: #24718
Release Notes:
- N/A
Ben Kunkle
created
c38deb1
zeta: Remove `predict-edits-launch` feature flag (#24829)
Click to expand commit body
This PR removes the `predict-edits-launch` feature flag that was added
in #24720.
We don't need this anymore now that we've launched!
Release Notes:
- N/A
Marshall Bowers
created
8af54c5
zeta: Update URL to edit prediction blog post (#24828)
Click to expand commit body
This PR updates the URL to the edit prediction blog post.
Release Notes:
- N/A
8c202b3
editor: Update git hunk indicators to show staging status when hunk is expanded (#24818)
Click to expand commit body
- Update git hunk indicators to show staging status when hunk is
expanded
- Updates uses of status colors to the new version control theme colors
- Adds new version control theme colors to included themes
Before:

After:

(Colors here are from before theme colors were added)
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: cole-miller <m@cole-miller.net>
Supercedes #24561
Closes #21059
Before this change we would skip saving multibuffers regardless of the
save intent. Now we correctly save them.
Along the way:
* Prompt to save when closing the last singleton copy of an item (even
if it's still open in a multibuffer).
* Update our file name prompt to pull out dirty project items from
multibuffers instead of counting multibuffers as untitled files.
* Fix our prompt test helpers to require passing the button name instead
of the index. A few tests were passing invalid responses to save
prompts.
* Refactor the code a bit to hopefully clarify it for the next bug.
Release Notes:
- Fixed edge-cases when closing multiple items including multibuffers.
Previously no prompt was generated when closing an item that was open in
a multibuffer, now you will be prompted.
- vim: Fix :wq in a multibuffer
Conrad Irwin
created
8c780ba
Fix branches with slashes in their names not being listed (#24809)
Click to expand commit body
`refs/heads/*` doesn't match e.g. `refs/heads/cole/branch-with-slash`
(thanks fnmatch), but `refs/heads/**/*` does. This also works for
several levels of slash.
Release Notes:
- N/A
Cole Miller
created
de0d9d6
Save open buffers before staging or unstaging their backing files (#24767)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
2db5eed
edit predictions: Do not use conflict context for other providers (#24807)
Click to expand commit body
This is to avoid confusing copilot/supermaven users when the cursor is
on leading whitespace.
Release Notes:
- N/A
The MultiWrite struct is defined in the function scope and is allowed to
have a concrete type, which means we can throw away the extra Box.
PathBuf::exists is known to be prone to invalid usage. It doesn't take
into account permissions errors and just returns false, additionally it
introduces a time-of-check time-of-use bug. While extremely unlikely,
why not fix it anyway.
Release Notes:
- remove unnecessary Box
- prevent time-of-check time-of-use bug
7186709
Migrate edit_prediction_provider setting before updating its value to 'zed' during onboarding (#24781)
Click to expand commit body
This fixes a bug where we'd update your settings to an invalid state if
you were using the old `inline_completion_provider` setting, then
onboarded to Zeta, then migrated your settings.
Release Notes:
- N/A
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Max Brunsfeld
,
Michael Sloan
, and
Agus Zubiaga
created
3d68dba
edit predictions: Iterate on onboarding modal copywriting (#24779)
f0cd71e
Update cloudflare/wrangler-action digest to 392082e (#24753)
Click to expand commit body
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[cloudflare/wrangler-action](https://redirect.github.com/cloudflare/wrangler-action)
| action | digest | `7a5f8bb` -> `392082e` |
---
### Configuration
π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
π¦ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
β» **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
π **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2Ny4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot]
and
renovate[bot]
created
a13c2ba
Improve error message for `AcceptEditPredictions` - add docs link (#24772)
Click to expand commit body
The docs have not been updated yet, this is anticipating their presence
soon.

Release Notes:
- N/A
Michael Sloan
created
7ba1492
file_icons: Add separate icon key for Bicep files (#24757)
Click to expand commit body
This PR adds support for bicep file icon:
Release Notes:
- Icon themes: Added the ability to change the file icon for Bicep
(`.bicep`) files.
Michal Vrbata
created
0a68122
edit predictions: Enable blog post link behind a feature flag (#24720)
Click to expand commit body
This PR updates the blog post link in the onboarding modal to be behind
the `predict-edits-launch` feature flag instead of a staff flag.
This will allow us to enable the blog post link once we're live.
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
This PR makes it so Zeta respects the `x-zed-minimum-required-version`
header sent back from the server.
If the current Zed version is strictly less than the indicated minimum
required version, we show an error indicating that an update is required
in order to continue using Zeta:
<img width="472" alt="Screenshot 2025-02-12 at 6 15 44β―PM"
src="https://github.com/user-attachments/assets/51b85dff-23a0-464c-ae4b-5b8f46b5915c"
/>
Release Notes:
- N/A