8ab52f3
editor: Fix `SelectionsCollection::disjoint` not being ordered correctly (#40249)
Click to expand commit body
We've been seeing the occasional `cannot seek backwards` panic within
`SelectionsCollection` without means to reproduce.
I believe the cause is one of the callers of
`MutableSelectionsCollection::select` not passing a well formed
`Selection` where `start > end`, so this PR enforces the invariant in
`select` by swapping the fields and setting `reversed` as required as
the other mutator functions already do that as well.
We could also just assert this instead, but it callers usually won't
care about this so its the less user facing annoyance to just fix this
invariant up internally.
Fixes ZED-253
Fixes ZED-ZJ
Fixes ZED-23S
Fixes ZED-222
Fixes ZED-1ZV
Fixes ZED-1SN
Fixes ZED-1Z0
Fixes ZED-10E
Fixes ZED-1X0
Fixes ZED-12M
Fixes ZED-1GR
Fixes ZED-1VE
Fixes ZED-13X
Fixes ZED-1G4
Release Notes:
- Fixed occasional panics when querying selections
ec0eeaf
rope: Assert utf8 boundary of start of `Chunks::new` range (#40253)
Click to expand commit body
We seem to run into panics in related code, so better assert early
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
3763354
zeta2: Numbered lines prompt format (#40218)
Click to expand commit body
Adds a new `NumberedLines` format which is similar to `MarkedExcerpt`
but each line is prefixed with its line number.
Also fixes a bug where contagious snippets wouldn't get merged.
Release Notes:
- N/A
---------
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
Co-authored-by: Michael <michael@zed.dev>
Agus Zubiaga
,
Michael Sloan
, and
Michael
created
4f656ce
acp: Fix /logout for agents that support it (#40248)
Click to expand commit body
We were clearing the message editor too early. We only want to clear the
message editor if we are going to short circuit and return early before
submitting.
Otherwise, the agents that can handle this themselves won't have the
ability to do so.
Release Notes:
- acp: Fix /logout not working for some agents
Ben Brandt
created
0e9ee3c
docs: Add section for configuring Codex (#40250)
7beae75
acp: Allow updating default mode for Codex (#40238)
Click to expand commit body
Release Notes:
- acp: Save default mode for codex
Ben Brandt
created
a6e99c1
project: Always use shell env in `LocalLspAdapterDelegate::which` (#40237)
Click to expand commit body
Windows not having a default shell does not matter here, we might still
have an environment from other means (by being spawned from the cli for
example).
Release Notes:
- N/A *or* Added/Fixed/Improved ...
No need to clutter the `--help` docs with default directories for
platforms other than the current one.
Release Notes:
- N/A
Co-authored-by: David Kleingeld <davidsk@zed.dev>
Julia Ryan
and
David Kleingeld
created
877790a
docs: Remove duplicate Grok 4 Fast entry in `models.md` (#40232)
Click to expand commit body
Release Notes:
- N/A
Djordje
created
0c08bbc
Avoid gap between titlebar and body on linux (#40228)
Click to expand commit body
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: John Tur <john-tur@outlook.com>
Release Notes:
- N/A
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: John Tur <john-tur@outlook.com>
Conrad Irwin
,
Max Brunsfeld
, and
John Tur
created
ba0b687
Fix triggers for debugger thread and session lists not rendering (#40227)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
45af5e4
Fix a couple of bugs in remote browser debugging implementation (#40225)
Click to expand commit body
Follow-up to #39248
- Correctly forward ports over SSH, including the port from the debug
scenario's `url`
- Give the companion time to start up, instead of bailing if the first
connection attempt fails
Release Notes:
- Fixed not being able to launch a browser debugging session in an SSH
project.
f348240
Don't probe for local workspaces pointing to WSL filesystem on startup (#40142)
Click to expand commit body
We automatically delete a local workspace if the folders comprising it
no longer exist.
If a local workspace points to folders in the WSL filesystem, checking
whether those folders exist will make us wait for the WSL VM and file
server to boot up. This can block Zed startup for many seconds.
Supported scenarios use remote workspaces, so delete these local
workspaces to ensure that we don't try to access their folders on the
startup path.
Release Notes:
- N/A
Release Notes:
- Fixes bug were typing `9999999999999999999j` (19 9's) would go up
instead of down
- Max Vim count is now isize::MAX - 1
AidanV
created
1bd34e0
zeta2 cli: Export retrieval stats data frame (#40145)
Click to expand commit body
Retrieval stats will now use polars to build a big data frame for
references with the cartesian product of LSP declarations and retrieved
declaration candidates (with all their score components) and rebuilds
the stats summary on top of it.
This data frame is written to a `.parquet` file, which we can load into
advanced analytics tools (such as Metabase), so we can explore our
scoring distributions and find ways to improve retrieval, and then train
the decision tree.
Release Notes:
- N/A
Agus Zubiaga
created
ce696c1
Remove ping/unwrap from crash handler (#39870)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Julia Ryan <juliaryan3.14@gmail.com>
Fix issue where Zed would unconditionally override user's custom shell
with system default from passwd entry.
Closes https://github.com/zed-industries/zed/issues/40171
Release Notes:
- Fix issue where Zed would unconditionally override user's custom shell
with system default from passwd entry.
---------
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
8c7fb26
acp tools: Add button to copy all observed messages (#40076)
Click to expand commit body
Added a "Copy All Messages" button to the ACP logs toolbar that copies
all messages in the watched stream to the clipboard as structured JSON.
## Motivation
When troubleshooting ACP protocol implementations, it's helpful to
provide the entire message thread to an LLM for analysis. Previously, I
had to copy individual messages one at a time, which was tedious and
time-consuming. This feature allows copying the entire conversation
history in a single click.
Release Notes:
- Added: Copy All Messages button to ACP logs view
---------
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Yordis Prieto
and
Agus Zubiaga
created
867b5df
settings_ui: Only allow to reset a setting to default in the file in which it was customized (#40182)
Click to expand commit body
Plus some other tiny visual adjustments.
Release Notes:
- N/A
Danilo Leal
created
c5bbd55
Add rust-analyzer support for musl linux (#40108)
Click to expand commit body
Release Notes:
- Added rust-analyzer support for musl remotes
localcc
created
4a84b78
collab_ui: Make collaboration panel label responsive on resize (#40157)
fd63d43
Remove obsolete contents tool and add open to write profile (#40131)
Click to expand commit body
`contents` doesn't exist anymore.
`open` was only set for `ask` and not `write`.
Release Notes:
- N/A
Abdelhakim Qbaich
created
ab70555
git_ui: Apply accented color to links in Blame tooltip (#40124)
Click to expand commit body
# Why
Follow up to:
* #39905
# How
Apply accented color to links in message content inside Blame tooltip,
to match appearance in Markdown Preview panel.
Release Notes:
- Improved appearance of links in message content inside Blame tooltip.
# Preview
### Before
<img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 37"
src="https://github.com/user-attachments/assets/33ab4fb5-7910-4d28-9152-c692d6ddeaa6"
/>
### After
<img width="1186" height="798" alt="Screenshot 2025-10-13 at 19 33 10"
src="https://github.com/user-attachments/assets/38082c5c-50d6-4fb3-90ca-410accff9aad"
/>
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bartosz Kaszubowski
and
Danilo Leal
created
474eb8d
git_ui: Layout/spacing tweaks for Blame tooltip (#40130)
Click to expand commit body
# Why
Spotted that spacing of different Blame tooltip elements are spaced
uneven, also the fact that message content disappears on scroll before
reaching border felt a bit odd.
# How
Layout/spacing tweaks for Blame tooltip.
Release Notes:
- Improved appearance of Git Blame tooltip.
# Preview
### Before
<img width="1034" height="702" alt="Screenshot 2025-10-13 at 20 01 07"
src="https://github.com/user-attachments/assets/0c2715d5-d8fa-41dc-b891-a320a74d6fb0"
/>
<img width="1006" height="410" alt="Screenshot 2025-10-13 at 20 06 15"
src="https://github.com/user-attachments/assets/8c16f6dc-58e5-46cc-83fb-dd71a63e7557"
/>
### After
<img width="1034" height="672" alt="Screenshot 2025-10-13 at 20 00 33"
src="https://github.com/user-attachments/assets/e22e0e42-676e-411a-8773-2e57cdaaab17"
/>
<img width="1006" height="370" alt="Screenshot 2025-10-13 at 20 06 55"
src="https://github.com/user-attachments/assets/761995a9-153a-4e5d-923b-e7fbd73dc475"
/>
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bartosz Kaszubowski
and
Danilo Leal
created
da5f25d
acp: Hide completion menu when typing slash command argument (#40126)
Click to expand commit body
Release Notes:
- acp: Fix an issue where the completion menu would still be active
after confirming a slash command
This reverts commit f1db1f3a3c933d8b4d35d83f6bbc49fd46749519.
This seems to have affected the vertical positioning of text that
doesn't contain emojis in a way that was unintended.
Release Notes:
- N/A
Cole Miller
created
da583e5
Revert "fs: Replace a bunch of uses of smol::fs with manual impls" (#40170)
Click to expand commit body
Reverts zed-industries/zed#39906
This PR should not have landed prior to Wednesday.
Piotr Osiewicz
created
9ad6196
fs: Replace a bunch of uses of smol::fs with manual impls (#39906)
Click to expand commit body
smol::fs uses a separate threadpool, which is a bit yuck.
Release Notes:
- N/A
Piotr Osiewicz
created
d4cc4f8
editor: Fix highlight and selection overlap causing flicker while selecting (#40168)
Click to expand commit body
Regressed in https://github.com/zed-industries/zed/pull/39857, only on
Nightly.
Release Notes:
- N/A
Smit Barmase
created
c61429e
acp: Pass through experimental capability for terminal output (#40165)
Click to expand commit body
Release Notes:
- N/A
Ben Brandt
created
4c70d55
acp: Don't collapse tool calls by default (#40164)
Click to expand commit body
Previously, if a tool call's output was just text, it would be collapsed
with no way to open it.
Now we track the collapsed cards instead of the expanded ones to allow
all tool calls to be expanded by default, and only collapse the ones
required by settings changes
Release Notes:
- acp: Fix tool call markdown output unintentionally being collapsed by
default
Ben Brandt
created
025938b
remote: Wrap `uname` invocation in `sh` for `nu` shell (#40084)
Click to expand commit body
Closes https://github.com/zed-industries/zed/pull/39994
Release Notes:
- Fixed remoting not working when nushell is set as the default shell on
the remote target