bb5177b
Remove use of `gpui/screen-capture` feature from collab
Michael Sloan created
bb5177b
Remove use of `gpui/screen-capture` feature from collab
Michael Sloan created
3751737
Add zed://extension/{id} links (#34492)
Release Notes:
- Add zed://extension/{id} links to open the extensions UI with a
specific extension
Conrad Irwin created
ec52e92
Add xAI language model provider (#33593)
Closes #30010 Release Notes: - Add support for xAI language model provider
Umesh Yadav created
af0031a
Fix positioning of terminal inline assist after clearing the screen (#34465)
Closes #33945. Here's my attempt to describe what's going on in that issue and what this fix is doing: We always render the terminal inline assistant starting on the line after the cursor, with a height of 4 lines. When deploying it, we scroll the viewport to the bottom of the terminal so that the assistant will be in view. When scrolling while the assistant is deployed (including in that case), we need to make an adjustment that "pushes up" the terminal content by the height of the assistant, so that we can scroll to see all the normal content plus the assistant itself. That quantity is `scroll_top`, which represents _how much height in the current viewport is occupied by the assistant that would otherwise be occupied by terminal content_. So when you scroll up and a line of the assistant's height goes out of view, `scroll_top` decreases by 1, etc. When we scroll to the bottom after deploying the assistant, we set `scroll_top` to the result of calling `max_scroll_top`, which computes it this way: ``` block.height.saturating_sub(viewport_lines.saturating_sub(terminal_lines)) ``` Which, being interpreted, is "the height of the assistant, minus any viewport lines that are not occupied by terminal content", i.e. the assistant is allowed to eat up vertical space below the last line of terminal content without increasing `scroll_top`. The problem comes when we clear the screen---this adds a full screen to `terminal_lines`, but the cursor is positioned at the top of the viewport with blank lines below, just like at the beginning of a session when `terminal_lines == 1`. Those blank lines should be available to the assistant, but the `scroll_top` calculation doesn't reflect that. I've tried to fix this by basing the `max_scroll_top` calculation on the position of the cursor instead of the raw `terminal_lines` value. There was also a special case for `viewport_lines == terminal_lines` that I think can now be removed. Release Notes: - Fixed the positioning of the terminal inline assistant when it's deployed after clearing the terminal.
Cole Miller created
b398935
Fix comment in default.json (#34481)
Update line to properly reference the intended setting. Release Notes: - N/A
Ariel Rzezak created
78b7737
Remove scap from workspace-hack (#34490)
Regression in #34251 which broke remote_server build Release Notes: - N/A
Michael Sloan created
57e8f5c
Automatically retry in more situations (#34473)
In #33275 I was very conservative about when to retry when there are errors in language completions in the Agent panel. Now we retry in more scenarios (e.g. HTTP 5xx and 4xx errors that aren't in the specific list of ones that we handle differently, such as 429s), and also we show a notification if the thread halts for any reason. <img width="441" height="68" alt="Screenshot 2025-07-15 at 12 51 30 PM" src="https://github.com/user-attachments/assets/433775d0-a8b2-403d-9427-1e296d164980" /> <img width="482" height="322" alt="Screenshot 2025-07-15 at 12 44 15 PM" src="https://github.com/user-attachments/assets/5a508224-0fe0-4d34-9768-25d95873eab8" /> Release Notes: - Automatic retry for more Agent errors - Whenever the Agent stops, play a sound (if configured) and show a notification (if configured) if the Zed window was in the background.
Richard Feldman created
729cde3
project_panel: Add rename, delete and duplicate actions to workspace (#34478)
Release Notes: - Added `project panel: rename`, `project panel: delete` and `project panel: duplicate` actions to workspace. Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Smit Barmase and Danilo Leal created
ebbf02e
keymap_ui: Keyboard navigation for keybind edit modal (#34482)
Adds keyboard navigation to the keybind edit modal. Using up/down arrows to select the previous/next input editor, and `cmd-enter` to save + `escape` to exit Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
3ecdfc9
Remove auto-width editor type (#34438)
Closes #34044
`EditorMode::SingleLine { auto_width: true }` was only used for the
title editor in the rules library, and following
https://github.com/zed-industries/zed/pull/31994 we can replace that
with a normal single-line editor without problems. The auto-width editor
was interacting badly with the recently-added newline visualization
code, causing a panic during layout---by switching it to
`Editor::single_line` the newline visualization works there too.
Release Notes:
- Fixed a panic that could occur when opening the rules library.
---------
Co-authored-by: Finn <finn@zed.dev>
Cole Miller and Finn created
f9561da
Maintain keymap editor position when deleting or modifying a binding (#34440)
When a key binding is deleted we keep the exact same scroll bar position. When a keybinding is modified we select that keybinding in it's new position and scroll to it. I also changed save/modified keybinding to use fs.write istead of fs.atomic_write. Atomic write was creating two FS events that some scrollbar bugs when refreshing the keymap editor. Co-authored-by: Ben \<ben@zed.dev\> Release Notes: - N/A
Anthony Eid created
b3747d9
keymap_ui: Add column for conflict indicator and edit button (#34423)
This PR adds a column to the keymap editor to highlight warnings as well as add the possibility to click the edit icon there for editing the corresponding entry in the list. Release Notes: - N/A --------- Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Finn Evers , Danilo Leal , and Danilo Leal created
95de2bf
keymap_ui: Limit length of keystroke input and hook up actions (#34464)
Closes #ISSUE Changes direction on the design of the keystroke input. Due to MacOS limitations, it was decided that the complex repeat keystroke logic could be avoided by limiting the number of keystrokes so that accidental repeats were less damaging to ux. This PR follows up on the design pass in #34437 that assumed these changes would be made, hooking up actions and greatly improving the keyboard navigability of the keystroke input. Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
d7bb1c1
lsp: Fix workspace diagnostics lag & add streaming support (#34022)
Closes https://github.com/zed-industries/zed/issues/33980 Closes https://github.com/zed-industries/zed/discussions/33979 - Switches to the debounce task pattern for diagnostic summary computations, which most importantly lets us do them only once when a large number of DiagnosticUpdated events are received at once. - Makes workspace diagnostic requests not time out if a partial result is received. - Makes diagnostics from workspace diagnostic partial results get merged. There might be some related areas where we're not fully complying with the LSP spec but they may be outside the scope of what this PR should include. Release Notes: - Added support for streaming LSP workspace diagnostics. - Fixed editor freeze from large LSP workspace diagnostic responses.
teapo created
5f3e7a5
lsp: Wait for shutdown response before sending exit notification (#33417)
Follow up: #18634 Closes #33328 Release Notes: - Fixed language server shutdown process to prevent race conditions and improper termination by waiting for shutdown confirmation before closing connections.
Umesh Yadav created
0671a4d
Allow for venv activation script to use `pyenv` (#33119)
Release Notes: - Allows for configuration and use of `pyenv` as a virtual environment provider
Taylor Beever created
bd78f2c
project: Use `checked_sub` for next/previous in search history (#34408)
Use `checked_sub` instead of checking for bounds manually. Also greatly simplifies the logic for `next` and `previous`. Removing other manual bounds checks as well Release Notes: - N/A
tidely created
d1abba0
gpui: Reduce manual shifting & other minor improvements (#34407)
Minor cleanup in gpui. - Reduce manual shifting by using `u32::to_be_bytes` - Remove eager `Vec` allocation when listing registered actions - Remove unnecessary return statements - Replace manual `if let Some(_)` with `.as_deref_mut()` Release Notes: - N/A
tidely created
0506598
cli: Remove manual `std::io::copy` implementation (#34409)
Removes a manual implementation of `std::io::copy`. The internal buffer of `std::io::copy` is also 8 kB and behaves exactly the same. On Linux `std::io::copy` also has access to some better performing file copying. Release Notes: - N/A
tidely created
7ab8f43
Update to acp 0.0.9 (#34463)
Release Notes: - N/A
Ben Brandt created
050ed85
Add severity argument to GoToDiagnostic actions (#33995)
This PR adds a `severity` argument so severity can be defined when
navigating through diagnostics. This allows keybinds like the following:
```json
{
"] e": ["editor::GoToDiagnostic", { "severity": "error" }],
"[ e": ["editor::GoToDiagnostic", { "severity": "error" }]
}
```
I've added test comments and a test. Let me know if there's anything
else you need!
Release Notes:
- Add `severity` argument to `editor::GoToDiagnostic`,
`editor::GoToPreviousDiagnostic`, `project_panel::SelectNextDiagnostic`
and `project_panel::SelectPrevDiagnostic` actions
Hilmar Wiegand created
858e176
Refine keymap UI design (#34437)
Release Notes: - N/A --------- Co-authored-by: Ben Kunkle <Ben.kunkle@gmail.com>
Danilo Leal and Ben Kunkle created
a65c0b2
collab: Fix typo in log message (#34455)
This PR fixes a small typo in a log message. Release Notes: - N/A
Marshall Bowers created
848a86a
collab: Sync model overages for all active Zed Pro subscriptions (#34452)
Release Notes: - N/A
Marshall Bowers created
52f2b32
extension_cli: Copy over snippet file when bundling extensions (#34450)
Closes #30670 Release Notes: - Fixed snippets from extensions not working.
Piotr Osiewicz created
8dca4d1
Fix border and minimap flickering on pane split (#33973)
Closes #33972 As noted on https://github.com/zed-industries/zed/pull/31390#discussion_r2147473526, when splitting panes and having a border size set for the active pane, or the minimap visibility configured to the active editor only, zed will shortly show a flicker of the border or the minimap on the pane that's being deactivated. Release Notes: - Fixed an issue where pane activations would sometimes have a brief delay, causing a flicker in the process.
Alvaro Parker created
440beb8
Improve Java LSP documentation (#34410)
Remove references to [ABckh/zed-java-eclipse-jdtls](https://github.com/ABckh/zed-java-eclipse-jdtls) which hasn't seen a new version in 10 months (2024-10-01). Release Notes: - N/A
Peter Tripp created
ce63a6d
Exclude .repo folders by default (#34431)
These are used by [Google's `repo` tool](https://android.googlesource.com/tools/repo) used for Android for managing hundreds of git subprojects. Originally reported in: - https://github.com/zed-industries/zed/issues/34302 Release Notes: - Add Google Repo `.repo` folders to default `file_scan_exclusions`
Peter Tripp created
26ba6e7
editor: Improve minimap performance (#33067)
This PR aims to improve the minimap performace. This is primarily achieved by disabling/removing stuff that is not shown in the minimal as well as by assuring the display map is not updated during minimap prepaint. This should already be much better in parts, as the block map as well as the fold map will be less frequently updated due to the minimap prepainting (optimally, they should never be, but I think we're not quite there yet). For this, I had to remove block rendering support for the minimap, which is not as bad as it sounds: Practically, we were currently not rendering most blocks anyway, there were issues due to this (e.g. scrolling any visible block offscreen in the main editor causes scroll jumps currently) and in the long run, the minimap will most likely need its own block map or a different approach anyway. The existing implementation caused resizes to occur very frequently for practically no benefit. Can pull this out into a separate PR if requested, most likely makes the other changes here easier to discuss. This is WIP as we are still hitting some code path here we definitely should not be hitting. E.g. there seems to be a rerender roughly every second if the window is unfocused but visible which does not happen when the minimap is disabled. While this primarily focuses on the minimap, it also touches a few other small parts not related to the minimap where I noticed we were doing too much stuff during prepaint. Happy for any feedback there aswell. Putting this up here already so we have a place to discuss the changes early if needed. Release Notes: - Improved performance with the minimap enabled. - Fixed an issue where interacting with blocks in the editor would sometimes not properly work with the minimap enabled.
Finn Evers created
363a265
Add test for running `Close Others` on an inactive item (#34425)
Adds a test for the changes added in: https://github.com/zed-industries/zed/pull/34355 Release Notes: - N/A
Joseph T. Lyons created
37e73e3
Only depend on scap x11 feature when gpui x11 feature is enabled (#34251)
Release Notes: - N/A
Michael Sloan created
32f5132
Fix contrast adjustment for Powerline separators (#34417)
It turns out Starship is using custom Powerline separators in the Unicode private reserved character range. This addresses some issues seen in the comments of #34234 Release Notes: - Fix automatic contrast adjustment for Powerline separators
Richard Feldman created
fd5650d
debugger: A support for data breakpoint's on variables (#34391)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ... --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com> Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Anthony Eid , Piotr Osiewicz , Mikayla Maki , and Mikayla Maki created
8b6b039
vim: Add missing normal mode binding for signature help overload (#34278)
Closes #ISSUE related https://github.com/zed-industries/zed/pull/33199
domi created
4848bd7
docs/debugger: Remove mention of onboarding calls (#34414)
Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
45d0686
Remove unused KeycodeSource (#34403)
Release Notes: - N/A
Conrad Irwin created
eca36c5
Route all LLM traffic through `cloud.zed.dev` (#34404)
This PR makes it so all LLM traffic is routed through `cloud.zed.dev`. We're already routing `llm.zed.dev` to `cloud.zed.dev` on the server, but we want to standardize on `cloud.zed.dev` moving forward. Release Notes: - N/A
Marshall Bowers created
6673c7c
debugger: Add memory view (#33955)
This is mostly setting up the UI for now; I expect it to be the biggest chunk of work. Release Notes: - debugger: Added memory view --------- Co-authored-by: Anthony Eid <hello@anthonyeid.me> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com> Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Piotr Osiewicz , Anthony Eid , Mikayla Maki , and Mikayla Maki created
a2f5c47
Add `editor::ToggleFoldAll` action (#34317)
In multibuffers adds the ability to alt-click to fold/unfold all
excepts. In singleton buffers it adds the ability to toggle back and
forth between `editor::FoldAll` and `editor::UnfoldAll`.
Bind it in your keymap with:
```json
{
"context": "Editor && (mode == full || multibuffer)",
"bindings": {
"cmd-k cmd-o": "editor::ToggleFoldAll"
}
},
```
<img width="253" height="99" alt="Screenshot 2025-07-11 at 17 04 25"
src="https://github.com/user-attachments/assets/94de8275-d2ee-4cf8-a46c-a698ccdb60e3"
/>
Release Notes:
- Add ability to fold all excerpts in a multibuffer (alt-click) and in
singleton buffers `editor::ToggleFoldAll`
Peter Tripp created
c6a6db9
emacs: Fix cmd-f not working in Terminal (#34400)
Release Notes: - N/A
Peter Tripp created
6f9e052
languages: Add JS/TS generator functions to outline (#34388)
Functions like `function* iterateElements() {}` would not show up in the
editor's navigation outline. With this change, they do.
| **Before** | **After**
|-|-|
|<img width="453" height="280" alt="Screenshot 2025-07-13 at 4 58 22 PM"
src="https://github.com/user-attachments/assets/822f0774-bda2-4855-a6dd-80ba82fffaf3"
/>|<img width="564" height="373" alt="Screenshot 2025-07-13 at 4 58
55 PM"
src="https://github.com/user-attachments/assets/f4f6b84f-cd26-49b7-923b-724860eb18ad"
/>|
Note that I decided to use Zed's agent assistance features to do this PR
as a sort of test run. I don't normally code with an AI assistant, but
figured it might be good in this case since I'm unfamiliar with the
codebase. I must say I was fairly impressed. All the changes in this PR
were done by Claude Sonnet 4, though I have done a manual review to
ensure the changes look sane and tested the changes by running the
re-built `zed` binary with a toy project.
Closes #21631
Release Notes:
- Fixed JS/TS outlines to show generator functions.
Brian Donovan created
2edf85f
evals: Switch disable_cursor_blinking to determenistic asserts (#34398)
Release Notes: - N/A
Oleksiy Syvokon created
00ec243
pane: 'Close others' now closes relative to right-clicked tab (#34355)
Closes #33445 Fixed the "Close others" context menu action to close tabs relative to the right-clicked tab instead of the currently active tab. Previously, when right-clicking on an inactive tab and selecting "Close others", it would keep the active tab open rather than the right-clicked tab. ## Before/After https://github.com/user-attachments/assets/d76854c3-c490-4a41-8166-309dec26ba8a ## Changes - Modified `close_inactive_items()` method to accept an optional `target_item_id` parameter - Updated context menu handler to pass the right-clicked tab's ID as the target - Maintained backward compatibility by defaulting to active tab when no target is specified - Updated all existing call sites to pass `None` for the new parameter Release Notes: - Fixed: "Close others" context menu action now correctly keeps the right-clicked tab open instead of the active tab
vipex created
84124c6
Fix cannot select in terminal when copy_on_select is enabled (#34131)
Closes #33989  Release Notes: - N/A
feeiyu created
cf1ce1b
languages: Fix ESLint diagnostics not getting shown (#33814)
Closes #33442 Release Notes: - Resolved an issue where the ESLint language server returned an empty string for the CodeDescription.href field in diagnostics, leading to missing diagnostics in editor.
Umesh Yadav created
e4effa5
linux: Fix keycodes mapping on Wayland (#34396)
We are already converting Wayland keycodes to X11's; double conversion results in a wrong mapping. Release Notes: - N/A
Oleksiy Syvokon created
f500417
Language independent hotkeys (#34053)
Addresses #10972 Closes #24950 Closes #24499 Adds _key_en_ to _Keystroke_ that is derived from key's scan code. This is more lightweight approach than #32529 Currently has been tested on x11 and windows. Mac code hasn't been implemented yet. Release Notes: - linux: When typing non-ASCII keys on Linux we will now also match keybindings against the QWERTY-equivalent layout. This should allow most of Zed's builtin shortcuts to work out of the box on most keyboard layouts. **Breaking change**: If you had been using `keysym` names in your keyboard shortcut file (`ctrl-cyrillic_yeru`, etc.) you should now use the QWERTY-equivalent characters instead. --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Sergei Surovtsev and Conrad Irwin created
51df8a1
project_panel: Do not render a single sticky entry when scrolled all the way to the top (#34389)
Fixes root entry not expanding/collapsing on nightly. Regressed in https://github.com/zed-industries/zed/pull/34367. Release Notes: - N/A
Smit Barmase created
85d1254
linux: Add `file_finder::Toggle` key binding (#34380)
This fixes a bug on linux where repeated presses of p while holding down the ctrl modifier navigates through options in reverse. Closes #34379 The main issue is the default biding of ctrl-p on linux is menu::SelectPrevious hence in context "context": "FileFinder || (FileFinder > Picker > Editor)" it would navigate in reverse Release Notes: - Fixed `file_finder::Toggle` on Linux not scrolling forward
Somtoo Chukwurah created
0af7d32
keymap_ui: Dismiss context menu less frequently (#34387)
This PR fixes an issue where the context menu in the keymap UI would be immediately dismissed after being opened when using a trackpad on MacOS. Right clicking on MacOS almost always fires a scroll event with a delta of 0 pixels right after (which is not the case when using a mouse). The fired scroll event caused the context menu to be removed on the next frame. This change ensures the menu is only removed when a vertical scroll is actually happening. Release Notes: - N/A
Finn Evers created