19eb280
Fix selection background too
Click to expand commit body
Refactor code to centralize the logic too
Conrad Irwin created
19eb280
Fix selection background too
Refactor code to centralize the logic too
Conrad Irwin created
7a1f404
Add dismiss button to project search
Piotr Osiewicz created
d4d3261
WIP
Nathan Sobo created
adc5046
WIP
Nathan Sobo created
e3a4d17
Fix bash `path_suffixes `and add `cmd-/` line comment support (#2827)
<img width="1608" alt="SCR-20230806-cyrg" src="https://github.com/zed-industries/zed/assets/19867440/2491c4bc-5797-4417-9633-08c136b4e8fe"> I noticed we weren't highlghting bash files if the shebang line didn't exist. After checking, it looks like the `.` were accidentally added to the `path_suffixes` list. This PR fixes that and adds in support for `cmd-/` to trigger line comments. <img width="1608" alt="SCR-20230806-czxh" src="https://github.com/zed-industries/zed/assets/19867440/37dd0c8e-c4e7-49e2-9997-9dd8145f460e"> Release Notes: - Fixed a bug where shell files weren't syntax highlighted if a shebang didn't exist. - Added support for `cmd-/` to add line comments to shell files.
Joseph T. Lyons created
ef5b982
Fix bash path_suffixes and add line_comment
Joseph T. Lyons created
dcf8b00
WIP
Nathan Sobo created
7777d97
Expand empty selections to cover full word when doing case conversions and fix bugs (#2826)
When doing case conversions, specifically in the case of an empty selection, in both VS Code and Sublime, the cursor winds up being in a different place relative to where it started. In VS Code, the cursor maintains it position in the text, no matter if the text expands or shrinks https://github.com/zed-industries/zed/assets/19867440/b24f5d86-c315-4a72-9ed4-3732b490ea9a In Sublime, I have no idea what is going on: https://github.com/zed-industries/zed/assets/19867440/05f21303-6e42-47b2-b844-7accd0bf05d7 I thought it would be a better experience if, when doing an empty selection transformation, we simply expand the selection and park the cursor at the end of the newly-transformed text. https://github.com/zed-industries/zed/assets/19867440/833619ef-04e2-47b6-ad4e-e2b43d54fb2b This feels similar to us expanding the selection when doing line manipulations: https://github.com/zed-industries/zed/assets/19867440/c30c5332-787d-4cf0-a9ee-e66c3c159956 Selections are adjusted to match however each word expands and shrinks, even when there are multiple: https://github.com/zed-industries/zed/assets/19867440/d7073aac-8a59-4f2c-b0e5-1df37be1694c Release Notes: - Improved behavior of empty-selection case transformations by selecting resulting word. - Fixed some bugs with overflow
Joseph T. Lyons created
1abb6a0
Expand empty selections to cover full word and fix bugs
Joseph T. Lyons created
d1048d0
Add more convert to case commands (#2825)
I'm using [convert_case](https://crates.io/crates/convert_case)
underneath the hood, which has over 35 million downloads and feels
solid.
Release Notes:
- Added commands to convert between variable name styles
([#1821](https://github.com/zed-industries/community/issues/1821)).
- `convert to kebab case`
- `convert to snake case`
- `convert to upper camel case`
- `convert to lower camel case`
- `convert to title case`
Joseph T. Lyons created
12e8f41
Add more convert to case commands
ConvertToTitleCase ConvertToSnakeCase ConvertToKebabCase ConvertToUpperCamelCase ConvertToLowerCamelCase
Joseph T. Lyons created
2ccd153
Fix joining descendant channels, style channel invites
Co-authored-by: Mikayla <mikayla@zed.dev>
Max Brunsfeld and Mikayla created
5c2f38a
Add `convert to {upper,lower} case` commands (#2824)
Release Notes: - Added `convert to upper case` and `convert to lower case` commands ([#1011](https://github.com/zed-industries/community/issues/1011)).
Joseph T. Lyons created
87b2d59
Flesh out channel member management
Co-authored-by: Mikayla <mikayla@zed.dev>
Max Brunsfeld and Mikayla created
8c98b02
Add `convert to {upper,lower} case` commands
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>
Joseph T. Lyons and Julia created
a2486de
Don't expose channel admin actions in UI if user isn't admin
Max Brunsfeld created
9889449
Adjust row count for project search.
Instead of using the same row count as for the breadcrumbs, we double the height so that there's some space for padding. Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
1762d2c
Add test assertion where user is not admin of channel
Max Brunsfeld created
de8e185
Align match count
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
8fa082c
Center the query editor (for real now)
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
82eb6d8
Change styling of match nav buttons
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
b6110fe
WIP
Nathan Sobo created
22927fa
Fix visual selection cursor in multibuffers
Conrad Irwin created
2c0e388
Align search bar in the middle
Piotr Osiewicz created
fcefb37
Prevent modes from being vertically centered when row_count changes
Piotr Osiewicz created
792f29e
Refresh windows on toggle_filters.
Piotr Osiewicz created
50d03ff
Revert "Focus filters when enabled"
This reverts commit 13a6b65a35b886b9ac380e56354acb7e562bcfab.
Piotr Osiewicz created
196946c
Squelch warnings for now
Nathan Sobo created
379652f
Merge branch 'main' into cells
Nathan Sobo created
7a04ee3
Start work on exposing which channels the user has admin rights to
Max Brunsfeld created
95b1ab9
Implement channel member removal, permission check for member retrieval
Max Brunsfeld created
d3c1966
WIP: Return WindowHandle<V: View> from AppContext::add_window (#2820)
Instead of returning a usize for the window id, I'm instead returning a `WindowHandle<V: View>` where `V` is the type of the window's root view. @as-cii helped me with a cool technique using generic associated types where methods on `WindowHandle` can return either T or Option<T> depending on the `BorrowWindowContext::Result` associated type. Some example usage... ```rs let window = cx.add_window(|cx| MyView::new(cx)); let my_view = window.root(cx); // If cx is TestAppContext, returns MyView. Otherwise returns Option<MyView>, because the window could be closed. ``` This isn't insanely beneficial on its own, but I think it will help clean up our testing story. I'm planning on making `window` more useful in tests for laying out elements, etc. - [x] Rework tests that call `add_window` 😅 to expect only a window in return. - [x] Get tests passing - [x] 🚬 test
Nathan Sobo created
13a6b65
Focus filters when enabled
Piotr Osiewicz created
2d96388
Use WindowHandles in a couple places
Nathan Sobo created
4a6c73c
Lay-out channel modal with picker beneath channel name and mode buttons
Co-authored-by: Mikayla <mikayla@zed.dev>
Max Brunsfeld and Mikayla created
485c0a4
Don't refcount window handles
Nathan Sobo created
afcc0d6
WIP
Nathan Sobo created
ee1b4a5
Add `PathExt` trait (#2823)
This PR adds a `PathExt` trait. It pulls in our existing `compact()` function, as a method, and then adds a method, and testing, for `icon_suffix()`. A test was added to fix: - https://github.com/zed-industries/community/issues/1877 Release Notes: - Fixed a bug where file icons would not be registered for files with with `.` characters in their name ([#1877](https://github.com/zed-industries/community/issues/1877)).
Joseph T. Lyons created
a7e883d
Implement basic channel member management UI
Co-authored-by: Mikayla <mikayla@zed.dev>
Max Brunsfeld and Mikayla created
c14a99d
updated project_search text
KCaverly created
129f289
simplify server implementation
Mikayla Maki created
9a1dd0c
Fetch channel members before constructing channel mgmt modal
Max Brunsfeld created
6c4964f
WIP: continue channel management modal and rename panel to collab_panel
Mikayla Maki created
4658bc6
Update styling of nav buttons (width, corner_radius)
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
31fb503
Rewrite permission queries (it no longer blocks)
Co-authored-by: Kyle <kyle@zed.dev> Co-authored-by: Max <max@zed.dev>
Piotr Osiewicz , Kyle , and Max created
d450c4b
WIP: add custom channel modal
Mikayla Maki created
d157e35
Query semantic_permissioned on demand.
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
799adf6
Query Semantic Index Engine for permission state.
Co-authored-by: Kyle <kyle@zed.dev>
Piotr Osiewicz and Kyle created
8dd330a
add semantic search prompt for the indexing permission on first search
Co-authored-by: Piotr <piotr@zed.dev>
KCaverly and Piotr created
358e4e5
update minor text when actively searching
KCaverly created