Commit log

933537e zed 0.107.5

Antonio Scandurra created

c44181d Revert outline summarization (#3114)

Click to expand commit body
This pull request essentially reverts #3067: we noticed that only using
the function signatures produces far worse results in codegen, and so
that feels like a regression compared to before. We should re-enable
this once we have a smarter approach to fetching context during codegen,
possibly when #3097 lands.

As a drive-by, we also fixed a longstanding bug that caused codegen to
include the final line of a selection even if the selection ended at the
start of the line.

Ideally, I'd like to hot fix this to preview so that it goes to stable
during the weekly release.

/cc: @KCaverly @nathansobo 

Release Notes:

- N/A

Antonio Scandurra created

ad0e53a Fix Discord text truncation

Joseph T. Lyons created

0f62241 zed 0.107.4

Max Brunsfeld created

7ef8bd6 Always log panics (#2896)

Click to expand commit body
I just panicked and wanted to see the cause, but forgot that panic files
get deleted when Zed uploads them.

Release Notes:

- Panics are now written to `~/Library/Logs/Zed/Zed.log`

Max Brunsfeld created

aed3178 Fix inclusion of spurious views from other projects in FollowResponse (#3116)

Click to expand commit body
A logic error in https://github.com/zed-industries/zed/pull/2993 caused
follow responses to sometimes contain extra views for other unshared
projects 😱 . These views would generally fail to deserialize on the
other end. This would create a broken intermediate state, where the
following relationship was registered on the server (and on the leader's
client), but the follower didn't have the state necessary for following
into certain views.

Release Notes:

- Fixed a bug where following would sometimes fail if the leader had
another unshared project open.

Max Brunsfeld created

a15b9a5 Truncate Discord release note text (#3112)

Click to expand commit body
Hopefully this works the first time 😅

Release Notes:

- N/A

Joseph T. Lyons created

91ee6b5 zed 0.107.3

Max Brunsfeld created

78fe18a More small following-related fixes (#3110)

Max Brunsfeld created

9d76ba4 Detect file paths that end with `:` (#3109)

Click to expand commit body
New rustc messages look like

```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
  left: 0
 right: 1
```

now and we fail to parse that `13:` bit properly, fix that.

One caveat is that we highlight the entire word including the trailing
`:`:
<img width="914" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/d653a8ff-3e6e-4e3d-b6ea-dad0c8db0f06">

this is unfortunate, but better than nothing (as now).
This is due to the fact, that we detect words with regex inside the
`terminal.rs` and send events to other place that's able to check paths
for existence (and whether that's a path at all), currently there's no
way to detect a path and sanitize it in `terminal.rs`

Release Notes:

- N/A

Kirill Bulatov created

b865efe Fix bug that allowed following multiple people in one pane (#3108)

Click to expand commit body
I've also simplified the representation of a workspace's leaders, so
that it encodes in the type that there can only be one leader per pane.

Release Notes:

- Fixed a bug where you could accidentally follow multiple collaborators
in one pane at the same time.

Max Brunsfeld created

f92d44e Use display name for release channel in panic events (#3101)

Click to expand commit body
This was a mistake from long ago - something I've been meaning to fix
for a long time. All other events use `display_name()`, but panic
events, which leads to mistakes when filtering out `Zed Dev`, which
isn't the format that `dev_name()` returns. I'm adding a fix to zed.dev
as well:

- https://github.com/zed-industries/zed.dev/pull/393

so that the values are adjusted for all clients, not just ones with this
fix. I will correct the data in clickhouse, and adjust the queries in
metabase.

Release Notes:

- N/A

Joseph T. Lyons created

62358b9 Add session id to panic events (#3098)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

df63290 Fix panic when immediately closing a window while opening paths (#3092)

Click to expand commit body
Fixes this panic that I've been seeing in Slack:


[example](https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1696530575535779)


```
thread 'main' panicked at 'assertion failed: opened_items.len() == project_paths_to_open.len()'
crates/workspace/src/workspace.rs:3628
<backtrace::capture::Backtrace>::create
<backtrace::capture::Backtrace>::new
Zed::init_panic_hook::{closure#0}
std::panicking::rust_panic_with_hook
std::panicking::begin_panic_handler::{{closure}}
std::sys_common::backtrace::__rust_end_short_backtrace
_rust_begin_unwind
core::panicking::panic_fmt
core::panicking::panic
<workspace::Workspace>::new_local::{closure#0}::{closure#0}
```

I believe it was caused by a window being closed immediately, while it
was still loading some paths. There was a mismatch in expectation
between the `workspace::open_items` function (which contains this
assertion), and the `Workspace::load_workspace` method. That later
method can return an empty vector if the workspace handle is dropped
while it is executing.

Release Notes:

- Fixed a crash when closing a Zed window immediately after opening it

Max Brunsfeld created

6098f94 zed 0.107.2

Max Brunsfeld created

6f4dee5 Add markdown parsing to channel chat (#3088)

Click to expand commit body
TODO:
- [x] Add markdown rendering to channel chat
- [x] Unify (?) rendering logic between hover popover and chat
- [x] ~~Determine how to deal with document-oriented markdown like `#`~~
Unimportant until we want to do something special with `#channel`
- [x] Tidy up spacing and styles in chat panel

Release Notes:

- Added markdown rendering to channel chat
- Improved channel chat message style
- Fixed a bug where long chat messages would not soft wrap

Mikayla Maki created

4ca2645 Fix bugs in handling mutual following (#3091)

Click to expand commit body
This fixes some bugs in our following logic, due to our attempts to
prevent infinite loops when two people follow each other.

* Propagate all of leader's views to a new follower, even if those views
were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
following that follower.
* Avoid redundant active view updates on the client.

Release Notes:

- Fixed bugs where it was impossible to follow someone into a view that
they previously following you into.

Max Brunsfeld created

c41a3ec Add session id (#3090)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

4edd036 collab 0.22.2

Mikayla created

cc4fb1c zed 0.107.1

Mikayla created

fc3d754 Remove old code from notes icon click handler (#3085)

Click to expand commit body
Release Notes:

- Fix clicking the notes icon when people are in the channel (preview
only)

Mikayla Maki created

643f3db 107 channel touch ups (#3087)

Click to expand commit body
Release Notes:

- Add user avatars to channel chat messages
- Group messages by sender
- Fix visual bugs in new chat and note buttons

Mikayla Maki created

b90c040 Ensure chat messages are retrieved in order of id (#3086)

Click to expand commit body
Also, remove logic for implicitly marking chat messages as observed when
they are fetched. I think this is unnecessary, because the client always
explicitly acknowledges messages when they are shown.

Release Notes:

- Fixed a bug where chat messages were shown out of order (preview only)

Max Brunsfeld created

11f7a2c Fix panic in increment (#3084)

Click to expand commit body
Release Notes:

- Fixes a panic in vim when incrementing a non-number.

Conrad Irwin created

8bdc597 v0.107.x preview

Joseph T. Lyons created

01b45f4 Show when a channel resource changes (#3074)

Click to expand commit body
This PR adds a mechanism for notifying the client when a channel note
has been edited or a message has been changed.

TODO: 
- [x] Fix infinite loop when opening the chat panel
- [x] Switch to client-side ack model of observation detection
- [x] Add client-side-only change detection (e.g. for when a channel
note is open locally but not focused)
- [x] Review implementation / query performance.
- [x] Fix lack of ACK on restart for channel buffers
- [x] remove channel note opening on click
- [x] Fix channel messages sent while chat channel is in the background
not showing the channel as changed.

Release Notes:

- N/A

Mikayla Maki created

4d61d01 Add an RPC handler for channel buffer acks

Click to expand commit body
co-authored-by: max <max@zed.dev>

Mikayla and max created

dd0edcd Changed the on-click behavior of joining a channel to not open the chat, and only open 1 project instead of all projects

Click to expand commit body
Co-authored-by: conrad <conrad.irwin@gmail.com>
Co-authored-by: max <max@zed.dev>

Mikayla , conrad , and max created

e548572 Fix channel messages test

Mikayla created

db8096c Fix most tests for new chat changes

Mikayla created

3bc7024 Fix unit test

Click to expand commit body
co-authored-by: Conrad <conrad.irwin@gmail.com>

Mikayla and Conrad created

4ff80a7 Fix a few mouse event id bugs and move facepile to the left

Click to expand commit body
co-authored-by: conrad <conrad.irwin@gmail.com>

Mikayla and conrad created

23ee821 Lower frequency of popup warning when leaving a call

Click to expand commit body
co-authored-by: conrad <conrad.irwin@gmail.com>

Mikayla and conrad created

95342c8 Merge branch 'main' into channel-changes

Max Brunsfeld created

61e0289 Acknowledge channel notes and chat changes when views are active

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created

af09861 Specify uuid crate in the root Cargo.toml

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created

55d2b9b join channels (#3082)

Click to expand commit body
Release Notes:

- Clicking on a channel in the sidebar will now join the channel and
open the notes
- If you join a channel that already shared projects, you will join the
projects automatically and follow the host.
- Clicking on the current channel in the sidebar will re-open the notes.
- Chat can now be accessed from the right click menu of channels.


- (probably not worth mentioning) Various improvements to hover states
and tooltips in the collab ui; and if you click on a channel while in
another call, confirm before switching.

Conrad Irwin created

044fb9e Confirm on switching channels

Conrad Irwin created

6007c87 Upgrade SeaORM to latest version, also upgrade sqlite bindings, rustqlite, and remove SeaQuery

Click to expand commit body
co-authored-by: Max <max@zed.dev>

Mikayla and Max created

d696b39 Tooltips for contacts

Conrad Irwin created

32c4138 Added db message and edit operation observation

Click to expand commit body
Co-authored-by: Max <max@zed.dev>

Mikayla and Max created

d8bfe77 Scroll so that collab panel is in good state for calls

Conrad Irwin created

8b0969b Update cpu and memory event code (#3081)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

66dfa47 Update collab ui to join channels again

Conrad Irwin created

b10255a Update cpu and memory event code

Click to expand commit body
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>

Joseph T. Lyons and Julia created

cf5d89d Leverage embeddings query to collapse syntax nodes if not selected (#3067)

Click to expand commit body
Reverts zed-industries/zed#3049

Kyle Caverly created

9f16053 move collapsed only matches outside item parent in embedding.scm

KCaverly created

18e7305 Change channel join behavior

Click to expand commit body
- Clicking on a channel name now joins the channel if you are not in it
- (or opens the notes if you are already there).
- When joining a channel, previously shared projects are opened
  automatically.
- If there are no previously shared projects, the notes are opened.

Conrad Irwin created

d9813a5 show host in titlebar (#3072)

Click to expand commit body
Release Notes:

- show host in the titlebar of shared projects
- clicking on faces in the titlebar will now always follow the person
(it used to toggle)
- clicking on someone in the channel panel will follow that person
- highlight the currently open project in the channel panel

- fixes a bug where sometimes following between workspaces would not
work

Conrad Irwin created

d7867cd Add/fix mouse interactions in current call sidebar

Conrad Irwin created