Still to do:
- [ ] Figure out why `ctrl-g` `ctrl-g` doesn't dismiss GoToLine (but
`cmd-shift-p` `cmd-shift-p` does dismiss Command). Likely to do with the
"Editor" context in the keymap, but this did used to work in gpui1.
- [ ] Fix first render with incorrect matches immediately flashes.
- [ ] Show keybindings
- [x] Figure out why `cmd-shift-p "go to line" enter` panics
- [ ] Fix the selected visuals
- [ ] Party hard
- [ ] Uncomment the tests
Conrad Irwin
created
cc9fb9d
Fix panic caused by focusing the same thing twice
b9e098e
Start work on creating gpui2 version of project panel
Max Brunsfeld
created
cb8c534
theme_importer: Support importing themes containing comments (#3298)
Click to expand commit body
This PR updates the `theme_importer` with support for parsing theme
files containing comments.
Up until now we've been manually removing comments from the VS Code
theme files.
Release Notes:
- N/A
8bd02fd
Extend RGBA hex color parsing to support 3-value and 4-value variants (#3295)
Click to expand commit body
This PR extends our support for parsing hex color codes to `Rgba` to
additionally support 3-value (`#rgb`) and 4-value (`#rgba`) formats.
See [here](https://developer.mozilla.org/en-US/docs/Web/CSS/hex-color)
for more details on these hex color variants.
Release Notes:
- N/A
This PR fixes some issues in response to feedback from Dan Abramov and
Jose Valim.
To do:
* [x] fix non-word search suggestions
* [x] add setting for disabling search suggestions
Release Notes:
- Fixed an issue where opening a search without text selected would
populate the search query with non-word characters adjacent to the
cursor.
- Added a setting, `seed_search_query_from_cursor`, which controls
whether the search query is automatically populated from the buffer when
starting a new buffer search or project search.
By default, the search query will always be set to the word under the
cursor. If you want to only populate the search query when text is
selected, you can add the following to your `~/.zed/settings.json`:
```json
{
"seed_search_query_from_cursor": "selection"
}
```
If you don't want the search query to be automatically populated, even
when there is text selected, add the following:
```json
{
"seed_search_query_from_cursor": "never"
}
```
Max Brunsfeld
created
b6eef26
Merge branch 'main' into search-query-suggestion-fixes
This PR refines a number of styles in the default theme, as well as
updates the theme importer to support importing syntax styles from VS
Code themes.
Release Notes:
- N/A
Marshall Bowers
created
7b489f5
Allow user-theme related methods to be unused
c6b76d9
Use normal JS comments within JSX tags and JSX expression blocks (#3290)
Click to expand commit body
This fix only required changing the `overrides` queries for JavaScript
and TSX. I've made the fix in both the `zed2` and `zed` crates.
Release Notes:
- Fixed an issue in JavaScript and TSX files, where the 'toggle
comments' command used the wrong comment syntax inside of JSX tags and
expressions within JSX.
Max Brunsfeld
created
e50318e
Duplicate buffer test changes in language2 version
Max Brunsfeld
created
4c89b28
Use normal JS comments within JSX tags and JSX expression blocks
ff19a0c
Add `importing-themes` feature flag to `theme2` crate
Click to expand commit body
When this feature is set the `themes` module won't be compiled.
This allows us to run the `theme_importer` even when the `themes` module
has compile errors in it.
Marshall Bowers
created
60eae3e
Emit unique highlights for each syntax token