Commit log

b6ed3b2 Remove debug

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

50fe683 Fix typos

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

b5924d6 Add simulate_window_resize.

Click to expand commit body
Fixes up tests for movement in editor/scrolling.

Co-authored-by: Antonio <antonio@zed.dev>

Piotr Osiewicz and Antonio created

80ae640 Add additional cursors to gpui2

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

0af0c55 Update toolbar left tool group

Nate Butler created

68d309e Fix disparity between editor2 and edito1 wrt copilot completions.

Click to expand commit body
Fixes test test_copilot.

Co-authored-by: Antonio <antonio@zed.dev>

Piotr Osiewicz and Antonio created

fd2f1c2 Fix up copilot2 test

Click to expand commit body
Co-authored-by: Antonio <antonio@zed.dev>

Piotr Osiewicz and Antonio created

2108ddf Defer activating Subscriptions that are invoked as a part of an effect.

Click to expand commit body
Fixes test test_edit_events.

Co-authored-by: Antonio <antonio@zed.dev>

Piotr Osiewicz and Antonio created

ee23fa4 Disable instance handshake in dev builds (#3485)

Click to expand commit body
It feels like every week or two someone hits this and is confused about
why the app isn't launch, been meaning to disable this in dev builds for
a while. This does mean that it'll be possible to hit the local DB lock
panic in a dev build if you run it multiple times but that is so rare
that it seems preferable

Release Notes:

- N/A

Julia created

118c9b5 Ensure disabled buttons don't have interaction styles

Nate Butler created

b9a917f Fix up condition not checking the condition at the start.

Click to expand commit body
Co-authored-by: Antonio <antonio@zed.dev>

Piotr Osiewicz and Antonio created

7dc22fe Prevent tab bar from growing in height when a tab is added

Nate Butler created

24b0892 Revert "fix display map tests"

Click to expand commit body
This reverts commit 0f7fc8c1a03eaec347df101ada66f28aefa3162a.

Piotr Osiewicz created

dfe4fc4 Disable instance handshake in dev builds

Julia created

11c1625 Update empty pane state

Nate Butler created

ff734d4 uncomment and augment mouse_context_menu tests

Piotr Osiewicz created

3b1a065 inlay hints: Relax the test condition.

Click to expand commit body
We've investigated another spurious failure, this time with test_multiple_excerpts_large_multibuffer; sadly it didn't really get us anywhere, so for now we're relaxing an assert.

Co-authored-by: Kirill <kirill@zed.dev>

Piotr Osiewicz and Kirill created

b3e741b Fix up test_highlighted_ranges

Click to expand commit body
Returned highlights were okay, but the test was trying to normalize the output by sorting the highlights by color. The ordering is different between gpui1 Color and gpui2 Hsla.

Piotr Osiewicz created

1a5f6f6 Uncomment & fix up test_transpose

Piotr Osiewicz created

0f7fc8c fix display map tests

Click to expand commit body
These tests failed due to an indefinite hang in buffer.condition in the following code:
\`\`\`rust
    let buffer = cx
        .add_model(|cx| Buffer::new(0, cx.model_id() as u64, text).with_language(language, cx));
    buffer.condition(cx, |buf, _| !buf.is_parsing()).await;
`\`\`
In both gpui1 and gpui2 \`.with_language\` spawns a task that notifies the context once it's done. The \`condition\` waits for notifications to be raised. The gist of the problem was that in gpui2, the spawned task was scheduled straight away, so we never really saw the notification with \`condition\`, causing us to wait indefinitely. This is probably a difference in test between schedulers in gpui1 and gpui2, but I kind of sidestepped the issue by spawning a condition before firing off a parsing task with \`set_language\`.

Piotr Osiewicz created

9ffe78d Fix up random wrap map test

Piotr Osiewicz created

45230dc Log project path that was no open due to no project entry found

Kirill Bulatov created

aa3c9b8 In-flight entertainment (#3484)

Click to expand commit body
- +language_selector2
- Language Selector 2 working!
- Prevent languages showing in wrong order first
- copilot_menu2 (though only tested offling, which is insufficient)
- Dismiss tooltips at capture
- Get ChannelModal opening

[[PR Description]]

Release Notes:

-  N/A

Conrad Irwin created

859f2d2 Get ChannelModal opening

Conrad Irwin created

63b65b2 Dismiss tooltips at capture

Click to expand commit body
(Otherwise they stay open when you hover over the editor, which
stops mouse move events propagating)

Conrad Irwin created

1da18eb copilot_menu2 (though only tested offling, which is insufficient)

Conrad Irwin created

6426997 Prevent languages showing in wrong order first

Conrad Irwin created

6a5b5f0 Language Selector 2 working!

Conrad Irwin created

2de6758 +language_selector2

Conrad Irwin created

0edd89a Bind CloseWindow and Open actions on workspace

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Nathan Sobo and Max created

6f7995c Enable workspace::Open global action

Nathan Sobo created

379ba62 Move workspace bindings to workspace context

Click to expand commit body
Without this, hitting cmd-n on the context menu in the project browser
invokes the workspace::NewFile action instead of the project::NewFile
action. We're considering changing the behavior so that bindings with no
context can only invoke global actions.

Co-Authored-By: Max <max@zed.dev>

Nathan Sobo and Max created

2bf4887 Progress on diagnostic multibuffer

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

03ebf0a Implement FixedWidth for all button types

Click to expand commit body
[no-ci]

Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

26ae31b Bump RPC protocol version in zed2 to match zed1 (#3482)

Max Brunsfeld created

6b0457c Bump RPC protocol version in zed2 to match zed1

Max Brunsfeld created

d81fb36 Uncomment copilot2 tests

Piotr Osiewicz created

d788bf3 Fix retrieval of app version in auto_update2 (#3481)

Click to expand commit body
With this fix, auto-updates should work on nightly.

Max Brunsfeld created

c07455e Update path header style

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

d85db44 Fix retrieval of app version in auto_update2

Max Brunsfeld created

89aa6a3 Re-add diagnostic headers

Nate Butler created

f5679f9 Update diagnostics style

Nate Butler created

be509a5 test_clipboard

Piotr Osiewicz created

5dd9db3 collab 0.29.1

Max Brunsfeld created

aace0d8 Prevent moving a channel into its descendant (#3480)

Click to expand commit body
This fixes a bug where it was possible to put the channel tree into a
bad state by accidentally dragging a channel into itself or one of its
descendants.

Max Brunsfeld created

4479628 Prevent moving a channel into its descendant

Max Brunsfeld created

0a1765b test_following_with_multiple_excerpts (passes)

Piotr Osiewicz created

c3e7732 Add support for optional icon to `Button` (#3479)

Click to expand commit body
This PR extends `Button` with support for an optional icon to be
displayed next to the label.

As part of this, the functionality for displaying an icon within a
button has been factored out into an internal `ButtonIcon` component.
`ButtonIcon` is now used by both `IconButton` and `Button` to
encapsulate the concerns of an icon that is rendered within a button.

Release Notes:

- N/A

Marshall Bowers created

a985b7a test_following (passes :))

Piotr Osiewicz created

20ae58e Bunch of new tests

Piotr Osiewicz created