81cc6e8
pane: When opening a buffer, actually scroll to the selected tab. (#3306)
Click to expand commit body
Previously it might've reused a shared state.
Deals with https://github.com/zed-industries/community/issues/2262 also
fixes influencer's feedback.
No gpui2 port, due to 0 scrollable functionality in it yet.
Release Notes:
- Fixed tabs not being scrolled to on buffer (re)open
(https://github.com/zed-industries/community/issues/2262)
Kirill Bulatov
created
f0f0b47
pane: When opening a buffer, actually scroll to the selected tab. Previously it might've reused a shared state.
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2262 also fixes influencer's feedback.
Co-Authored-By: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
9c18253
Register key and action listeners using `Interactive::initialize`
Click to expand commit body
Co-Authored-By: Thorsten <mrnugget@gmail.com>
Antonio Scandurra
and
Thorsten
created
318cb78
Fix panic when calling `with_key_dispatch` recursively
Click to expand commit body
Co-Authored-By: Thorsten <mrnugget@gmail.com>
Antonio Scandurra
and
Thorsten
created
13255ef
Poke at getting the project panel showing up
This resolves a minor issue where build scripts could've acquired more job server tokens from Cargo than allowed by `-j` parameter. I've filled a PR at https://github.com/rust-lang/cc-rs/pull/878 and we've iterated on the design over there since.
TL;DR: some build scripts may complete a tad bit quicker, potentially shaving off a few seconds off of debug/release builds.
3cd4eef
Do not add diagnostics for any selection in the diagnostics panel (#3300)
Click to expand commit body
Make the panel less jumpy by deferring diagnostics updates until cmd-s
is pressed, if any caret is placed inside the diagnostics panel.
Release Notes:
- N/A
Kirill Bulatov
created
d38a2b7
Do not add diagnostics for any selection in the diagnostics panel
Still to do:
- [ ] Figure out why `ctrl-g` `ctrl-g` doesn't dismiss GoToLine (but
`cmd-shift-p` `cmd-shift-p` does dismiss Command). Likely to do with the
"Editor" context in the keymap, but this did used to work in gpui1.
- [ ] Fix first render with incorrect matches immediately flashes.
- [ ] Show keybindings
- [x] Figure out why `cmd-shift-p "go to line" enter` panics
- [ ] Fix the selected visuals
- [ ] Party hard
- [ ] Uncomment the tests
Conrad Irwin
created
cc9fb9d
Fix panic caused by focusing the same thing twice
b9e098e
Start work on creating gpui2 version of project panel
Max Brunsfeld
created
cb8c534
theme_importer: Support importing themes containing comments (#3298)
Click to expand commit body
This PR updates the `theme_importer` with support for parsing theme
files containing comments.
Up until now we've been manually removing comments from the VS Code
theme files.
Release Notes:
- N/A
8bd02fd
Extend RGBA hex color parsing to support 3-value and 4-value variants (#3295)
Click to expand commit body
This PR extends our support for parsing hex color codes to `Rgba` to
additionally support 3-value (`#rgb`) and 4-value (`#rgba`) formats.
See [here](https://developer.mozilla.org/en-US/docs/Web/CSS/hex-color)
for more details on these hex color variants.
Release Notes:
- N/A
This PR fixes some issues in response to feedback from Dan Abramov and
Jose Valim.
To do:
* [x] fix non-word search suggestions
* [x] add setting for disabling search suggestions
Release Notes:
- Fixed an issue where opening a search without text selected would
populate the search query with non-word characters adjacent to the
cursor.
- Added a setting, `seed_search_query_from_cursor`, which controls
whether the search query is automatically populated from the buffer when
starting a new buffer search or project search.
By default, the search query will always be set to the word under the
cursor. If you want to only populate the search query when text is
selected, you can add the following to your `~/.zed/settings.json`:
```json
{
"seed_search_query_from_cursor": "selection"
}
```
If you don't want the search query to be automatically populated, even
when there is text selected, add the following:
```json
{
"seed_search_query_from_cursor": "never"
}
```
Max Brunsfeld
created
b6eef26
Merge branch 'main' into search-query-suggestion-fixes