Commit log

dfed171 Ensure that new view observers are called by WindowContext::replace_root_view (#3730)

Click to expand commit body
This fixes a bug where the window got into a bad, non-interactive state
when opening a project from an empty window.

Max Brunsfeld created

c81e89a Ensure that new view observers are called by WindowContext::replace_root_view

Max Brunsfeld created

71d17e2 Fix layout of diagnostic blocks (#3729)

Click to expand commit body
Previously, all of the lines in a multi-line error message were painted
on top of each other. I also simplified the logic for highlighting
backtick-enclosed ranges in a diagnostic message.

Max Brunsfeld created

305cd9b Style go-to-definition links (#3727)

Click to expand commit body
This PR styles go-to-definition links using the link color from the
theme.

Release Notes:

- N/A

Marshall Bowers created

3fccc64 Fix layout of diagnostic blocks

Max Brunsfeld created

0390fb1 Reintroduce LSP diagnostic/status message

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

afcf6c6 Map `textLink.activeForeground` from VS Code to `link_text_hover`

Marshall Bowers created

a0224b9 Use `link_text_hover` for go-to-definition links

Marshall Bowers created

53b76e3 Style pane drop targets (#3726)

Click to expand commit body
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.

We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.

Release Notes:

- N/A

Marshall Bowers created

547ad77 Style tab drop targets for project entries (#3725)

Click to expand commit body
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.

I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.

Release Notes:

- N/A

Marshall Bowers created

599ec5c Make collab panel usable from the keyboard, add missing styling (#3724)

Click to expand commit body
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items

Max Brunsfeld created

afd3bf7 Add missing selected state and keyboard action for some collab panel items

Max Brunsfeld created

901795b Don't reset the collab panel when it loses focus

Max Brunsfeld created

1b09862 Restrcit context for some editor bindings that don't apply to single-line editors

Max Brunsfeld created

acbb3f3 Better display items from different sources with different z-indices in the same place (#3723)

Kirill Bulatov created

cf12d62 Tidy up z-index handling

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created

097640e Fix typo in `ButtonCommon` doc comment (#3722)

Click to expand commit body
This PR fixes a small typo in the doc comments for `ButtonCommon`.

Was waiting to roll this up into another PR, but it never ended up
happening.

Release Notes:

- N/A

Marshall Bowers created

f6d3191 Optimize stack id in-memory layout

Kirill Bulatov created

8f1c537 Fix more z-index and rendering issues

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created

825a8f0 Initial fix of the z-index

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Kirill Bulatov , Antonio Scandurra , and Nathan Sobo created

a9fe108 Fix typo in "Quote Selection" tooltip (#3721)

Click to expand commit body
This PR fixes a typo in the "Quote Selection" tooltip.

Release Notes:

- N/A

Marshall Bowers created

7bc9319 Apply padding at the toolbar level (#3720)

Click to expand commit body
This PR adjusts the padding in the toolbar to be applied within the
toolbar itself.

Previously the different elements within the toolbar were applying their
own padding, which led to inconsistencies.

Release Notes:

- N/A

Marshall Bowers created

407478d Add missing collab panel features (#3719)

Click to expand commit body
* channel modal
* channel invites in collab panel

Max Brunsfeld created

a9b1273 Clean up commented code

Click to expand commit body
Co-authored-by: Nathan <nathan@zed.dev>

Max Brunsfeld and Nathan created

1c3698a Implement channel modal

Click to expand commit body
Co-authored-by: Nathan <nathan@zed.dev>

Max Brunsfeld and Nathan created

4e07167 Use `child` instead of `children` (#3718)

Click to expand commit body
This PR refactors some code where we were using `children` when we could
have used `child` instead.

Release Notes:

- N/A

Marshall Bowers created

80b6922 wip

Max Brunsfeld created

a4bfd01 Render channel invites in collab panel, fix unused warnings

Max Brunsfeld created

a3bab25 Style contact finder (#3717)

Click to expand commit body
This PR styles the contact finder.

<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217">

Release Notes:

- N/A

Marshall Bowers created

ef39382 Allow editor mouse drag selection outside interactive bounds (#3716)

Click to expand commit body
Release Notes:

- N/A

Julia created

961f989 Match zed1 scrollbar drag behavior (#3715)

Click to expand commit body
Still not ideal, but we need to ship and this is more than reasonable

Release Notes:

- N/A

Julia created

e08fc0b Allow editor mouse drag selection outside interactive bounds

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

5139634 Match zed1 scrollbar drag behavior

Click to expand commit body
Still not ideal, but we need to ship and this is more than reasonable

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

e778e17 Style assistant panel (#3711)

Click to expand commit body
[[PR Description]]

Styles most of the assistant panel. A few notes:

- We now cut off the title if it gets to long so the assistant tools
don't get cut off
- I wasn't able to get to the "no api key" state, so that hasn't been
style checked yet.
- A few of icons were updated in this PR

I also added a new tooltip that teaches you a bit about role cycling:

![CleanShot 2023-12-19 at 12 08
15@2x](https://github.com/zed-industries/zed/assets/1714999/89dcdcc0-9ef9-4527-94a2-6146b5f127f2)

🐜 Known issues 🐜

- There is a bug where zooming the panel makes it shift 1px (@maxdeviant
I think this has to do with panel borders)
- We are showing a timestamp for new conversations before you have sent
a message/launched an assist action. I wasn't sure how to case this out.

Before:

![CleanShot 2023-12-19 at 12 06
17@2x](https://github.com/zed-industries/zed/assets/1714999/16154add-a7f4-455a-a5c5-706847e012a2)

![CleanShot 2023-12-19 at 12 05
00@2x](https://github.com/zed-industries/zed/assets/1714999/a6d325ec-59c2-41b3-ad82-6cf88f2f70a0)

After:

![CleanShot 2023-12-19 at 12 05
37@2x](https://github.com/zed-industries/zed/assets/1714999/aaa4668e-b361-411a-8865-1989bd1c3ae1)

![CleanShot 2023-12-19 at 12 05
52@2x](https://github.com/zed-industries/zed/assets/1714999/0c6a9970-56ab-43cc-9394-fd3f6bf0ed6a)


Release Notes:

- N/A

Nate Butler created

616ea13 Style buffer search input (#3713)

Click to expand commit body
This PR styles the text input for the buffer search.

Release Notes:

- N/A

Marshall Bowers created

b797cd3 Fix panel resize (#3707)

Click to expand commit body
* [x] Reposition right dock handle
* [x] Handle mouse events correctly for drag and drop
* [x] Prevent drag events from passing through the resize handle to the
draggable items in the panels (channels, files)
* [x] Stop the editor gutter from stealing mouse move events

Max Brunsfeld created

5d95e13 Update assistant editor

Nate Butler created

e655d24 Don't stop propagation on mouse move over editor gutter

Max Brunsfeld created

d8eea94 Update assistant panel message header, model switcher

Nate Butler created

a108518 use `to_string` to return the format distance string from FormatDistance

Nate Butler created

cf037ea Merge branch 'main' into fix-panel-resize

Max Brunsfeld created

d8a8feb Add FormatDistance struct, add hide_prefix option

Nate Butler created

3e6b84a Wire up the middle mouse button to close tabs (#3714)

Click to expand commit body
This PR wires up the middle mouse button to close tabs.

Right now we're doing this using `on_mouse_down`, but we need a way in
GPUI2 to have an `on_click` for a mouse button other than the left one.

Release Notes:

- N/A

Marshall Bowers created

79653d2 Rename format distance test names

Nate Butler created

ae313ff Allow format_distance to take a DateTimeType

Nate Butler created

30b01b9 Update imports, tab height const

Nate Butler created

286f654 Update assistant header

Nate Butler created

cc107f7 Maintain scroll position in `CollabPanel` after updating entries (#3712)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

57efaa9 Style assistant header, update icons

Nate Butler created

dd84993 Maintain scroll position in CollabPanel after updating entries

Click to expand commit body
Co-Authored-By: Julia <julia@zed.dev>

Antonio Scandurra and Julia created