Commit log

c63e577 zed 0.119.2

Joseph T. Lyons created

26ed524 Merge branch 'main' into v0.119.x

Joseph T. Lyons created

1d09c9a Fix accidental load of default keymap *after* loading user keymap (#3901)

Max Brunsfeld created

c29a7f2 Fix terminal selection when cursor leaves terminal bounds (#3898)

Click to expand commit body
Previously, terminal mouse selection didn't work when the cursor moved
outside the bounds of the terminal, which made it difficult to select
large amounts of text in the terminal.

Max Brunsfeld created

ad20bc3 Fix accidental load of default keymap *after* loading user keymap

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Mikayla , and Marshall created

783256c Move Registrar implementation for Workspace to outer scope.

Click to expand commit body
This fixes various actions like "Activate regex mode" that were dispatched onto main pane instead of assistant search bar.

Piotr Osiewicz created

b6655de Add DivRegistrar to reduce code duplication

Piotr Osiewicz created

9cdcdbe Use Registrar in Assistant Panel.

Click to expand commit body
This fixes various actions like "Activate regex mode" that were dispatched onto main pane instead of assistant search bar.

Piotr Osiewicz created

5ad125a Touchups to registrar API

Piotr Osiewicz created

f70eddc Explore registrar-based API for search bar.

Click to expand commit body
This commit adds a Registrar trait for use by search crate. Registrar can register actions on some target and search can utilize that trait to opaquely add actions on that target.
Notably, search is now opt-in (it always was in zed2 actually). Having editor doesn't make it searchable straight out of the gate. You might have to call BufferSearchBar::new a bunch more.

Piotr Osiewicz created

cd0b15e fixup! terminal/search: Partially fix search in terminal. There are two issues with search in terminal as is: - terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that workspace::active_pane will *never* return terminal pane as active. - We've had the implementation of as_searchable commented out. Duh!

Piotr Osiewicz created

b3d8b23 terminal/search: Partially fix search in terminal.

Click to expand commit body
There are two issues with search in terminal as is:
- terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that
  workspace::active_pane will *never* return terminal pane as active.
- We've had the implementation of as_searchable commented out. Duh!

This commit fixes second issue. That means that if you drag the terminal over to the main editor pane (so that it's in a "legit" pane), it'll work. 1st issue still stands though.

Piotr Osiewicz created

3f06a05 Iterate on collab panel filter input style (#3900)

Click to expand commit body
This PR takes another pass at the collab panel filter input to improve
its styling.

Release Notes:

- Improved the look of the filter input in the collab panel.

Marshall Bowers created

ba13540 Fix inconsistent selection start when dragging outside of terminal bounds

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created

61db60b Fix incorrect placement of terminal selection when dragging

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created

269b665 Remove outdated TODO

Joseph T. Lyons created

a8efb41 Remove outdated TODOs

Joseph T. Lyons created

47476fa Fix label color for inactive tabs (#3899)

Click to expand commit body
This PR fixes an issue where certain tabs were not using the correct
color for their labels when they were inactive.

Release Notes:

- Fixed an issue where some inactive tabs were not using the correct
label color.

Marshall Bowers created

32cd4d7 Render an empty placeholder when not showing file icons in the project panel (#3897)

Click to expand commit body
This PR makes it so when we're not showing file icons in the project
panel we render an empty placeholder instead of nothing.

This prevents the indentation of the items in the file tree from
changing based on the presence of the icon.

Release Notes:

- Fixed layout shift when `project_panel.file_icons` is set to `false`.

Marshall Bowers created

0c4e2ef Fix terminal selection when cursor leaves terminal bounds

Max Brunsfeld created

88f0dc7 zed 0.119.1

Joseph T. Lyons created

47f24f9 Merge branch 'main' into v0.119.x

Joseph T. Lyons created

5e3d488 Fix some bugs in keymap handling (#3895)

Click to expand commit body
- `base_keymap` setting was not respected, now it is
- without a `~/.config/zed/keymap.json` file, we would fail to load the
*default* keymap

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

2da314f Fix font resolution for UI text so we render with the fallback font (#3893)

Click to expand commit body
This PR updates the font resolution for shaped text to use the new
`resolve_font` method on the text system.

This makes it so we use the fallback font if the desired font cannot be
found rather than rendering nothing.

Release Notes:

- Fixed an issue where nothing would render when the font set in
`ui_font_family` was not found.

Marshall Bowers created

e4aa7ba Try to load fallback fonts instead of panicking when a font is not found (#3891)

Click to expand commit body
This PR adjusts our font resolution code to attempt to use a fallback
font if the specified font cannot be found.

Right now our fallback font stack is `Zed Mono`, followed by `Helvetica`
(in practice we should always be able to resolve `Zed Mono` since we
bundle it with the app).

In the future we'll want to surface the ability to set the fallback font
stack from GPUI consumers, and potentially even support specifying font
stacks in the user settings (as opposed to a single font family).

Release Notes:

- Fixed a panic when trying to load a font that could not be found.

Marshall Bowers created

3d1023e lsp: Do not cache initialization options

Piotr Osiewicz created

6335117 Fix version comparison in auto update (#3889)

Max Brunsfeld created

c209712 Fix version comparison in auto update (#3889)

Max Brunsfeld created

90fc1eb Fix version comparison in auto update

Click to expand commit body
Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Max Brunsfeld and Antonio Scandurra created

4e1b987 Implement "open in terminal" (#3888)

Conrad Irwin created

8d07246 Prevent scrolling editor and resizing panels at the same time (#3887)

Click to expand commit body
Release Notes:

- Fixed a bug that would cause Zed to never stop resizing panels when
the drag handle overlapped with an editor scrollbar.

Antonio Scandurra created

4e310b9 Implement "open in terminal"

Conrad Irwin created

dd89ecf Show pointer hand on tab & give last tab border right (#3865)

Click to expand commit body
Release Notes:

- N/A

Julia created

6f4a08b Prevent scrolling editor and resizing panels at the same time

Click to expand commit body
This fixes a bug that would cause Zed to never stop resizing
panels when the drag handle overlapped with an editor scrollbar.

Co-Authored-By: Marshall <marshall@zed.dev>

Antonio Scandurra and Marshall created

a7550de Show pointer hand on tab & give last tab border right

Julia created

e8d01f4 Merge remote-tracking branch 'origin/main' into v0.119.x

Antonio Scandurra created

7f62a17 Re-enable key bindings for `AssistantPanel` (#3885)

Click to expand commit body
Release Notes:

- Fixed a bug that caused `cmd-g` and `cmd-shift-g` to not work anymore
in the assistant panel.

Antonio Scandurra created

5a1509e Re-enable key bindings for `AssistantPanel`

Antonio Scandurra created

f141495 Fix border rendering (#3884)

Click to expand commit body
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of the
same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.

This commit uses Porter-Duff compositing (i.e., `over`) to produce a
color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.

Release Notes:

- Fixed incorrect rendering of borders.

Antonio Scandurra created

3ab2062 Fix border rendering

Click to expand commit body
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of
the same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.

This commit uses Porter-Duff compositing (i.e., `over`) to produce
a color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.

Antonio Scandurra created

e5156d1 Clip `List` items that partially overflow (#3882)

Click to expand commit body
Release Notes:

- Fixed a visual bug that caused channels to overlap with the filter
input.

Antonio Scandurra created

b78497b Clip List items that partially overflow

Antonio Scandurra created

8ad7418 Fix quitting Zed when project was unshared (#3881)

Click to expand commit body
Release Notes:

- Fixed a bug that would disable `cmd-q` after a remote project was
unshared.

Antonio Scandurra created

f6af7ab Fix quitting Zed when project was unshared

Antonio Scandurra created

f4290c9 Show scrollbar even when buffer search highlights are outside viewport (#3880)

Click to expand commit body
Release Notes:

- Fixed a bug that prevented scrollbars from being shown when search
matches were outside the viewport.

Antonio Scandurra created

f0afa3f Show scrollbar even when buffer search highlights are outside viewport

Antonio Scandurra created

5a43cba channels: Move name of the channel to the same line as the hash icon.

Piotr Osiewicz created

1d98132 Move telemetry settings check into telemetry module (#3877)

Click to expand commit body
This is a small change I've been meaning to do to make it easier to call
the telemetry report event methods.

Release Notes:

- N/A

Joseph T. Lyons created

2972ee8 Move telemetry settings check into telemetry module

Joseph T. Lyons created

c76fcb3 UI grab bag (#3875)

Click to expand commit body
- Tidy up some ui crate docs
- Update "checking" diagnostic color + add icon
- Make scrollbar track transparent in all themes
- Update border variant color in all themes
- Use theme colors for muted/speaking indicators

Release Notes:

- N/A

Nate Butler created