Commit log

933fb87 Fix editor selection issue (#4110)

Click to expand commit body
Release Notes:

- Fixes a bug where, editor selections would update in the wrong pane
when split.

Mikayla Maki created

aa73510 Add typo detection to CI (#4107)

Click to expand commit body
Adding the typos crate to our CI will take some doing, as we have
several tests which rely on typos in various ways (e.g. checking state
as the user types), but I thought I'd take a first stab at fixing what
it finds.

Release Notes:

- N/A

Mikayla Maki created

58333b9 Adjust config

Mikayla created

6ea23d0 Fix canary

Mikayla created

4070eef Use cargo to install typo check

Mikayla created

edb2045 Fix selection bug in editor causing selections to be un-ended

Mikayla created

9521f49 Clean up references in doc comments in `lsp` crate (#4109)

Click to expand commit body
This PR cleans up a handful of references in doc comments in the `lsp`
crate so that `rustdoc` will link and display them correctly.

Release Notes:

- N/A

Marshall Bowers created

9a3709d Revert vscode theme changes

Mikayla created

ec2b299 settings: Suggest fonts bundled in Zed (#4102)

Click to expand commit body
Fixes an issue where Zed Sans is not being suggested as a font.

Release Notes:
- N/A

Piotr Osiewicz created

078fd35 WIP

Mikayla created

17018fa Update typos.toml

Mikayla Maki created

6cbc49e Editor docs (#4097)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Kirill <kirill@zed.dev>

Piotr Osiewicz and Kirill created

e3e3ef5 Add typos ci

Mikayla created

e42a9ac Add typos configuration for zed and add a few more typo fixes

Mikayla created

647b08b Update local development workflow to not involve zed.dev (#4103)

Click to expand commit body
When testing Zed locally, it's rarely necessary to log in the real with,
via Zed.dev and GitHub. We usually use `zed-local`. Since zed.dev is not
going to be open source (at least right away), this PR removes it from
our local development workflow.

* Remove zed.dev from the Procfile
* Change the `seed` script to not create an admin user for your
signed-in github user
* Instead have both `zed-local` and the `seed` script read from an
`.admins.json` file, which the user can create in order to customize who
they sign in as when running `zed-local`.
* Update all of the docs for building and developing zed.

Max Brunsfeld created

e6ca92f Fix a few more typos

Mikayla created

285f4d1 Fix busted test

Mikayla created

9a7d2e3 fmt

Mikayla created

0711476 Merge branch 'main' into fix-typos

Mikayla Maki created

75f8748 Document party 2 (#4106)

Click to expand commit body
@mikayla-maki and @nathansobo's contributions

Release Notes:

- N/A

Mikayla Maki created

57400e9 Fix typos detected by crate-ci/typos

Mikayla created

6f40da7 Fix scrolling in collab panel (#4105)

Click to expand commit body
When the `List` element's state is `ListState::reset()`, it eagerly
trashes it's cached element heights in anticipation of a prompt render.
But, due to the recent `display_layer` changes, that re-render is not
always forthcoming. This is a problem for `ListState::scroll()`, which
depends on these cached elements to correctly calculate the new logical
scroll offset.

Solutions we attempted:

- Cache the element heights and continue the scroll calculation 
- This was conceptually incorrect, reset should only be called when the
underlying data has been changed, making any calculation with the old
results meaningless.
- Lazily re-compute the element heights in scroll 
- Beyond being a non-trivial refactor, this would probably also cause us
to double-render the list in a single frame, which is bad.
- Cache the scroll offset and only calculate it in paint 
- This solution felt awkward to implement and meant we can't supply
synchronous list scroll events.
- Delay resetting until paint 
- This means that all of the other APIs that `ListState` supplies would
give temporarily incorrect results, worsening the problem

Given these issues, we settled on the solution with the least
compromises: drop scroll events if the state has been `reset()` between
`paint()` and `scroll()`. This shifts the responsibility for the problem
out of the List element and into consumers of `List`, if you want
perfectly smooth scrolling then you need to use `reset()` judiciously
and prefer `splice()`.

That said, I tested this by aggressively scrolling the Collab panel, and
it seems to work as well as it did before.

This PR also includes some initial testing infrastructure for working
with input from the platform and rendered elements.

Release Notes:

- N/A

Mikayla Maki created

9a22327 Add migration information to release docs and fix scripts (#4026)

Click to expand commit body
Release Notes:

- N/A

Mikayla Maki created

9eecda2 Update method name and partially document platform crate

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

7a299e9 Document view crate

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

d67e461 document app module in gpui 🎉

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>

Mikayla and Nathan created

8f3d79c Fix file paths in stories (#4104)

Click to expand commit body
This PR fixes some file paths used in our stories that were still
referencing the `ui2` crate.

Release Notes:

- N/A

Marshall Bowers created

6db18e8 Drop scroll events if there's been a reset

Click to expand commit body
co-authored-by: Nathan <nathan@zed.dev>
co-authored-by: Conrad <conrad@zed.dev>

Mikayla , Nathan , and Conrad created

ad2b4f2 Update procfile and local development docs, zed.dev is no longer needed

Max Brunsfeld created

9367f71 Rework db-seeding, so that it doesn't depend on a github auth token

Click to expand commit body
Instead, admins are specified using a JSON file, 'admins.json'. This file is
gitignored. If it is not present, there is a default list of admins in
'admins.default.json'.

Max Brunsfeld created

b2afa73 Decrease the size of timestamps in the assistant conversation editor (#4101)

Click to expand commit body
This PR decreases the size of the timestamps in the assistant's
conversation editor.

Ideally we'd want to align the baseline of the timestamp text with the
text in the sender button. I spent a while trying to do this, but it
seems like it may be pretty tricky.

Release Notes:

- Decreased the size of timestamps in the assistant panel conversation
editor.

Marshall Bowers created

d2eab5c Properly register workspace handlers for search elements (#4100)

Kirill Bulatov created

1e67577 Ignore buffer search events if it's not for the current buffer

Kirill Bulatov created

65be909 Implement similar workspace registration flow for project search actions

Kirill Bulatov created

0be2f7f Properly register buffer_search'es actions handlers

Click to expand commit body
Now those handlers do not intercept events/actions when the buffer search bar is dismissed.

co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

306e469 Start adding project search listeners to workspace

Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>

To be able to trigger them from search multibuffer excerpts.

Kirill Bulatov created

bcf3476 zed 0.119.11

Joseph T. Lyons created

937c701 Merge branch 'main' into v0.119.x

Joseph T. Lyons created

c6c56c3 Downgrade LiveKit client (#4096)

Click to expand commit body
There's a deadlock that we're seeing when joining a room, which we think
is a bug in the LiveKit client.

Also, we're still getting crashes when leaving calls:
https://github.com/livekit/client-sdk-swift/issues/299.

At this point, we believe both problems are due to recent changes to the
LiveKit swift sdk.

Max Brunsfeld created

15a21f5 Also update chat location when opening a new workspace (#4099)

Click to expand commit body
This happens a lot in guest workflows where they open the call with a
link and are jumped straight to a shared workspace.

Release Notes:

- Fixed opening the chat automatically in new windows

Conrad Irwin created

e1194e0 Document LSP crate (#4098)

Click to expand commit body
Release Notes:

- N/A

Julia created

552d2c2 Also update chat location when opening a new workspace

Click to expand commit body
This happens a lot in guest workflows where they open the call with a
link and are jumped straight to a shared workspace.

Conrad Irwin created

d7503a7 Document LSP crate

Click to expand commit body
Co-Authored-By: Thorsten Ball <thorsten@zed.dev>

Julia and Thorsten Ball created

cf5dc09 Add more documentation to `collab` (#4095)

Click to expand commit body
This PR adds more documentation to the `collab` crate.

Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>

Marshall Bowers and Conrad created

6734e52 Revert "Bump livekit client"

Click to expand commit body
This reverts commit 5730d0ef2107f2a10fe01595ce34f14f97e289ad.

Max Brunsfeld created

4e4a1e0 Document the public interface of the `vim` crate (#4093)

Click to expand commit body
This PR documents the public interface of the `vim` crate.

Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>

Marshall Bowers and Conrad created

ed67363 Update README.md

Click to expand commit body
FIx typos

Nate Butler created

c4ba5ef Update Readme & building Zed doc (#4094)

Click to expand commit body
This PR cleans out the README.md, moves most relevant build details to
`docs/src/developing_zed__building_zed.md`.

It also restructures and cleans up the Building Zed doc.

There are a number of outstanding TODOs to have this doc be ready for
external folks to be able to build Zed.

Release Notes:

- N/A

Nate Butler created

d0f22df Reorganize building zed doc

Click to expand commit body
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com>

Nate Butler and Joseph T. Lyons created

29df128 Add CONTRIBUTING.md (#3656)

Click to expand commit body
Written by @iamnbutler 

This PR adds a basic CONTRIBUTING.md. It has a few links that need to be
added, which we marked as coming soon.

Here are a number of follow up tasks we need to do:

- [ ] Add CLA link
- [ ] Add public roadmap link
- [ ] Add link to channels doc once it is up
- [ ] Add link explaining how to find a channel related to your
contribution or or to create one

Release Notes:

- N/A

Nate Butler created