This PR fixes the names of the Rosé Pine themes.
We want to keep the Unicode "é" in the theme name, both because this is
the actual name of the theme, and also to maintain parity with Zed1.
Release Notes:
- N/A
Marshall Bowers
created
94e22ae
Fix typo in "Noctis Hibernus" theme name (#3770)
Click to expand commit body
This PR fixes a typo in the name of the "Noctis Hibernus" theme.
Release Notes:
- N/A
Marshall Bowers
created
4fb12cb
Add vertical padding to the picker entry list (#3769)
Click to expand commit body
This PR adds vertical padding to the list of picker entries.
This prevents us from ending up with entries squished against the edges
of the picker.
Release Notes:
- N/A
Marshall Bowers
created
5307b75
Add more left padding to title bar (#3768)
Click to expand commit body
This PR adds more left padding to the title bar to achieve the same
positioning of the title bar items that we have in Zed1.
Release Notes:
- N/A
Fixes:
- drag and drop into terminal element does not change its style
- drag and drop terminal tab into main pane then back panics
- can drop non-terminal items into the terminal pane
Release Notes:
- N/A
Julia
created
f3fda80
Prevent drag-dropping non-terminal item into terminal pane
This PR scales down the sizes of items in the status bar.
This brings us more in line with Zed1.
Release Notes:
- N/A
Marshall Bowers
created
e2c3663
Align `Picker` editor with entries (#3765)
Click to expand commit body
This PR re-aligns the `Picker` editor with the entries after the changes
in #3764.
Release Notes:
- N/A
Marshall Bowers
created
be08a0b
Increase spacing of `ListItem`s inside `Picker`s (#3764)
Click to expand commit body
This PR increases the spacing of `ListItem`s inside of `Picker`s to give
the UI some more breathing room.
#### Before
<img width="584" alt="Screenshot 2023-12-21 at 4 36 21 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ed324c0d-e606-4844-b30a-7d5b8b8c9e47">
#### After
<img width="592" alt="Screenshot 2023-12-21 at 4 36 31 PM"
src="https://github.com/zed-industries/zed/assets/1486634/fbbcb230-0048-4310-8e06-07943af6a38e">
Release Notes:
- N/A
Marshall Bowers
created
71a222a
Use sparse spacing for `ListItem`s in `Picker`s
Marshall Bowers
created
dc09dbc
Use a `ListItem` as the empty state for `Picker`s
Marshall Bowers
created
a773a3c
Increase horizontal padding for inset `ListItem`s
Marshall Bowers
created
dabc986
Use small labels for title bar buttons (#3763)
Click to expand commit body
This PR adjusts the sizing of the labels in the buttons in the title bar
to use the small label size.
This should bring them more in line with how things looked in Zed1.
Release Notes:
- N/A
Marshall Bowers
created
a1fe514
Revert "Optimize order rendering and border drawing" (#3761)
Click to expand commit body
Reverts zed-industries/zed#3759
It seems like this is not quite right yet. Reverting until we figure out
what's wrong.
Antonio Scandurra
created
7cfea09
Revert "Optimize order rendering and border drawing"
Antonio Scandurra
created
9efe5a3
Fix pane drag target not appearing over terminal element
Julia
created
31e47f9
Prevent panic dragging tab into terminal panel
f83d156
Fix clicking on "+" button not working when a tab was underneath (#3755)
Click to expand commit body
We were mistakenly pushing an opaque layer without intersecting it with
the content mask. Also, we were pushing two opaque layers for the same
div unnecessarily.
Release Notes:
- N/A
Antonio Scandurra
created
b0ee7b2
Fix clicking on "+" button not working when a tab was underneath
Click to expand commit body
We were mistakenly pushing an opaque layer without intersecting it
with the content mask. Also, we were pushing two opaque layers for
the same div unnecessarily.
e4904e0
Fix `WindowContext::available_actions` missing some actions (#3752)
Click to expand commit body
This pull request also allows turning an `ArenaBox` into an `ArenaRef`
when non-mutable access is required, which makes `ArenaRef: Clone`. This
fixes a bug that prevented the command palette from reading all the
available actions while the `command_palette::Toggle` action was being
dispatched.
Release Notes:
- N/A
73682da
Provide mut access to allocated arena struct via non-cloneable ArenaBox
Click to expand commit body
This commit also allows turning an `ArenaBox` into an `ArenaRef` when
non-mutable access is required, which makes `ArenaRef: Clone`. This fixes
a bug that prevented the command palette from reading all the available
actions while the `command_palette::Toggle` action was being dispatched.
Antonio Scandurra
created
ca091f3
Fix layout issues with feedback modal (#3751)
e5ce5e8
Clear pending keystrokes when an action is dispatched (#3750)
Click to expand commit body
This prevents the `cmd-k` keystroke, which clears the terminal, from
staying around as a pending keystroke on the parent workspace.
Release Notes:
- N/A
Nathan Sobo
created
4680aad
Correctly compute placeholder text for buffer search query editor (#3749)
Click to expand commit body
Rather than relying on the focused element, instead explicitly pass the
focus handle for the query editor when determining the prev/next
bindings. Only compute these values once.
Release Notes:
- N/A
Nathan Sobo
created
5747c9b
Clear pending keystrokes when an action is dispatched
4f6bef5
Improve interaction between clicking and dragging (#3737)
Click to expand commit body
Once a drag starts, we won't fire click listeners or style any elements
as active.
- Don't fire click listeners or show active state once a drag is in
progress
- Don't show hover style when a drag is in progress
- Draw borders above content
- If borders are opaque, apply them to the content mask. This prevents
hovers from firing on content underneath the border, which was creating
issues where the drag handle was inside the border, so we'd flicker the
hover when the mouse moved out of the drag handle and into the 1px
border on the left dock.
- Add a `block_mouse` helper which causes transparent elements to paint
an "opaque" layer to prevent mouse events from falling through. We use
this for the drag handle as well to disable hover, click, etc on items
in the panel.
Release Notes:
- N/A
Nathan Sobo
created
afbc655
Ensure that views' `on_release` callbacks are always called (#3747)
Click to expand commit body
* Ensure that views' on_release callbacks are always called (even if
their window is gone), by passing them a `AppContext`, not a
`WindowContext`.
* Fix leaked handles to `CollabPanel`, `NotificationPanel`, and
`ChatPanel` caused by captures in a `ListState` render callback.
This fixes two issues we were seeing with following:
* inability to rejoin a remote project after you closed it
* following not working if a window had previously been closed
Max Brunsfeld
created
87a1387
For file finder queries, match in all gitignored worktree entries (#3748)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2347
Part of https://github.com/zed-industries/community/issues/1538
Now file finder will match all gitignored worktree entries.
Zed does not traverse gitignored dirs by default, which means that not
all gitignored files will be matches, but all that were toggled in
project panel and all root non-directory gitignored entries will be now
used, hopefully causing less questions.
Release Notes:
- Improved file finder to match all gitignored files that were added
into worktrees (e.g. due to opening gitignored directories in project
panel)
Kirill Bulatov
created
24970c1
Fix view handle leaks in ListState callbacks