669293e
Screenshare item background is now of editor background's color
Kirill Bulatov created
669293e
Screenshare item background is now of editor background's color
Kirill Bulatov created
e549ef0
Restore tooltipts for all collab buttons
Kirill Bulatov created
a7901ab
following tests (#3902)
Starting work on the following tests. * The first failure was caused by not properly dropping the references, which is now fixed. * The next failure is caused by a `cx.after_window_update` being changed to `cx.on_next_frame`. This doesn't seem to work (at least in tests), but might also explain the flaky following behavior Max and I observed if there's a timing bug in production too. * * When you are following someone and they move their cursor you should receive two proto messages: UpdateBuffer to move the cursor, and UpdateFollowers to update where you're following. It seems like this could be made a bit less chatty/fragile, but probably out of scope for this. * With that worked around, there's one more failure, but I haven't looked into it yet. (possibly caused by an incorrect fix for the cx one).
Max Brunsfeld created
385cbfe
Tidy up context usage
Co-Authored-By: Max <max@zed.dev>
Conrad Irwin and Max created
709682e
Tidy up TestContext lifecycle
Co-Authored-By: Max <max@zed.dev>
Conrad Irwin and Max created
c7568a7
All the following tests
Co-Authored-By: Max <max@zed.dev>
Conrad Irwin and Max created
204ef45
Merge branch 'main' into following-tests
Conrad Irwin created
f239a82
More following tests
Conrad Irwin created
81d707a
Port 1.00 following tests
Co-Authored-By: Max <max@zed.dev>
Conrad Irwin and Max created
f5c2e15
Restore the ability to disable key bindings by setting them to `null` in your keymap (#3921)
* Fix an incorrect use of `Any::type_id` that prevented the disabling of key bindings * Restructured the representation of disabled key bindings so that they handle context predicates correctly. Previously, to disable key binding, you needed to supply the exact same context predicate (e.g. `Editor && mode == "full"`) as the binding that you are trying to disable. Now, the context predicates of disabled key bindings are evaluated just like any other context predicate (with the current context) to see if they apply. Release Notes: - Fixed an issue where disabling key bindings didn't work. To disable a key binding, set it to `null` in your keymap.
Max Brunsfeld created
7e810d7
Restore the ability to disable key bindings by setting them to `null` in your keymap (#3921)
* Fix an incorrect use of `Any::type_id` that prevented the disabling of key bindings * Restructured the representation of disabled key bindings so that they handle context predicates correctly. Previously, to disable key binding, you needed to supply the exact same context predicate (e.g. `Editor && mode == "full"`) as the binding that you are trying to disable. Now, the context predicates of disabled key bindings are evaluated just like any other context predicate (with the current context) to see if they apply. Release Notes: - Fixed an issue where disabling key bindings didn't work. To disable a key binding, set it to `null` in your keymap.
Max Brunsfeld created
1e4e2af
zed 0.119.3
Joseph T. Lyons created
0f8c58f
Merge branch 'main' into v0.119.x
Joseph T. Lyons created
be98ff4
Iterate on design of channel management modal (#3923)
This PR refines the design of the channel management modal: #### Before <img width="585" alt="Screenshot 2024-01-05 at 4 17 32 PM" src="https://github.com/zed-industries/zed/assets/1486634/a6d96674-b688-4549-8fb8-0a7b2c7c88be"> #### After <img width="589" alt="Screenshot 2024-01-05 at 4 15 20 PM" src="https://github.com/zed-industries/zed/assets/1486634/31ae8dc1-a129-4a15-963e-9779b9b79bd9"> Release Notes: - Improved the look of the channel management modal.
Marshall Bowers created
8a96562
Handle contexts correctly for disabled key bindings
Max Brunsfeld created
6cb8b86
Tidy up styling of connection status in the title bar (#3922)
This PR tidies up the styling of the connection status indicators in the title bar. Removed some debug styles and tweaked the styling to match the rest of the title bar overall. Release Notes: - Improved the connection status indicators in the title bar.
Marshall Bowers created
573b749
Deploy tweaks (#3920)
Bugs from the 0.34.0 collab nightly deploy
Conrad Irwin created
0dfeae6
Deploy tweaks
Conrad Irwin created
ff82fb9
Gracefully prevent submitting feedback while in a shared project (#3919)
This PR fixes a panic that would occur when trying to submit feedback while within a shared project. There may be a way we want to support this in the future, but for now we just show a toast letting the user know this is not supported: <img width="415" alt="Screenshot 2024-01-05 at 2 46 02 PM" src="https://github.com/zed-industries/zed/assets/1486634/d3eff4d9-90ba-4257-9857-19b1bc933cf3"> Release Notes: - Fixed a panic when attempting to open the feedback modal while in a shared project.
Marshall Bowers created
fa40433
Remove old theme system (#3883)
This PR removes the old typescript-based theme system, and it's related functions. TODO: - [x] Create standalone repo of old theme system in case it is needed. - https://github.com/zed-industries/zed1-styletrees - [x] Remove `styles` - [x] Remove licenses generating code related to `styles` - [x] Remove docs related to old theme system - [x] Add license generation to new theme system (#3917) - [x] Check as best possible that all the places we were accessing `styles` are removed or updated. Note: For now, the JSON files in `assets/themes` will remain until we are finished with the Zed 1 theme importer. We should be able to remove those in the next few weeks. Release Notes: - N/A
Nate Butler created
79cccdb
Use regular text color for diagnostic popovers (#3918)
This PR updates the diagnostic popovers to use the regular editor text color rather than one specific to the diagnostic kind. Release Notes: - Updated text color in diagnostic popovers.
Marshall Bowers created
1e7e380
Merge branch 'main' into remove-old-theme
Marshall Bowers created
c7c874a
Decouple theme license generation from TypeScript theme definitions (#3917)
This PR decouples the generation of licenses for the themes we ship from the TypeScript theme definitions. For now, we are embedding the license information for the themes in the `theme_importer`, and emit a combined `LICENSES` file in the `theme` crate whenever we import themes. This is also where we check that each theme has a valid license. We then use this `LICENSES` file when building up the global license file for Zed. This decoupling is one step towards us being able to delete the old Zed1 styles. Release Notes: - N/A
Marshall Bowers created
254a52d
gpui: Remove dependency on sqlez (#3871)
This removes one of the path dependencies in gpui that's only really needed by `workspace` (which can work around lack of these implementations by itself). In theory it should also improve build scheduling (as gpui doesn't have to wait for main dependency of sqlez - libsqlite3 - to finish it's 25 seconds-long build in release), though in practice I didn't notice a substantial improvement. Moreover `sqlez` was unused by `settings` too, so that's removed as well. Release Notes: - N/A
Piotr Osiewicz created
15d8fed
collab 0.34.0
Conrad Irwin created
1a993ca
Read-only access for channel guests (#3841)
Conrad Irwin created
460b364
Disable Dangerous Downtime-causing Default (#3873)
According to https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates you can specify whether to disable automatic DNS record creation for the certificate upon the load balancer’s creation using the do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you specify true, we will not automatically create a DNS A record at the apex of your domain to support the SSL certificate.
Conrad Irwin created
94d0fe9
Fix current lsp logs menu item not shown as selected (#3916)
Release Notes: - Fixed current LSP logs menu item not shown as selected
Kirill Bulatov created
12b5dbf
Fix current lsp logs menu item not shown as selected
Kirill Bulatov created
c066480
Fix dock right click labels (#3626)
Release Notes: - N/A
Conrad Irwin created
4644d55
Upgrade `ctor` to v0.2.6 (#3915)
This PR upgrades our version of `ctor` to v0.2.6. We were previously using a fork that contained this fix: https://github.com/mmastrac/rust-ctor/pull/295. A new version of `ctor` has now been released with that change, so we can switch back to the mainline version. I scanned through the diff between versions (since we're upgrading from effectively v0.1.20) and didn't notice anything that seemed obviously breaking: https://github.com/mmastrac/rust-ctor/compare/564b87f1dc13cf061ef9997ee501fa5378f35ba1...ee6b4b1c7bd3c9c1edad3b6f4d906e767767ba3d Release Notes: - N/A
Marshall Bowers created
3c00528
Merge branch 'main' into channel-guests
Conrad Irwin created
7cc0068
Bump nu tree sitter dependency (#3914)
My contact over at nushell told me they are finally getting some fixes in on the tree sitter repo, as they have an enthusiastic user running around opening PRs - figured it would be good to bump this again, since it wasn't in a great place before. https://github.com/nushell/tree-sitter-nu/commits/main/ Release Notes: - Bumped `nu` tree sitter dependency
Joseph T. Lyons created
df0076a
Better TestWindow support (#3876)
Adding guest roles led us down a rabbit hole where we'd have liked to rely on a side-effect of activating a window in tests; but the test window didn't implement that. Looking into that, I realized our TestWindow wasn't doing a great job of emulating the MacWindow, so this makes the two more similar.
Conrad Irwin created
fa73cf3
Correct dock menu names
Conrad Irwin created
c57a556
Bump nu tree sitter dependency
Joseph T. Lyons created
06ab986
fmt
Conrad Irwin created
ea43d7a
Iterate on design of project search bar (#3913)
This PR iterates on the design of the project search bar: - Mode selections have been updated to use `ToggleButton`s - Spacing has been added between the various elements. Release Notes: - Improved the look of the project search bar.
Marshall Bowers created
5935979
Set a minimum size for the search input field (#3912)
Release Notes: - Show search input field wider for narrow panes
Kirill Bulatov created
319f18e
Use the `editor_background` color for the project search empty state (#3911)
This PR updates the project search empty state to use the same background color as the editor. Release Notes: - Updated the background color of the project search's empty state to match the editor background.
Marshall Bowers created
6cc48b9
Set a minimum size for the search input field
Kirill Bulatov created
0083ca3
Use the `editor_background` color for the welcome screen's background (#3910)
This PR updates the welcome screen to use the same background color as the editor. <img width="1136" alt="Screenshot 2024-01-05 at 11 28 19 AM" src="https://github.com/zed-industries/zed/assets/1486634/30f2bd7b-e25f-4851-9f43-eb187d1d62e6"> Release Notes: - Updated the background color of the welcome screen to match the editor background.
Marshall Bowers created
a205b2d
Update call controls & Add tinted buttons (#3886)
This PR introduces Tinted button styles and the `selected_style` field
on buttons to allow replicating the previous design of titlebar call
controls. It also updates the styles of the titlebar controls.
### Creating a tinted button:
```
Button::new("accept-cta", "Accept")
.style(ButtonStyle::Tinted(TintColor::Accent))
.on_click(...)
```
Ths button will always be tinted blue.
### Creating a button that becomes tinted when selected::
```rust
IconButton::new("screen-share", Icon::Screen)
.style(ButtonStyle::Subtle)
.selected(is_screen_sharing)
.selected_style(ButtonStyle::Tinted(TintColor::Accent))
.on_click(...),
```
This button will be flat/subtle by default, but be tinted blue when it
is `selected`.
Note: There appears to be some issue where `is_deafened` isn't
activating correctly, making the speaker icon not toggle when selected.
Release Notes:
- Restore call control styles to a similar look to Zed 1.
Nate Butler created
6c43509
Update titlebar call status icons
Nate Butler created
9d4d58a
Implement Tinted buttons and selected_style for buttons
Nate Butler created
c8dcc80
Respect the setting to show/hide the assistant and chat panels (#3909)
This PR makes it so we respect the setting to show/hide the assistant and chat panels. Resolves https://github.com/zed-industries/community/issues/2370. Release Notes: - Fixed an issue where the settings to show/hide certain panels were not respected.
Marshall Bowers created
bf11a04
Remove extra dbg!'s
Kirill Bulatov created
eceed71
Avoid leaking `TerminalPanel`, which would in turn leak `Project` (#3908)
Release Notes: - Fixed a leak that would prevent projects from being automatically unshared or left when closing the corresponding window.
Antonio Scandurra created
b853937
Avoid leaking `TerminalPanel`, which would in turn leak `Project`
Antonio Scandurra created
92d6a8c
Return back git status colors for tab labels (#3906)
Kirill Bulatov created