Commit log

4afa5fb Add stories for collab notifications (#3967)

Click to expand commit body
This PR adds some basic stories for collab notifications to make them
easier to work on:

<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c">

I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.

We can't use the actual notification components in the stories due to
their data dependencies.

Release Notes:

- N/A

Marshall Bowers created

27d4d72 Attempt to write test

Mikayla created

c40a7f3 Stop propagation when deploying the context menu for a project panel entry (#3965)

Click to expand commit body
This PR fixes an issue where right-click on any project panel entry
would cause the context menu on the root of the project panel
(introduced in #3954) to deploy.

We need to stop propagation in the handler on the inner project panel
list items so that the click event doesn't bubble up the tree.

Release Notes:

- Fixed an issue where the project panel was always deploying the root
context menu rather than on the clicked item.

Marshall Bowers created

6982b4b Fix off by 1 error when computing available key bindings (#3964)

Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2379

Release Notes:

- Fixed issue where keybindings in some context menus would not show
reliably.

Mikayla Maki created

0684369 Fix off by 1 error when computing available key bindings

Mikayla created

435b5ca Restore the terminal cursor settings (#3963)

Click to expand commit body
As it says on the tin

Release Notes:

- Restored the terminal cursor's I-beam and pointing hand settings

Mikayla Maki created

ec7db3f Restore the terminal cursor settings

Mikayla created

68e705d Restore the active pane magnification feature (#3961)

Click to expand commit body
As it says on the tin

Release Notes:

- Restored the active pane magnification setting.

Mikayla Maki created

ca0c06b Fix assets build (#3962)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

6f6fa5b Fix assets build

Conrad Irwin created

51caa74 Restore the active pane magnification feature

Mikayla created

4007b2f Tighten up feedback modal design (#3960)

Click to expand commit body
This PR tightens up the design of the feedback dialog:

<img width="680" alt="Screenshot 2024-01-08 at 6 20 50 PM"
src="https://github.com/zed-industries/zed/assets/1486634/8dc0e687-2459-4ab3-b69f-b610ce067ef1">

<img width="682" alt="Screenshot 2024-01-08 at 6 21 24 PM"
src="https://github.com/zed-industries/zed/assets/1486634/f0730710-16e0-4d61-a919-60874442186a">

Release Notes:

- Improved the design of the feedback dialog.

Marshall Bowers created

32cd956 Push branch before tag

Conrad Irwin created

e876262 collab 0.35.0

Conrad Irwin created

fac8ebf Fix error border color for email input in feedback dialog (#3959)

Click to expand commit body
This PR fixes the border color used when the email input in the feedback
dialog is invalid.

Previously this was hardcoded just to `red` instead of using the
appropriate color from the theme.

<img width="653" alt="Screenshot 2024-01-08 at 5 40 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ea01cd76-d661-4512-b668-c82b8d00d84e">

Release Notes:

- Fixed the border color used for the email input in the feedback dialog
when an invalid email is entered.

Marshall Bowers created

475d91a guest acls (#3958)

Click to expand commit body
- First pass of real access control
- Check user is host for host-broadcasted project messages
- Only allow read-write users to update buffers

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

59a1648 Disallow creating files with '..' (#3156)

Click to expand commit body
Release Notes:

- Fixed a crash that could occur when creating files with '..' in the
path

Conrad Irwin created

d7c5d29 Only allow read-write users to update buffers

Conrad Irwin created

71149bc Fix relative path opening from project symbols

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

ae6d09b chore: Extract `assets` module out of zed crate. (#3957)

Click to expand commit body
This essentially shaves off about 10% off of an incremental build after
project change and potentially more if you're changing stuff like
`welcome` that's very close to the `zed` crate in the dep graph. That's
because macro expansion takes place even in incremental builds it seems?
And zed (lib) + zed (bin) could take up to 4 seconds out of an
incremental build, which is a *lot* in a 10s build. In reality though it
shaves 1 second off of 5 seconds incremental 'welcome'/ 1s off of 10s
'project' builds.

Note that we had `assets` crate in the past (removed in #2575 /cc
@maxbrunsfeld), but this is a bit different, because `assets` is a
dependency of *just* zed and nothing else. We essentially cache macro
expansion results ourselves.

Release Notes:

- N/A

Piotr Osiewicz created

80f204f Style the chat panel message input (#3956)

Click to expand commit body
This PR styles the message input in the chat panel.

<img width="242" alt="Screenshot 2024-01-08 at 4 28 33 PM"
src="https://github.com/zed-industries/zed/assets/1486634/48e83692-878e-4891-8e40-8738cdeb23a8">

Release Notes:

- Improved the styling of the message editor in the chat panel.

Marshall Bowers created

c951b4c Fix prevention of cross-channel joins (#3949)

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

aed97f6 Use "test" consistently

Conrad Irwin created

667d901 Improve chat panel empty states (#3955)

Click to expand commit body
This PR improves the empty states for the chat panel:

- The signed-out state has been updated to match our other signed-out
panel states.
- A new state has been added to account for the case where a user is
signed in but doesn't have an active chat.

Release Notes:

- Improved the design of empty states in the chat panel.

Marshall Bowers created

ed76315 Fix prevention of cross-channel joins

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

604fcd8 No .. paths...

Conrad Irwin created

a2a0628 Show context menu on project panel empty space right click (#3954)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2383

Release Notes:

- Fixed context menu not shown when right clicking empty project panel
space

Kirill Bulatov created

35ce34c Show context menu on project panel empty space right click

Kirill Bulatov created

18b31f1 Check user is host for host-broadcasted project messages

Max Brunsfeld created

7235b3d Clean up outline selections when its modal gets closed (#3953)

Click to expand commit body
Release Notes:

- Fixed outline selections not being cleared on certain modal dismiss
actions

Kirill Bulatov created

2ca17bd Clean up outline selections when its modal gets closed

Kirill Bulatov created

dd73054 chore: Fix spurious rebuilds of Zed library and binary (#3952)

Click to expand commit body
Currently when one runs `cargo build` twice without changing anything,
zed lib and binary are gonna get rebuilt every time. I checked out cargo
logs and it turns out we were querying wrong path to `.git/logs/HEAD` in
our build.rs, causing it to rerun on every build and thus marking zed
lib as dirty.

See logs (`CARGO_LOG=cargo::core::compiler::fingerprint=trace cargo
build`):
```
0.501173792s  INFO cargo::core::compiler::fingerprint: fingerprint dirty for zed v0.120.0 (/Users/hiro/Projects/zed/crates/zed)/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/Users/hiro/Projects/zed/crates/zed/build.rs", Edition2021) }
0.501180417s  INFO cargo::core::compiler::fingerprint:     dirty: FsStatusOutdated(StaleItem(MissingFile("/Users/hiro/Projects/zed/crates/zed/.git/logs/HEAD")))
```
The path to .git directory is relative to crates/zed and not to the
workspace's root.

/cc @maxbrunsfeld 

Release Notes:
- N/A

Piotr Osiewicz created

8214a7f Fix inconsistent sizing between the buffer search and the project search (#3951)

Click to expand commit body
This PR fixes the inconsistent sizing between the buffer search and the
project search when both elements have both a primary and secondary item
shown in the toolbar.

Release Notes:

- Fixed some inconsistent sizing in the buffer search and project search
when both have two rows of tools in the toolbar.

Marshall Bowers created

a3bc482 First pass of real access control

Click to expand commit body
Co-Authored-By: Max<max@zed.dev>

Conrad Irwin and Max created

5c28c68 theme: Removed commented-out `ActiveTheme` impl (#3950)

Click to expand commit body
This PR removes a commented-out implementation for the `ActiveTheme`
trait on the `WindowContext`.

We don't need this implementation as we can go through the
`AppContext`'s implementation.

Release Notes:

- N/A

Marshall Bowers created

9b06c66 terminal: Remove resolved TODO (#3948)

Click to expand commit body
This PR removes a resolved TODO in the `terminal` crate.

Release Notes:

- N/A

Marshall Bowers created

00fc22a terminal: Clean up doc comment for `rgb_for_index` (#3947)

Click to expand commit body
This PR cleans up the doc comment for the `rgb_for_index` function.

Release Notes:

- N/A

Marshall Bowers created

1bf7afd Update Copilot UI (#3904)

Click to expand commit body
Updates Zed2 Copilot UI

- Introduces the `Headline` component for rendering large text
- Styles the 3 Copilot prompt states

![CleanShot 2024-01-08 at 13 19
09@2x](https://github.com/zed-industries/zed/assets/1714999/4b58b85f-23aa-4c22-9ca6-d0abd232cf18)
![CleanShot 2024-01-08 at 13 18
55@2x](https://github.com/zed-industries/zed/assets/1714999/0bf71e1d-63b5-4fbb-8672-e42f8602516d)


Release Notes:

- Updated the connect Copilot modal UI.

Nate Butler created

e4b1c76 Display setting documentation in settings.json (#3936)

Click to expand commit body
Let this screenshot of settings.json speak for itself: 

![image](https://github.com/zed-industries/zed/assets/24362066/fca60383-1788-43f9-803b-00f083394c8a)

Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Piotr Osiewicz and Marshall Bowers created

5e401e4 Fix layout shift when renaming a channel (#3946)

Click to expand commit body
This PR fixes the layout shift that would occur in the channel list when
opening a rename editor for a channel.

Release Notes:

- Fixed layout shift when opening a rename editor for a channel.

Marshall Bowers created

72de75d Adjust spacing of extra call participant count indicator (#3945)

Click to expand commit body
This PR adjusts the spacing of the indicator showing the number of extra
call participants that appears after the facepile:

<img width="242" alt="Screenshot 2024-01-08 at 1 09 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6d9cbefa-3b4e-4501-ab11-51026dfb5b6c">

Release Notes:

- Added more space between the call participant facepile and the number
indicating additional call participants.

Marshall Bowers created

b57a1f9 Update copilot ui

Nate Butler created

a8c193c Remove resolved TODO (#3943)

Click to expand commit body
This PR removes a resolved TODO in drawing diff hunk status.

Release Notes:

- N/A

Marshall Bowers created

4ebff57 Fix flaky open_paths_action test (#3944)

Click to expand commit body
I've missed a single run_until_parked call. mb

Release Notes:

- N/A

Piotr Osiewicz created

f56f50d zed 0.119.4

Joseph T. Lyons created

0f17fa8 Merge branch 'main' into v0.119.x

Joseph T. Lyons created

46a99fe Use correct color for folded diff indicator (#3942)

Click to expand commit body
This PR updates the indicator for changes within a fold to use the
correct color from the theme:

<img width="380" alt="Screenshot 2024-01-08 at 12 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/b8bf6bf3-6acc-43a4-8c4b-a02c975c7f02">

Release Notes:

- Updated the color of the indicator for a fold containing modified
lines.

Marshall Bowers created

2f6bbde Improve styling of tree branches in collab panel (#3941)

Click to expand commit body
This PR updates the styling of the tree branches in the current call
section of the collab panel:

- Fixed the gap between the notes and chat items.
- We now overdraw the tree branch on the notes item so it fills the gap.
- The tree branch lines are now thinner.

<img width="231" alt="Screenshot 2024-01-08 at 12 35 35 PM"
src="https://github.com/zed-industries/zed/assets/1486634/844c9e18-c2de-4163-9384-41d1577e23a0">

Note: I think the signature for `render_tree_branch` could use some
improvement. I don't like having the multiple `bool` parameters, but any
change I could think of was going to be a bit more invasive than I
wanted to take on in this PR.

Release Notes:

- Improved the style of the tree branches in current call details in the
collab panel.

Marshall Bowers created

fd2abb7 Adjust thickness of tree branches

Marshall Bowers created

d3c9626 Comment out test_open_paths_action pending investigation (#3939)

Click to expand commit body
Commenting this one out temporarily to not break CI for folks while I
look into it.
Release Notes:

- N/A

Piotr Osiewicz created