1d09c9a
Fix accidental load of default keymap *after* loading user keymap (#3901)
Max Brunsfeld
created
c29a7f2
Fix terminal selection when cursor leaves terminal bounds (#3898)
Click to expand commit body
Previously, terminal mouse selection didn't work when the cursor moved
outside the bounds of the terminal, which made it difficult to select
large amounts of text in the terminal.
Max Brunsfeld
created
ad20bc3
Fix accidental load of default keymap *after* loading user keymap
f70eddc
Explore registrar-based API for search bar.
Click to expand commit body
This commit adds a Registrar trait for use by search crate. Registrar can register actions on some target and search can utilize that trait to opaquely add actions on that target.
Notably, search is now opt-in (it always was in zed2 actually). Having editor doesn't make it searchable straight out of the gate. You might have to call BufferSearchBar::new a bunch more.
Piotr Osiewicz
created
cd0b15e
fixup! terminal/search: Partially fix search in terminal. There are two issues with search in terminal as is: - terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that workspace::active_pane will *never* return terminal pane as active. - We've had the implementation of as_searchable commented out. Duh!
Piotr Osiewicz
created
b3d8b23
terminal/search: Partially fix search in terminal.
Click to expand commit body
There are two issues with search in terminal as is:
- terminal's pane is not registered as a "legit" pane, so we dispatch buffer search bar::Deploy on the most recent "legit" pane. By legit I mean that
workspace::active_pane will *never* return terminal pane as active.
- We've had the implementation of as_searchable commented out. Duh!
This commit fixes second issue. That means that if you drag the terminal over to the main editor pane (so that it's in a "legit" pane), it'll work. 1st issue still stands though.
Piotr Osiewicz
created
3f06a05
Iterate on collab panel filter input style (#3900)
Click to expand commit body
This PR takes another pass at the collab panel filter input to improve
its styling.
Release Notes:
- Improved the look of the filter input in the collab panel.
Marshall Bowers
created
ba13540
Fix inconsistent selection start when dragging outside of terminal bounds
Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>
Max Brunsfeld
and
Mikayla
created
61db60b
Fix incorrect placement of terminal selection when dragging
This PR fixes an issue where certain tabs were not using the correct
color for their labels when they were inactive.
Release Notes:
- Fixed an issue where some inactive tabs were not using the correct
label color.
Marshall Bowers
created
32cd4d7
Render an empty placeholder when not showing file icons in the project panel (#3897)
Click to expand commit body
This PR makes it so when we're not showing file icons in the project
panel we render an empty placeholder instead of nothing.
This prevents the indentation of the items in the file tree from
changing based on the presence of the icon.
Release Notes:
- Fixed layout shift when `project_panel.file_icons` is set to `false`.
Marshall Bowers
created
0c4e2ef
Fix terminal selection when cursor leaves terminal bounds
- `base_keymap` setting was not respected, now it is
- without a `~/.config/zed/keymap.json` file, we would fail to load the
*default* keymap
Co-authored-by: Marshall <marshall@zed.dev>
bf8f3e3
Unbork test relying on old keystroke behavior
Click to expand commit body
Previously it would both send the keydown *and then* the action, now
it send the action, and then because there was an action, does not send
the keydown
Co-Authored-By: Conrad Irwin <conrad@zed.dev>
Julia
and
Conrad Irwin
created
2da314f
Fix font resolution for UI text so we render with the fallback font (#3893)
Click to expand commit body
This PR updates the font resolution for shaped text to use the new
`resolve_font` method on the text system.
This makes it so we use the fallback font if the desired font cannot be
found rather than rendering nothing.
Release Notes:
- Fixed an issue where nothing would render when the font set in
`ui_font_family` was not found.
4dbec66
Return back old project search behavior as default.
Click to expand commit body
Add a `workspace::DeploySearch` action and use it as a default for "cmd-shift-f" binding.
This action opens existing search tab if it exists, or creates a new one otherwise.
`workspace::NewSearch` action is still available and always opens an existing search tab.
Kirill Bulatov
created
e4aa7ba
Try to load fallback fonts instead of panicking when a font is not found (#3891)
Click to expand commit body
This PR adjusts our font resolution code to attempt to use a fallback
font if the specified font cannot be found.
Right now our fallback font stack is `Zed Mono`, followed by `Helvetica`
(in practice we should always be able to resolve `Zed Mono` since we
bundle it with the app).
In the future we'll want to surface the ability to set the fallback font
stack from GPUI consumers, and potentially even support specifying font
stacks in the user settings (as opposed to a single font family).
Release Notes:
- Fixed a panic when trying to load a font that could not be found.
Marshall Bowers
created
09b32e6
Attempt to run keystroke actions before attempting key listeners
dd89ecf
Show pointer hand on tab & give last tab border right (#3865)
Click to expand commit body
Release Notes:
- N/A
Julia
created
427e7f6
Read only permissions for project panel too
Conrad Irwin
created
6f4a08b
Prevent scrolling editor and resizing panels at the same time
Click to expand commit body
This fixes a bug that would cause Zed to never stop resizing
panels when the drag handle overlapped with an editor scrollbar.
Co-Authored-By: Marshall <marshall@zed.dev>
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of the
same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.
This commit uses Porter-Duff compositing (i.e., `over`) to produce a
color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.
Release Notes:
- Fixed incorrect rendering of borders.
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of
the same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.
This commit uses Porter-Duff compositing (i.e., `over`) to produce
a color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.