Commit log

062288d Search woes (#6698)

Click to expand commit body
Fixes #6441 
Release Notes:
- Fixed "SelectNextMatch", "SelectPrevMatch" and "SelectAllMatches"
actions not working when search bar is not visible.
- Fixed "SelectPrevMatch" not being bound in project search.

---------

Co-authored-by: Kirill <kirill@zed.dev>

Piotr Osiewicz and Kirill created

dd3ec15 Log error if worktree fails to relativize git repo path (#6693)

Click to expand commit body
This is a follow-up to #6459. It logs the error instead of silently
skipping it.

Release Notes:

- N/A

Thorsten Ball created

d17d37f Log error if worktree fails to relativize git repo path

Click to expand commit body
We saw a panic that was caused by the previous `Option.unwrap()`, so
this changes the method to return a `Result` and logs the error if
possible.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

710e479 Add Conrad and Thorsten to .mailmap file (#6691)

Click to expand commit body
Follow-up to #4138.

Release Notes:

- N/A

Thorsten Ball created

c6e7cf1 bugfix: fix LineEnding for windows (#6688)

Click to expand commit body
fixes a bug when compiling on windows


![image](https://github.com/zed-industries/zed/assets/715417/5a35b1b2-29f4-4987-9410-730c9b287f82)

Release Notes:

- Fixed: compilation error related to `LineEnding` on Windows

Thorsten Ball created

dcf0581 Add Conrad and Thorsten to .mailmap file

Thorsten Ball created

0c4679f bugfix: fix LineEnding for windows

Sharun created

dd07d2f Update cocoa to crates.io version (#6452)

Click to expand commit body
https://github.com/servo/core-foundation-rs/pull/457 was released in
cocoa 0.25, so this patch dependency on github can be removed.

Release Notes:

- N/A

gmorenz created

5c1de4c Try to flesh out our panic stacks more

Click to expand commit body
Although we now usually get the .ips file alongside a panic, when we
don't it's much harder to track down where panics happen because we're
not showing inlined frames.

Try iterating over all symbols in a frame to see if that improves panic
reporting.

Conrad Irwin created

1c2859d collab errors (#4152)

Click to expand commit body
One of the complaints of users on our first Hack call was that the error
messages you got when channel joining failed were not great.

This aims to fix that specific case, and lay the groundwork for future
improvements.

It adds two new methods to anyhow::Error

* `.error_code()` which returns a value from zed.proto (or
ErrorCode::Internal if the error has no specific tag)
* `.error_tag("key")` which returns the value of the tag (or None).

To construct errors with these fields set, you can use a builder API
based on the ErrorCode type:

* `Err(ErrorCode::Forbidden.anyhow())`
* `Err(ErrorCode::Forbidden.message("cannot join channel").into())` - to
add any context you want in the logs
* `Err(ErrorCode::WrongReleaseChannel.tag("required", "stable").into())`
- to add structured metadata to help the client handle the error better.


Release Notes:

- Improved error messaging when channel joining fails.

Conrad Irwin created

01424a6 Allow prompts to have detail, and use for good

Click to expand commit body
Make channel panel errors louder

Conrad Irwin created

5fcc75b gpui: Add hello world example (#6465)

Click to expand commit body
Added hello world example to the gpui crate copied from https://gpui.rs

Release Notes:

- N/A

Sean Aye created

cf3b2ba Fix panic from unwrapping a relativize() (#6459)

Click to expand commit body
Release Notes:

- Fixed a panic that could occur finding a git repository.

Conrad Irwin created

e77db87 Remove references to community repo (#6466)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

f9170cb Remove references to community repo

Joseph T. Lyons created

bf74892 Clean up docs (#6464)

Click to expand commit body
This PR cleans up some of the Zed meta docs.

Namely:
- Removed references to the `zed-industries/community` repository
- Removed old docs directory (it'll be in Git history if we need it)

Release Notes:

- N/A

Marshall Bowers created

ba97661 Fix backend dependencies link in local collaboration docs (#6461)

Click to expand commit body
Release Notes:

- N/A

Jeff Li created

320088f Fix panic from unwrapping a relativize()

Conrad Irwin created

df420c3 Better naming

Conrad Irwin created

4bcd349 Try to send typed errors back and forth

Click to expand commit body
TEMP

TEMP

First pass of structured errors

Improved error handling for channel joining failures

Conrad Irwin created

8653698 Fix circular locking in prompts (#6456)

Click to expand commit body
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks

Release Notes:

- Fixed a crash when opening the MacOS Save As dialogue.

Conrad Irwin created

a181dc8 Use the correct snapshot when calculating mouse positions (#6453)

Click to expand commit body
Release Notes:

- Fixed a panic in calculating remote cursor positions

Conrad Irwin created

249a6da Fix circular locking in prompts

Click to expand commit body
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks

Conrad Irwin created

f185aca Use the correct snapshot when calculating mouse positions

Conrad Irwin created

6ed7cc7 Simplify language server startup (#6449)

Click to expand commit body
These are just some small refactorings of our language-server-starting
code, motivated by another change that I decided to bail on:
https://github.com/zed-industries/zed/pull/6448.

Max Brunsfeld created

02ab160 Get basic syntax highlighting for Haskell working

Pseudomata created

90c1d8f Update `Cargo.lock` (#6445)

Click to expand commit body
This PR updates `Cargo.lock` to reflect the changes made in #6435.

Release Notes:

- N/A

Marshall Bowers created

416696a Fix typo in build instructions (#6444)

Click to expand commit body
Typo fix.

Release Notes:

- N/A

Dragan Okanovic created

1043779 Remove unused dependency (#6435)

Click to expand commit body
[[PR Description]]

The `color` crate is not actually used by the `zed` crate, despite being
listed as a dependency. This PR removes it.

Joseph T. Lyons created

569bb68 Prevent channel from vertically growing when containing facepile (#6439)

Click to expand commit body
Previously at UI font size of 20
 - User-less channel: 28 px tall
 - Occupied channel: 30 px tall
 
Now, still at UI font size 20:
 - User-less channel: 30 px tall
 - Occupied channel: 30 px tall

Release Notes:

- Fixed an issue where a channel would grow in height while showing
participant avatars.

Julia created

9bc968e Prevent channel from vertically growing when containing facepile

Julia created

4ac3095 chat mentions for newly joined users (#5099)

Click to expand commit body
Release Notes:

- Added chat mentions for everyone in the call

Conrad Irwin created

5907bb5 Remove unused dependency

Julian Braha created

28b2c89 Fix crash in feedback modal (#6431)

Click to expand commit body
After the general release we saw a number of crashes due to a SEGFAULT
inside the
System::new() method apparently relating to refreshing the user list.

As we do not need the user list, and the similar code in the telemtry
create is not crashing,
do less work for now.

Release Notes:

- Fixed a crash when opening the feedback modal

Conrad Irwin created

cf3b4b0 Fix: Comment shortcut in Svelte files now respects if the line(s) are HTML vs JS/TS (#5860)

Click to expand commit body
Release Notes:

- Fixed: When using the comment shortcut, previously HTML or JS/TS would
all prefix lines with `// `. This PR brings the comments inline with
what is expected (`// ` for JS/TS, `<!-- ... -->` for HTML). Fixes
[#4578](https://github.com/zed-industries/zed/issues/4578).

Chase Weaver created

71ec781 Fix RUSTSEC-2018-0017 (#5338)

Click to expand commit body
[[PR Description]]

This replaces the `tempdir` crate with `tempfile`, which resolves
[RUSTSEC-2018-0017](https://rustsec.org/advisories/RUSTSEC-2018-0017).

Mikayla Maki created

e1b7b5e Update all links pointing to community (#6434)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

40dbe15 Update all links point to community

Joseph T. Lyons created

6c555fe Fix typos (#6429)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

334dc62 Fix crash in feedback modal

Conrad Irwin created

1a11da9 Fix typos

Joseph T. Lyons created

fc01eee Update links to script

Joseph T. Lyons created

fde4c09 Remove open source checklist from issue config

Joseph T. Lyons created

482c01a Ensure chat opens when guests join shared projects (#6425)

Click to expand commit body
This was broken because the panel was created before being added to a
dock. Invert the control order and add `starts_open()` to the Panel
trait (which lets us simplify how this worked for the ProjectPanel too)

Release Notes:

- Improved Chat visibility when joining a call as a guest

Conrad Irwin created

db33eaf Delete 0_feature_parity_report.yml

Joseph T. Lyons created

855e0f6 Add top-ranking issues script

Joseph T. Lyons created

c56debc clippy

Conrad Irwin created

e7db5d0 Use run_until_parked instead of condition

Click to expand commit body
Avoids spurious failures when the CI server is going slow

Conrad Irwin created

a860ca6 Fix tests that were toggling the panel shut

Conrad Irwin created

4427e79 (probably) install rosetta if it's not there (#5817)

Click to expand commit body
We set up a new CI server recently, and this caused a build to fail

Release Notes:

- N/A

Conrad Irwin created