Fixes #6441
Release Notes:
- Fixed "SelectNextMatch", "SelectPrevMatch" and "SelectAllMatches"
actions not working when search bar is not visible.
- Fixed "SelectPrevMatch" not being bound in project search.
---------
Co-authored-by: Kirill <kirill@zed.dev>
Piotr Osiewicz
and
Kirill
created
dd3ec15
Log error if worktree fails to relativize git repo path (#6693)
Click to expand commit body
This is a follow-up to #6459. It logs the error instead of silently
skipping it.
Release Notes:
- N/A
Thorsten Ball
created
d17d37f
Log error if worktree fails to relativize git repo path
Click to expand commit body
We saw a panic that was caused by the previous `Option.unwrap()`, so
this changes the method to return a `Result` and logs the error if
possible.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
710e479
Add Conrad and Thorsten to .mailmap file (#6691)
Click to expand commit body
Follow-up to #4138.
Release Notes:
- N/A
Thorsten Ball
created
c6e7cf1
bugfix: fix LineEnding for windows (#6688)
Click to expand commit body
fixes a bug when compiling on windows

Release Notes:
- Fixed: compilation error related to `LineEnding` on Windows
https://github.com/servo/core-foundation-rs/pull/457 was released in
cocoa 0.25, so this patch dependency on github can be removed.
Release Notes:
- N/A
Although we now usually get the .ips file alongside a panic, when we
don't it's much harder to track down where panics happen because we're
not showing inlined frames.
Try iterating over all symbols in a frame to see if that improves panic
reporting.
One of the complaints of users on our first Hack call was that the error
messages you got when channel joining failed were not great.
This aims to fix that specific case, and lay the groundwork for future
improvements.
It adds two new methods to anyhow::Error
* `.error_code()` which returns a value from zed.proto (or
ErrorCode::Internal if the error has no specific tag)
* `.error_tag("key")` which returns the value of the tag (or None).
To construct errors with these fields set, you can use a builder API
based on the ErrorCode type:
* `Err(ErrorCode::Forbidden.anyhow())`
* `Err(ErrorCode::Forbidden.message("cannot join channel").into())` - to
add any context you want in the logs
* `Err(ErrorCode::WrongReleaseChannel.tag("required", "stable").into())`
- to add structured metadata to help the client handle the error better.
Release Notes:
- Improved error messaging when channel joining fails.
Conrad Irwin
created
01424a6
Allow prompts to have detail, and use for good
This PR cleans up some of the Zed meta docs.
Namely:
- Removed references to the `zed-industries/community` repository
- Removed old docs directory (it'll be in Git history if we need it)
Release Notes:
- N/A
Marshall Bowers
created
ba97661
Fix backend dependencies link in local collaboration docs (#6461)
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks
Release Notes:
- Fixed a crash when opening the MacOS Save As dialogue.
Conrad Irwin
created
a181dc8
Use the correct snapshot when calculating mouse positions (#6453)
Click to expand commit body
Release Notes:
- Fixed a panic in calculating remote cursor positions
Sometimes Cocoa calls app delegate methods (notably the display link)
while we're calling Cocoa methods. This causes a deadlock unless we
are careful to run cocao methods while we're not holding our internal
locks
Conrad Irwin
created
f185aca
Use the correct snapshot when calculating mouse positions
These are just some small refactorings of our language-server-starting
code, motivated by another change that I decided to bail on:
https://github.com/zed-industries/zed/pull/6448.
Max Brunsfeld
created
02ab160
Get basic syntax highlighting for Haskell working
[[PR Description]]
The `color` crate is not actually used by the `zed` crate, despite being
listed as a dependency. This PR removes it.
Joseph T. Lyons
created
569bb68
Prevent channel from vertically growing when containing facepile (#6439)
Click to expand commit body
Previously at UI font size of 20
- User-less channel: 28 px tall
- Occupied channel: 30 px tall
Now, still at UI font size 20:
- User-less channel: 30 px tall
- Occupied channel: 30 px tall
Release Notes:
- Fixed an issue where a channel would grow in height while showing
participant avatars.
Julia
created
9bc968e
Prevent channel from vertically growing when containing facepile
Julia
created
4ac3095
chat mentions for newly joined users (#5099)
Click to expand commit body
Release Notes:
- Added chat mentions for everyone in the call
After the general release we saw a number of crashes due to a SEGFAULT
inside the
System::new() method apparently relating to refreshing the user list.
As we do not need the user list, and the similar code in the telemtry
create is not crashing,
do less work for now.
Release Notes:
- Fixed a crash when opening the feedback modal
Conrad Irwin
created
cf3b4b0
Fix: Comment shortcut in Svelte files now respects if the line(s) are HTML vs JS/TS (#5860)
Click to expand commit body
Release Notes:
- Fixed: When using the comment shortcut, previously HTML or JS/TS would
all prefix lines with `// `. This PR brings the comments inline with
what is expected (`// ` for JS/TS, `<!-- ... -->` for HTML). Fixes
[#4578](https://github.com/zed-industries/zed/issues/4578).
[[PR Description]]
This replaces the `tempdir` crate with `tempfile`, which resolves
[RUSTSEC-2018-0017](https://rustsec.org/advisories/RUSTSEC-2018-0017).
Mikayla Maki
created
e1b7b5e
Update all links pointing to community (#6434)
fde4c09
Remove open source checklist from issue config
Joseph T. Lyons
created
482c01a
Ensure chat opens when guests join shared projects (#6425)
Click to expand commit body
This was broken because the panel was created before being added to a
dock. Invert the control order and add `starts_open()` to the Panel
trait (which lets us simplify how this worked for the ProjectPanel too)
Release Notes:
- Improved Chat visibility when joining a call as a guest