79c1003
go: fix highlighting of brackets, variables, fields (#7276)
Click to expand commit body
This changes the highlighting of Go code to make it more similar to how
we highlight Rust
* normal variables have the normal color, vs. being highlighted. This
really stuck out.
* brackets are properly highlighted
It also brings it closer to Neovim's tree-sitter highlighting by
changing how struct fields are highlighted.
Release Notes:
- Improved highlighting of Go code by tuning highlighting of variables,
brackets, and struct fields.
## Before & After
Thorsten Ball
created
d576cda
project: Do not inline LSP related methods
Click to expand commit body
The way Rust generics works, having a generic argument puts the burden of codegen on the crate that instantiates a generic function, which in our case is an editor.
Piotr Osiewicz
created
10cd978
go: improve outline queries to get rid of whitespace (#7273)
Click to expand commit body
This changes the Go `outline.scm` queries a bit so that we don't have
these stray whitespaces floating around. I'm sure there's more
improvements possible, but for now I think this makes it look less
wrong.
Release Notes:
- Improved outline and breadcrumbs for Go code.
## Before
## After
This PR implements support for displaying diagnostics in the scrollbar,
similar to what is already done for search results, symbols, git diff,
...
For example, changing a field name (`text`) without changing the
references looks like this in `buffer.rs` (note the red lines in the
scrollbar):
As you can see, the errors, warnings, ... are displayed in the scroll
bar, which helps to identify possible problems with the current file.
Relevant issues: #4866, #6819
Release Notes:
- Added diagnostic indicators to the scrollbar
Bennet Bo Fenner
created
2940a0e
Revert "Avoid excessive blocking of main thread when rendering in direct mode (#7253)" (#7272)
Click to expand commit body
This reverts commit 020c38a8916c063cba36c2c88a69b5e287269d5a because it
leads to glitches when selecting text.
https://github.com/zed-industries/zed/assets/1185253/78c2c184-bc15-4b04-8c80-a23ca5c96afa
Release Notes:
- N/A
Thorsten Ball
created
8fed9aa
Fix project panel selection related issues (#7245)
Click to expand commit body
Fixes #7003 and #7005.
Selecting as a reaction to actually opening a new item doesn’t seem
robust in all cases, the PR improves that.
Release Notes:
- Fixed missing project panel file selection in certain cases
Release Notes:
- Added outline support for Markdown files
- Added the ability to link to channel notes:
https://zed.dev/channel/zed-283/notes#Roadmap
Conrad Irwin
created
b35a722
Add missing secret in release nightly workflow
Max Brunsfeld
created
020c38a
Avoid excessive blocking of main thread when rendering in direct mode (#7253)
Click to expand commit body
Release Notes:
- Fixed a bug that caused inconsistent frame rate when scrolling on
certain hardware.
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
,
Antonio Scandurra
, and
Nathan Sobo
created
21f4da6
Correctly log LSP adapter name on LSP request error (#7232)
Click to expand commit body
Previously, we were logging the language server's binary filename
instead.
Release Notes:
- N/A
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
Max Brunsfeld
,
Nathan
, and
Antonio
created
da44f63
Order history items by open recency (#7248)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/7244
Follow-up of https://github.com/zed-industries/zed/pull/7210 that
returns back ordering of history items by open recency (last opened
history item should be on top)
Release Notes:
- N/A
---------
Co-authored-by: Andrew Lygin <alygin@gmail.com>
After this change we'll be able to push a tag to github to deploy to
collab.
The advantages of this are that there's no longer a separate step to
first
build the image, and then deploy it.
In the future I'd like to make this happen more automatically (maybe as
part of
bump nightly).
Release Notes:
- N/A
Conrad Irwin
created
5424c8b
Introduce a fast path for drawing quads with no borders / corner radii (#7231)
Click to expand commit body
This will introduce an extra conditional but saves us from doing a bunch
of math in the simple case of drawing simple rectangles that aren't
rounded or don't have borders.
Release Notes:
- Improved rendering performance.
Release Notes:
- vim: Fixed , and ; in visual mode
([#7182](https://github.com/zed-industries/zed/issues/7182)).
Conrad Irwin
created
d4264cb
Fix scrolling and wrapping in the markdown preview renderer (#7234)
Click to expand commit body
Release Notes:
- N/A
Mikayla Maki
created
97be0a9
Add syntax highlighting and LSP (erlang_lsp) for Erlang (#7093)
Click to expand commit body
This pull request implements support for the [Erlang
Language](https://erlang.org/).
**It adds:**
* [tree-sitter-erlang](https://github.com/WhatsApp/tree-sitter-erlang)
grammar
highlights (Licensed under Apache-2 from WhatsApp which is compatible
with Zed licensing model), folds and indents
* Erlang file icon based on the [official
one](https://www.erlang.org/doc/erlang-logo.png)
* [erlang_ls](https://github.com/erlang-ls/erlang_ls) support
Fixes https://github.com/zed-industries/zed/issues/4939, possibly a
duplicate of https://github.com/zed-industries/zed/pull/7085 with more
features. Suppose @wingyplus wants to join efforts here.
**To complete (out of scope for this PR):**
* Support for the ELP language server from WhatsApp. CC @robertoaloi
* Better indentation handling, need something like
`indentNextLinePattern` in VS Code
**Screenshots:**
Outline:
**Release Notes:**
* Added Erlang Support
([7093](https://github.com/zed-industries/zed/pull/7093)).
---------
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Co-authored-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Dairon M
and
Thanabodee Charoenpiriyakij
created
3107ed8
lsp: if language server closes stdout/stderr, break loop (#7229)
Click to expand commit body
Previously we would run these loops indefinitely when a language server
closed its stdout/stderr and the `read_until` returned `0` bytes read.
Easy to reproduce: start Zed with LSP attached, `kill -9` the LSP, see
logs accumulate.
Release Notes:
- Fix high CPU usage when a language server crashes (or closes its
stdout/stderr on purpose).
Co-authored-by: Julia <julia@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>
Thorsten Ball
,
Julia
, and
Mikayla
created
944a1f8
Send lsp_types::InitializeParams with Zed version (#7216)
Click to expand commit body
Based on the great work in
https://github.com/zed-industries/zed/pull/7130 , now sends this data
```
[crates/lsp/src/lsp.rs:588] ClientInfo { name: name.to_string(), version: Some(version.to_string()) } = ClientInfo {
name: "Zed Dev",
version: Some(
"0.122.0",
),
}
```
with every LSP server initialization.
Release Notes:
- Added Zed name and version to LSP InitializeParams requests
Kirill Bulatov
created
47a1ff7
markdown_preview: Sort dependencies in `Cargo.toml` (#7226)
Click to expand commit body
This PR sorts the dependencies for the `markdown_preview` crate in
alphabetical order.
Release Notes:
- N/A
adc7cfb
Fix moving focus to docks when navigating via keybinds (#7221)
Click to expand commit body
This is a follow-up to #7141 and fixes the focus-switching to docks in
case they haven't been focused before.
We ran into issues when trying to focus a dock, that hasn't been focused
in the app's lifecycle: focus would only flip after the next re-render
(which could be triggered by moving the mouse, for example)
This changes the approach and uses the one we have for `toggle focus`
actions.
Release Notes:
- N/A
Co-authored-by: Piotr <piotr@zed.dev>
Co-authored-by: bennetbo <bennetbo@gmx.de>
Add YAML file type icon from
[file-icons/icons](https://github.com/file-icons/icons)
https://github.com/file-icons/icons/blob/master/svg/YAML.svg
Release Notes:
- Added YAML file type icon.
---------
Co-authored-by: d1y <chenhonzhou@gmail.com>
thurain
and
d1y
created
2d41a11
markdown: Support alignment for table cells (#7201)
Click to expand commit body
Just a small improvement as a follow up to @kierangilliam great work on
#6958
Rendering a table specified like this:
```markdown
| Left columns | Center columns | Right columns |
| ------------- |:--------------:| -------------:|
| left foo | center foo | right foo |
| left bar | center bar | right bar |
| left baz | center baz | right baz |
```
Does now look like this (notice the cell alignments):
Release Notes:
- N/A
Bennet Bo Fenner
created
0102ffb
Refactor file_finder send element open code (#7210)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/6947 (cc
@alygin) that fixes a few style nits and refactors the code around:
* use already stored `currently_opened_path` to decide what to do with
the history item sorting
* use the same method to set history items, encapsulate the bubbling up
logic there
* ensure history elements are properly sorted before populating
The main reason to change all that is the new comparator in the previous
version:
https://github.com/zed-industries/zed/pull/6947/files#diff-eac7c8c99856f77cee39117708cd1467fd5bbc8805da2564f851951638020842R234
that almost violated `util::extend_sorted` contract, requiring both
collections to be sorted the same way as the comparator would be: it did
work, because we bubbled currently open item up in the history items
list manually, and that we have only one such item.
Release Notes:
- N/A
Kirill Bulatov
created
0edffd9
Select the second item in the file finder by default (#6947)
Click to expand commit body
This PR completes the first task of the Tabless editing feature (#6424).
It makes file finder select the previously opened file by default which
allows the user to quickly switch between two last opened files by
clicking `Cmd-P + Enter`.
This feature was also requested in #4663 comments.
Release Notes:
* Improved file finder selection: currently opened item is not selected now
Andrew Lygin
created
e65a76f
Add ability to navigate to/from docks via keybindings (#7141)
Click to expand commit body
This adds the ability to navigate to/from docks (Terminal, Project,
Collaboration, Assistant) via keybindings.
When using the `ActivatePaneInDirection` keybinding from the
left/bottom/right dock, we check whether the movement is towards the
center panel. If it is, we focus the last active pane.
Fixes https://github.com/zed-industries/zed/issues/6833 and it came up
in a few other tickes/discussions.
Release Notes:
- Added ability to navigate to docks and back to the editor using the
`workspace::ActivatePaneInDirection` action (by default bound to `Ctrl-w
[hjkl]` in Vim mode).
([#6833](https://github.com/zed-industries/zed/issues/6833)).
## Drawback
There's this weird behavior: if you start Zed and no files are opened,
you focus terminal, go left (project panel), then back to right to
terminal, the terminal isn't focused. Even though we focus it in the
code.
Maybe this is a bug in the current focus handling code?
## Demo
https://github.com/zed-industries/zed/assets/1185253/5d56db40-36aa-4758-a3bc-7a0de20ce5d7
---------
Co-authored-by: Piotr <piotr@zed.dev>
Thorsten Ball
and
Piotr
created
6c93c4b
assistant: render api key editor if no credentials are set (#7197)
Click to expand commit body
This hopefully reduces confusion for new users. I updated the docs just
this morning, but I figured it's probably better to fix the issue
itself.
So what this does is to render the API key editor whenever the assistant
panel is opened/focused and no credentials can be found.
See: https://github.com/zed-industries/zed/discussions/6943
Release Notes:
- Fixed assistant panel not showing dialog to enter API key when opened
without saved credentials.
---------
Co-authored-by: Piotr <piotr@zed.dev>
Thorsten Ball
and
Piotr
created
8bafc61
Add initial markdown preview to Zed (#6958)
Click to expand commit body
Adds a "markdown: open preview" action to open a markdown preview.
https://github.com/zed-industries/zed/assets/18583882/6fd7f009-53f7-4f98-84ea-7dd3f0dd11bf
This PR extends the work done in `crates/rich_text` to render markdown
to also support:
- Variable heading sizes
- Markdown tables
- Code blocks
- Block quotes
## Release Notes
- Added `Markdown: Open preview` action to partially close
([#6789](https://github.com/zed-industries/zed/issues/6789)).
## Known issues that will not be included in this PR
- Images.
- Nested block quotes.
- Footnote Reference.
- Headers highlighting.
- Inline code highlighting (this will need to be implemented in
`rich_text`)
- Checkboxes (`- [ ]` and `- [x]`)
- Syntax highlighting in code blocks.
- Markdown table text alignment.
- Inner markdown URL clicks
Kieran Gill
created
3b88291
Filter LSP github releases that have no assets to properly download LSP servers (#7189)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/7183
Release Notes:
- Filter lsp github releases that have no assets ([7189](https://github.com/zed-industries/zed/issues/7183))
3025e56
Tell the user when screen-sharing fails (#7171)
Click to expand commit body
Release Notes:
- Added an alert when screen-sharing fails
Conrad Irwin
created
c4083c3
Watch the themes directory for changes (#7173)
Click to expand commit body
This PR makes Zed watch the themes directory for changes.
When theme files are added or modified, we reload the theme and apply
any changes to Zed.
Release Notes:
- Added live reloading for the themes directory.
- Send app version and release stage to collab on connect
- Read the new header on the server
Release Notes:
- Added the ability to collaborate with users on different releases of
Zed.
We're seeing a bit of nonsense on telemetry. Although the checksum seed
isn't secret per-se, it does make sending nonsense a little more effort.
Release Notes:
- N/A
- Disallow sharing gitignored files through collab
- Show errors when failing to open files
- Show a warning to followers when view is unshared
/cc @mikaylamaki, let's update this to use your `private_files` config
before merge.
Release Notes:
- Added the ability to prevent sharing private files over collab.
---------
Co-authored-by: Piotr <piotr@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>
f98d636
WIP: Add a setting to visually redact enviroment variables (#7124)
Click to expand commit body
Release Notes:
- Added bash syntax highlighting to `.env` files.
- Added a `private_files` setting for configuring which files should be
considered to contain environment variables or other sensitive
information.
- Added a `redact_private_values` setting to add or remove censor bars
over variable values in files matching the `private_files` patterns.
-(internal) added a new `redactions.scm` query to our language support,
allowing different config file formats to indicate where environment
variable values can be identified in the syntax tree, added this query
to `bash`, `json`, `toml`, and `yaml` files.
---------
Co-authored-by: Nathan <nathan@zed.dev>
Mikayla Maki
and
Nathan
created
5333eff
Improve file finder by ignoring spaces in query (#7068)
Click to expand commit body
Release Notes:
- Changed file finder to ignore spaces in queries ([#5324
](https://github.com/zed-industries/zed/issues/5324)).
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Ben Hamment
and
Marshall Bowers
created
135bca2
vim: Make H/M/L work in visual mode (#7166)
ebdabb9
vim: Support counts for `H` and `L` motions (#7149)
Click to expand commit body
Release Notes:
- Added support for counts to `H` and `L` motions
([#4941](https://github.com/zed-industries/zed/issues/4941)).
Vishal Bhavsar
created
689d430
Don't panic when collaborating with older Zed versions (#7162)
Click to expand commit body
Older Zed versions may send a buffer id of 0, which is no-longer
supported. (as of #6993)
This doesn't fix that, but it does ensure that we don't panic in the
workspace by maintaining the invariant that from_proto_state returns
Some(Task) if the variant matches.
It also converts the panic to an error should something similar happen
again in the future.
Release Notes:
- N/A