e8bf06f
Style crate names in `CONTRIBUTING.md` (#6939)
Click to expand commit body
This PR styles the crate names in `CONTRIBUTING.md` using inline code.
Release Notes:
- N/A
Marshall Bowers
created
5dec9f7
Link to the Zed roadmap in `CONTRIBUTING.md` (#6937)
Click to expand commit body
This PR updates `CONTRIBUTING.md` to link to the public Zed roadmap.
Release Notes:
- N/A
Marshall Bowers
created
f7b6bfe
chore: Remove rerun-if-changed clause that might cause spurious rebuilds (#4193)
Click to expand commit body
Something is stomping over the timestamp of generated scene.h right
after the build script finishes:
`Dirty gpui v0.1.0 (/Users/someonetoignore/work/zed/zed/crates/gpui):
the file target/debug/build/gpui-ca04eedfe8d0e13c/out/scene.h has
changed (1705922004.637000680s, 1s after last build at
1705922003.507431315s)`
^ That's an output of `-v` flag added to either `cargo run` or `cargo
build`.
This comes up when you do `cargo build` followed by `cargo run` or
another `cargo build`; the artifact is not getting reused, even though
it should be possible?
Release Notes:
- N/A
This should be a standard recognized by everyone
```bash
mkdir todo
touch todo/.gitkeep # just placeholder
git add todo
git commit
```
Release Notes:
- Added icon for `.gitkeep` files.
This icon is designed based on [Ruby's official logo], to harmonize with
the other icons.
It is deformed and simplified to be human-recognizable, even at letter
size.
[Ruby's official logo]: https://www.ruby-lang.org/en/about/logo/
Release Notes:
- Added Ruby file icon.
This PR replaces a usage of an IIFE with `maybe!`.
Release Notes:
- N/A
Marshall Bowers
created
bbdf401
Use `async_maybe!` instead of inline IIFEs (#6906)
Click to expand commit body
This PR replaces instances where we were using an async IIFE with the
`async_maybe!` macro.
Release Notes:
- N/A
Marshall Bowers
created
5b9cc26
Gracefully handle errors when loading themes (#6904)
Click to expand commit body
This PR improves the theme loading to gracefully handle when a theme
couldn't be loaded.
Trying to debug a panic that happens on startup in Nightly.
Release Notes:
- N/A
Marshall Bowers
created
dfad36f
Upgrade `tree-sitter-php` to v0.21.1 (#6902)
Click to expand commit body
This PR upgrades `tree-sitter-php` to v0.21.1.
Here is the diff between our current version and this version:
https://github.com/tree-sitter/tree-sitter-php/compare/d43130fd1525301e9826f420c5393a4d169819fc...29a49d3a53353444ee2226e2efa140fec69dd3e0
The primary impetus for this change is to get this change that adds the
`license` field to the `Cargo.toml`:
https://github.com/tree-sitter/tree-sitter-php/pull/193
This will silence the warning that is shown when running
`script/generate-licenses`.
Release Notes:
- Upgraded `tree-sitter-php` to v0.21.1.
This PR bumps our version of `tree-sitter-haskell` for the addition of
the `license` field in
https://github.com/tree-sitter/tree-sitter-haskell/pull/112.
This will silence the warning that is shown when running
`script/generate-licenses`.
Release Notes:
- N/A
Marshall Bowers
created
9b453d2
Remove old themes using `UserTheme` constructs (#6897)
Click to expand commit body
This PR removes the themes defined using the `UserTheme` types, as we're
now loading the themes via JSON.
The `theme_importer` has also been reworked to read in a VS Code theme
and output a new JSON theme.
Release Notes:
- N/A
This PR changes the theme loading to use the JSON themes bundled with
the binary rather then the Rust theme definitions.
### Performance
I profiled this using `cargo run --release` to see what the speed
differences would be now that we're deserializing JSON:
**Before:** `ThemeRegistry::load_user_themes` took 16.656666ms
**After:** `ThemeRegistry::load_user_themes` took 18.784875ms
It's slightly slower, but not by much. There is probably some work we
could do here to bring down the theme loading time in general.
Release Notes:
- N/A
This PR adds serialized versions of each of the themes that currently
ship with Zed.
In a future PR we'll be looking to make these the canonical
representations of the built-in themes.
Note that we're intentionally repurposing the `theme_importer` to do
this, so that crate is a bit rough-and-ready at the moment.
Release Notes:
- N/A
- check hidden files
- fix a typos in a hidden file
- ignore "ba" typos in a more specific way
- ignore a typo in collab/migrations/ literally
Release Notes:
- N/A
Viktor Szépe
created
1564bd8
Add installation instructions to README (#6870)
Click to expand commit body
This PR adds installation instructions to the README, with a note on
which platforms we currently support.
Release Notes:
- N/A
Marshall Bowers
created
bd39258
Address a couple comments re Ruby file associations (#6863)
Click to expand commit body
Release Notes:
- Fixed: Address a [couple comments re Ruby file
associations](https://github.com/zed-industries/zed/pull/6812#discussion_r1468437144)
Stuart Hinson
created
ac3e0af
fix: move anyhow dependency to dependencies (#6866)
Click to expand commit body
Was moved by mistake in: ebbe52e6b0a33458956e1db400ba07f0e33398c3
This was throwing errors everywhere on Linux because anyhow is needed by
the code and is not macOS dependent.
Release Notes:
- N/A
William Desportes
created
0a0a866
Licenses: change license fields in Cargo.toml to AGPL-3.0-or-later. (#5535)
This PR adds the Haskell tree-sitter grammar copied from
[`nvim-treesitter`](https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries/haskell).
It also adds the Haskell Language Server.
This is a joint effort by myself (adding the grammar) and @leifu1128
(who is adding the language server integration).
This PR resolves https://github.com/zed-industries/zed/issues/5281
Release Notes:
- Added Haskell support
([#5281](https://github.com/zed-industries/zed/issues/5281)).
Mikayla Maki
created
0e722f6
Extend support for outlining in Gleam (#6834)
Click to expand commit body
This PR extends support for outlines in the recently-added Gleam
support.
Note that I'm leaving the release notes section blank as we haven't yet
released Gleam support, so it can just roll up into that item.
Release Notes:
- N/A
This change will work without any configuration and assume the user will install the Haskell Language Server using `ghcup`
Pseudomata
created
53ee597
Documentation: Clarify shortcuts and fix grammar (#6821)
Click to expand commit body
I got stuck on the "Getting started" page because I was trying to use
the shortcut `⌘+,` and not `⌘,`. This PR removes the `+`'s to make the
shortcuts clearer to the reader.
Release Notes:
- Improved getting started instructions.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Kieran Gill
and
Marshall Bowers
created
f369e9a
vim: fix dtx when x is immediately to the right
Brian Strauch
created
9833d4b
Add a couple common Ruby file suffixes (#6812)
Click to expand commit body
Release Notes:
- Added `Gemfile.lock` and `rake` as associated Ruby files.
This PR renames the `BellBadged` icon to `BellDot` to be a bit clearer
as to what its contents are.
Release Notes:
- N/A
Marshall Bowers
created
62365e6
Add a badge to the bell icon on new notifications (#6751)
Click to expand commit body
It changes the icon if a new notification event is consumed and changes
it back to normal upon toggling NotificationPanel.
Added a new field to NotificationPanel:
- have_unseen_notifications: bool
Added a new icon asset
- IconName::BellBadged => "assets/icons/bell_badged.svg"
Release Notes:
- Added a badge to bell icon for new notifications
([#6721](https://github.com/zed-industries/zed/issues/6721)).
- Allow people to leave channels
- Make contacts use right click menu for call
- Add a hover menu to see who's in a channel
Release Notes:
- Fixed clicking on contacts to *not* call them immediately
- Added a hover menu on channels to see who is there
- Added a "Leave Channel" right click option
a0f8a23
Add a hover menu to see who's in a channel
Click to expand commit body
Co-Authored-By: Max <max@zed.dev>
Inspired-By: @RemcoSmitsDev
Conrad Irwin
and
Max
created
95fab10
Make contacts use right click menu for call
Click to expand commit body
Fixes accidental anxiety.
Co-Authored-By: Max <max@zed.dev>
Conrad Irwin
and
Max
created
1761e60
Improve performance of JSON schema creation (#6770)
Click to expand commit body
JSON LSP adapter now caches the schema. `workspace_configuration` is
back to being async, and we are also no longer asking for font names
twice while constructing the schema.
Release Notes:
- Improved performance when opening the .json files.
---------
Co-authored-by: Kirill <kirill@zed.dev>
Piotr Osiewicz
and
Kirill
created
0a124a9
Feature: PHP: Add `readonly` keyword to keyword list (#6798)
Click to expand commit body
Release Notes:
- Added `readonly` to keyword list for PHP
([#6797](https://github.com/zed-industries/zed/issues/6797)).
Mikayla Maki
created
f5f7be1
Add `experimental.theme_overrides` to settings file (#6791)
Click to expand commit body
This PR adds **experimental** support for overriding theme values in the
current theme.
Be advised that both the existence of this setting and the structure of
the theme itself are subject to change.
But this is a first step towards allowing Zed users to customize or
bring their own themes.
### How it works
There is a new `experimental.theme_overrides` setting in
`settings.json`.
This accepts an object containing overrides for values in the theme. All
values are optional, and will be overlaid on top of whatever theme you
currently have set by the `theme` field.
There is JSON schema support to show which values are supported.
### Example
Here's an example of it in action:
https://github.com/zed-industries/zed/assets/1486634/173b94b1-4d88-4333-b980-8fed937e6f6d
Release Notes:
- Added `experimental.theme_overrides` to `settings.json` to allow for
customizing the current theme.
- This setting is experimental and subject to change.
Marshall Bowers
created
c9c9a6b
Activate the nushell virtualenv overlay correctly (#6766)
Click to expand commit body
The activate.nu file works a little differently than its counterparts in
other shells, and it needs to be invoked as an overlay, rather than
sourced directly into the shell.
This fixes an outstanding issue left over from #6323.
Release Notes:
- (Improved) ...
([#6323](https://github.com/zed-industries/zed/issues/6323)).
Simplify Zed's collaboration system by:
- Only allowing member management on root channels.
- Disallowing moving sub-channels between different roots.
- Disallowing public channels nested under private channels.
This should make the mental model easier to understand, and makes it
clearer
who has what access. It is also significantly simpler to implement, and
so
hopefully more performant and less buggy.
Still TODO:
- [x] Update collab_ui to match.
- [x] Fix channel buffer tests.
Release Notes:
- Simplified channel membership management.