This PR turns `FacePile` back into a component.
Our usage of it seemed a little weird, with us calling `render`
manually.
We're now implementing `Styled` on `FacePile` through its inner `Div` so
that we can apply the `p_1` at the call site.
Release Notes:
- N/A
Marshall Bowers
created
bac2e59
Fix popin for project panel by pre-resolving keybindings in the project panel (#4141)
Click to expand commit body
Also, factors out the fluent building APIs from IntoElement into their
own traits.
Also makes the project panel context menu initialization fluent:
<img width="1328" alt="Screenshot 2024-01-18 at 3 33 45 PM"
src="https://github.com/zed-industries/zed/assets/2280405/3468b6f2-07f0-48cf-bec1-ac0379333209">
Release Notes:
- Fixed pop in when right clicking on the project panel.
Mikayla Maki
created
20b58fe
Merge branch 'main' into fix-popin-for-project-panel
903176d
Pull out fluent builder helpers into re-usable trait
Mikayla
created
0691ad4
Make clicking `ListHeader` labels toggle the disclosure (#4140)
Click to expand commit body
This PR makes clicking the label inside of a `ListHeader` with a
disclosure also toggle the disclosure.
Release Notes:
- Added support for clicking the "Online", "Offline", and "Requests"
headers in the contact list to toggle their expansion.
Marshall Bowers
created
a508451
Fix popin for project panel by pre-resolving keybindings in terms of the project panel
Mikayla
created
b65cf6d
Merge branch 'main' into language-api-docs
This PR removes the VS Code themes from the `assets/` directory, as
we're not currently using them (and it's unlikely we will in their
current state).
Release Notes:
- N/A
Marshall Bowers
created
7860372
gpui: Always recompute layout on cache miss. (#4131)
Click to expand commit body
I'm not yet sure whether this is 100% correct, but it seems to alleviate
the following issue:
`When opening a dock, the panel doesn't appear right away. An empty dock
is briefly visible.`
Release Notes:
- Fixed panel layout being incorrect for a brief time after opening
(fixes https://github.com/zed-industries/community/issues/2415)
This PR adds a Git [`.mailmap`](https://git-scm.com/docs/gitmailmap)
file to canonicalize committer names/emails.
Release Notes:
- N/A
Marshall Bowers
created
b0db384
Restore the colored background for collaborators that you are following (#4137)
Max Brunsfeld
created
827a8da
Send crash reports to Slack automatically (#4111)
Click to expand commit body
This uploads apples crash reports to our servers when telemetry is
enabled.
Rather than jumping via the website, it uploads to collab directly. (I'd
like
to update the panic handler to do this too to make it possible to work
on that end-to-end without zed.dev running).
Release Notes:
- Added reporting of crashes when telemetry is enabled
Conrad Irwin
created
4b92a15
Restore the colored background for collaborators that you're following
Max Brunsfeld
created
2443ee6
Account for titlebar when tiling windows in zed-local
Max Brunsfeld
created
547aab2
Style the reset key state for the assistant panel (#4136)
Click to expand commit body
This PR styles the reset key state for the assistant panel.
Community issue: https://github.com/zed-industries/community/issues/2429
<img width="641" alt="Screenshot 2024-01-18 at 4 28 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/57377804-2867-45d3-906c-353130ec78e6">
Release Notes:
- Fixed the reset key screen for the assistant panel.
Marshall Bowers
created
bf8e570
Avoid gutter resizes on line number increase/decrease
Click to expand commit body
Reserves 4 characters for the line number in the gutter to avoid editor bounds jumping when editing small files like commit messages.
Also, some fun test helpers
Co-Authored-By: Mikayla <mikayla@zed.dev>
You can now use .debug_selector() to make it possible for tests to find
a given element,
and .debug_bounds() to find the coordinates of where it was painted.
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
Conrad Irwin
created
4408d45
gpui: Always recompute layout on cache miss.
Also, some fun test helpers
Co-Authored-By: Mikayla <mikayla@zed.dev>
Conrad Irwin
and
Mikayla
created
194e0f3
Always synchronize terminal before rendering it (#4114)
Click to expand commit body
Previously, we were trying not to synchronize the terminal too often
because there could be multiple layout/paint calls prior to rendering a
frame.
Now that we perform a single render pass per frame, we can just
synchronize the terminal state. Not doing so could make it seem like
we're dropping frames.
Release Notes:
- Improved terminal rendering performance.
f2f3a93
Store the impersonator id on access tokens created via ZED_IMPERSONATE (#4108)
Click to expand commit body
* Use the impersonator id to prevent these tokens from counting against
the impersonated user when limiting the users' total of access tokens.
* When connecting using an access token with an impersonator add the
impersonator as a field to the tracing span that wraps the task for that
connection.
* Disallow impersonating users via the admin API token in production,
because when using the admin API token, we aren't able to identify the
impersonator.
Max Brunsfeld
created
bfe7631
Invoke pane's focus_in handler when pane is focused directly (#4129)
Click to expand commit body
Fixes a bug where, when focusing a pane directly, it failed to transfer
focus to the active item.
2e35d90
Invoke pane's focus_in handler when pane is focused directly
Max Brunsfeld
created
9615eb8
Don't send follower events from other panes (#4127)
Click to expand commit body
Co-Authored-By: Mikayla <mikayla@zed.dev>
[[PR Description]]
Release Notes:
- Fixed a bug where following could scroll incorrectly
Conrad Irwin
created
2835c9a
Don't send follower events from other panes
Click to expand commit body
Co-Authored-By: Mikayla <mikayla@zed.dev>
Conrad Irwin
and
Mikayla
created
7b9e7fe
Use regular info color for speaker borders (#4126)
Click to expand commit body
This PR updates the speaker borders to use the regular `info` status
color instead of the `info_border` color.
This should provide more contrast and make it clearer as to who is
speaking.
Release Notes:
- Made the active speakers' borders more visible when in a call.
aef4547
Fix missing icons: set svg_renderer when assets are updated (#4124)
Click to expand commit body
This fixes the missing icons in nightly. Regression was introduced in
https://github.com/zed-industries/zed/pull/4122.
Release Notes:
- N/A
Mikayla Maki
created
b30efc9
Fix missing icons: set svg_renderer when assets are updated
Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>
Thorsten Ball
and
Mikayla
created
36ed5a3
Wrap over picker's matches when reaching the end of the list
Kirill Bulatov
created
87046ef
Fix focus and re-focus of project-wide search (#4121)
Click to expand commit body
This fixes the issue of `Cmd-shift-f` not refocusing the search bar when
a project-wide search already exists.
It also fixes the handlers for "search in new" and "new search".
Release Notes:
- N/A
Thorsten Ball
created
006bc5a
Minor API adjustments to make my blog post clearer (#4122)
Click to expand commit body
I don't want to clutter this post with the asset source, so I made it
optional. I'm also checking in an example which helps me ensure my code
examples are valid.
Release Notes:
- N/A
Nathan Sobo
created
130ea79
Fix focus and re-focus of project-wide search
Click to expand commit body
This fixes the issue of `Cmd-shift-f` not refocusing the search bar when
a project-wide search already exists.
It also fixes the handlers for "search in new" and "new search".
Co-authored-by: Kirill <kirill@zed.dev>