The entity map needs to be able to distinguish between the case when
the entity_id is waiting to be dropped, and when it is completely gone.
Before 8bc207141, it assumed that entity_ids in dropped_entity_ids could
be re-used. This caused `take_dropped` to error because the slot had
been overwritten. The fix there caused weak handles to allow upgrading
a reference count from 0, which could resurrect items in
`dropped_entity_ids` which caused them to be dropped twice.
We could allow weak items to upgrade from 0, and delete from
dropped_entity_ids, but that seemed more complicated than necessary.
84c5494
Fix prettier errors around Zed's settings.json/keymap.json files
Click to expand commit body
Ports https://github.com/zed-industries/zed/pull/3191 to zed2
Deals with zed-industries/community#2191
Fix Zed starting too many prettier installations in the beginning, and not being able to format the config files.
Kirill Bulatov
created
45e695c
Fix prettier errors around Zed's settings.json/keymap.json files (#3191)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2191
Fix Zed starting too many prettier installations in the beginning, and
not being able to format the config files.
Release Notes:
- Fixed prettier not being able to format Zed's config files and spawning excessive prettier installations
Adds an `Entity` trait for abstracting over `View`s and `Model`s, and
implements it for the `subscribe()` and `observe()` APIs.
The last commit also includes a fun experiment I added, using the
`Result` type to return the owned model handles back to the caller in
the case of downcast failure, inspired by the `binary_search*` methods.
Antonio Scandurra
created
c98a811
Only process diagnostics if corresponding project is alive
Click to expand commit body
Part of https://github.com/zed-industries/zed/pull/3128 that is possible
to apply now.
d6abd8a
Add missing dev-dependency feature for editor multi_buffer dependency
Max Brunsfeld
created
30dffbb
Introduce a Render trait, make views implement it
Click to expand commit body
Don't pass a render function separately from the view.
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Antonio <as-cii@zed.dev>
Max Brunsfeld
,
Nathan Sobo
,
Mikayla
, and
Antonio
created