62d6a85
Restore namespace parameter to `actions!` (#3577)
Click to expand commit body
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
Although automatically deriving the namespace worked in many situations,
it was
unclear what to do with nested modules. Vim wanted all actions to be
registered
under vim, while collab_ui wanted one namespace per action.
It seems better to make the implicit explicit, and give the flexibility
to hide
implementation details from the end-users.
Release Notes:
- N/A
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
Conrad Irwin
created
cbbb0d0
Paint code-action/fold buttons above the gutter (#3576)
Click to expand commit body
Previously, clicking on fold indicators or code action lightning bolts
wouldn't work - it would instead perform the normal gutter click handler
(selecting the clicked line).
By painting those indicators at a higher z-index, we ensure that the
indicators' click handlers are invoked instead.
Max Brunsfeld
created
7b722c3
Paint code-action/fold buttons above the gutter
Max Brunsfeld
created
188d727
Fix crash due to mutating command palette's candidates on confirmation (#3575)
Click to expand commit body
I was seeing a crash when confirming the command palette. It was caused
by getting the palette's `commands` (match candidates) and `matches`
getting out of sync because we mutated `commands` when removing the
selected command.
Max Brunsfeld
created
6b58eb2
Fix crash due to mutating command palette's candidates on confirmation
049314e
Restructure chat message rendering to allow text to wrap
Max Brunsfeld
created
d03e29d
Start work on rendering formatted chat messages
Max Brunsfeld
created
8feb11c
Make clicking the breadcrumb toggle the symbol outline (#3571)
Click to expand commit body
This PR wires up clicks on the breadcrumb to toggle the symbol outline.
Note that the behavior of the symbol outline is a little wonky at the
moment, due to the issues with pane focus.
Release Notes:
- N/A
Marshall Bowers
created
008c56a
Adjust which status colors we import from the VS Code theme (#3570)
Click to expand commit body
This PR adjusts the status colors we import from the VS Code theme to be
the right ones.
Instead of looking at the Git status colors, we use the
`editorGutter.addedBackground`, `editorGutter.modifiedBackground`, and
`editorGutter.deletedBackground` colors for added, modified, and deleted
status colors, respectively.
Release Notes:
- N/A
Marshall Bowers
created
cf42d95
Use the diff status colors defined in the theme (#3569)
Click to expand commit body
This PR updates the diff status colors to use the ones defined in the
theme instead of placeholder colors.
Release Notes:
- N/A
Marshall Bowers
created
60e4311
Fix bug where feedback dismissal prompt is shown twice (#3568)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
cbbcc35
Fix bug where feedback dismissal prompt is shown twice
Joseph T. Lyons
created
44890d6
Weight scope matches to improve results (#3567)
Click to expand commit body
This PR adds a simple weighting system for the matching of scopes from
the VS Code theme.
This gives us more control over the matches we get out of the theme, and
subsequently improves the results.
Release Notes:
- N/A
This PR restores the sorting of themes in the theme selector in Zed2.
Release Notes:
- N/A
Marshall Bowers
created
40b219f
zed2: Position terminal context menu, wire up dismis, and unbork context menu (#3561)
Click to expand commit body
Release Notes:
- N/A
Julia
created
f67d4ce
Add more harness around nightly builds (#3562)
Click to expand commit body
Part of
https://zed-industries.slack.com/archives/C05SJGT0M33/p1702039430077589
The nightly job managed to pass successfully (build & upload nightly),
logged a proper commit sha that got into latest_sha on the nightly
bucket — but Zed version in about was wrong.
* Log Zed build sha in release builds to ensure CI uses the right one
* make curl to return non-zero code for non-200 nightly file uploads
Release Notes:
- N/A
Also ensure that curl commands for nightly uploads return 200 (fail otherwise).
Kirill Bulatov
created
133b1a8
Fix palette/picker colors for imported themes (#3560)
Click to expand commit body
This PR fixes the palette/picker colors for themes imported from VS
Code.
- We now use the `dropdown.background` to set the background color for
elevated surfaces
- We now pull in `list.activeSelectionBackground` to use as the color
for selected ghost elements
Release Notes:
- N/A
27501d2
Pull in colors for selected ghost elements
Marshall Bowers
created
77c8108
Use `dropdown.background` from VS Code for elevated surface background
Marshall Bowers
created
1c850f4
Use `breadcrumb.background` from VS Code for toolbar background (#3559)
Click to expand commit body
This PR changes the color we use for the toolbar background from the VS
Code theme to `breadcrumb.background`.
If this value isn't set then we fall back to the `editor.background`.
Release Notes:
- N/A
Marshall Bowers
created
1d35a81
Use `editorGroupHeader.tabsBackground` from VS Code as tab bar background (#3558)
Click to expand commit body
This PR changes the color we use for the tab bar background from the VS
Code theme to `editorGroupHeader.tabsBackground`.
Release Notes:
- N/A