All code paths have already transitioned to `Foreground::Deterministic`.

This fails because we don't yet handle this scenario.

This prevents a race condition where the host will send us messages and
responses about a worktree that we have seen but haven't yet finished loading.

Improve remote file handling

Use the File proto to build the File associated with the buffer rather than relying on the local entry.

If you want to call `abs_path` or `load`, the file needs to be local. You call `as_local` which returns `Option<dyn LocalFile>` with those local-only methods. I think this makes it more explicit what works only locally vs everywhere.

This allows us to remove the absolute path and scan-related state from the Snapshot. None of this data is relevant or valid on guests.

I'd like to only have methods related to absolute paths on local worktrees, because it's not really possible to implement them on remote worktrees since we don't know the full path being shared and wouldn't have anything to do with it anyway if we did.

Fix panic in ProjectDiagnosticsEditor::open_excerpts by introducing new defer feature to GPUI

Activating a new item causes the current item to be deactivated. We're the current item, but we're on the stack, so we panic if we try to do this synchronously. If we use defer to wait until we're off the stack it works.

It's like update, but happens after the current effect instead of synchronously. Also, it doesn't allow the callback to return a value because there would be nothing to do with it.

This takes a closure that will be enqueued as an effect to ensure there are no entities on the stack.

Move buffers to project

This shouldn't be necessary in practice but makes testing easier.

The former always adds a worktree, even if we have one already in the
project and that could be misused. The public API should always search
for a local worktree containing the requested path first so that the
project can uphold invariants about which worktrees it has.

Update diagnostics on project instead of on worktree

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

* Fix misuse of guest buffer's id as its remote id

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Go to definition

We'll implement this soon but want to merge something stable to main.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

This reverts commit 9c9a09cccb41c4ea2a3d06b32170876e77946ba1.

We don't use it now, and plan on dealing with it in a dedicated way when we need mouse hover interactions.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Also, avoid showing them in the project panel as well as in the
contacts panel.

When jumping between different buffers, we don't care about the cursor's previous location. When navigating backward, we want to jump directly to the site of the jump.

Move window to the foreground when opening a path in an existing workspace

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Co-Authored-By: Nathan Sobo <nathan@zed.dev>