Commit log

62d6551 Fire focus handlers on draw to avoid timing with newly created item (#3640)

Click to expand commit body 
See title

Any focus changes which fire from within a focus handler should be
handled in the next frame

Release Notes:

- N/A

Julia created

de523c2 Give correct focus handle when project search has no matches

Julia created

4be84f3 Merge branch 'main' into focus-handlers-on-draw

Julia created

70a14bb Implement user menu (#3636)

Click to expand commit body 
Release Notes:

- N/A

Conrad Irwin created

d4e0923 Give result-less project search a focus handle

Julia created

7e1d61d Merge branch 'main' into user-menu

Conrad Irwin created

46bd608 Fix some todos, add others (#3669)

Click to expand commit body 
As it says on the tin

Release Notes:

-

Mikayla Maki created

ff4da87 Render panel in these tests

Julia created

fbcaf96 Track focus on TestItem

Julia created

6973b1b Add several red outlines

Mikayla created

ead5206 Fix todos in auto-update

Mikayla created

b52db69 Fix overlay rendering when dragging onto the center of a pane (#3667)

Max Brunsfeld created

52b9fc3 Fix overlay rendering when dragging onto the center of a pane

Max Brunsfeld created

c27dd57 Make more performance improvements to GPUI 2 (#3664)

Click to expand commit body 
In the 3 charts below, "window draw" has 3 major subroutines. Request
layout, where we walk over the tree and have everything talk to the
layout engine initially. Compute layout, where we have the layout engine
actually do the layout, and then paint, where we use the computed bounds
to populate the scene.


![image_720](https://github.com/zed-industries/zed/assets/1789/d2225389-865f-4c8a-9452-9f611da64dcf)

Things are moving quickly so before/after comparisons are tough. In the
graph above, green bars are from a commit actually pre-dates a merge of
master which increased the complexity of layout. The red bars represent
the state of the world after this PR. Note how we improve the
performance of `paint`.

Improvements:

- Not moving `self` in `Element::paint`. This was moving from the heap
to the stack and imposing a big cost. This is the biggest win in this
PR.
- We got some minor wins by making the stacking order a bigger smallvec
of u8 instead of u32.
- A big win that doesn't show up in this chart is avoiding a double
render of the editor when autoscrolling by never pushing notification
effects or marking the window dirty when notifying during a window draw.

Release Notes:

- N/A

Mikayla Maki created

b95cc72 Fix centering of empty pane text (#3666)

Click to expand commit body 
The formatting of the empty pane text regressed in #3665, in which I
also made it possible to drag items onto an empty pane.

Max Brunsfeld created

05cb68e Merge branch 'main' into perf-2

Mikayla Maki created

842f15c Fix centering of empty pane text

Max Brunsfeld created

82c8b49 Fix stickiness of main pane drag target (#3665)

Click to expand commit body 
Reimplement the pane drag targets using on_drag_move

Max Brunsfeld created

8418f25 Merge branch 'main' into perf-2

Mikayla Maki created

d6383ab Fix stickiness of main pane drag target

Click to expand commit body 
Reimplement the pane drag targets using on_drag_move

Max Brunsfeld created

0b4b81f Fix dock resizing (#3663)

Click to expand commit body 
This fixes some bugs in the display and tracking of dock resizes

Release Notes:

-

Mikayla Maki created

ad8165a Rename draw2 -> draw_and_update_state

Nathan Sobo created

f4a954d Merge remote-tracking branch 'origin/main' into perf-2

Nathan Sobo created

8b4cf38 Fix dock resize handles

Click to expand commit body 
co-authored-by: conrad <conrad@zed.dev>

Mikayla and conrad created

02606d1 Merge remote-tracking branch 'origin/main' into perf-2

Nathan Sobo created

bc3e664 Fix warning in release mode (#3662)

Click to expand commit body 
This PR fixes a warning that was present in release mode, which was
preventing the nightly builds from running:

```
error: variable does not need to be mutable
   --> crates/gpui2/src/elements/div.rs:547:9
    |
547 |     let mut div = Div {
    |         ----^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`
```

Release Notes:

- N/A

Marshall Bowers created

4c63c74 Fix bug in drag move dispatch

Click to expand commit body 
co-authored-by: conrad <conrad@zed.dev>

Mikayla and conrad created

e4f9bdd Remove unused imports

Nate Butler created

139fe7c Use separate editor foreground color (#3661)

Click to expand commit body 
This PR populates the `editor_foreground` color in the various themes
and updates the editor to use this as the color for text.

The `text` field in the theme should now be used for UI elements, while
`editor_foreground` should be used for buffers.

This improves the contrast in some themes, notably Ayu Dark.

Release Notes:

- N/A

Marshall Bowers created

936c78b WIP IconButton story

Nate Butler created

fcbd58f Enable all warnings in workspace, fix all warnings (#3660)

Max Brunsfeld created

3cf0037 Use updated story container in Text story

Nate Butler created

2b278e6 Use `editor_foreground` color in editor

Marshall Bowers created

292fac3 Use `editor.foreground` from VS Code for the editor foreground

Marshall Bowers created

8bac4e1 Emit `editor_foreground` color from theme converter

Marshall Bowers created

6170895 Fix bug in Workspace::activate_pane_in_direction

Click to expand commit body 
Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

4e7005b Use bitflags to hold error states

Joseph T. Lyons created

b5e9e27 Re-enable cmd-<number> key bindings for activating panes (#3659)

Max Brunsfeld created

23d5f3f Enable all warnings in workspace, fix all warnings

Click to expand commit body 
Bring back some workspace tests

Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

d13a21c Don't move in paint

Nathan Sobo created

bbbdb9f Render panel in this test to make sure it can receive focus

Julia created

63c3edf Continue styling new story components

Nate Butler created

8d994ce Enable dragging from project panel to panes (#3658)

Click to expand commit body 
Rework gpui2 drag API so that receivers need not specify the dragged
view type.

Max Brunsfeld created

6b06bb4 Re-enable cmd-<number> key bindings for activating panes

Click to expand commit body 
co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

8791f7c Enable dragging from project panel to panes

Click to expand commit body 
Rework gpui2 drag API so that receivers need not specify the dragged view type.

co-authored-by: Max <max@zed.dev>
co-authored-by: Conrad <conrad@zed.dev>

Mikayla , Max , and Conrad created

fb3382b Merge remote-tracking branch 'origin/main' into perf-2

Nathan Sobo created

c7d60bb Add some TODOs

Joseph T. Lyons created

35838ae Style "Replace in project" input in project search (#3657)

Click to expand commit body 
This PR styles the "Replace in project" input in the project search.

Release Notes:

- N/A

Marshall Bowers created

0dd6c50 Use FxHashMap for element state

Nathan Sobo created

5f25fa1 Tweak wording

Joseph T. Lyons created