da01c1a
Open bug reports in `zed-industries/zed` (#5862)
Click to expand commit body
It looks like bug reports are being moved from
`zed-industries/community` to `zed-industries/zed`. This PR updates the
`feedback` crate to update the GitHub URL to reflect this change.
Pseudomata
created
a736890
Revert "Ensure that notify observations are sent during `Window::draw()`"
Mikayla Maki
created
ad537f6
(probably) install rosetta if it's not there
Since our last measurements, startup time in Zed had regressed quite
significantly. This was due to several issues:
- We were loading IBMPlex, which we're not really using in the UI.
- Images were being parsed in the foreground, thus blocking the main
thread
- Language models (for semantic index and assistant) were being loaded
in the foreground, thus blocking the main thread
- Interaction with the keychain was blocking the main thread
In addition to these, with this pull request we will now deserialize the
items for a pane in parallel, as opposed to doing so sequentially.
All combined, when running the zed binary directly this brings startup
time from ~350ms to ~210ms on my machine.
Release Notes:
- Improved startup time.
Antonio Scandurra
created
25a7eb2
Move interaction with keychain off the main thread
Antonio Scandurra
created
2ce24dc
Fix tab bar button's focus handling lagging behind (#4247)
Click to expand commit body
This fixes https://github.com/zed-industries/community/issues/2442 for
me.
Previously, the tab bar buttons would stay when the chat panel was
opened (and received focus) until something else was drawn (or caused a
render?)
With this change, the tab bar buttons are only shown if the pane was
focus.
I'm not sure about the side-effects of this, but the toolbar still seems
to work fine.
### Before
https://github.com/zed-industries/zed/assets/1185253/24b56e51-467b-4a09-909f-72ee6f76f32c
### After
https://github.com/zed-industries/zed/assets/1185253/18865f49-d00e-453a-8a38-aee15f06beb8
### Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
Thorsten Ball
created
b9218ae
Add module documentation to GPUI and make gpui.rs example compile (#4241)
fe2cb9f
fixup! pane: Another stab at focus flickers in tab bar
Piotr Osiewicz
created
0497b2f
pane: Another stab at focus flickers in tab bar
Click to expand commit body
This time around, we address the flicker seen in #3857 by querying the active item (that might've just been added),
as it knows whether it has focus even if the parent Pane does not.
Co-authored-by: Thorsten <thorsten@zed.dev>
e4604eb
Parallelize deserialization of pane items on startup
Click to expand commit body
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
Antonio Scandurra
and
Mikayla Maki
created
526ea40
Log if element arena allocation is >80% (#4246)
Click to expand commit body
We recently doubled the size of the `ELEMENT_ARENA` after someone ran
into a panic due to the arena running out of space.
This adds some logging so that we can hopefully develop a better
understanding of when the element area's allocation is elevated.
Release Notes:
- N/A
Antonio Scandurra
created
027f425
Fix tab bar button's focus handling lagging behind
Click to expand commit body
This fixes https://github.com/zed-industries/community/issues/2442 for
me.
Previously, the tab bar buttons would stay when the chat panel was
opened (and received focus) until something else was drawn (or caused a
render?)
With this change, the tab bar buttons are only shown if the pane was
focus.
I'm not sure about the side-effects of this, but the toolbar still seems
to work fine.
Thorsten Ball
created
e018506
Cache font-missing result to avoid unnecessary lookups (#4245)
Click to expand commit body
This fixes the performance problem we saw in
https://github.com/zed-industries/community/issues/2405.
In a trace we could see that if a font is missing we'd constantly look
it up and never cache that it's missing.
This changes that and does cache the font-is-missing result.
Drawback is that one would need to restart Zed after installing a
missing font that was configured in settings. That seems acceptable for
now, though.
Release Notes:
- Improved rendering performance when configured fonts are missing on
the system.
We recently doubled the size of the `ELEMENT_ARENA` after someone ran
into a panic due to the arena running out of space.
This adds some logging so that we can hopefully develop a better
understanding of when the element area's allocation is elevated.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
4800991
Cache font-missing result to avoid unnecessary lookups
Click to expand commit body
This fixes the performance problem we saw in https://github.com/zed-industries/community/issues/2405.
In a trace we could see that if a font is missing we'd constantly look
it up and never cache that it's missing.
This changes that and does cache the font-is-missing result.
Drawback is that one would need to restart Zed after installing a
missing font that was configured in settings. That seems acceptable for
now, though.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
bd6197e
Increase capacity of element arena to 8MB (#4244)
Click to expand commit body
This fixes a panic we just saw on nightly. It's the first time we see
this panic, so I think it's pretty safe to assume having twice as much
capacity will fix it.
Release Notes:
- Fixed a crash that could sometimes occur when the window contained
lots of graphical elements.
This fixes a panic we just saw on nightly. It's the first time we
see this panic, so I think it's pretty safe to assume having twice as
much capacity will fix it.
This PR does some cleanup of the `gpui` docs, making sure we're linking
things appropriately and following good Rust documentation style.
Release Notes:
- N/A
Marshall Bowers
created
1aa02ac
Ensure that notify observations are sent during `Window::draw()` (#4236)
Click to expand commit body
This PR fixes a bug in GPUI where the observation API would not be
triggered if a focus event caused a `notify()`
Release Notes:
- N/A
This PR adds a `CODE_OF_CONDUCT.md` that links out to the existing code
of conduct on the Zed site.
The link in the file is currently a dead link, but will work once the
new site goes live tomorrow.
Release Notes:
- N/A
* Fixed jumping of list item when the separator appeared and
disappeared.
* Fixed a bug where the selection got into a valid state when updating
the matches
Release Notes:
- Fixed an issue where the file finder's selection got into a state
where nothing was selected after filtering the matches.