I was experiencing hang, and we blamed it on spawning a few hundred git
processes
simultaneously.
cc @MrNugget
Release Notes:
- Fixed slowness with hundreds of buffers open doing git blame.
Conrad Irwin
created
eb0f1e7
Show dev server in the titlebar for remote projects (#11276)
Click to expand commit body
Co-Authored-By: Mikayla <mikayla@zed.dev>
Release Notes:
- Show server name in the titlebar for remote projects
Co-authored-by: Mikayla <mikayla@zed.dev>
This PR cleans up the `Indicator` component:
- Renamed `IndicatorStyle` to `IndicatorKind` and made it private.
- Fixed `Indicator::bar()` to construct an indicator using the right
`IndicatorKind`.
- Removed the `IndicatorIcon`, since we didn't actually end up using it.
Release Notes:
- N/A
Marshall Bowers
created
fa0253b
Disallow adding folders to projects and opening the terminal in remote projects (#11261)
e5b88ac
Use HIGH priority to wake blocked timers (#11269)
Click to expand commit body
One contributor to some beach-balls was that the main thread was calling
block_with_timeout, but the timeout never fired.
Release Notes:
- Reduced main thread hangs under very high system load
Conrad Irwin
created
4739797
Add the ability to render icons as indicators (#11273)
Click to expand commit body
This PR adds the ability to render `Icon`s as an `Indicator`.
Release Notes:
- N/A
Co-authored-by: Nate Butler <nate@zed.dev>
Marshall Bowers
and
Nate Butler
created
4f53128
Replace rem size literals with constant (#11272)
Click to expand commit body
This PR replaces the rem size literals with the `BASE_REM_SIZE_IN_PX`
constant.
This way we can retain our source of truth for the rem size that we're
designing against.
Release Notes:
- N/A
Marshall Bowers
created
a194c0a
Compile and instantiate wasm modules on a background thread (#11270)
Click to expand commit body
Release Notes:
- Fixed a hang that could occur when loading some extensions, by loading
extensions on a background thread.
Max Brunsfeld
created
fb0d2e9
assistant2: Use new icon in status bar (#11268)
Click to expand commit body
This PR updates the new assistant to use the new (temporary) icon in the
status bar to distinguish it.
We added the icon in #11257, but hadn't wired it up.
Release Notes:
- N/A
Marshall Bowers
created
aa1b4c7
Add an `explore extensions` button to welcome screen (#11265)
Click to expand commit body
We are still getting comments from users saying they didn't know we had
extensions until just now. This doesn't fix anything for existing users,
but it helps make new users more aware, earlier on. There's probably
more we need to do for discoverability, but this feels like it should
help.
Release Notes:
- N/A
Joseph T. Lyons
created
dad3cbb
Enable random_channel_buffer_tests to run on Linux (#10863)
Click to expand commit body
With this patch applied I can see the following line in the test output:
test tests::random_channel_buffer_tests::test_random_channel_buffers has
been running for over 60 seconds
Without it I run in a failure with 'Invalid keystroke `cmk-,`
Release Notes:
- N/A
---------
Co-authored-by: Max Linke <kain88-de@users.noreply.github.com>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Max Linke
,
Max Linke
, and
Marshall Bowers
created
Part of https://github.com/zed-industries/zed/issues/4523
Added two new actions with the default keybindings
```
"cmd-'": "editor::ToggleHunkDiff",
"cmd-\"": "editor::ExpandAllHunkDiffs",
```
that allow to browse git hunk diffs in Zed:
https://github.com/zed-industries/zed/assets/2690773/9a8a7d10-ed06-4960-b4ee-fe28fc5c4768
The hunks are dynamic and alter on user folds and modifications, or
toggle hidden, if the modifications were not adjacent to the expanded
hunk.
Release Notes:
- Added `editor::ToggleHunkDiff` (`cmd-'`) and
`editor::ExpandAllHunkDiffs` (`cmd-"`) actions to browse git hunk diffs
in Zed
Kirill Bulatov
created
5831d80
Return an error from project index tool when embedding query fails (#11264)
Click to expand commit body
Previously, a failure to embed the search query (due to a rate limit
error) would appear the same as if there were no results.
* Avoid repeatedly embedding the search query for each worktree
* Unify tasks for searching all worktree
Release Notes:
- N/A
Max Brunsfeld
created
4b76769
Fix scrollbar auto-show for cursors out of sight (#11244)
Click to expand commit body
This PR fixes scrollbar auto-show feature when there're not visible
cursors. The intial behavior was broken in #11147.
The problem is that `selections` only contains visible selections, so
the `if` with `non_visible_cursors |= true` is only visited in rare edge
cases when we have at least part of the selection still visible on the
screen. But when we scroll far enough from the cursor,
`non_visible_cursors` keeps its default `false` value, which is
incorrect.
Release Notes:
- N/A
This PR adds a new `ChatNotice` component for displaying notices within
the assistant.
We will be able to use this for allowing the user to confirm a project
index request.
<img width="518" alt="Screenshot 2024-05-01 at 2 41 31 PM"
src="https://github.com/zed-industries/zed/assets/1486634/3beaeeaf-6046-4284-ac0a-4248e1f9ac20">
Release Notes:
- N/A
This PR updates the Homebrew installation instructions for the Preview
release, which has been migrated to ```homebrew/cask``` as
```zed@preview``` (see
[Commit](https://github.com/Homebrew/homebrew-cask/commit/bad25d79e13ca41b492c976ef70b72117c402d20)).
Release Notes:
- N/A
Note: You shouldn't use the `unstable.ui_density` setting – it is only
being added for testing and to enable new UI components to be built with
density in mind. Don't expect this to work well, or at all right now.
Adds some of the basic wiring we'll need to start scaling UI elements
throughout the app based on a desired density setting.
Release Notes:
- N/A
Co-Authored-By: Mikayla <mikayla@zed.dev>
My Zed was running out with collab + chat + recent projects + two splits
on a large monitor
Release Notes:
- N/A
Co-authored-by: Mikayla <mikayla@zed.dev>
Follup up from
https://github.com/zed-industries/zed/pull/11229#pullrequestreview-2033556336
Release Notes:
- N/A
Conrad Irwin
created
8907d11
project panel: Adjust formatting of trash/delete action (#11252)
Click to expand commit body
This PR removes a confusing quotation mark when trashing/deleting a
file, introduced in #10875.
Also makes it clear that the file is actually going into trash instead
of being deleted permanently
Before (trash):
<img width="266" alt="image"
src="https://github.com/zed-industries/zed/assets/53836821/f94a6257-62d0-4a3f-bc44-19e36bb28f67">
After (trash):
<img width="285" alt="image"
src="https://github.com/zed-industries/zed/assets/53836821/becb8143-06cf-4b5e-a52e-be2726df5955">
Before (delete):
<img width="263" alt="image"
src="https://github.com/zed-industries/zed/assets/53836821/e109a127-5f9c-4eeb-950e-4c4d5157061b">
After (delete):
<img width="260" alt="image"
src="https://github.com/zed-industries/zed/assets/53836821/246d0d94-e3d2-4279-84e2-74b313fe00a7">
Release Notes:
- Fixed formatting of prompt action when trashing/deleting a file
eb4ac7e
Suggest the SCSS extension for `.scss` files (#11249)
Click to expand commit body
This PR adds a suggestion for the new [SCSS
extension](https://github.com/bajrangCoder/zed-scss) when `.scss` files
are opened.
Release Notes:
- Added a suggestion for the SCSS extension when `.scss` files are
opened.
Contributes: #11168
https://developer.apple.com/documentation/corefoundation/1542428-cfrunloopgetcurrent
implies that we should be `CFRetain`ing the run loop.
Lets do that, and see if it reduces the number of crashes we see.
Release Notes:
- (maybe) Fix a rare crash in watching settings files.
Conrad Irwin
created
45cf101
Add MimeType to open directory with zed (#11238)
Click to expand commit body
Release Notes:
- open directory using context menu (Right click -> open with -> zed).
Zorin FOSS
created
f39a242
Adjust the yss surrounds operator (#11212)
Click to expand commit body
For #11084 In the case of an indentation in front of the current line,
it may also be necessary to deal with the start point of the selected
range
Release Notes:
- N/A
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Hans
and
Conrad Irwin
created
c9778a3
Use Elixir LS as the default language server for Elixir (#11234)
Click to expand commit body
This PR adds `language_servers` settings for Elixir and HEEX to ensure
they both only use Elixir LS by default.
Eventually we'd like to have these provided by the Elixir extension, but
there are some outstanding questions on the design.
For now we can just use the built-in default settings to ensure a good
out-of-the-box experience for Elixir users.
Release Notes:
- N/A
Marshall Bowers
created
d1abbb1
assistant2: Refine editing of previous messages (#11233)
Click to expand commit body
This PR refines the UX of editing a previous message, including the
following:
- Focus the prev message body editor on double-click
- Restore previous body text on cancel
- Cancel pending completion upon submission of previous message
- Drive-by: Remove min height on composer editor
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <marshall@zed.dev>
This PR sets up the `assistant2` crate with the storybook so that UI
elements can be iterated on in isolation.
To start, we have some stories for the `ChatMessage` component:
```sh
cargo run -p storybook -- components/assistant_chat_message
```
<img width="1233" alt="Screenshot 2024-04-30 at 5 20 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/510967ea-0e9b-4fa9-94fb-421ee74bcc45">
Release Notes:
- N/A
Marshall Bowers
created
96b1fc4
assistant2: Align chat messages with composer (#11227)
Click to expand commit body
This PR adds some additional spacing to the composer so it aligns with
the chat messages.
Release Notes:
- N/A
cb73501
Don't allow dropping files on remote projects (#11218)
Click to expand commit body
Release Notes:
- Fixed a panic when a remote participant dropped a local file on your
project
Conrad Irwin
created
f11a781
assistant2: Use composer for editing inline messages (#11222)
Click to expand commit body
This PR updates the assistant to render historical user messages the
same as ones from the assistant.
Double-clicking on a message will open a composer inline for editing.
Pressing `Esc` will cancel the edit.
We don't yet restore the previous state of the message upon canceling.
<img width="401" alt="Screenshot 2024-04-30 at 4 04 01 PM"
src="https://github.com/zed-industries/zed/assets/1486634/5f253fa8-6578-4054-be30-c495e326d700">
<img width="401" alt="Screenshot 2024-04-30 at 4 04 28 PM"
src="https://github.com/zed-industries/zed/assets/1486634/edf25cea-d97e-44d2-8772-3690eac017a4">
Release Notes:
- N/A
* [x] Fixed an issue where embeddings would be assigned incorrectly to
files if a subset of embedding batches failed
* [x] Added a command to debug which paths are present in the semantic
index
* [x] Determine why so many paths are often missing from the semantic
index
* we erroring out if an embedding batch contained multiple texts that
were the same, which can happen if a worktree contains multiple copies
of the same text (e.g. a license).
Release Notes:
- N/A
---------
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle Kelley <rgbkrk@gmail.com>
Max Brunsfeld
,
Marshall
,
Nathan
,
Kyle
, and
Kyle Kelley
created
This PR adds a new tool to the `assistant2` crate that allows the
assistant to create a new buffer with some content.
Release Notes:
- N/A
---------
Co-authored-by: Nathan <nathan@zed.dev>
Marshall Bowers
and
Nathan
created
ada2791
editor: Move code actions menu closer to the indicator when it is deployed via click (#11214)
713c314
Clean up doc comments on `LanguageModelTool` trait (#11217)
Click to expand commit body
This PR cleans up the doc comments on the `LanguageModelTool` trait to
follow Rust documentation conventions.
Release Notes:
- N/A
Marshall Bowers
created
e3de440
assistant2: Restructure tools in preparation for adding more (#11213)
Click to expand commit body
This PR does a slight restructuring of how tools are defined in the
`assistant2` crate to make it more amenable to adding more tools in the
near future.
Release Notes:
- N/A
Marshall Bowers
created
d743c19
Add script to package Linux binary into archive (#11165)
Click to expand commit body
Release Notes:
- N/A
Thorsten Ball
created
73d0600
project: Set completion to undocumented if text empty (#11207)
Click to expand commit body
I think the previous code was missing a `return` in there because it
always overwrote the `completion.documentation` field, even if the
`text.is_empty()` is true.
Release Notes:
- N/A
Thorsten Ball
created
f96cab2
Add avatar support for codeberg in git blame (#10991)
Click to expand commit body
Release Notes:
- Added support for avatars in git blame for repositories hosted on
codeberg
<img width="1144" alt="Screenshot 2024-04-25 at 16 45 22"
src="https://github.com/zed-industries/zed/assets/43210583/d44770d8-44ea-4c6b-a1c0-ac2d1d49408f">
Questions:
- Should we move git stuff like `Commit`, `Author`, etc outside of
hosting-specific files (I don't think so, as other hostings can have
different stuff)
- Should we also add support for self hosted forgejo instances or should
it be a different PR?
Stanislav Alekseev
created
8152e06
Allow triggering preview and stable simultaneously (#11201)
Click to expand commit body
Release Notes:
- N/A
Conrad Irwin
created
62c12cd
Reduce frequency of workspace save (#11183)