20f37f0
chore: Change git deps to crates.io dependencies where possible (#12362)
Click to expand commit body
Release Notes:
- N/A
Piotr Osiewicz
created
a6dd2ca
Allow saving prompts from the Prompt Manager (#12359)
Click to expand commit body
Adds the following features to the prompt manager:
- New prompt – Create a new prompt from the UI. It will only persist if
it is saved.
- Save prompt – Save a prompt by clicking the save button in the UI. A
keybinding will be added for this in the future.
- Reveal prompt - Show the selected prompt on the file system. Only
available for saved prompts.
New prompts that are saved will use the
`{slugified_title}_{ver}_{id}.md` format which all imported prompts will
move to in the near future.
Also orders prompts in alphabetical order by default.
Release Notes:
- N/A
Nate Butler
created
345361c
json: Register tasks on Rust side and not via tasks.json (#12345)
Click to expand commit body
/cc @RemcoSmitsDev new task indicators weren't showing for me in JSON
files.
`tasks.json` of native grammars is not being read by anything by
default, so we tend to register tasks as Rust structs, foregoing the
deserialization step. This doesn't apply to tasks registered in
extensions, which have to have tasks.json.
Release Notes:
- N/A
Piotr Osiewicz
created
e19339b
Allow UI font weight to be assigned in settings (#12333)
Click to expand commit body
Release Notes:
- Added the ability to configure the weight of your UI font in standard
CSS weight units from 0 to 900.
Nathan Sobo
created
6276281
linux: Fix IBus in vim mode and some compose state fixes (#12299)
Click to expand commit body
Release Notes:
- N/A
Fixes #12198 and some minor fixes:
* IBus was intercepting normal keys like `a`, `k` which caused some
problems in vim mode.
* Wayland: Trying to commit the pre_edit on click wasn't working
properly, should be fixed now.
* X11: The pre_edit was supposed to be cleared when losing keyboard
focus.
* X11: We should commit the pre_edit on click.
---------
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
a84344a
linux: Get the color scheme through xdg-desktop-portal (#11926)
Click to expand commit body
The method has been tested on:
- Gnome 46 (Working)
- Gnome 40 (Not supported)
Tasks
- [x] Implements a draft which get and provides the user theme to
components which needs it
- [x] Implements a way to call the callback function when the theme is
updated
- [X] Cleans the code
Release notes:
- N/A
citorva
created
b1cfd46
Fix ctrl click to open file on windows (#12294)
Click to expand commit body
There were two issues:
1. the `ModifiersChanged` event was never emitted on windows.
macOS, x11 and wayland have separate events for this, while on windows
they are sent via the usual `keyup` and `keydown` events, but
`parse_keydown_msg_keystroke` just ignored them.
2. the word segmenting regex didn't include '\' so paths weren't
correctly detected
fixes https://github.com/zed-industries/zed/issues/12321
Release Notes:
- N/A
Jakob Hellermann
created
e54455b
Call `OleInitialize` to fix `DirectWrite` in `TestPlatform` on windows (#12289)
Click to expand commit body
Running the tests on windows currently fails for every gpui test using
the `TestPlatform` with
```rs
called `Result::unwrap()` on an `Err` value: CoInitialize has not been called. (0x800401F0)
```
trying to call `CoCreateInstance`in the `DirectWriteComponent`.
The `WindowsPlatform` calls
[`OleInitialize`](https://learn.microsoft.com/de-de/windows/win32/api/ole2/nf-ole2-oleinitialize)
which internally calls `CoInitializeEx` so I just copied that to the
`TestPlatform`.
Release Notes:
- N/A
Jakob Hellermann
created
9cc5ba8
windows: Make "Reveal in Finder" always open the file explorer (#12207)
Click to expand commit body
At the current moment, the "Reveal in Finder" behavior on Windows
"opens" the file using direct execution. This causes files to be opened
with whatever software they are associated with (i.e. will open Sublime
Text instead of the file explorer).
Release Notes:
- Fixed "Reveal in Finder" on Windows to open with the File Explorer.
The new behavior always opens the file explorer with the target
folder/file pre-selected.
https://github.com/zed-industries/zed/assets/28355157/b8ba471d-2f5b-4529-90c3-4dc59f308b99
Robert Borghese
created
9e3a182
docs: Add an entry for msys2 package (#12287)
Click to expand commit body
a package for Zed is now avialable in msys2 repository so let the users
know about it. [package
page](https://packages.msys2.org/base/mingw-w64-zed)
Release Notes:
- N/A
starting with v0.1.7, winapi-util switched to windows-sys crate. this
small update will reduce dependence from winapi crate
Release Notes:
- N/A
Maksim Bondarenkov
created
8e07fd2
Update time crate to fix compilation error (#12189)
Click to expand commit body
run `cargo update --package time` due to
https://github.com/time-rs/time/issues/681
Release Notes:
- N/A
Jakob Hellermann
created
d8605c8
x11: Implement various window functions (#12070)
Click to expand commit body
This (mostly) allows the CSD added in
https://github.com/zed-industries/zed/pull/11525 to work in X11. It's
still a bit buggy as it detects a second window drag right after the
first one finishes, but it's probably better to change the way window
drags are detected in the title bar itself (as that causes other
issues).
The CSD can be tested by changing the return value of
`should_render_window_controls` to true.
Also fixes F11 crashing.
Release Notes:
- N/A
apricotbucket28
created
c0259a4
windows: Slightly improve font rendering quality (#12015)
Click to expand commit body
Upper before this PR, lower after.

This PR manually applies a MSAA to the font atlas. Before this PR, the
font may seem aliased ( espeacially on low DPI monitors ), that's
because `DirectWrite` and `CoreText` ( on which currently `Zed` built
the whole text system ) uses different anti-aliasing strategy. The
different anti-aliasing approach used by `DirectWrite` and `CoreText`:

The upper is `VSCode` font rendering result, middle `macOS`, lower this
PR ( pic captured with same font face, same font size, same DPI, same
physical resolution, same editor theme, and same magnification rate ).
This PR brings a quality similiar to `CoreText`. What's more, from the
`VSCode` image, you can see how `DirectWrite` sub-pixel anti-aliasing is
performed on the edge of the glyph. Can we achieve the same rendering
quality? Currently, No. `Zed` use a grayscale image to render glyph, and
a sub-pixel anti-aliasing `DirectWrite` requires all RGB channels and
the foreground color of the rendering glyph, which `Zed` dose not
provide.
So, to achieve the quality of `VSCode` font rendering, the text system
of `Zed` needs much much more efforts to refactor the codes.
Release Notes:
- N/A
Release Notes:
- Improved expand excerpt indicators to allow unidirectional expansion.
Also added the `editor::ExpandExcerptsUp` and
`editor::ExpandExcerptsDown` actions, which can both take a `lines`
parameter. Also added a `expand_excerpt_lines` setting which controls
the default number of lines that the indicators and actions use.
---------
Co-authored-by: conrad <conrad@zed.dev>
Mikayla Maki
and
conrad
created
a0f9129
task: Do not wrap custom task variables in braces (#12322)
Implemented runnables for specially for running tests for Go.
I'm grateful for your feedback because this is my first experience with
Rust and Zed codebase.

https://github.com/zed-industries/zed/assets/1047345/ae1abd9e-3657-4322-9c28-02d0752b5ccd
Release Notes:
- Added Runnables/Tasks for:
- Run test functions which start with "Test"
- Run subtests
- Run benchmark tests
- Run main function
---------
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Anıl Şenay
,
Thorsten Ball
, and
Piotr Osiewicz
created
5665cad
json: Add runnable for `package.json` and `composer.json` scripts (#12285)
Click to expand commit body
**Package.json**
https://github.com/zed-industries/zed/assets/62463826/f8ca12a5-1292-4465-83e1-3c2ab65f5833
**Composer.json**
https://github.com/zed-industries/zed/assets/62463826/61f9e74d-c6ed-4329-855b-d0161e0a117b
Release Notes:
- Added runnable for `package.json` and `composer.json` scripts
([#12215](https://github.com/zed-industries/zed/issues/12215)).
Remco Smits
created
a1e5b12
Fix some warnings/issues uncovered by the new cfg checking (#12310)
Click to expand commit body
Rust recently got the ability to check for typos or errors in `cfg`
attributes: https://blog.rust-lang.org/2024/05/06/check-cfg.html
This PR fixes the new warnings.
- gpui can be run with `RUSTFLAGS="--cfg gles"`, make this explicit in
`[workspace.lints.rust]`
- `cfg!(any(test, sqlite))` was just a bug, it should be
`feature(sqlite)`
- the `languages` crate had a `#[cfg(any(test, feature =
"test-support"))]` function without ever declaring the `test-support`
feature
- the `MarkdownTag` enum had a `cfg_attr` for serde without actually
having serde support
Now the only warnings when building are unused fields
`InlayHover.excerpt`, `SavedConversationMetadata.path` ,
`UserTestPlan.allow_client_reconnection` and `SyntaxMapCapture.depth`.
Release Notes:
- N/A
Jakob Hellermann
created
78aaa29
assistant: Replace an `expect` with a precondition check (#12292)
Click to expand commit body
This PR replaces an `expect` with a precondition check to avoid a panic
if the `LspAdapterDelegate` isn't set when invoking a slash command.
Release Notes:
- N/A
Marshall Bowers
created
8450d63
Remove potential crash when missing worktrees (#12291)
Click to expand commit body
This PR removes a potential crash when there are no worktrees in the
project.
Present on Nightly only.
Release Notes:
- N/A
Marshall Bowers
created
ace371a
node_runtime: Restrict the `windows` dependency to the Windows target (#12284)
Click to expand commit body
This PR fixes an issue where the `windows` dependency was being included
on non-Windows targets.
Resolves https://github.com/zed-industries/zed/issues/12282.
Release Notes:
- N/A
This PR updates the Ruby docs with a note on how to switch to using
`ruby-lsp`.
Release Notes:
- N/A
Marshall Bowers
created
5213f62
docs: Add tweaks to the "Remote development" page (#12267)
Click to expand commit body
Mostly tiny stuff. Quick run-down of the changes:
- Using `*Note*` instead of `NOTE` for the blockquote callouts
(piggybacking from https://github.com/zed-industries/zed/pull/11724)
- Use hyphens for bullet lists instead of asterisks
- Capitalize every (applicable) mention to Zed
- Capitalize mentions of other products (e.g., google cloud → Google
Cloud)
- Swap e.g. → for example — for clarity (latinisms may be unfamiliar for
some non-native English speakers, surprisingly!)
Release Notes:
N/A
Danilo Leal
created
e5085df
lsp: explicitly drop locks in handle_input (#12276)
Click to expand commit body
Due to lifetime extension rules, we were holding onto the request
handler map mutex during parsing of the request itself. This had no
grand repercussions; it only prevented registering a handler for next
request until parsing of the previous one was done.
Release Notes:
- N/A
Piotr Osiewicz
created
32f11df
Use language settings' prettier parsers as a fallback for files with no path (#12273)
Click to expand commit body
Follow-up of
https://github.com/zed-industries/zed/pull/12095#issuecomment-2123230762
reverting back part of https://github.com/zed-industries/zed/pull/11558
that was related to `language.toml` parsing.
Now all extensions that define `prettier_parser_name` in their language
configs, will enable formatting untitled buffers without any extra
language settings like
```json
{
"languages": {
"JSON": {
"prettier": {
"allowed": true,
"parser": "json"
}
}
}
}
```
Release Notes:
- Improved ergonomics of untitled buffer formatting with prettier, no
extra language settings are needed by default.
Prompts in the prompt library will be in A->Z order by default.
Release Notes:
- N/A
Nate Butler
created
f7a8696
Avoid holding worktree lock for a long time while updating large repos' git status (#12266)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/9575
Fixes https://github.com/zed-industries/zed/issues/4294
### Problem
When a large git repository's `.git` folder changes (due to a `git
commit`, `git reset` etc), Zed needs to recompute the git status for
every file in that git repository. Part of computing the git status is
the *unstaged* part - the comparison between the content of the file and
the version in the git index. In a large git repository like `chromium`
or `linux`, this is inherently pretty slow.
Previously, we performed this git status all at once, and held a lock on
our `BackgroundScanner`'s state for the entire time. On my laptop, in
the `linux` repo, this would often take around 13 seconds.
When opening a file, Zed always refreshes the metadata for that file in
its in-memory snapshot of worktree. This is normally very fast, but if
another task is holding a lock on the `BackgroundScanner`, it blocks.
### Solution
I've restructured how Zed handles Git statuses, so that when a git
repository is updated, we recompute files' git statuses in fixed-sized
batches. In between these batches, the `BackgroundScanner` is free to
perform other work, so that file operations coming from the main thread
will still be responsive.
Release Notes:
- Fixed a bug that caused long delays in opening files right after
performing a commit in very large git repositories.
Moved some things around so prompts now always have front-matter to
return, either by creating a prompt with default front-matter, or
bailing earlier on importing the prompt to the library.
In the future we'll improve visibility of malformed prompts in the
`prompts` folder in the prompt manager UI.
Fixes:
- Prompts inserted with the `/prompt` command now only include their
body, not the entire file including metadata.
- Prompts with an invalid title will now show "Untitled prompt" instead
of an empty line.
Release Notes:
- N/A
Nate Butler
created
461e7d0
Create a new directory when a new file ends with `/` (#12018)
Click to expand commit body
Release Notes:
- Made project panel to create directories when renaming into paths ending with `/`
Avinash Thakur
created
82f5f36
Allow defining slash commands in extensions (#12255)
Click to expand commit body
This PR adds initial support for defining slash commands for the
Assistant from extensions.
Slash commands are defined in an extension's `extension.toml`:
```toml
[slash_commands.gleam-project]
description = "Returns information about the current Gleam project."
requires_argument = false
```
and then executed via the `run_slash_command` method on the `Extension`
trait:
```rs
impl Extension for GleamExtension {
// ...
fn run_slash_command(
&self,
command: SlashCommand,
_argument: Option<String>,
worktree: &zed::Worktree,
) -> Result<Option<String>, String> {
match command.name.as_str() {
"gleam-project" => Ok(Some("Yayyy".to_string())),
command => Err(format!("unknown slash command: \"{command}\"")),
}
}
}
```
Release Notes:
- N/A
Marshall Bowers
created
055a13a
Allow clients to run Zed tasks on remote projects (#12199)
Click to expand commit body
Release Notes:
- Enabled Zed tasks on remote projects with ssh connection string
specified
---------
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Kirill Bulatov
and
Conrad Irwin
created
df35fd0
Show Delete shortcuts in project panel context menu (#12250)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/12234 by making both
default keymap and the menu `Delete` action declarations to have the
same `skip_prompt` value.
`Trash` action got more explicit `skip_prompt` declarations in this PR,
but those were the defaults already, so not changed.
Now, `Delete` action in the project panel will always show a prompt
before removing, both on the keystroke and menu item click.
To note, VSCode does skips prompt for the `Trash` action, so we might
want to change that too (later?), the PR does not alter it.
Release Notes:
- Shows Delete action binding keys in the project panel context menu
([12234](https://github.com/zed-industries/zed/issues/12234))
Kirill Bulatov
created
27229bb
tasks: Provide task variables from matching runnable ranges in task modal (#12237)
Click to expand commit body
In #12003 we found ourselves in need for precise region tracking in
which a given runnable has an effect in order to grab variables from it.
This PR makes it so that in task modal all task variables from queries
overlapping current cursor position.
However, in the process of working on that I've found that we cannot
always use a top-level capture to represent the full match range of
runnable (which has been my assumption up to this point). Tree-sitter
captures cannot capture sibling groups; we did just that in Rust
queries.
Thankfully, none of the extensions are affected as in them, a capture is
always attached to single node. This PR adds annotations to them
nonetheless; we'll be able to get rid of top-level captures in extension
runnables.scm once this PR is in stable version of Zed.
Release Notes:
- N/A
This PR adds the missing `lints.workspace` setting to the `assistant`
crate's `Cargo.toml`.
Release Notes:
- N/A
Marshall Bowers
created
8040e43
Extract `SlashCommand` trait from `assistant` (#12252)
Click to expand commit body
This PR extracts the `SlashCommand` trait (along with the
`SlashCommandRegistry`) from the `assistant` crate.
This will allow us to register slash commands from extensions without
having to make `extension` depend on `assistant`.
Release Notes:
- N/A
Fixes indent guides when using tabs,
Fixes: #12209, fixes #12210
Release Notes:
- N/A
Bennet Bo Fenner
created
414f97f
docs: Fix path to "configuring-zed" page in Python lang doc (#12233)
Click to expand commit body
Fix path to the `configuring-zed` page in Python language documentation.
Release Notes:
- N/A
Vitaly Slobodin
created
0eff1ea
task: Add ZED_DIRNAME and ZED_RELATIVE_FILE task variables (#12245)
Click to expand commit body
Release Notes:
- Added ZED_RELATIVE_FILE (path to current file relative to worktree
root) and ZED_DIRNAME (path to the directory containing current file)
task variables.
Piotr Osiewicz
created
b0d89d6
Fix jetbrains keymap alt-enter to do `search::SelectAllMatches` (#11951)
Click to expand commit body
The default keymap uses alt-enter for `SelectAllMatches` for `context:
BufferSearchBar`.
Jetbrains keymap uses alt-enter for `ToggleCodeActions` for `context:
Editor`.
When focusing on search bar, currently alt-enter does not perform
`SelectAllMatches`, whereas `ToggleCodeActions` is triggered instead,
because search bar's text input element has `context: Editor
mode=single_line`.
This PR restricts `ToggleCodeActions` to `Editor (full mode)` context to
allow `SelectAllMatches` to be triggered for alt-enter when the search
bar is active.
Release Notes:
- Fixed alt-enter with JetBrains keymap ignoring `search::SelectAllMatches` in certain contexts ([11840](https://github.com/zed-industries/zed/issues/11840))
Congyu
created
d116f3c
Use checked `str` slices in `Rgba::TryFrom<str>` (#12097)
70e8737
Allow information popovers while showing autocomplete suggestions (#12157)
Click to expand commit body
Allows information popovers to display while autocomplete suggestions
are also being displayed.
Before:
https://github.com/zed-industries/zed/assets/50590465/a61f0b4e-1521-42de-84fd-c5a3586b74ab
After:
https://github.com/zed-industries/zed/assets/50590465/ad2daae7-aebc-4c71-ad4c-f9d2deb6d0d0
Release Notes:
- Allow hover and completion popovers to appear at the same time ([12152](https://github.com/zed-industries/zed/issues/12152))
Release Notes:
- Preserve order of worktrees in project
([#10883](https://github.com/zed-industries/zed/issues/10883)).
- Enable drag-and-drop reordering for project worktrees
Note: worktree order is not synced during collaboration but guests can
reorder their own project panels.

---------
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Elliot Thomas
and
Kirill Bulatov
created
1e5389a
rust: Add runnable icon for `#[cfg(test)] mod tests` (#12017)
Click to expand commit body
This allows you to run all the tests inside the `mod tests` block.
Fixes #11967.
<img width="366" alt="Screenshot 2024-05-18 at 16 07 32"
src="https://github.com/zed-industries/zed/assets/62463826/01fc378c-1546-421d-8250-fe0227c1e5a0">
<img width="874" alt="Screenshot 2024-05-18 at 16 37 21"
src="https://github.com/zed-industries/zed/assets/62463826/4a880b91-df84-4917-a16e-5d5fe20e22ac">
Release Notes:
- Added runnable icon for Rust `#[cfg(test)] mod tests` blocks
([#11967](https://github.com/zed-industries/zed/issues/11967)).
Remco Smits
created
2177ee8
Highlight files ending in `mdwn` as Markdown (#12224)
Click to expand commit body
Highlight files ending in `mdwn` as Markdown.
(Ikiwiki uses `mdwn` as the file extension for Markdown.)
This pull request was inspired by this one:
- #1209/
Release Notes:
- Added ".mdwn" as a Markdown file extension.
Philip Durbin
created
3ec9469
Make reconnects smoother for dev servers (#12223)
Release Notes:
- vim: Added `]d/[d` for go to prev/next diagnostic
- vim: Added `]c/[c` to go to prev/next git change (`:diff` and
`:revert` show the diff and revert it)
- vim: Added `g cmd-d` for go to implementation