aa5113c
vim: Support paste with count (#11621)
Click to expand commit body
Fixes: #10842 Release Notes: - vim: Fix pasting with a count (#10842)
Conrad Irwin created
aa5113c
vim: Support paste with count (#11621)
Fixes: #10842 Release Notes: - vim: Fix pasting with a count (#10842)
Conrad Irwin created
bca639b
Use larger runners for Linux CI steps (#11574)
To speed up Linux CI builds, use a set of self-hosted Linux machines and use them to run all slow CI steps for Linux: "tests", bundling and nightly builds. Also adds a set of dev icons as Linux bundling script required them for `run-bundling`-tagged builds from regular PRs. Same icons as for Preview were used, but, ideally, something different could be created. Release Notes: - N/A
Kirill Bulatov created
bff1d8b
task: Allow obtaining custom task variables from tree-sitter queries (#11624)
From now on, only top-level captures are treated as runnable tags and the rest is appended to task context as custom environmental variables (unless the name is prefixed with _, in which case the capture is ignored). This is most likely gonna help with Pest-like test runners. Release Notes: - N/A --------- Co-authored-by: Remco <djsmits12@gmail.com>
Piotr Osiewicz and Remco created
95e246a
windows: Better dispatcher (#11485)
This PR leverages a more modern Windows API to implement `WindowsDispatcher`, aligning its implementation more closely with that of the `macOS` platform. The following improvements have been made: 1. Similar to `macOS`, there is no longer a need to use `sender` and `receiver` to dispatch a `Runnable` on the main thread. 2. There is also no longer a need to use an `Event` for synchronization. 3. Consistent with #7506 and #11269, `Runnable` is now executed with high priority. However, this PR raises the minimum Windows version requirement of `GPUI` to Windows 10, specifically Windows 10 Fall Creators Update (10.0.16299). However, the `alacritty_terminal` dependency in Zed relies on `conPTY` on Windows, an API introduced in the Windows 10 Fall Creators Update. Therefore, the impact of this PR on Zed should be minimal. I'd like to hear your voices about this PR, especially about the minimum Windows version bumping. Release Notes: - N/A
张小白 created
ba25e37
Fix scrollbar markers for folded code (#11625)
There're two errors in scrollbar markers in the presence of folded code: 1. Some markers are not displayed (when the marked row numbers are greater than the total displayed rows count after folding). 2. Code folding / unfolding doesn't trigger markers repainting. This PR fixes both problems. Release Notes: - Fixed scrollbar markers for folded code. The second problem (markers are repainted after I move the cursor, not after folding): https://github.com/zed-industries/zed/assets/2101250/57ed563d-186d-4497-98ab-d4f946416726
Andrew Lygin created
c73ef1a
assistant2: List saved conversations from disk (#11627)
This PR updates the saved conversation picker to use a list of conversations retrieved from disk instead of the static placeholder values. Release Notes: - N/A
Marshall Bowers created
8b5a0cf
vim: Fix e/E with inlay hints (#11616)
Co-Authored-By: Sergey <sergey.b@hey.com> Fixes: #7046 Release Notes: - vim: Fixes e/E with inlay hints (#7046) Co-authored-by: Sergey <sergey.b@hey.com>
Conrad Irwin and Sergey created
f0af508
Revert "chore: Bump taffy version to 0.4.3" (#11622)
Reverts zed-industries/zed#11606
Piotr Osiewicz created
5fe4070
docs: Fix copying code blocks (#11617)
This PR fixes copying code blocks in the docs. The problem was that some of the elements we removed from the base mdBook template were causing errors in the script, which prevented the right event listeners from being registered for the copy button. To remedy this, the elements have been restored, but are using `display: none` so that they don't appear in the UI. Resolves #11592. Release Notes: - N/A
Marshall Bowers created
981a143
copilot: Update root path on Windows (#11613)
This PR updates the root path used by Copilot to be a validate path when running on Windows. Release Notes: - N/A Co-authored-by: Jason Lee <huacnlee@gmail.com>
Marshall Bowers and Jason Lee created
5e06ce4
Add `zip` extract support for Windows (#11156)
Release Notes: - [x] Fixed install Node.js runtime and NPM lsp installation on Windows. - [x] Update Node runtime command to execute on Windows with no window popup. Ref #9619, #9424 --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Jason Lee and Marshall Bowers created
3bd53d0
chore: Bump taffy version to 0.4.3 (#11606)
Taffy 0.4 has been released 2 months ago. We've been using an older commit from their 0.4 development branch since November. Compared to the commit we were pinned to, the following relevant changes have been made: - https://github.com/DioxusLabs/taffy/commit/563d5dcee7b9138b4c3f865155d036a8b7597e65 - https://github.com/DioxusLabs/taffy/commit/64f8aa0fb114d939ca0d53ddc44045a03fde548d - https://github.com/DioxusLabs/taffy/commit/70b35712a2e79b6fdfef4cff4392ca94287cd0b1  Release Notes: - N/A
Piotr Osiewicz created
7653557
Task indicators in multibuffers (#11603)
Following #11487 the task indicators would no longer show up in multibuffers. Release Notes: - N/A
Piotr Osiewicz created
fdcedf1
editor: Do not show test indicators if a line is folded (#11599)
Originally reported by @RemcoSmitsDev Release Notes: - N/A
Piotr Osiewicz created
bd6d385
gpui: Pass Style by value to request_layout (#11597)
A minor thing I've spotted and decided to fix on the spot. It was being cloned twice within the body of that function (one of which was redundant even without this PR); now in most cases we go down from 2 clones to 0. Release Notes: - N/A
Piotr Osiewicz created
5df1481
Introduce a new `markdown` crate (#11556)
This pull request introduces a new `markdown` crate which is capable of parsing and rendering a Markdown source. One of the key additions is that it enables text selection within a `Markdown` view. Eventually, this will replace `RichText` but for now the goal is to use it in the assistant revamped assistant in the spirit of making progress. <img width="711" alt="image" src="https://github.com/zed-industries/zed/assets/482957/b56c777b-e57c-42f9-95c1-3ada22f63a69"> Note that this pull request doesn't yet use the new markdown renderer in `assistant2`. This is because we need to modify the assistant before slotting in the new renderer and I wanted to merge this independently of those changes. Release Notes: - N/A --------- Co-authored-by: Nathan Sobo <nathan@zed.dev> Co-authored-by: Conrad <conrad@zed.dev> Co-authored-by: Alp <akeles@umd.edu> Co-authored-by: Zachiah Sawyer <zachiah@proton.me>
Antonio Scandurra , Nathan Sobo , Conrad , Alp , and Zachiah Sawyer created
ddaaaee
docs: Fix a typo (#11588)
This PR fixes a typo in docs/src/development/debugging-crashes.md. Release Notes: - N/A
Doy Bachtiar created
9772b7a
windows: Fix `Zed` freezing when resuming from sleep (#11589)
It seems that on the first frame after the system resumes from sleep, `dcomp_vsync_fn` mistakenly detects the `timer_stop_event` triggering and exits the loop. Release Notes: - N/A
张小白 created
2e0811e
windows: Improve platform clipboard (#11553)
I thought platform clipboard should share one ctx. and fixed in vim mode, read from clipboard crash when using `unwrap`. Release Notes: - N/A
CharlesChen0823 created
1b292d2
Fix crash when the length of a line is greater than 1024 chars (#11536)
Close #11518 Release Notes: - N/A
张小白 created
adecbd1
Make Markdown default to `"format_on_save": "off"` (#11584)
This PR changes the Markdown language defaults to set `format_on_save`
to be `off`.
Prettier's Markdown formatting is a bit controversial for some people,
so we turn it off by default.
To restore the previous behavior, add the following to your settings:
```json
{
"languages": {
"Markdown": {
"format_on_save": "on"
}
}
}
```
Release Notes:
- Changed the default `format_on_save` behavior for Markdown files to be
`off`.
Marshall Bowers created
a7aa257
Implement serialization of assistant conversations, including tool calls and attachments (#11577)
Release Notes: - N/A --------- Co-authored-by: Kyle <kylek@zed.dev> Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld , Kyle , and Marshall created
24ffa0f
Don't panic on failure to allocate an AtlasTile (#11579)
Release Notes: - Fixed a panic in graphics allocation
Conrad Irwin created
b0494d1
Pass hover position as an anchor (#11578)
It's too easily to accidentally pass a point from one snapshot into another Release Notes: - Fixed a panic in show hover
Conrad Irwin created
a89dc8c
blade: Switch to linear color space (#11534)
Release Notes: - N/A ## What Addresses a long-standing issue of doing the blending operations in sRGB space. Currently, the input HSL colors are provided in sRGB space and converted to linear in the vertex shader. Conversion back to sRGB, which is required on most platforms today, happens at the very end of the pipeline when writing into sRGB render target. Note-1: in the future we may consider doing HSL -> sRGB -> Linear transform on CPU before feeding into shaders. However, I don't expect any significant difference here given that we are likely bound by fill rate and pixel shaders, anyway. Note-2: the graphics stack is programmed to detect if the platform supports presenting in linear color space and avoids converting to sRGB at the end in this case. However, on my Z13 laptop this isn't supported by the RADV driver. Closes #7684 Closes #11462 @jansol please confirm if you can! ## Comparison Screenshot of the Glazier theme before the change:  Same theme after the change: 
Dzmitry Malyshau created
d103903
Style header for assistant2 (#11570)
Release Notes: - N/A
Nate Butler created
ec3aabe
windows: Fix crash when saving files to disk (#11547)
closes #11544, sorry for introduce this issue by pre pr. Release Notes: - N/A
CharlesChen0823 created
4b98c35
windows: Let IME early return in vim mode (#11551)
This PR follows up #11387 , slightly changes the IME window behavior to match macOS implementation. Release Notes: - N/A
张小白 created
5103995
windows: Fix incorrect font rendering (#11545)
Previously, `DirectWrite` had been following the text system implementation on `macOS`, using the font's postscript name to differentiate between different font faces. However, I noticed occasional rendering issues, such as fonts incorrectly rendering as italics. Later, I discovered that on `Windows`, the postscript name is **not** unique. Surprisingly, even the same font can have different postscript names on macOS and Windows! It's hard to believe! The postscript name of a font face should be obtained from the same font table. Why would the same font face have different names? For example, the postscript name of ZedMono on `macOS` is `Zed-Mono-Bold-Extended-Italic`, while on `Windows`, it is `Zed-Mono-Extended`, missing weight and style information, leading to incorrect rendering. This PR introduces a `FontIdentifier` struct to uniquely identify font faces. Release Notes: - N/A
张小白 created
fb4c6db
windows: Implement `ResizeColumn` and `ResizeRow` cursor style (#11533)
This PR follows up #11406 Release Notes: - N/A
张小白 created
91c1716
Fix horizontal scrolling direction on Windows (#11520)
As per Microsoft documentation, positive values scroll right, not left. GPUI was incorrectly assuming it perfectly mirrored vertical scrolling. Fixes #11515 Release Notes: - N/A
LoganDark created
0933426
Editor tab bar settings (#7356)
This PR is another step to tabless editing (#6424, #4963). It adds
support for tab bar settings that allow the user to change its placement
or to hide completely.
Configuraton:
```json
"tab_bar": {
"show": true
}
```
Placemnet options are "top", "bottom" and "no".
This PR intentionally doesn't affect tab bars of other panes (Terminal
for instance) to keep code changes small. I guess we'll do the rest in
separate PRs.
Release Notes:
- Added support for configuring the editor tab bar (part of #6424,
#4963).
---------
Co-authored-by: Mikayla <mikayla@zed.dev>
Andrew Lygin and Mikayla created
689e4ae
Render messages as early as possible to show progress (#11569)
This shows "Researching..." as placeholder text as early as possible so that the user can see the model is working on reading/researching/etc. This also adds on an `Option<Value>` to the `render_running` function so that tools can hopefully render based on partially completed JSON (still to come). Release Notes: - N/A
Kyle Kelley created
dbebb40
linux: Store binary path before restart to handle deleted binary file (#11568)
This fixes restart after updates not working on Linux. On Linux we can't reliably get the binary path after an update, because the original binary was deleted and the path will contain ` (deleted)`. See: https://github.com/rust-lang/rust/issues/69343 We *could* strip ` (deleted)` off, but that feels nasty. So instead we save the original binary path, before we do the installation, then restart. Later on, we can also change this to be a _new_ binary path returned by the installers, which we then have to start. Release Notes: - N/A
Thorsten Ball created
d2cec02
Run windows CI on our own GH-hosted windows runner (#11567)
It's a 16-core runner. Release Notes: - N/A
Max Brunsfeld created
724acaa
v0.136.x dev
Joseph T. Lyons created
ffa2d90
Return prettier entry back to LSP logs (#11563)
Fixes prettier entries disappeared after https://github.com/zed-industries/zed/pull/10788 Release Notes: - N/A
Kirill Bulatov created
5c2ec17
docs: Fix default value for `formatter` setting (#11560)
This PR fixes the default value for the `formatter` setting listed in the docs. The default value is `"auto"`: https://github.com/zed-industries/zed/blob/194c43b84b4c2b0f2e78d8ef533bb99b6916f38c/assets/settings/default.json#L367 Resolves #11468. Release Notes: - N/A
Marshall Bowers created
2671b9c
Fix alignment of code actions menu with narrow panes
Piotr Osiewicz created
68fe2bb
Do away with display points in toggle_code_actions
Piotr Osiewicz created
65f7238
editor: Fix task indicator layout for wrapped lines
Piotr Osiewicz created
ca680f0
branch picker: Always show HEAD first (#11552)
I think this is a lot less confusing than another branch being selected by default when there's no query. Release Notes: - Changed the branch picker to always show the current branch as the default selected entry. https://github.com/zed-industries/zed/assets/1185253/18b50656-f6ac-4138-b4e0-9024072e1555
Thorsten Ball created
9d681bd
go: support highlight regexp (#11538)
Before: <img width="521" alt="image" src="https://github.com/zed-industries/zed/assets/45585937/7b87e552-0cf0-4168-933f-21d1ae84bf64"> After: <img width="499" alt="image" src="https://github.com/zed-industries/zed/assets/45585937/f1171375-8c22-4186-a5f1-1bdfa56cf01f"> Release Notes: - Added go regexp highlighting
d1y created
1669ff8
editor: Fix menu::Confirm falling through to editor when confirming task entry in code actions (#11546)
Release Notes: - N/A
Piotr Osiewicz created
45aca34
Take local project settings into account when launching terminals (#11526)
Fixes #7599 Use project level settings if possible, when creating terminals. Release Notes: - Fixed terminals ignoring project-specific settings ([7599](https://github.com/zed-industries/zed/issues/7599))
LoganDark created
07942bb
Editor: Do not display code actions in task gutter menu if they belong to different line (#11506)
This doesn't address the focus issues we saw with @maxbrunsfeld yet. Release Notes: - N/A
Piotr Osiewicz created
47c12c6
Make `prefer_line` the default soft-wrap behavior. (#11542)
Stops lines from clipping at 1024 by default, returning it to the old default behaviour where it wraps at 512. The `none` mode is only supposed to be used for git hunks. See https://github.com/zed-industries/zed/issues/11518#issuecomment-2099836283. Release Notes: - N/A
Owen Law created
63a5f46
Remember window restore size (#10429)
Now, regardless of how the Zed window is closed, Zed can remember the window's restore size. - [x] Windows implementation - [x] macOS implementation - [x] Linux implementation (partial) - [x] update SQL data base (mark column `fullscreen` as deprecated) The current implementation on Linux is basic, and I'm not sure if it's correct. The variable `fullscreen` in SQL can be removed, but I'm unsure how to do it. edit: mark `fullscreen` as deprecated ### Case 1 When the window is closed as maximized, reopening it will open in the maximized state, and returning from maximized state will restore the position and size it had when it was maximized. https://github.com/zed-industries/zed/assets/14981363/7207752e-878a-4d43-93a7-41ad1fdb3a06 ### Case 2 When the window is closed as fullscreen, reopening it will open in fullscreen mode, and toggling fullscreen will restore the position and size it had when it entered fullscreen (note that the fullscreen application was not recorded in the video, showing a black screen, but it had actually entered fullscreen mode). https://github.com/zed-industries/zed/assets/14981363/ea5aa70d-b296-462a-afb3-4c3372883ea3 ### What's more - As English is not my native language, some variable and struct names may need to be modified to match their actual meaning. - I am not familiar with the APIs related to macOS and Linux, so implementation for these two platforms has not been done for now. - Any suggestions and ideas are welcome. Release Notes: - N/A
张小白 created
6ddcff2
Show annotations more like the inline assistant (#11530)
* compute gutter width * show the AI icon * borders, background, and text color for annotations <img width="1840" alt="image" src="https://github.com/zed-industries/zed/assets/836375/93f2e9b8-d7f7-4c25-b3e2-cf77a0c4ca36"> Release Notes: - N/A
Kyle Kelley created
1cf40d7
Supermaven enhanced (#11521)
Fixes #11422 by accepting just the start of the line. Release Notes: - N/A --------- Co-authored-by: max <max@zed.dev> Co-authored-by: jacob <jacob@supermaven.com>
Kyle Kelley , max , and jacob created