Commit log

54226b2 Bump to 0.139.2 for @osiewicz

Zed Bot created

301b01a Bump to 0.139.1 for @osiewicz

Zed Bot created

a678dad Fixed default LSP default settings for `JavaScript`, `TypeScript` & `TSX` (#12716)

Click to expand commit body
Fixed the default LSP settings for `JavaScript`, `TypeScript` & `TSX`,
correcting the "rest" value from `".."` to `"..."`.

Release Notes:
- N/A

Chung Wei Leong created

e398772 v0.139.x preview

Joseph T Lyons created

8682848 Bump alacritty to fix some file descriptor yuck (#12687)

Click to expand commit body
https://github.com/alacritty/alacritty/pull/7996

Release Notes:

- Fixed a crash caused by bad file descriptor lifetime handling.

Conrad Irwin created

6bbe9a2 Polish prompt library some more (#12686)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

7a05db6 Cancel inline assist editor on blur if it wasn't confirmed (#12684)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

3587e97 Support wrapping and hard newlines in inline assistant (#12683)

Click to expand commit body
Release Notes:

- Improved UX for the inline assistant. It will now automatically wrap
when the text gets too long, and you can insert newlines using
`shift-enter`.

Antonio Scandurra created

a96782c Allow using the inline assistant in prompt library (#12680)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

0289c31 editor: Render boundary whitespace (#11954)

Click to expand commit body
![image](https://github.com/zed-industries/zed/assets/1240491/3dd06e45-ae8e-49d5-984d-3d8bdf98d983)

Added support for only rendering whitespace that is on a
boundary, the logic of which is explained below:

- Any tab character
- Whitespace at the start and end of a line
- Whitespace that is directly adjacent to another whitespace


Release Notes:

- Added `boundary` whitespace rendering option
([#4290](https://github.com/zed-industries/zed/issues/4290)).




---------

Co-authored-by: Nicholas Cioli <nicholascioli@users.noreply.github.com>

Nicholas Cioli and Nicholas Cioli created

63a8095 Revert "Fix a bug where the IME pre-edit would desync from Zed (#12651)" (#12678)

Click to expand commit body
This reverts commit 1a0708f28cf302a0fe726a82b8cba63b839076cb since after
that, default task-related keybindings (alt-t and alt-shift-t) started
to leave `†` and `ˇ` symbols in the text editors before triggering
actions.


Release Notes:

- N/A

Kirill Bulatov created

1768c0d Do not occlude terminal pane by terminal element (#12677)

Click to expand commit body
Release Notes:

- Fixed file drag and drop not working for terminal

Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created

27e9c68 Autocomplete commands that don't require access to workspace in prompt library (#12674)

Click to expand commit body
This is useful to autocomplete prompts when writing a new one in the
prompt library.

Release Notes:

- N/A

Antonio Scandurra created

ad2ddf1 Omit clickable hunks when git hunks are disabled in the gutter (#12671)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/12644 

https://github.com/zed-industries/zed/pull/12425 fixes the issue so that
clicks are never reaching the hunks' hitboxes in such case, this PR
actually removes those hitboxes.
Hunks can still be toggled via the action.

Release Notes:

- N/A

Kirill Bulatov created

d6e271c Add note about auto-updating on Linux (#12662)

Click to expand commit body
Release Notes:

- N/A

Owen Law created

da29e33 Auto updater disabler (#12660)

Click to expand commit body
Supersedes https://github.com/zed-industries/zed/pull/12659
Fixes https://github.com/zed-industries/zed/issues/12588

One of Zed's core features is our collaboration software. As such, it is
important that we notify the user when their RPC protocol is out of
date, and how to update it. This PR adds a mechanism to replace the
existing auto updater with a message explaining how to update Zed for
this environment.

Release Notes:

- N/A

Mikayla Maki created

3fd118f html_to_markdown: Remove unused examples (#12658)

Click to expand commit body
This PR removes the unused `examples` from the `html_to_markdown` crate.

I was just using these to dogfood the parsing initially, but now that
it's wired up in the Assistant, the examples are no longer useful.

Release Notes:

- N/A

Marshall Bowers created

27beb9e Update linux binary expectations (#12622)

Click to expand commit body
Fixes #12585

This changes the expectations for installed binaries on linux based on
work
that @jirutka has done for Alpine.

In particular, we now put the cli in place as `bin/zed` and the zed
binary as
`libexec/zed-editor`, and assume that packagers do the same.

cc @someone13574

Release notes:

- N/A

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

c7d5630 Always open the project panel for dev server projects (#12654)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

74cb92f vue: Bump to v0.0.3 (#12656)

Click to expand commit body
This PR bumps the Vue extension to v0.0.3.

Changes:

- #11482

Release Notes:

- N/A

Marshall Bowers created

8a659b0 Implement Indent & Outdent as operators (#12430)

Click to expand commit body
Release Notes:

- Fixes [#9697](https://github.com/zed-industries/zed/issues/9697).

Implements `>` and `<` with motions and text objects.
Works with repeat action `.`

Paul Eguisier created

25050e8 vue: Improve syntax highlighting (#11482)

Click to expand commit body
close #8989

Before:

<img width="690" alt="image"
src="https://github.com/zed-industries/zed/assets/45585937/02b6f703-d54a-4e08-82f8-4ed624f37a64">

After:

<img width="571" alt="image"
src="https://github.com/zed-industries/zed/assets/45585937/9abd39d0-c4e8-426e-b0d8-62e26090332a">


Release Notes:

- Improve vue highlighting

d1y created

2d94796 Make HTML to Markdown conversion more pluggable (#12653)

Click to expand commit body
This PR overhauls the HTML to Markdown conversion functionality in order
to make it more pluggable. This will ultimately allow for supporting a
variety of different HTML input structures (both natively and via
extensions).

As part of this, the `rustdoc_to_markdown` crate has been renamed to
`html_to_markdown`.

The `MarkdownWriter` now accepts a list of trait objects that can be
used to drive the conversion of the HTML into Markdown. Right now we
have some generic handler implementations for going from plain HTML
elements to their Markdown equivalents, as well as some rustdoc-specific
ones.

Release Notes:

- N/A

Marshall Bowers created

1c61747 Allow restarting remote language servers (#12652)

Click to expand commit body
Release Notes:

- Added the ability to restart the remote language servers when
collaborating

Conrad Irwin created

1a0708f Fix a bug where the IME pre-edit would desync from Zed (#12651)

Click to expand commit body
fixes #11829 

In https://github.com/zed-industries/zed/pull/7494, we introduced IME
event buffering, so that we could preempt the IME with a keystroke event
in some cases. However, this caused a desynchronization bug in long
multi-step IME composition, such as the pre-edit used in the Japanese
Romaji keyboard (and other languages). We found that this was due to the
IME issuing actions, and then immediately querying the editor's state
before we had applied those actions. Therefore, this PR removes IME
action buffering.

We have tested all of the cases in the `handle_key_event` documentation
and added a few of our own.

Release Notes:

- Fixed an issue where the IME pre-edit could desynchronize from the
editor on macOS
([#11829](https://github.com/zed-industries/zed/pull/12651))

---------

Co-authored-by: Jan Solanti <jhs@psonet.com>

Mikayla Maki and Jan Solanti created

62e7900 vcs_menu: Fix header taking up too much space (#12646)

Click to expand commit body
We've spotted a regression following
https://github.com/zed-industries/zed/pull/12468


![image](https://github.com/zed-industries/zed/assets/24362066/8e2659c7-50fe-4a09-af9d-d04416a66276)
This PR addresses that.
Release Notes:

- N/A

Co-authored-by: Bennet <bennet@zed.dev>

Piotr Osiewicz and Bennet created

c5b22ee Polish prompt library UX (#12647)

Click to expand commit body
This could still use some improvement UI-wise but the user experience
should be a lot better.

- [x] Show in "Window" application menu
- [x] Load prompt as it's selected in the picker
- [x] Refocus picker on `esc`
- [x] When creating a new prompt, if a new prompt already exists and is
unedited, activate it instead
- [x] Add `/default` command
- [x] Evaluate /commands on prompt insertion
- [x] Autocomplete /commands (but don't evaluate) during prompt editing
- [x] Show token count using the settings model, right-aligned in the
editor
- [x] Picker 
- [x] Sorted alpha
- [x] 2 sublists
    - Default
        - Empty state: Star a prompt to add it to your default prompt
        - Otherwise show prompts with star on hover
    - All
        - Move prompts with star on hover

Release Notes:

- N/A

Antonio Scandurra created

e4bb666 assistant: Add `/fetch` slash command (#12645)

Click to expand commit body
This PR adds a new `/fetch` slash command to the Assistant for fetching
the content of an arbitrary URL as Markdown.

Currently it's just using the same HTML to Markdown conversion that
`/rustdoc` uses, but I'll be working to refine the output to be more
widely useful.

Release Notes:

- N/A

Marshall Bowers created

910f668 php/elixir: Bump extensions versions to 0.0.6 and 0.0.5 (#12636)

Click to expand commit body
Includes:
- https://github.com/zed-industries/zed/pull/12526
- https://github.com/zed-industries/zed/pull/11879
- https://github.com/zed-industries/zed/pull/12467

Release Notes:

- N/A

Piotr Osiewicz created

8e79609 editor: Cancel ongoing completion requests more eagerly (#12630)

Click to expand commit body
Previously, we were:
- cancelling previous requests only after the latest one has completed
- always running the debounced documentation resolution to completion,
even when we had no need for it.

In this commit, we drop the ongoing completion requests as soon as the
new one is fired.
Fixes #5166 

Release Notes:

- Improved performance and reliability of completions in large
Typescript projects

Co-authored-by: Bennet Bo <bennet@zed.dev>

Piotr Osiewicz and Bennet Bo created

47122a3 Fix excluded file creation (#12620)

Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/10890

* removes `unwrap()` that caused panics for text elements with no text,
remaining after edit state is cleared but project entries are not
updated, having the fake, "new entry"
* improves discoverability of the FS errors during file/directory
creation: now those are shown as workspace notifications
* stops printing anyhow backtraces in workspace notifications, printing
the more readable chain of contexts instead
* better indicates when new entries are created as excluded ones


Release Notes:

- Improve excluded entry creation workflow in the project panel
([10890](https://github.com/zed-industries/zed/issues/10890))

Kirill Bulatov created

edd6130 linux watcher (#12615)

Click to expand commit body
fixes https://github.com/zed-industries/zed/issues/12297
fixes https://github.com/zed-industries/zed/issues/11345

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>

Conrad Irwin and Max created

3cd6719 Fix issues with Claude in Assistant2 (#12619)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Nathan <nathan@zed.dev>

Mikayla Maki and Nathan created

afc0650 Paginate through extensions from the blob store (#12614)

Click to expand commit body
This PR updates the background task used to fetch extensions from the
blob store to account for the possibility that the result set will be
paginated.

Will now paginate through all of the results and collect them up before
proceeding to determining which extensions need to be synced.

Release Notes:

- N/A

Marshall Bowers created

14c2fab assistant: Allow `/rustdoc` to use local docs (#12613)

Click to expand commit body
This PR updates the `/rustdoc` slash command to use local docs built
with `cargo doc`.

If the docs for a particular crate/module are available locally, those
will be used. Otherwise, it will fall back to retrieving the docs from
`docs.rs`.

The placeholder output for the slash command will indicate which source
was used for the docs:

<img width="289" alt="Screenshot 2024-06-03 at 4 13 42 PM"
src="https://github.com/zed-industries/zed/assets/1486634/729112e4-80ca-4f08-bdb3-88fc950351c3">

Release Notes:

- N/A

Marshall Bowers created

c752763 Remove default language settings that are provided by extensions (#12612)

Click to expand commit body
This PR removes some default language settings that are now provided by
their respective extensions.

In #10296 we added the ability for the language configuration within
extensions to provide certain language settings (e.g., `tab_size`).

New versions of the extensions have been published that take advantage
of that and have been in circulation for over a month now. To that end,
we no longer need these settings provided as defaults.

Release Notes:

- N/A

Marshall Bowers created

2f65c3c Disable `vtsls` by default (#12611)

Click to expand commit body
This PR adds default settings to disable `vtsls` by default so that
there aren't multiple TypeScript language servers running.

I also renamed the language server from `vtsls-language-server` to just
`vtsls`, since the `-language-server` suffix was redundant.

Release Notes:

- N/A

Marshall Bowers created

959f0dc Fix terminal key bindings (#12558)

Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/12556

Only changed the keymap on Linux since I'm not sure if the behaviour is
correct on macOS

Release Notes:

- N/A

apricotbucket28 created

be2df79 gpui: Handle null string pointer in `window::insert_text` (#12446)

Click to expand commit body
`[NSString UTF8String]` sometimes returns null (it's documented as
such), and when it does, zed crashes in `window::insert_text`. I'm
running into this sometimes when using alt-d to delete forward. It
usually only happens with multiple cursors, but sometimes with a single
cursor. It *might* only happen when using the "Unicode Hex Input"
keyboard 'Input Source' (which I started using to avoid entering weird
characters in zed when using emacs meta keybindings that I haven't
defined in zed).

When using the US English input source, alt-d always results in a call
to `insert_text`. When using the Unicode Hex Input source it usually
doesn't, but when it does `text.UTF8String()` returns null. `text` isn't
null. `[text length]` returns 1. `[text characterAtIndex: 0]` seems to
always return `56797` (an undefined utf-16 codepoint).

Release Notes:

- Fixed crash on mac when deleting with alt-d

Sean Billig created

344e5e1 wayland: Fix window bounds restoration (#12581)

Click to expand commit body
Fixes multiple issues that prevented window bounds restoration to not
work on Wayland.

Note: Since the display uuid depends on the `wl_output.name` field, this
only works properly on KDE 5.26+ or Gnome 44+ ([kwin
commit](https://github.com/KDE/kwin/commit/330a02d862329893957532f46655c52c755f3731),
[mutter](https://github.com/GNOME/mutter/commit/7e838b1115f195ba4c7b06169ade3407d29c66d0)).

Release Notes:

- N/A

apricotbucket28 created

ed86b86 cosmic_text: Handle variation selectors; fix emoji colors (#12587)

Click to expand commit body
Basically, we detect if a glyph is a variation selector if its `id` is 3
(i.e. a whitespace character) and if it comes from an emoji font (since
variation selectors are only used for emoji glyphs).

- Fixes https://github.com/zed-industries/zed/issues/11703 and
https://github.com/zed-industries/zed/issues/12022

Release Notes:

- N/A

apricotbucket28 created

726f23e Add !vimwaiting to togglecomment (#12552)

Click to expand commit body
Release Notes:
-Fixed #12483 
It turns out to be very simple. `fg` has conflict with `gc` mapping so
when you type g editor state is pending.

xzbdmw created

b1efea1 typescript: Add support for VTSLS (#12606)

Click to expand commit body
You can opt into using VTSLS instead of typescript-language-server by
pasting the following snippet into your settings:
```
  "languages": {
    "TSX": {
      "language_servers": [
        "!typescript-language-server",
        "vtsls-language-server"
      ]
    }
  },
```

Related to: #5166 
Release Notes:

- Added support for using [vtsls](https://github.com/yioneko/vtsls)
language server for Typescript/Javascript.

Piotr Osiewicz created

2b21c89 Fix XI2 Scrolling Issue (#12603)

Click to expand commit body
ref #11679
https://github.com/zed-industries/zed/pull/11235#issuecomment-2144727144

Filters leave events to ensure they are in the normal notify leave
events (not grab or ungrab)
([spec](https://www.x.org/releases/X11R7.7/doc/inputproto/XI2proto.txt)).
Confirmed to fix the issue @mrnugget was having.

Release Notes:

- linux: Fixed a regression that caused some X11 input devices being
unable to scroll.

Owen Law created

d0fa012 Support formatting unsaved buffers with external formatter (#12597)

Click to expand commit body
Closes #4529


https://github.com/zed-industries/zed/assets/53836821/b84efd5e-89da-4ff7-9a29-2b2f7285d427

Release Notes:

- Added ability to format unsaved buffers with external formatters
([#4529](https://github.com/zed-industries/zed/issues/4529))

Bennet Bo Fenner created

338df5d linux/x11: Ignore bounds.origin on resize event (#12604)

Click to expand commit body
This fixes #11236 by ignoring the `bounds.origin` values when the window
is only being resized.

The cause for the issue was that the `ConfigureNotify` event would
contain "wrong" values when the window was being resized (by dragging a
corner).

In my case it would *always* contain x:14/y:49, which is I think might
map to the origin of the top bar in GNOME.

We would then persist these wrong values when serializing the workspace.
On restart, we'd use these values and end up with the window decorations
in the wrong place.

What I still don't know:
1. What exactly the 14/49 map to, because it's not the origin of the top
bar in GNOME. I also tried the X11 TranslateCoordinates call but
couldn't get meaningful results back (even taking scale factor into
account).
2. Why the window decorations end up looking wrong vs. the window being
in the first place. But if you look at my screenshot in #11236, it looks
like the decorations are off exactly by 14/49px.

That being said, I think the solution here is a good one for now: we
don't do an additional X11 call and when we're resizing, we're not
interested in the origin changing.



Release Notes:

- N/A

Proof:

[Screencast from 2024-06-03
15-08-36.webm](https://github.com/zed-industries/zed/assets/1185253/90efccfc-8ec6-42d2-8380-1625eff57805)

Thorsten Ball created

5f98b96 Start on a database-backed prompt library (#12468)

Click to expand commit body
Using the file system as a database seems like it's easy, but it's
actually a real pain. I'd like to use LMDB to store the prompts locally
so we have more control. We can always add an export option, but I want
the source of truth to be somewhere other than the file system.

So far, I have a PromptStore which is global to the application and can
be initialized on startup. Then there's a `PromptLibrary` which is
intended to be the root of a new kind of Zed window. I haven't actually
seen pixels yet, but I've sketched out the basics needed to create a new
prompt, save, etc.

Still lots to figure out but the foundations of being backed by a DB and
rendering in an independent window are in place.

/cc @iamnbutler @as-cii 

Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

18e2b43 task: Rebind UseSelectedQuery in modal to F2 (#12601)

Click to expand commit body
Also fix click handler for "Rerun last task".

Fixes #12580
Release Notes:

- Fixed click handler for "rerun last task" in task modal not working.
- Rebound "picker::UseSelectedQuery" from `opt-E` to `F2`.

Piotr Osiewicz created

5e3d85c json: Fix tsconfig.json schema overriding other schemas (such as keymap) (#12600)

Click to expand commit body
@mrnugget spotted that tsconfig.json schema is getting applied on
current Nightly. I've tracked it down to a misconfiguration of JSON
language server. Mea culpa.

No release note as that change has not went out to the public yet.

Release Notes:

- N/A

Piotr Osiewicz created

ae55d35 windows: Fix project prepare_ssh_shell to support setting PATH on Windows (#12370)

Click to expand commit body
Release Notes:

- N/A

Update to use `std::env::join_paths` to prepare `PATH` env.

Ref
https://github.com/zed-industries/zed/pull/12087#issuecomment-2122852384
@mrnugget

---------

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>

Jason Lee and Thorsten Ball created