da960ff
calls: Fix off by one in prompts for leaving a call. (#3649)
Click to expand commit body
We've noticed how leaving a call with multiple windows open would still
prompt with the popup along the lines of "Do you want to leave the
current call?". In Zed1, that popup only showed up when you've had just
one window open.
The code for prompting did not change at all between zed1 and zed2, but
the way we calculate the window count did. Calling AppContext::windows
to get all window handles from WindowContext::update essentially
excluded the window we were updating (that is the window being closed)
from the returned Vec of window handles. I've decided to keep the code
as close to original as possible (as the alternative would be to change
the \# of workspaces needed for a prompt to pop up). We now query the
window handles via a deref to AsyncAppContext, which does not exclude
"our" window handle from the returned results.
Release Notes:
- N/A
Header and footer are gonna be added in a separate PR as they require
changes to Picker trait that I feel are separate from the contents of
this PR.
Release Notes:
- N/A
Piotr Osiewicz
created
cfe7336
Return include warnings toggle to the diagnostics panel
Kirill Bulatov
created
3ad9677
Change project search bar flex axis to `column` (#3647)
Click to expand commit body
This PR changes project search bar's flex axis to `column`.
This fixes an issue where toggling the filters would cause the search
controls to center themselves vertically instead of staying next to the
search input.
Release Notes:
- N/A
Marshall Bowers
created
cd08d34
Quick and dirty attempt to immediately apply focus change in tests
4f196f6
Fix bugs in resizing the docks + Add debug styling (#3645)
Click to expand commit body
This PR:
- Fixes several bugs with dock resizing
- Adds a new drag move API for resizes
- Adds special debug styling for elements, including auto-opening Zed at
the element's location in source
- Changes the `cx.paint_quad()` API to take a type and adds several
helpers to create this type.
- Adds `()` as the empty element, and uses it to implement a derive
macro for the `Render` trait.
Release Notes:
- N/A
Mikayla Maki
created
d9adfde
Highlight email address field as red when invalid
- Cleans up modal state logic by using an enum over multiple booleans
- Simulates sending feedback in dev mode, so UI can be easily tested
Release Notes:
- N/A
Joseph T. Lyons
created
53b1948
Remove inconsistency with how GPUI used to handle these events
ceede28
Ensure the outer `ListItem` element has a unique ID (#3644)
Click to expand commit body
This PR fixes an issue where the outer `ListItem` element was using a
static ID instead of the one provided to the component.
Now that active states are fixed, this meant that any time there were
sibling list items they would share active states if one of them was
clicked.
Release Notes:
- N/A
Marshall Bowers
created
474f09c
Remove unneeded left-click filtering in `ListItem` (#3643)
Click to expand commit body
This PR removes the left-click filtering from the `on_click` handler for
`ListItem`s.
It's no longer needed after #3584.
Release Notes:
- N/A
057b235
Implement `VisibleOnHover` for `IconButton` (#3642)
Click to expand commit body
This PR implements the `VisibleOnHover` trait for `IconButton`s.
I noticed that in a lot of places we were wrapping an `IconButton` in an
extra `div` just so we could call `visible_on_hover` on it. By
implementing the trait on `IconButton` directly it allows us to avoid
the interstitial `div` entirely.
Release Notes:
- N/A
Marshall Bowers
created
15f62a4
Allowing dragging tabs onto panes and pane edges (#3641)
This PR adds a `.visible_on_hover` helper method that can be used to
make an element only visible on hover.
I noticed we were repeating this similar stanza in a bunch of different
spots:
```rs
some_element
.invisible()
.group_hover("", |style| style.visible())
```
so it seemed like a nice thing to factor out into a reusable utility.
Release Notes:
- N/A
This PR adds config files for running the Postgres instance for local
Zed development in a Docker Compose instance.
For those of us who don't like to have a Postgres install always present
on the host system 😄
Usage:
```
docker compose up -d
```
Release Notes:
- N/A
943acc5
Optimize inserting lots of primitives with the same `StackingOrder` (#3631)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
ee509e0
Rework `ListItem` and `ListHeader` to use slot-based APIs (#3635)
Click to expand commit body
This PR reworks the `ListItem` and `ListHeader` components to use
slot-based APIs, making them less opinionated about their contents.
Splitting this out of the collab UI styling PR so we can land it to
avoid conflicts.
Co-authored-by: Nate <nate@zed.dev>
Release Notes:
- N/A
This PR fixes an issue where the tab bar drop target was not receiving
any size.
The styling isn't 100% correct yet, as the updated background color has
a gap around it.
Release Notes:
- N/A