be2bf98
Show task summary in its terminal after it stops running (#10615)
Click to expand commit body
Based on https://github.com/alacritty/alacritty/issues/7795
Unknown error code commands (now includes the interrupted ones):

Successful command:

Unsuccessful command:

The "design", including wordings and special characters, is not final,
suggestions are welcome.
The main idea was to somehow distinguish the appended lines without
occupying extra vertical space.
Release Notes:
- Added task summary output into corresponding terminal tabs
This PR implements the Centered Layout feature (#4685):
- Added the `toggle centered layout` action.
- The centered layout mode only takes effect when there's a single
central pane.
- The state of the centered layout toggle is saved / restored between
Zed restarts.
- The paddings are controlled by the `centered_layout` setting:
```json
"centered_layout": {
"left_padding": 0.2,
"right_padding": 0.2
}
```
This allows us to support both the VSCode-style (equal paddings) and
IntelliJ-style (only left padding in Zen mode).
Release Notes:
- Added support for Centered Layout
([#4685](https://github.com/zed-industries/zed/pull/9754)).
https://github.com/zed-industries/zed/assets/2101250/2d5b2a16-c248-48b5-9e8c-6f1219619398
Related Issues:
- Part of #4382
This PR bumps the Zig extension to v0.1.1.
Changes:
- #10559
- #10634
Release Notes:
- N/A
Marshall Bowers
created
9470a52
lua: Fix broken LuaLS download on x64 (#10642)
Click to expand commit body
The changes in #10437 accidentally switched 'x64' to 'x86_64' which
breaks installs on linux x64, macos x64 and windows x64. This yields the
following error:
```
[2024-04-16T12:58:01-04:00 ERROR project] failed to start language server "lua-language-server": no asset found matching "lua-language-server-3.7.4-darwin-x86_64.tar.gz"
[2024-04-16T12:58:01-04:00 ERROR project] server stderr: Some("")
```
It's trying to download:
`lua-language-server-3.7.4-darwin-x86_64.tar.gz`
which should be
`lua-language-server-3.7.4-darwin-x64.tar.gz`
See [LuaLS release
page](https://github.com/LuaLS/lua-language-server/releases/tag/3.6.25).
CC: @maxbrunsfeld
lua.rs before ef4c70c:
https://github.com/zed-industries/zed/blob/c6028f665182403a035af193a3f27021f6e57c67/crates/languages/src/lua.rs#L35
lua.rs after:
https://github.com/zed-industries/zed/blob/5d7148bde108bd59ca20f297fcebbcb9b8c27452/extensions/lua/src/lua.rs#L49
Release Notes:
- N/A
This PR updates the C# extension to not cache the binary when it is
using the one on the $PATH.
Release Notes:
- N/A
Marshall Bowers
created
9c569c8
zig: Rename `cached_binary` to `cached_binary_path` (#10637)
Click to expand commit body
This PR renames the `cached_binary` field on the `ZigExtension` back to
`cached_binary_path` to make it match the other extensions.
Release Notes:
- N/A
This PR updates the Gleam extension to not cache the binary when it is
using the one on the $PATH.
Release Notes:
- N/A
Marshall Bowers
created
210f8eb
zig: Do not cache user-installed `zls` (#10634)
Click to expand commit body
This was a bug introduced when moving to extensions: when we find a
binary in the user's project environment, we shouldn't cache that
globally since it might not work for other projects.
See also: https://github.com/zed-industries/zed/pull/10559
Release Notes:
- N/A
Thorsten Ball
created
c015b5c
Enable inline-git-blame by default (#10632)
Click to expand commit body
Release Notes:
- N/A
Thorsten Ball
created
c1c8a74
Add ability to specify binary path/args for clangd (#10608)
Click to expand commit body
This uses the language server settings added in #9293 to allow users to
specify the binary path and arguments with which to start up `clangd`.
Example user settings for `clangd`:
```json
{
"lsp": {
"clangd": {
"binary": {
"path": "/usr/bin/clangd",
"arguments": ["--log=verbose"]
},
}
}
}
```
Constraints:
* Right now this only allows ABSOLUTE paths.
Release Notes:
- Added ability to specify `clangd` binary `path` (must be absolute) and
`arguments` in user settings. Example: `{"lsp": {"clangd": {"binary":
{"path": "/usr/bin/clangd", "arguments": ["--log=verbose"] }}}}`
Add some keywords (bracket, quote, etc)to the comments describing
`use_autoclose` preference in the settings json.
This setting took me a while to find -- so now it'll be more easily
searchable for others.
Release Notes:
- N/A
Peter Tripp
created
5c5fb97
Handle setting git blame delay to 0 (#10626)
Click to expand commit body
Release Notes:
- N/A
Thorsten Ball
created
7928095
chore: parse cli args just once in zed crate (#10613)
Click to expand commit body
Release Notes:
- N/A
Piotr Osiewicz
created
70c3ca4
Fix toggling of inline git blame when it's delayed (#10620)
Click to expand commit body
Release Notes:
- N/A
Thorsten Ball
created
d49271a
Use project search action with the default keybinding in app menus (#10618)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/10611
Zed has `workspace::NewSearch` (without a default keybinding) and
`workspace::DeploySearch` (with the default keybinding for its
`DeploySearch::find()` form).
Use the one with the keybinding, as it's the whole point of the menu.
Release Notes:
- Fixed "Find In Project" app menu item having no keybinding
([10611](https://github.com/zed-industries/zed/issues/10611))
Kirill Bulatov
created
e34c443
lsp: Do not set error/result fields if they're missing. (#10610)
Click to expand commit body
We were previously not conforming to LSP spec, as we were setting
**both** result field and error field on response fields, which could
confuse servers. Excerpt from the spec:
> * The result of a request. This member is REQUIRED on success.
> * This member MUST NOT exist if there was an error invoking the
method.
Fixes #10595
Release Notes:
- N/A
Piotr Osiewicz
created
2630230
Show Zoom In/Out shortcuts in the labels (#10604)
Click to expand commit body
Based on https://github.com/zed-industries/zed/discussions/10599
Does the same as the assistant tab with the Zoom In/Out labels.

Release Notes:
- Adjusted Zoom In/Out for Pane and Terminal Pane to show keybinding
labels
Kirill Bulatov
created
7e1a184
Fix Markdown code rendering in tooltips ignoring languages (#10607)
Click to expand commit body
Some code blocks that are returned in tooltips (returned by language
servers, for example) use the language file extension as the language in
the the triple-backtick code blocks.
Example:
```rs
fn rust_code() {}
```
```cpp
fn rust_code() {}
```
Before this change we only looked up the language with the
`rs`/`cpp`/... being interpreted as the language name. Now we also treat
it as a possible file extension.
Release Notes:
- Fixed Markdown code blocks in tooltips not having correct language
highlighting.
Before:

After:

Co-authored-by: Bennet <bennetbo@gmx.de>
Thorsten Ball
and
Bennet
created
c834ea7
Fix `---` in Markdown docs not rendered correctly (#10606)
Click to expand commit body
This fixes #10511 by turning off the YAML metadata block rendering in
the Markdown parser.
`clangd` uses `---` as dividers, but our parser interpreted it as a YAML
metadata block, even though it didn't contain any valid YAML.
Example Markdown from `clangd`:
### instance-method `format`
---
→ `void`
Parameters:
- `const int &`
- `const std::tm &`
- `int & dest`
---
```cpp
// In my_formatter_flag
public: void format(const int &, const std::tm &, int &dest)
```
What's between the two `---` is *not* valid YAML. Neovim, too,
interprets these as dividers and renders them as such.
And since we don't handle any possible metadata anyway, we can turn off
the metadata handling, which causes the parser to interpret the `---` as
dividers.
Release Notes:
- Fixed Markdown returned by `clangd` being rendered the wrong way.
([#10511](https://github.com/zed-industries/zed/issues/10511)).
Before:

After:

Co-authored-by: Bennet <bennetbo@gmx.de>
Thorsten Ball
and
Bennet
created
4d8cba2
Fix long git author names/emails overflowing blame tooltip (#10605)
Click to expand commit body
This fixes https://github.com/zed-industries/zed/issues/10581.
Release Notes:
- N/A
Co-authored-by: Bennet <bennetbo@gmx.de>
Fixes inline blame not being displayed correctly for soft-wrapped lines.
(Can't find the ticket)

Release Notes:
- N/A
Thorsten Ball
created
2cfb1ff
add a setting to control show/hide terminal button for status bar (#10593)
Click to expand commit body
Release Notes:
- Added a setting to show/hide the terminal button in the status bar:
`{"terminal": {"button": false}}` to hide it. (#10513)
---------
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Zed displays scrollbar markers of three types: git diffs, background
highlights and diagnostics. At the moment, the "background highlights"
markers are displayed for all the supported highlights:
- Occurences of the symbol under cursor.
- Search results.
- Scope boundaries (only works when a symbol is selected).
- Active hover popover position.
They all use the same color, which leads to confusing results. For
instance, in the following case I expect to see markers for the
`new_anchor` occurences in lines 43 and 47. But besides them, there're
also scope-markers for `ScrollAnchor` initialization block in lines 46
and 49, which makes me think that there're four places where
`new_anchor` appears.
<img width="740" alt="zed-scrollbar-markers"
src="https://github.com/zed-industries/zed/assets/2101250/78700e6b-fdd1-4c2f-beff-e564d8defc13">
Existing settings `selection` and `symbol_selection` in the `scrollbar`
section [don't work as
expected](https://github.com/zed-industries/zed/pull/10080#discussion_r1552325493),
which increases confusion.
This PR only leaves two types of bg-highlight-markers and provides
dedicated settings for them:
- Occurences of the symbol under cursor. Setting: `selected_symbol`,
default is `true`.
- Search results. Setting: `search_results`, default is `true`.
The `selection` and `symbol_selection` settings are not used anymore.
Release Notes:
- Breaking changes. Settings `selection` and `symbol_selection` in the
`scrollbar` section renamed to `search_results` and `selected_symbol`
respectively. Fixed the effect of these settings on which markers are
displayed on the scrollbar.
Optionally, include screenshots / media showcasing your addition that
can be included in the release notes.
- N/A
/cc @mrnugget
Andrew Lygin
created
33b9aca
Add a bump patch version workflow (#10588)
Click to expand commit body
I'd like to make it less clunky to release a new patch version of
preview/stable.
Release Notes:
- N/A
Conrad Irwin
created
57b087e
On label conflict, prefer resolved tasks with never templates (#10586)
Click to expand commit body
This way, static (and other) templates that change, e.g. env vars, will
get the new template resolved task in the modal to run.
Release Notes:
- N/A
Kirill Bulatov
created
2a9ce3c
Handle no active editor available (#10503)
Click to expand commit body
Cleaned up a stray `.unwrap()`
Release Notes:
- N/A
Kyle Kelley
created
f5c2483
Close the backticks in gpui geometry examples (#10579)
Click to expand commit body
I noticed some of the examples in `crates/gpui/src/geometry.rs` were
missing ending triple backticks.
Release Notes:
- N/A
Kyle Kelley
created
4d314b2
Increase the context in other multibuffers (#10582)
Click to expand commit body
This moves the diagnostics and find all references to be in line with
the search pane. This also centralizes the constant into the editor code
base.
Release Notes:
- Increased diagnostic context to match the project search context.
Mikayla Maki
created
7a112b2
dart: Use upstream tree-sitter-dart (#10552)
Click to expand commit body
Update `tree-sitter-dart` to the upstream package, there was an issue
building Rust package which is resolved now.
Release Notes:
- N/A
4f776f9
Don't make -l imply -d in bundle-mac script (#10438)
Click to expand commit body
If you want a debug build, you can easily pass `-ld`.
Release Notes:
- N/A
Nathan Sobo
created
0c77e1c
Disable extension entries when the corresponding dev extension is installed (#10580)
Click to expand commit body
This PR updates the extension list to disable remote entries when the
corresponding dev extension is installed.
Here is what this looks like:
<img width="1189" alt="Screenshot 2024-04-15 at 4 09 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/48bb61d4-bc85-4ca6-b233-716831dfa7d8">
Release Notes:
- Disabled extension entries when there is a development copy of that
extension installed.
Although we thought this fixed the bug, it just worked around it, and
runnign two copies of tracing in one app is a bad idea.
Simplify default RUST_LOG in development to avoid
https://github.com/tokio-rs/tracing/issues/2927#issuecomment-2040080189
Release Notes:
- N/A
Fixes the cursor not updating when (a) switching windows from another
program via a shortcut and (b) when cursor updates were triggered by
something other than moving the mouse (e.g. when scrolling or pressing a
key).
Release Notes:
- N/A
It seems that windows always report IME composition string, so there is
no need to store this string manually.
Release Notes:
- N/A
张小白
created
3e44e97
Install the latest compatible version of an extension when clicking "Install" (#10575)
Click to expand commit body
This PR makes it so clicking "Install" will install the latest
compatible version of an extension instead of disabling the button when
the latest version is not compatible.
The "Upgrade" button will still be disabled when the latest version is
not compatible. We will also now display a tooltip to better indicate
why the button is disabled:
<img width="607" alt="Screenshot 2024-04-15 at 2 41 26 PM"
src="https://github.com/zed-industries/zed/assets/1486634/16ad516e-1c0c-4505-b994-158ea655641b">
Related to https://github.com/zed-industries/zed/issues/10509.
Release Notes:
- Changed the "Install" button for extensions to always install the
latest compatible version instead of becoming disabled when the latest
version of an extension is incompatible with the current Zed version.
Marshall Bowers
created
fda2123
Indicate which extension version is installed when on an older version (#10574)
Click to expand commit body
This PR adds an indicator to show what extension version is currently
installed when on an extension version that is not the latest.
<img width="1156" alt="Screenshot 2024-04-15 at 2 10 33 PM"
src="https://github.com/zed-industries/zed/assets/1486634/61c5e4cf-a0b8-48fc-8e52-f04f1c351794">
Release Notes:
- Added an indicator to show the currently-installed extension version
when not on the latest version.
Marshall Bowers
created
57a736d
Fuse iterator supplied to `SumTree::from_iter` (#10571)
Click to expand commit body
This fixes an issue that could cause `from_iter` to never finish if the
underlying iterator restarted after returning `None` for the first time.
We only saw this in development but I wanna cherry-pick it to stable and
preview, just in case.
Release Notes:
- N/A
Co-authored-by: Kyle <kylek@zed.dev>
Antonio Scandurra
and
Kyle
created
015e2ec
Remove built-in Nu support in favor of extension (#10570)
Click to expand commit body
Release Notes:
- Removed built-in Nu language support in favor of an extension.
---------
Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld
and
Marshall
created
5037f46
Defer first update active buffer for conversation (#10564)
Click to expand commit body
This fixes when the workspace is not actually available for a
`.read(cx)`.
Release Notes:
- Fix a panic when quoting a selection before the assistant panel has
been started
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Kyle Kelley
and
Conrad Irwin
created
f28fde5
Move constraints to query parameters for `GET /extensions/:extension_id/download` (#10562)
Click to expand commit body
This PR fixes a bug where the constraints provided when downloading the
latest version of an extension were not being read properly.
These constraints are passed in the query string, but `collab` was
attempting to read them from the path.
This should fix https://github.com/zed-industries/zed/issues/10484, once
it is deployed.
Release Notes:
- N/A
ad22bdd
diagnostics: Update diagnostics more eagerly (#10560)
Click to expand commit body
Here comes a lenghty explanation for a short commit: We've had feedback
that our diagnostics tab often mismatches what's shown in the status
bar. E.g: https://x.com/fasterthanlime/status/1778764747732594753 Let's
dive into the lifetime of diagnostic tab first; it is actually spawned
*just once per workspace*, the first time you click on the diagnostics
status indicator. Even if you close this tab, we still reuse the same
object under the hood later on. This has upsides, as it means that you
can close a tab and then reopen it with your selections still in-tact
and so on. However, this also leads to the perceived staleness.
Crucially, the first time ever in a given session that you spawn the
diagnostics tab, the status bar counts match the content of a tab. That
is because we always call \`update_excerpts\` when we create diagnostics
tab for the first time, but later on we have severe constraints on when
we want to update the excerpts in diagnostics tab, mostly centered
around presence of selections in an editor... but, since we reuse the
diagnostic tab object under the hood, we're always gonna have at least
one selection in an editor sans the first time you open it. The end
result is that in order for diagnostic tab contents to be updated, we
have to get a "on-disk-diagnostics-finished" notification from language
server, which can take a long time.
Another example of this property manifesting itself is that if you fix a
diagnostic warning/error, it takes a while for diagnostic tab to reflect
it.
With this PR, I've afforded a bit of leniency in refreshing the contents
of that tab. The old check that discarded updates when diagnostics
editor had at least one selection has been updated to instead reject
multicursors; this is still overly conservative, as I'm not yet sure how
big of an issue is the cursor that's jumping around (as that's what the
selections constraint is supposed to prevent).
Release Notes:
- Fixed diagnostics tab showing outdated entries before the language
server is done with it's analysis.