07dc405
Do not bind cmd-enter for repl::Run when in AssistantContext (#14066)
Click to expand commit body
Don't pollute cmd-enter in the Assistant's `ContextEditor`.
Release Notes:
- N/A
Kyle Kelley
created
896b9bd
Stick REPL icon in quick action bar (#14064)
Click to expand commit body
REPL Quick Actions
<img width="325" alt="image"
src="https://github.com/zed-industries/zed/assets/836375/faaf4c8f-ef12-4417-a9dd-158d5beae8ba">
When the Jupyter REPL is enabled and a kernel is available, show the
status in the editor bar:

Release Notes:
- N/A
---------
Co-authored-by: Nate Butler <iamnbutler@gmail.com>
The biggest hurdle turned out to be use of `Arc<Language>` in maps, as
`clippy::mutable_key_type` started triggering on it (due to - I suppose
- internal mutability on `HighlightMap`?). I switched over to using
`LanguageId` as the key type in some of the callsites, as that's what
`Language` uses anyways for it's hash/eq, though I've still had to
suppress the lint outside of language crate.
/cc @maxdeviant , le clippy guru.
Release Notes:
- N/A
Piotr Osiewicz
created
d4ddc4c
gpui: Fix `cx.bounds`, `cx.open_window` position on macOS (#14044)
Click to expand commit body
Release Notes:
- gpui: Fixed `cx.bounds` method to get correct `y` position on macOS.
- gpui: Fixed `cx.open_window` position when macOS Dock is existed.
- Fixed call notification and reopen window position.
## Before

https://github.com/zed-industries/zed/assets/5518/ab925779-4253-4b27-9084-01023888087f
## After
<img width="533" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/142e9aaa-ae82-4a72-9acf-04097c545bf0">
https://github.com/zed-industries/zed/assets/5518/8793824a-8b74-4913-8204-7b39649aeeed
---
The case is I have made a Popover by use child window, the coordinate of
the window is always can't placement a right position.
So, I make this example to test the `cx.bounds` and set bounds to
window.
---
By this test, is the `cx.bounds` have a bug?
For example the **Top Left** window, we give it origin (150,150), but it
`cx.bounds()` returns (150,262)
> On the window label, middle line is the `bounds` that we set to the
window, last line is `cx.bounds()` result.
Display 1:
<img width="1512" alt="CleanShot 2024-07-10 at 14 52 26@2x"
src="https://github.com/zed-industries/zed/assets/5518/3adf9e79-f237-431a-a72b-02face7b2361">
---
Or is there something I missed. Is it correct to use `cx.bounds` method
to get the bounds of the current window?
At the same time, I also found that when there are multiple screens, the
information obtained by cx.bounds is very different on different
screens, and it seems that the origin is not relative to the screen.
Display 2:
<img width="2560" alt="SCR-20240710-nkmq"
src="https://github.com/zed-industries/zed/assets/5518/d87d4151-0562-4bf8-b3b3-5da3b4d09d82">
Jason Lee
created
8944af7
Lay the groundwork for collaborating on assistant panel (#13991)
Click to expand commit body
This pull request introduces collaboration for the assistant panel by
turning `Context` into a CRDT. `ContextStore` is responsible for sending
and applying operations, as well as synchronizing missed changes while
the connection was lost.
Contexts are shared on a per-project basis, and only the host can share
them for now. Shared contexts can be accessed via the `History` tab in
the assistant panel.
<img width="1819" alt="image"
src="https://github.com/zed-industries/zed/assets/482957/c7ae46d2-cde3-4b03-b74a-6e9b1555c154">
Please note that this doesn't implement following yet, which is
scheduled for a subsequent pull request.
Release Notes:
- N/A
Antonio Scandurra
created
1662993
windows: Revert "windows: Fix font clipping issue" (#14045)
Click to expand commit body
The implemetation of that PR is totally wrong, sorry for that!
Release Notes:
- N/A
张小白
created
7ef64fe
vim: Add ctrl-m binding (equivalent to <CR>) (#14057)
Click to expand commit body
Now that we have macros I noticed how much I rely on this.
Release Notes:
- vim: `ctrl-m` now is equivalent to `enter` in editor.
e1a6efa
go: Quote targeting expression on runnables (#14055)
Click to expand commit body
Release Notes:
- Go: fix test runnables in fish shell.
Daniel Schmidt
created
ba7d5a3
Fixed keymap for toggling right dock in linux (#14041)
Click to expand commit body
Release Notes:
- N/A
Saurabh
created
6f99399
extensions: Add support for snippets provided by extensions (#14020)
Click to expand commit body
For now extensions can only register global snippets, but there'll be
follow-up work to support scope attribute in snippets.json.
Release Notes:
- Extensions can now provide snippets by including `snippets.json` file
next to the extension manifest.
---------
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Piotr Osiewicz
,
Marshall
, and
Marshall Bowers
created
2f2047a
outline_panel: Fix outline panel should autoscroll when selection has changed (#14038)
d01d764
gpui: Expose more granular style macros (#14035)
Click to expand commit body
This PR extract more GPUI style methods into macros that can be composed
together to selectively add styles to components.
Release Notes:
- N/A
Marshall Bowers
created
a46a562
ui: Add margin style methods to `Label` and `LabelLike` (#14032)
Click to expand commit body
This PR adds margin style methods to the `Label` and `LabelLike`
components.
This allows for callers to provide a margin to these components without
needing to introduce a wrapping `div` to do so.
Release Notes:
- N/A
Marshall Bowers
created
4bb8a08
Measure maximum width of each cell to render table (#14026)
Kyle Kelley
created
c4bca87
assistant: Replace margin with gap (#14027)
Click to expand commit body
This PR replaces a usage of margin with a gap. This allows us to remove
an extra wrapping `div`.
Release Notes:
- N/A
Fix it on linux too :facepalm:
Release Notes:
- N/A
Conrad Irwin
created
110ce8a
Python: Fix auto close for single quotes (#14014)
Click to expand commit body
Fixes #13972
Peter Tripp
created
c6b9f19
Remove additional wrapping elements in the chat panel (#14013)
Click to expand commit body
This PR removes some wrapping elements that were used inside of the chat
panel.
To facilitate this, the `Label` component now has a `weight` method to
change the font weight.
Release Notes:
- N/A
Marshall Bowers
created
df935df
windows: Obtain mouse double-click information from the system instead of hardcoding (#13391)
Click to expand commit body
Release Notes:
- N/A
张小白
created
68b5ea4
windows: Fix and simplify title bar padding (#13420)
Click to expand commit body
This PR fixes the off by one pixel of the top client rect when not
maximized due to the added border. It also simplifies and properly fixes
the title bar padding problem when maximized, it is now properly taken
care of in GPUI rather then adding the padding in the UI.
Release Notes:
- N/A
Matin Aniss
created
5e1521e
Change the default shortcut for git blame on Linux (#13637)
Click to expand commit body
Zed already has a shortcut assigned to ctrl-alt-g and it's mapped to
`search::SelectNextMatch`. Having another multi shortcut with the same
prefix makes `ctrl-alt-g` to have a very noticeable delay when pressed.
This commit changes the default shortcut for git blame to `alt-g b`
Release Notes:
- N/A
Aleksei Gusev
created
ba28827
Add support for numpad keys on linux (#14018)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/12117
Partial application of the changes in
https://github.com/zed-industries/zed/pull/13396
Release Notes:
- N/A
We should run this server with `powershell`, or we will get some runtime
errors.

Release Notes:
- Fixed `tailwindcss-language-server` on Windows.
Closes #12737 . Left before this PR, right after.

Release Notes:
- Fixed font rendering clipping issue on Windows.(#12737 )
张小白
created
ae414e2
gpui: Fix hide titlebar on Windows, with `titlebar: None` option (#13975)
Click to expand commit body
Release Notes:
- N/A
Ref the macOS Window:
When the `titlebar` is none, the titlebar should be hidden.
https://github.com/zed-industries/zed/blob/adaa4831766cde63b408909cf65cdeb1641e5888/crates/gpui/src/platform/mac/window.rs#L516-L528
```
cargo run -p gpui --example window_positioning
```
## Before

## After
<img width="466" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/176ce4ea-14e9-44c8-8f2d-01e20ff3e543">
Jason Lee
created
2dd4867
Reveal in files instead of Finder (#13432)
f44e81b
Add more package managers to docs (#14015)
Click to expand commit body
Release Notes:
- N/A
Mikayla Maki
created
c093bc8
Fix search/replace start of line anchor (#13920)
Click to expand commit body
This is related to #9428
I noticed that doing a search and replace for the beginning of a line
`^` results in the trailing line being included in the search. This
seems to be because of the way the range is generated for generating
matches being the up to the start of the trailing line rather than up to
the end of the last line.
I added a test and took a stab at fixing it but it is a bit yolo as this
is the first time I've seen this codebase.
Andy Weiss
created
09e7b48
lsp: Add support for ShowMessage notification (#14012)
Click to expand commit body
When "one newer language" sends these messages, "one newer editor" will
display a pop-up for users to see. :)
Related to https://github.com/gleam-lang/gleam/issues/3274

Release Notes:
- A certain popular language recently had to work around a missing LSP
notification. This has been fixed
3cdd465
gpui: Make style macros more composable (#14007)
Click to expand commit body
This PR begins the process of breaking up the `style_helpers!` macro
into smaller macros that can be used to generate methods for a related
subset of styles.
The style method macros also now accept an optional `visibility`
parameter to control the visibility of the generated methods. This
allows for adding these methods to a struct instead of a just a trait.
For example, to expose just the padding styles on a `Facepile` we can do
this:
```rs
impl Facepile {
fn style(&mut self) -> &mut StyleRefinement {
self.base.style()
}
gpui::padding_style_methods!({
visibility: pub
});
}
```
Release Notes:
- N/A
ce7074c
Fix panic when opening the same context twice (#14004)
Click to expand commit body
Release Notes:
- Fixed a crash that occurred when opening the same context twice in the
assistant panel (preview-only).
Antonio Scandurra
created
6cc8412
Prevent dumping of temporary files in config_dir (#14002)
Click to expand commit body
Move telemetry temp files from `config_dir` to `log_dir`. Fixes #7155
- On MacOS: from `~/.config/zed` to `~/Library/Logs/Zed`
- On Linux: from `~/.config/zed` to `.local/share/zed/logs` (or
`$FLATPAK_XDG_DATA_HOME/zed/logs`).
Release Notes:
- Fixed telemetry putting temporary files in config_dir
([#7155](https://github.com/zed-industries/zed/issues/7155)).
The problem seemingly was that scrolling only started after autoscroll
has finished. I have added a function to forcefully stop it, which I
call when scroll event happens
Release Notes:
- Fixed delay when changing scrolling direction (#13720)
---------
Co-authored-by: Piotr <piotr@zed.dev>
This PR removes some extraneous `Cargo.lock` files for the `storybook`
and `sqlez` crates.
These lockfiles were not used, as everything uses the workspace's
`Cargo.lock`.
Release Notes:
- N/A
This PR refactors the style definitions in the `gpui_macros` style
helpers to use structs instead of tuples for additional clarity.
Release Notes:
- N/A
Marshall Bowers
created
dd9b2e2
PR template: Make issue numbers double clickable (no brackets) (#13989)