b1639e5
Add cmd-g and cmd-shift-g to jump to next / previous result
I added the action handler on Pane so we can use these bindings when the find bar isn't focused.
Nathan Sobo created
f90193b
Populate query and select it only if find bar isn't already deployed
Antonio Scandurra created
83423a4
Use cmd-f to move focus back to the editor when find bar is focused
Antonio Scandurra created
9ce1eda
Bind `cmd-e` to deploy `FindBar` without focusing it
Antonio Scandurra created
ce52704
Propagate `Cancel` when editor is not in full mode
This is consistent with what VS Code and Sublime Text do and allows the user to perform only one keybinding to e.g. dismiss the find bar when the query is (partially) selected.
Antonio Scandurra created
c53b6b9
Populate query with text under selection when hitting `cmd-f`
Antonio Scandurra created
2a1b1ad
Bind `enter` and `shift-enter` in `FindBar`
Antonio Scandurra created
e8105c9
Show a message when no matches were found
Antonio Scandurra created
c16bd98
Fix panic when no matches were found
Antonio Scandurra created
969d81b
Determine active match index correctly when cursor is after last match
Antonio Scandurra created
df4cc45
Select next/prev find match based on whether we intersect active match
Also, capture the next/prev selection logic in a unit test.
Antonio Scandurra created
1d55872
Display active match and allow going to next or previous match
We still need to write a unit test for this, as well as add a keybinding.
Antonio Scandurra created
5ebd24d
:memo: Improve assertion comment
Antonio Scandurra created
a284e71
Always return valid locations when refreshing anchors
Specifically, with this commit: - We will now refresh the anchor if it escapes the boundaries of the excerpt by using the `Excerpt::contains` method. This was not the case before, as we were just checking if the excerpt id and buffer id of the anchors matched the ones stored on the excerpt. - We fixed a bug that was causing the anchor to be outside of the excerpt when resetting it to one of the excerpt's endpoints after we couldn't keep its position. This would happen because we were using `anchor_at`, which resolved the anchor to an offset first and then converted it back into an anchor with the given bias, which is a lossy operation. We now use `Anchor::bias` to achieve the same goal: note that this could still lead to the anchor escaping the excerpt's boundary when the bias doesn't match the endpoint's bias, so we take extra care to avoid that and `min`/`max` the newly-produced anchor with the other endpoint.
Antonio Scandurra created
2d6e348
Prevent anchors from escaping their excerpt's range when resolving them
This could happen if an anchor was created on an excerpt with a larger range. Then, if the excerpt was removed and added back at the same position and with the same buffer but a smaller range, resolving the anchor could overshoot the excerpt's boundaries.
Antonio Scandurra created
5c7cea5
WIP - Navigate to prev/next search result
Max Brunsfeld created
7e02d66
Add a simple unit test for find bar
Max Brunsfeld created
bfaeefc
Merge pull request #376 from zed-industries/bump-rust-analyzer
Bump rust-analyzer to the 2022-01-24 release
Max Brunsfeld created
be7f534
Adjust hover assertion in lsp test after bumping rust-analyzer
Max Brunsfeld created
e1c12ff
Bump rust-analyzer to the 2022-01-24 release
Antonio Scandurra created
d2a64f2
Optimize search when regex doesn't contain newlines
Co-Authored-By: Nathan Sobo <nathan@zed.dev> Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created
5b9d791
Implement regex search with multiline support
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
5c862bf
Maintain search results as query and active editor changes
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
860e37d
Move finding results in the background
Antonio Scandurra created
b2ded5b
Optimize some common operations when `MultiBuffer` is a singleton
Antonio Scandurra created
b980b11
Implement whole word mode
Antonio Scandurra created
df1810a
A bit more progress styling find
Fix the pinwheel when hovering mode buttons.
Nathan Sobo created
da35df0
WIP
Max Brunsfeld created
4f0ffdc
Avoid panic when closing the last tab in a pane, due to calling `activate_item`
Max Brunsfeld created
3abd7bc
Highlight find matches
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
34ed734
Add highlighted_ranges API to editor
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
d8e4464
WIP - Run substring search when typing in find bar
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
05e20ca
Inform toolbars when active item changes
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
bebde78
Deploy `FindBar` when hitting `cmd-f`
Co-Authored-By: Nathan Sobo <nathan@zed.dev> Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created
e7d4c38
Take an `Into<AnyViewHandle>` in `ChildView::new`
Co-Authored-By: Nathan Sobo <nathan@zed.dev> Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created
dbf48d2
Merge pull request #375 from zed-industries/more-project-diagnostics-styling
Last touches on project diagnostics for now
Antonio Scandurra created
24d1d2a
Merge pull request #374 from zed-industries/fix-editor-panic
Fix editor panic when ending transaction that wasn't started by the same editor
Antonio Scandurra created
3853826
Pause cursor blinking only when editor is focused
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
37032f5
Show non-disk-based diagnostics in project diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
ff24766
Fix warning
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
41ec464
Don't panic when ending transaction that wasn't started by the same editor
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
f055053
Avoid grouping transactions created by different editors
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
4d9cdd4
Style empty project diagnostics state
Antonio Scandurra created
adf00fa
Merge pull request #373 from zed-industries/empty-diagnostic-message
Filter out supporting diagnostics that contain no messages
Antonio Scandurra created
3e4fe09
Filter out supporting diagnostics that contain no messages
Antonio Scandurra created
dc95cd9
Merge pull request #371 from zed-industries/metal-debug
Add script to debug Metal frames
Antonio Scandurra created
7b2f55f
Add script to debug Metal frames
Antonio Scandurra created
2749001
Use latest rust docker image
Max Brunsfeld created
c054e4c
Use new feature resolver
This fixes a build failure on linux because gpui was being spuriously included as a dependency of zed-server, due to its presence as an optional dependency in the rpc crate. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
0e55f0c
Use Rust 2021 edition in all crates
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created